mirror of
https://github.com/git-for-windows/git.git
synced 2026-06-27 13:21:17 -05:00
9759608622
The Git project is not exactly the easiest project to get started in: it's written in C and POSIX shell, with bits of Perl, Rust and other languages sprinkled into it. On top of that, the project has grown somewhat organically over time, making the codebase hard to navigate. These are problems that we're aware of, and there have been and still are efforts to clean up some of the technical debt that is natural to exist an a project that is more than 20 years old. Furthermore, we provide resources to newcomers that help them out like our coding guidelines, code of conduct or "MyFirstContribution.adoc". But there is a rather practical problem: finding your way around in our project's tree is not easy. Doing a directory listing in the top-level directory will present you with more than 550 files, which makes it extremely hard for a newcomer to figure out what files they are even supposed to look at. This makes the onboarding experience somewhat harder than it really needs to be. This isn't only a problem for newcomers though, as I myself struggle to find the files I am looking for because of the sheer number of files. Besides the problem of discoverability it also creates a problem of structure. It is not obvious at all which files are part of "libgit.a" and which files are only linked into our final executables. So while we have this split in our build systems, that split is not evident at all in our tree. Introduce a new "lib/" directory and move all of our sources for "libgit.a" into it to fix these issues. It makes the split we have evident and reduces the number of files in our top-level tree from 550 files to ~80 files. This is still a lot of files, but it's significantly easier to navigate already. Furthermore, we can further iterate after this step and think about introducing a better structure for remaining files, as well. Signed-off-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>
59 lines
1.3 KiB
C
59 lines
1.3 KiB
C
#ifndef MAILINFO_H
|
|
#define MAILINFO_H
|
|
|
|
#include "strbuf.h"
|
|
|
|
#define MAX_BOUNDARIES 5
|
|
|
|
struct repository;
|
|
|
|
enum quoted_cr_action {
|
|
quoted_cr_unset = -1,
|
|
quoted_cr_nowarn,
|
|
quoted_cr_warn,
|
|
quoted_cr_strip,
|
|
};
|
|
|
|
struct mailinfo {
|
|
FILE *input;
|
|
FILE *output;
|
|
FILE *patchfile;
|
|
|
|
struct strbuf name;
|
|
struct strbuf email;
|
|
int keep_subject;
|
|
int keep_non_patch_brackets_in_subject;
|
|
int quoted_cr; /* enum quoted_cr_action */
|
|
int add_message_id;
|
|
int use_scissors;
|
|
int use_inbody_headers;
|
|
const char *metainfo_charset;
|
|
|
|
struct strbuf *content[MAX_BOUNDARIES];
|
|
struct strbuf **content_top;
|
|
struct strbuf charset;
|
|
unsigned int format_flowed:1;
|
|
unsigned int delsp:1;
|
|
unsigned int have_quoted_cr:1;
|
|
char *message_id;
|
|
enum {
|
|
TE_DONTCARE, TE_QP, TE_BASE64
|
|
} transfer_encoding;
|
|
int patch_lines;
|
|
int filter_stage; /* still reading log or are we copying patch? */
|
|
int header_stage; /* still checking in-body headers? */
|
|
struct strbuf inbody_header_accum;
|
|
struct strbuf **p_hdr_data;
|
|
struct strbuf **s_hdr_data;
|
|
|
|
struct strbuf log_message;
|
|
int input_error;
|
|
};
|
|
|
|
int mailinfo_parse_quoted_cr_action(const char *actionstr, int *action);
|
|
void setup_mailinfo(struct repository *r, struct mailinfo *);
|
|
int mailinfo(struct mailinfo *, const char *msg, const char *patch);
|
|
void clear_mailinfo(struct mailinfo *);
|
|
|
|
#endif /* MAILINFO_H */
|