mirror of
https://github.com/git-for-windows/git.git
synced 2026-06-27 13:21:17 -05:00
9759608622
The Git project is not exactly the easiest project to get started in: it's written in C and POSIX shell, with bits of Perl, Rust and other languages sprinkled into it. On top of that, the project has grown somewhat organically over time, making the codebase hard to navigate. These are problems that we're aware of, and there have been and still are efforts to clean up some of the technical debt that is natural to exist an a project that is more than 20 years old. Furthermore, we provide resources to newcomers that help them out like our coding guidelines, code of conduct or "MyFirstContribution.adoc". But there is a rather practical problem: finding your way around in our project's tree is not easy. Doing a directory listing in the top-level directory will present you with more than 550 files, which makes it extremely hard for a newcomer to figure out what files they are even supposed to look at. This makes the onboarding experience somewhat harder than it really needs to be. This isn't only a problem for newcomers though, as I myself struggle to find the files I am looking for because of the sheer number of files. Besides the problem of discoverability it also creates a problem of structure. It is not obvious at all which files are part of "libgit.a" and which files are only linked into our final executables. So while we have this split in our build systems, that split is not evident at all in our tree. Introduce a new "lib/" directory and move all of our sources for "libgit.a" into it to fix these issues. It makes the split we have evident and reduces the number of files in our top-level tree from 550 files to ~80 files. This is still a lot of files, but it's significantly easier to navigate already. Furthermore, we can further iterate after this step and think about introducing a better structure for remaining files, as well. Signed-off-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>
55 lines
1.8 KiB
C
55 lines
1.8 KiB
C
#ifndef ABSPATH_H
|
|
#define ABSPATH_H
|
|
|
|
int is_directory(const char *);
|
|
char *strbuf_realpath(struct strbuf *resolved, const char *path,
|
|
int die_on_error);
|
|
char *strbuf_realpath_forgiving(struct strbuf *resolved, const char *path,
|
|
int die_on_error);
|
|
char *real_pathdup(const char *path, int die_on_error);
|
|
const char *absolute_path(const char *path);
|
|
char *absolute_pathdup(const char *path);
|
|
|
|
/*
|
|
* Concatenate "prefix" (if len is non-zero) and "path", with no
|
|
* connecting characters (so "prefix" should end with a "/").
|
|
* Unlike prefix_path, this should be used if the named file does
|
|
* not have to interact with index entry; i.e. name of a random file
|
|
* on the filesystem.
|
|
*
|
|
* The return value is always a newly allocated string (even if the
|
|
* prefix was empty).
|
|
*/
|
|
char *prefix_filename(const char *prefix, const char *path);
|
|
|
|
/* Likewise, but path=="-" always yields "-" */
|
|
char *prefix_filename_except_for_dash(const char *prefix, const char *path);
|
|
|
|
static inline int is_absolute_path(const char *path)
|
|
{
|
|
return is_dir_sep(path[0]) || has_dos_drive_prefix(path);
|
|
}
|
|
|
|
/**
|
|
* Add a path to a buffer, converting a relative path to an
|
|
* absolute one in the process. Symbolic links are not
|
|
* resolved.
|
|
*/
|
|
void strbuf_add_absolute_path(struct strbuf *sb, const char *path);
|
|
|
|
/**
|
|
* Canonize `path` (make it absolute, resolve symlinks, remove extra
|
|
* slashes) and append it to `sb`. Die with an informative error
|
|
* message if there is a problem.
|
|
*
|
|
* The directory part of `path` (i.e., everything up to the last
|
|
* dir_sep) must denote a valid, existing directory, but the last
|
|
* component need not exist.
|
|
*
|
|
* Callers that don't mind links should use the more lightweight
|
|
* strbuf_add_absolute_path() instead.
|
|
*/
|
|
void strbuf_add_real_path(struct strbuf *sb, const char *path);
|
|
|
|
#endif /* ABSPATH_H */
|