mirror of
https://github.com/git-for-windows/git.git
synced 2026-06-27 00:58:30 -05:00
9759608622
The Git project is not exactly the easiest project to get started in: it's written in C and POSIX shell, with bits of Perl, Rust and other languages sprinkled into it. On top of that, the project has grown somewhat organically over time, making the codebase hard to navigate. These are problems that we're aware of, and there have been and still are efforts to clean up some of the technical debt that is natural to exist an a project that is more than 20 years old. Furthermore, we provide resources to newcomers that help them out like our coding guidelines, code of conduct or "MyFirstContribution.adoc". But there is a rather practical problem: finding your way around in our project's tree is not easy. Doing a directory listing in the top-level directory will present you with more than 550 files, which makes it extremely hard for a newcomer to figure out what files they are even supposed to look at. This makes the onboarding experience somewhat harder than it really needs to be. This isn't only a problem for newcomers though, as I myself struggle to find the files I am looking for because of the sheer number of files. Besides the problem of discoverability it also creates a problem of structure. It is not obvious at all which files are part of "libgit.a" and which files are only linked into our final executables. So while we have this split in our build systems, that split is not evident at all in our tree. Introduce a new "lib/" directory and move all of our sources for "libgit.a" into it to fix these issues. It makes the split we have evident and reduces the number of files in our top-level tree from 550 files to ~80 files. This is still a lot of files, but it's significantly easier to navigate already. Furthermore, we can further iterate after this step and think about introducing a better structure for remaining files, as well. Signed-off-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>
59 lines
1.6 KiB
C
59 lines
1.6 KiB
C
#ifndef SEND_PACK_H
|
|
#define SEND_PACK_H
|
|
|
|
#include "string-list.h"
|
|
|
|
struct child_process;
|
|
struct oid_array;
|
|
struct ref;
|
|
struct repository;
|
|
|
|
/* Possible values for push_cert field in send_pack_args. */
|
|
#define SEND_PACK_PUSH_CERT_NEVER 0
|
|
#define SEND_PACK_PUSH_CERT_IF_ASKED 1
|
|
#define SEND_PACK_PUSH_CERT_ALWAYS 2
|
|
|
|
/* At least one reference has been rejected by the remote side. */
|
|
#define ERROR_SEND_PACK_BAD_REF_STATUS 1
|
|
|
|
struct send_pack_args {
|
|
const char *url;
|
|
const struct string_list *negotiation_include;
|
|
const struct string_list *negotiation_restrict;
|
|
unsigned verbose:1,
|
|
quiet:1,
|
|
porcelain:1,
|
|
progress:1,
|
|
send_mirror:1,
|
|
force_update:1,
|
|
use_thin_pack:1,
|
|
use_ofs_delta:1,
|
|
dry_run:1,
|
|
/* One of the SEND_PACK_PUSH_CERT_* constants. */
|
|
push_cert:2,
|
|
stateless_rpc:1,
|
|
atomic:1,
|
|
disable_bitmaps:1;
|
|
const struct string_list *push_options;
|
|
};
|
|
|
|
struct option;
|
|
int option_parse_push_signed(const struct option *opt,
|
|
const char *arg, int unset);
|
|
|
|
/*
|
|
* Compute a packfile and write it to a file descriptor. The `fd` array needs
|
|
* to contain two file descriptors: `fd[0]` is the file descriptor used as
|
|
* input for the packet reader, whereas `fd[1]` is the file descriptor the
|
|
* packfile will be written to.
|
|
*
|
|
* Returns 0 on success, non-zero otherwise. Negative return values indicate a
|
|
* generic error, whereas positive return values indicate specific error
|
|
* conditions as documented with the `ERROR_SEND_PACK_*` constants.
|
|
*/
|
|
int send_pack(struct repository *r, struct send_pack_args *args,
|
|
int fd[], struct child_process *conn,
|
|
struct ref *remote_refs, struct oid_array *extra_have);
|
|
|
|
#endif
|