mirror of
https://github.com/git-for-windows/git.git
synced 2026-06-27 00:58:30 -05:00
9759608622
The Git project is not exactly the easiest project to get started in: it's written in C and POSIX shell, with bits of Perl, Rust and other languages sprinkled into it. On top of that, the project has grown somewhat organically over time, making the codebase hard to navigate. These are problems that we're aware of, and there have been and still are efforts to clean up some of the technical debt that is natural to exist an a project that is more than 20 years old. Furthermore, we provide resources to newcomers that help them out like our coding guidelines, code of conduct or "MyFirstContribution.adoc". But there is a rather practical problem: finding your way around in our project's tree is not easy. Doing a directory listing in the top-level directory will present you with more than 550 files, which makes it extremely hard for a newcomer to figure out what files they are even supposed to look at. This makes the onboarding experience somewhat harder than it really needs to be. This isn't only a problem for newcomers though, as I myself struggle to find the files I am looking for because of the sheer number of files. Besides the problem of discoverability it also creates a problem of structure. It is not obvious at all which files are part of "libgit.a" and which files are only linked into our final executables. So while we have this split in our build systems, that split is not evident at all in our tree. Introduce a new "lib/" directory and move all of our sources for "libgit.a" into it to fix these issues. It makes the split we have evident and reduces the number of files in our top-level tree from 550 files to ~80 files. This is still a lot of files, but it's significantly easier to navigate already. Furthermore, we can further iterate after this step and think about introducing a better structure for remaining files, as well. Signed-off-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>
70 lines
1.9 KiB
C
70 lines
1.9 KiB
C
#ifndef IDENT_H
|
|
#define IDENT_H
|
|
|
|
#include "string-list.h"
|
|
|
|
struct ident_split {
|
|
const char *name_begin;
|
|
const char *name_end;
|
|
const char *mail_begin;
|
|
const char *mail_end;
|
|
const char *date_begin;
|
|
const char *date_end;
|
|
const char *tz_begin;
|
|
const char *tz_end;
|
|
};
|
|
|
|
#define IDENT_STRICT 1
|
|
#define IDENT_NO_DATE 2
|
|
#define IDENT_NO_NAME 4
|
|
|
|
enum want_ident {
|
|
WANT_BLANK_IDENT,
|
|
WANT_AUTHOR_IDENT,
|
|
WANT_COMMITTER_IDENT
|
|
};
|
|
|
|
const char *ident_default_name(void);
|
|
const char *ident_default_email(void);
|
|
/*
|
|
* Prepare an ident to fall back on if the user didn't configure it.
|
|
*/
|
|
void prepare_fallback_ident(const char *name, const char *email);
|
|
void reset_ident_date(void);
|
|
/*
|
|
* Signals an success with 0, but time part of the result may be NULL
|
|
* if the input lacks timestamp and zone
|
|
*/
|
|
int split_ident_line(struct ident_split *, const char *, size_t);
|
|
|
|
/*
|
|
* Given a commit or tag object buffer and the commit or tag headers, replaces
|
|
* the idents in the headers with their canonical versions using the mailmap mechanism.
|
|
*/
|
|
void apply_mailmap_to_header(struct strbuf *, const char **, struct string_list *);
|
|
|
|
/*
|
|
* Compare split idents for equality or strict ordering. Note that we
|
|
* compare only the ident part of the line, ignoring any timestamp.
|
|
*
|
|
* Because there are two fields, we must choose one as the primary key; we
|
|
* currently arbitrarily pick the email.
|
|
*/
|
|
int ident_cmp(const struct ident_split *, const struct ident_split *);
|
|
|
|
const char *git_author_info(int);
|
|
const char *git_committer_info(int);
|
|
const char *fmt_ident(const char *name, const char *email,
|
|
enum want_ident whose_ident,
|
|
const char *date_str, int);
|
|
const char *fmt_name(enum want_ident);
|
|
|
|
int committer_ident_sufficiently_given(void);
|
|
int author_ident_sufficiently_given(void);
|
|
|
|
struct config_context;
|
|
int git_ident_config(const char *, const char *, const struct config_context *,
|
|
void *);
|
|
|
|
#endif
|