mirror of
https://github.com/git-for-windows/git.git
synced 2026-06-27 13:21:17 -05:00
9759608622
The Git project is not exactly the easiest project to get started in: it's written in C and POSIX shell, with bits of Perl, Rust and other languages sprinkled into it. On top of that, the project has grown somewhat organically over time, making the codebase hard to navigate. These are problems that we're aware of, and there have been and still are efforts to clean up some of the technical debt that is natural to exist an a project that is more than 20 years old. Furthermore, we provide resources to newcomers that help them out like our coding guidelines, code of conduct or "MyFirstContribution.adoc". But there is a rather practical problem: finding your way around in our project's tree is not easy. Doing a directory listing in the top-level directory will present you with more than 550 files, which makes it extremely hard for a newcomer to figure out what files they are even supposed to look at. This makes the onboarding experience somewhat harder than it really needs to be. This isn't only a problem for newcomers though, as I myself struggle to find the files I am looking for because of the sheer number of files. Besides the problem of discoverability it also creates a problem of structure. It is not obvious at all which files are part of "libgit.a" and which files are only linked into our final executables. So while we have this split in our build systems, that split is not evident at all in our tree. Introduce a new "lib/" directory and move all of our sources for "libgit.a" into it to fix these issues. It makes the split we have evident and reduces the number of files in our top-level tree from 550 files to ~80 files. This is still a lot of files, but it's significantly easier to navigate already. Furthermore, we can further iterate after this step and think about introducing a better structure for remaining files, as well. Signed-off-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>
39 lines
1.1 KiB
C
39 lines
1.1 KiB
C
#ifndef WALKER_H
|
|
#define WALKER_H
|
|
|
|
#include "remote.h"
|
|
|
|
struct walker {
|
|
void *data;
|
|
int (*fetch_ref)(struct walker *, struct ref *ref);
|
|
void (*prefetch)(struct walker *, const struct object_id *oid);
|
|
int (*fetch)(struct walker *, const struct object_id *oid);
|
|
void (*cleanup)(struct walker *);
|
|
int get_verbosely;
|
|
int get_progress;
|
|
int get_recover;
|
|
|
|
int corrupt_object_found;
|
|
};
|
|
|
|
/* Report what we got under get_verbosely */
|
|
__attribute__((format (printf, 2, 3)))
|
|
void walker_say(struct walker *walker, const char *fmt, ...);
|
|
|
|
/* Load pull targets from stdin */
|
|
int walker_targets_stdin(char ***target, const char ***write_ref);
|
|
|
|
/* Free up loaded targets */
|
|
void walker_targets_free(int targets, char **target, const char **write_ref);
|
|
|
|
/* If write_ref is set, the ref filename to write the target value to. */
|
|
/* If write_ref_log_details is set, additional text will appear in the ref log. */
|
|
int walker_fetch(struct walker *impl, int targets, char **target,
|
|
const char **write_ref, const char *write_ref_log_details);
|
|
|
|
void walker_free(struct walker *walker);
|
|
|
|
struct walker *get_http_walker(const char *url);
|
|
|
|
#endif /* WALKER_H */
|