Files
git/tools/coccinelle/strvec.cocci
Junio C Hamano 250e977a2b use strvec_pushv() to add another strvec
Add and apply a semantic patch that simplifies the code by letting
strvec_pushv() append the items of a second strvec instead of pushing
them one by one.

Suggested-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: René Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2026-03-24 12:26:58 -07:00

47 lines
819 B
Plaintext

@@
type T;
identifier i;
expression dst;
struct strvec *src_ptr;
struct strvec src_arr;
@@
(
- for (T i = 0; i < src_ptr->nr; i++) { strvec_push(dst, src_ptr->v[i]); }
+ strvec_pushv(dst, src_ptr->v);
|
- for (T i = 0; i < src_arr.nr; i++) { strvec_push(dst, src_arr.v[i]); }
+ strvec_pushv(dst, src_arr.v);
)
@ separate_loop_index @
type T;
identifier i;
expression dst;
struct strvec *src_ptr;
struct strvec src_arr;
@@
T i;
...
(
- for (i = 0; i < src_ptr->nr; i++) { strvec_push(dst, src_ptr->v[i]); }
+ strvec_pushv(dst, src_ptr->v);
|
- for (i = 0; i < src_arr.nr; i++) { strvec_push(dst, src_arr.v[i]); }
+ strvec_pushv(dst, src_arr.v);
)
@ unused_loop_index extends separate_loop_index @
@@
{
...
- T i;
... when != i
}
@ depends on unused_loop_index @
@@
if (...)
- {
strvec_pushv(...);
- }