From ac4e02c5030c05d71b20127a7118b0a0fc3c1c64 Mon Sep 17 00:00:00 2001 From: Aditya Garg Date: Fri, 20 Jun 2025 12:10:25 +0530 Subject: [PATCH] imap-send: fix memory leak in case auth_cram_md5 fails This patch fixes a memory leak by running free(response) in case auth_cram_md5 fails. Signed-off-by: Aditya Garg Signed-off-by: Junio C Hamano --- imap-send.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/imap-send.c b/imap-send.c index 37f94a37e8..1a582c8443 100644 --- a/imap-send.c +++ b/imap-send.c @@ -905,8 +905,10 @@ static int auth_cram_md5(struct imap_store *ctx, const char *prompt) response = cram(prompt, ctx->cfg->user, ctx->cfg->pass); ret = socket_write(&ctx->imap->buf.sock, response, strlen(response)); - if (ret != strlen(response)) + if (ret != strlen(response)) { + free(response); return error("IMAP error: sending response failed"); + } free(response);