From a5208164e25584456324edeb650c0ef2fe2881c0 Mon Sep 17 00:00:00 2001 From: Johannes Schindelin Date: Fri, 21 Apr 2017 14:43:04 +0200 Subject: [PATCH] am: close input stream even in case of an error Reported via Coverity. Signed-off-by: Johannes Schindelin --- builtin/am.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/builtin/am.c b/builtin/am.c index a9c6d7088e..9bba6a0a4b 100644 --- a/builtin/am.c +++ b/builtin/am.c @@ -762,9 +762,11 @@ static int split_mail_conv(mail_conv_fn fn, struct am_state *state, mail = mkpath("%s/%0*d", state->dir, state->prec, i + 1); out = fopen(mail, "w"); - if (!out) + if (!out) { + fclose(in); return error_errno(_("could not open '%s' for writing"), mail); + } ret = fn(out, in, keep_cr);