git-for-windows/git
1
0
Fork 0
mirror of https://github.com/git-for-windows/git.git synced 2026-04-29 13:27:29 -05:00
Code Issues Packages Projects Releases 335 Wiki Activity

commit: rename reverse_commit_list() to conform to coding guidelines

Browse Source 
Our coding guidelines say that:

  Functions that operate on `struct S` are named `S_<verb>()` and should
  generally receive a pointer to `struct S` as first parameter.

While most of the functions related to `struct commit_list` already
follow that naming schema, `reverse_commit_list()` doesn't.

Rename the function to address this and adjust all of its callers. Add a
compatibility wrapper for the old function name to ease the transition
and avoid any semantic conflicts with in-flight patch series. This
wrapper will be removed once Git 2.53 has been released.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Patrick Steinhardt
2026-01-15 10:35:33 +01:00
committed by Junio C Hamano
parent ff9fb2cfe6
commit a468f3cefa
6 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
commit.c
View File

@@ -691,7 +691,7 @@ struct commit_list *commit_list_copy(const struct commit_list *list)
return head;
}
struct commit_list *reverse_commit_list(struct commit_list *list)
struct commit_list *commit_list_reverse(struct commit_list *list)
{
struct commit_list *next = NULL, *current, *backup;
for (current = list; current; current = backup) {