From 4b900253860e23e1944d93e5fdffe15f321f9e75 Mon Sep 17 00:00:00 2001 From: Nikita Leonov Date: Sat, 8 Feb 2020 23:52:09 +0200 Subject: [PATCH] credential.c: fix credential reading with regards to CR/LF This fix makes using Git credentials more friendly to Windows users. In previous version it was unable to finish input correctly without configuration changes (tested in PowerShell, CMD, Cygwin). We know credential filling should be finished by empty input, but the current implementation does not take into account CR/LF ending, and hence instead of the empty string we get '\r', which is interpreted as an incorrect string. So this commit changes default reading function to a more Windows compatible reading function. Signed-off-by: Nikita Leonov Signed-off-by: Johannes Schindelin --- credential.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/credential.c b/credential.c index 62be651b03..65989dfa4d 100644 --- a/credential.c +++ b/credential.c @@ -146,7 +146,7 @@ int credential_read(struct credential *c, FILE *fp) { struct strbuf line = STRBUF_INIT; - while (strbuf_getline_lf(&line, fp) != EOF) { + while (strbuf_getline(&line, fp) != EOF) { char *key = line.buf; char *value = strchr(key, '=');