From 35f220b639849d43cd8aaae34ccbe38e9935ab2b Mon Sep 17 00:00:00 2001 From: Siddharth Shrimali Date: Tue, 10 Mar 2026 22:14:12 +0530 Subject: [PATCH] submodule--helper: replace malloc with xmalloc The submodule_summary_callback() function currently uses a raw malloc() which could lead to a NULL pointer dereference. Standardize this by replacing malloc() with xmalloc() for error handling. To improve maintainability, use sizeof(*temp) instead of the struct name, and drop the typecast of void pointer assignment. Signed-off-by: Siddharth Shrimali Signed-off-by: Junio C Hamano --- builtin/submodule--helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c index d537ab087a..20dd9d04b6 100644 --- a/builtin/submodule--helper.c +++ b/builtin/submodule--helper.c @@ -1059,7 +1059,7 @@ static void submodule_summary_callback(struct diff_queue_struct *q, if (!S_ISGITLINK(p->one->mode) && !S_ISGITLINK(p->two->mode)) continue; - temp = (struct module_cb*)malloc(sizeof(struct module_cb)); + temp = xmalloc(sizeof(*temp)); temp->mod_src = p->one->mode; temp->mod_dst = p->two->mode; temp->oid_src = p->one->oid;