git-for-windows/git
1
0
Fork 0
mirror of https://github.com/git-for-windows/git.git synced 2025-12-16 05:14:58 -06:00
Code Issues Packages Projects Releases 335 Wiki Activity

parse-options.c: use exhaustive "case" arms for "enum parse_opt_result"

Browse Source 
Change the "default" case in parse_options() that handles the return
value of parse_options_step() to simply have a "case" arm for
PARSE_OPT_UNKNOWN, instead of leaving it to a comment. This means the
compiler can warn us about any missing case arms.

This adjusts code added in ff43ec3e2d2 (parse-opt: create
parse_options_step., 2008-06-23), given its age it may pre-date the
existence (or widespread use) of this coding style, which we've since
adopted more widely.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Ævar Arnfjörð Bjarmason 2021-10-08 21:07:40 +02:00 committed by Junio C Hamano
parent 352e761388
commit 1b887353d7
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
parse-options.c
View File

@ -866,7 +866,7 @@ enum parse_opt_result parse_options(int argc, const char **argv,
case PARSE_OPT_NON_OPTION: case PARSE_OPT_NON_OPTION:
case PARSE_OPT_DONE: case PARSE_OPT_DONE:
break; break;
default: /* PARSE_OPT_UNKNOWN */ case PARSE_OPT_UNKNOWN:
if (ctx.argv[0][1] == '-') { if (ctx.argv[0][1] == '-') {
error(_("unknown option `%s'"), ctx.argv[0] + 2); error(_("unknown option `%s'"), ctx.argv[0] + 2);
} else if (isascii(*ctx.opt)) { } else if (isascii(*ctx.opt)) {