[PR #51] [MERGED] Discord WF #842

Closed
opened 2025-09-09 19:48:06 -05:00 by giteasync · 0 comments

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVED/pull/51
Author: @bvdberg01
Created: 3/14/2025
Status: Merged
Merged: 3/17/2025
Merged by: @bvdberg01

Base: mainHead: main


📝 Commits (1)

📊 Changes

2 files changed (+140 additions, -0 deletions)

View changed files

.github/workflows/archive-discord-thread.yml (+30 -0)
.github/workflows/create-discord-thread.yml (+110 -0)

📄 Description

✍️ Description

This PR adds a workflow to automatically create a Discord forum post inviting users to test the script. Once the related GitHub issue is closed, the forum post will be archived.

If we want to implement this, we need to invite a bot with into the discord server. And in GitHub, three secrets must be added.

@michelroegl-brunner can you have a look if this is something we can use :)

Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No breaking changes – Existing functionality remains intact.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔍 Code & Security Review (X in brackets)

  • Follows Code_Audit.md & CONTRIBUTING.md guidelines
  • Uses correct script structure (AppName.sh, AppName-install.sh, AppName.json)
  • No hardcoded credentials

📋 Additional Information (optional)

image
image
image


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVED/pull/51 **Author:** [@bvdberg01](https://github.com/bvdberg01) **Created:** 3/14/2025 **Status:** ✅ Merged **Merged:** 3/17/2025 **Merged by:** [@bvdberg01](https://github.com/bvdberg01) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`d170c30`](https://github.com/community-scripts/ProxmoxVED/commit/d170c300c48cf03dc5d1b82dee7c81c31f4f9d00) Discord WF ### 📊 Changes **2 files changed** (+140 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `.github/workflows/archive-discord-thread.yml` (+30 -0) ➕ `.github/workflows/create-discord-thread.yml` (+110 -0) </details> ### 📄 Description ## ✍️ Description This PR adds a workflow to automatically create a Discord forum post inviting users to test the script. Once the related GitHub issue is closed, the forum post will be archived. If we want to implement this, we need to invite a bot with into the discord server. And in GitHub, three secrets must be added. @michelroegl-brunner can you have a look if this is something we can use :) ## ✅ Prerequisites (**X** in brackets) - [ ] **Self-review completed** – Code follows project standards. - [ ] **Tested thoroughly** – Changes work as expected. - [ ] **No breaking changes** – Existing functionality remains intact. - [ ] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [ ] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [X] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [ ] 🆕 **New script** – A fully functional and tested script or script set. - [ ] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [ ] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs. --- ## 🔍 Code & Security Review (**X** in brackets) - [ ] **Follows `Code_Audit.md` & `CONTRIBUTING.md` guidelines** - [ ] **Uses correct script structure (`AppName.sh`, `AppName-install.sh`, `AppName.json`)** - [ ] **No hardcoded credentials** ## 📋 Additional Information (optional) ![image](https://github.com/user-attachments/assets/4628f3d4-9739-4e15-bc76-4d801038ae15) ![image](https://github.com/user-attachments/assets/db6f1d31-3acb-4a7b-a5b9-aec65adb84d7) ![image](https://github.com/user-attachments/assets/2da74992-b212-4d8d-945a-65ad9facd631) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
giteasync added the pull-request label 2025-09-09 19:48:06 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: community-scripts/ProxmoxVED#842