[PR #162] [MERGED] Fix for freepbx-install.sh #756

Closed
opened 2025-09-09 19:47:28 -05:00 by giteasync · 0 comments

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVED/pull/162
Author: @arian-nasr
Created: 3/31/2025
Status: Merged
Merged: 4/2/2025
Merged by: @michelroegl-brunner

Base: mainHead: main


📝 Commits (1)

  • ae8de86 Update freepbx-install.sh

📊 Changes

1 file changed (+1 additions, -2 deletions)

View changed files

📝 install/freepbx-install.sh (+1 -2)

📄 Description

Fix issue with output showing even when not verbose

🛑 New scripts must first be submitted to ProxmoxVED for testing.
PRs for new scripts that skip this process will be closed.


✍️ Description

Fixed issue with output showing even when not set to verbose mode

Link: #32

Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No breaking changes – Existing functionality remains intact.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔍 Code & Security Review (X in brackets)

  • Follows Code_Audit.md & CONTRIBUTING.md guidelines
  • Uses correct script structure (AppName.sh, AppName-install.sh, AppName.json)
  • No hardcoded credentials

📋 Additional Information (optional)


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVED/pull/162 **Author:** [@arian-nasr](https://github.com/arian-nasr) **Created:** 3/31/2025 **Status:** ✅ Merged **Merged:** 4/2/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`ae8de86`](https://github.com/community-scripts/ProxmoxVED/commit/ae8de861aa11b261a809fef101f35afb4fe8bb50) Update freepbx-install.sh ### 📊 Changes **1 file changed** (+1 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `install/freepbx-install.sh` (+1 -2) </details> ### 📄 Description Fix issue with output showing even when not verbose 🛑 **New scripts must first be submitted to [ProxmoxVED](https://github.com/community-scripts/ProxmoxVED) for testing.** PRs for new scripts that skip this process will be closed. --- ## ✍️ Description <!-- Briefly describe your changes. --> Fixed issue with output showing even when not set to verbose mode ## 🔗 Related PR / Issue Link: #32 ## ✅ Prerequisites (**X** in brackets) - [x] **Self-review completed** – Code follows project standards. - [x] **Tested thoroughly** – Changes work as expected. - [x] **No breaking changes** – Existing functionality remains intact. - [x] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [x] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [ ] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [ ] 🆕 **New script** – A fully functional and tested script or script set. - [ ] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [ ] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs. --- ## 🔍 Code & Security Review (**X** in brackets) - [x] **Follows `Code_Audit.md` & `CONTRIBUTING.md` guidelines** - [x] **Uses correct script structure (`AppName.sh`, `AppName-install.sh`, `AppName.json`)** - [x] **No hardcoded credentials** ## 📋 Additional Information (optional) <!-- Add any extra context, screenshots, or references. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
giteasync added the pull-request label 2025-09-09 19:47:28 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: community-scripts/ProxmoxVED#756