community-scripts/ProxmoxVED
2
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVED.git synced 2026-04-12 21:29:52 -05:00
Code Issues 34 Packages Projects Releases Wiki Activity

[PR #739] [MERGED] Update multiple services #251

New Issue
Closed
opened 2025-09-09 19:44:47 -05:00 by giteasync · 0 comments
giteasync commented 2025-09-09 19:44:47 -05:00
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVED/pull/739
Author: @remz1337
Created: 7/22/2025
Status: ✅ Merged
Merged: 7/24/2025
Merged by: @MickLesk

Base: main ← Head: pr-update-merge

📝 Commits (10+)

  • 3428070 Adds script to update LXC services from the host, allowing to automatically increase resources if needed to build the service
  • 5070576 Merge branch 'community-scripts:main' into pr-update-lxcs-services
  • 5ab98de (WIP) Support updating multiple containers
  • f586a21 Add logic for unattended updates and reboot containers if needed (following user prompt)
  • b62b0cc Adds resources scaling logic
  • 6c507a0 Remove old script and cleanup some messages
  • ae2c845 Allow updating stopped containers and check the download of the install script needed to assess build resource requirements
  • 0f772b7 Move functions to the top
  • 9b1382d Remove msg_info call to prevent spinner from overriding the whiptail menu
  • 3e2924d Fix backup storage detection to support local dir

📊 Changes

1 file changed (+82 additions, -31 deletions)

View changed files

📝 tools/pve/update-apps.sh (+82 -31)

📄 Description

🛑 New scripts must first be submitted to ProxmoxVED for testing.
PRs for new scripts that skip this process will be closed.

✍️ Description

Script to update the services of multiple containers at once.

🔗 Related PR / Issue

Link: https://github.com/community-scripts/ProxmoxVED/issues/678

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No breaking changes – Existing functionality remains intact.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • ✨ New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔍 Code & Security Review (X in brackets)

  • Follows Code_Audit.md & CONTRIBUTING.md guidelines
  • Uses correct script structure (AppName.sh, AppName-install.sh, AppName.json)
  • No hardcoded credentials

📋 Additional Information (optional)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVED/pull/739 **Author:** [@remz1337](https://github.com/remz1337) **Created:** 7/22/2025 **Status:** ✅ Merged **Merged:** 7/24/2025 **Merged by:** [@MickLesk](https://github.com/MickLesk) **Base:** `main` ← **Head:** `pr-update-merge` --- ### 📝 Commits (10+) - [`3428070`](https://github.com/community-scripts/ProxmoxVED/commit/3428070a0963b775575201f28c3ce98849748974) Adds script to update LXC services from the host, allowing to automatically increase resources if needed to build the service - [`5070576`](https://github.com/community-scripts/ProxmoxVED/commit/507057693a759af9de3b0b04a2fa161e431611e6) Merge branch 'community-scripts:main' into pr-update-lxcs-services - [`5ab98de`](https://github.com/community-scripts/ProxmoxVED/commit/5ab98dedd942ab7239f5c6cc92c0cc5127e4fe86) (WIP) Support updating multiple containers - [`f586a21`](https://github.com/community-scripts/ProxmoxVED/commit/f586a21e1e263bcd0e30f7a1aeb0f4678de39f2e) Add logic for unattended updates and reboot containers if needed (following user prompt) - [`b62b0cc`](https://github.com/community-scripts/ProxmoxVED/commit/b62b0ccc9b19900a8fb59bd221a237903b3ff290) Adds resources scaling logic - [`6c507a0`](https://github.com/community-scripts/ProxmoxVED/commit/6c507a0f9064983e574d8ad6a4f859ac69bee0e7) Remove old script and cleanup some messages - [`ae2c845`](https://github.com/community-scripts/ProxmoxVED/commit/ae2c84500ac0459a1b32ecedc00b6ba52611a82f) Allow updating stopped containers and check the download of the install script needed to assess build resource requirements - [`0f772b7`](https://github.com/community-scripts/ProxmoxVED/commit/0f772b7df561b8887b7cb35b5841eedefa1f0a87) Move functions to the top - [`9b1382d`](https://github.com/community-scripts/ProxmoxVED/commit/9b1382ddcf513030ae4205e14ecadf082e69c163) Remove msg_info call to prevent spinner from overriding the whiptail menu - [`3e2924d`](https://github.com/community-scripts/ProxmoxVED/commit/3e2924d2ed56f43f640c63fe9a3f9aab0ce860aa) Fix backup storage detection to support local dir ### 📊 Changes **1 file changed** (+82 additions, -31 deletions) <details> <summary>View changed files</summary> 📝 `tools/pve/update-apps.sh` (+82 -31) </details> ### 📄 Description 🛑 **New scripts must first be submitted to [ProxmoxVED](https://github.com/community-scripts/ProxmoxVED) for testing.** PRs for new scripts that skip this process will be closed. --- ## ✍️ Description Script to update the services of multiple containers at once. ## 🔗 Related PR / Issue Link: https://github.com/community-scripts/ProxmoxVED/issues/678 ## ✅ Prerequisites (**X** in brackets) - [X] **Self-review completed** – Code follows project standards. - [X] **Tested thoroughly** – Changes work as expected. - [X] **No breaking changes** – Existing functionality remains intact. - [X] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [X] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [ ] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [ ] 🆕 **New script** – A fully functional and tested script or script set. - [ ] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [ ] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs. --- ## 🔍 Code & Security Review (**X** in brackets) - [X] **Follows `Code_Audit.md` & `CONTRIBUTING.md` guidelines** - [X] **Uses correct script structure (`AppName.sh`, `AppName-install.sh`, `AppName.json`)** - [X] **No hardcoded credentials** ## 📋 Additional Information (optional) <!-- Add any extra context, screenshots, or references. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
giteasync added the pull-request label 2025-09-09 19:44:47 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
In Progress
Migration To ProxmoxVE
Ready For Testing
Ready For Testing
Started Migration To ProxmoxVE
Started Migration To ProxmoxVE
Started Migration To ProxmoxVE
addon/pve
awaiting external
not planned
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Octech6711
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: community-scripts/ProxmoxVED#251
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?