community-scripts/ProxmoxVED
2
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVED.git synced 2025-12-10 04:01:20 -06:00
Code Issues 34 Packages Projects Releases Wiki Activity

[PR #814] Comfyui #193

New Issue
Open
opened 2025-09-09 19:44:34 -05:00 by giteasync · 0 comments
giteasync commented 2025-09-09 19:44:34 -05:00
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVED/pull/814
Author: @jdacode
Created: 8/19/2025
Status: 🔄 Open

Base: main ← Head: comfyui

📝 Commits (10+)

📊 Changes

3 files changed (+233 additions, -0 deletions)

View changed files

➕ ct/comfyui.sh (+42 -0)
➕ frontend/public/json/comfyui.json (+47 -0)
➕ install/comfyui-install.sh (+144 -0)

📄 Description

🛑 New scripts must first be submitted to ProxmoxVED for testing.
PRs for new scripts that skip this process will be closed.

✍️ Description

Adds ComfyUI LXC Script

🔗 Related PR / Issue

Link: https://github.com/community-scripts/ProxmoxVE/discussions/3915

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No breaking changes – Existing functionality remains intact.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • ✨ New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔍 Code & Security Review (X in brackets)

  • Follows Code_Audit.md & CONTRIBUTING.md guidelines
  • Uses correct script structure (AppName.sh, AppName-install.sh, AppName.json)
  • No hardcoded credentials

📋 Additional Information (optional)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVED/pull/814 **Author:** [@jdacode](https://github.com/jdacode) **Created:** 8/19/2025 **Status:** 🔄 Open **Base:** `main` ← **Head:** `comfyui` --- ### 📝 Commits (10+) - [`87cd87c`](https://github.com/community-scripts/ProxmoxVED/commit/87cd87c6e2fc21b98a9f7b1ae077cbddad15398d) Init ComfyUI dev branch Testing - [`ea7298b`](https://github.com/community-scripts/ProxmoxVED/commit/ea7298b7df31691626ae8a37f1115a2ea474d25c) Fixed url build.func testing - [`dc95599`](https://github.com/community-scripts/ProxmoxVED/commit/dc955995413b25614fd3c37a97141d41b1a1b20c) Revert urls - [`ffd1b12`](https://github.com/community-scripts/ProxmoxVED/commit/ffd1b12322df5201eb7b2c9ba62fc5e029a585f6) Removed subfunctions - [`7c4e618`](https://github.com/community-scripts/ProxmoxVED/commit/7c4e618f8ff14891bc780f2fb9094b764164852b) Updated .sh correct url for testing - [`4c79d20`](https://github.com/community-scripts/ProxmoxVED/commit/4c79d203214f7297b4d4357d0173d0c27fbe3654) Fixed install.func for testing - [`fd252fc`](https://github.com/community-scripts/ProxmoxVED/commit/fd252fc463f87a75d773811bfb2b854fcf255c55) Fixed urls for testing - [`2e46718`](https://github.com/community-scripts/ProxmoxVED/commit/2e467183592d70c44a4d46d74aedce1b8db126b3) Added manager installation - [`11f3471`](https://github.com/community-scripts/ProxmoxVED/commit/11f3471f724a5bd7d53f050582efbe1ab9fcb5b6) Revert urls - [`a6f04e2`](https://github.com/community-scripts/ProxmoxVED/commit/a6f04e26b4cad97f0513cada386f0cff5c232a97) Updated script ### 📊 Changes **3 files changed** (+233 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `ct/comfyui.sh` (+42 -0) ➕ `frontend/public/json/comfyui.json` (+47 -0) ➕ `install/comfyui-install.sh` (+144 -0) </details> ### 📄 Description 🛑 **New scripts must first be submitted to [ProxmoxVED](https://github.com/community-scripts/ProxmoxVED) for testing.** PRs for new scripts that skip this process will be closed. --- ## ✍️ Description Adds ComfyUI LXC Script ## 🔗 Related PR / Issue Link: https://github.com/community-scripts/ProxmoxVE/discussions/3915 ## ✅ Prerequisites (**X** in brackets) - [X] **Self-review completed** – Code follows project standards. - [X] **Tested thoroughly** – Changes work as expected. - [X] **No breaking changes** – Existing functionality remains intact. - [X] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [ ] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [ ] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [X] 🆕 **New script** – A fully functional and tested script or script set. - [ ] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [ ] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs. --- ## 🔍 Code & Security Review (**X** in brackets) - [X] **Follows `Code_Audit.md` & `CONTRIBUTING.md` guidelines** - [X] **Uses correct script structure (`AppName.sh`, `AppName-install.sh`, `AppName.json`)** - [X] **No hardcoded credentials** ## 📋 Additional Information (optional) <!-- Add any extra context, screenshots, or references. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
giteasync added the
pull-request
 label 2025-09-09 19:44:34 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
In Progress
Migration To ProxmoxVE
Ready For Testing
Ready For Testing
Started Migration To ProxmoxVE
Started Migration To ProxmoxVE
Started Migration To ProxmoxVE
addon/pve
awaiting external
not planned
pull-request
Mirrored from GitHub Pull Request
question
No Label
pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Octech6711
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: community-scripts/ProxmoxVED#193
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?