community-scripts/ProxmoxVED
2
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVED.git synced 2026-04-10 05:58:11 -05:00
Code Issues 34 Packages Projects Releases Wiki Activity

[PR #866] Create docker-transmission-openvpn application #153

New Issue
Open
opened 2025-09-09 19:44:26 -05:00 by giteasync · 0 comments
giteasync commented 2025-09-09 19:44:26 -05:00
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVED/pull/866
Author: @SunFlowerOwl
Created: 9/4/2025
Status: 🔄 Open

Base: main ← Head: dev/SunFlowerOwl

📝 Commits (10+)

  • 91de209 Create docker-transmission-openvpn application
  • 4022543 Partially addressed review 1
  • 781851a Fix: Avoid .env generation error
  • 1135f85 Add execute right on image scripts
  • 7050bed Fix: Force transmission home var
  • 9017776 Fix: unsupported custom app path
  • 7f6ce18 Review: Make .env generation simpler
  • 4ad7f58 Fix: Change cron command causing error due to crlf
  • 27a8345 Review: Rework fetching WebUI
  • 43ce133 Improve cleaning up

📊 Changes

3 files changed (+318 additions, -0 deletions)

View changed files

➕ ct/transmission-openvpn.sh (+111 -0)
➕ frontend/public/json/transmission-openvpn.json (+40 -0)
➕ install/transmission-openvpn-install.sh (+167 -0)

📄 Description

🛑 New scripts must first be submitted to ProxmoxVED for testing.
PRs for new scripts that skip this process will be closed.

✍️ Description

Create ct maker script
Create installation script
Create web json config file
Add version in version.json
=> Need to create header

🔗 Related PR / Issue

[Script request]: docker-transmission-openvpn => transmission-openvpn #7402
Link: # https://github.com/community-scripts/ProxmoxVE/discussions/7402

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No breaking changes – Existing functionality remains intact.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • ✨ New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔍 Code & Security Review (X in brackets)

  • Follows Code_Audit.md & CONTRIBUTING.md guidelines
  • Uses correct script structure (AppName.sh, AppName-install.sh, AppName.json)
  • No hardcoded credentials

📋 Additional Information (optional)

I could not test with my fork because of hardcoded url referencing official ProxmoxVED.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVED/pull/866 **Author:** [@SunFlowerOwl](https://github.com/SunFlowerOwl) **Created:** 9/4/2025 **Status:** 🔄 Open **Base:** `main` ← **Head:** `dev/SunFlowerOwl` --- ### 📝 Commits (10+) - [`91de209`](https://github.com/community-scripts/ProxmoxVED/commit/91de209281efc513ee63d76db3cd002b7cca67a0) Create docker-transmission-openvpn application - [`4022543`](https://github.com/community-scripts/ProxmoxVED/commit/40225430abd4a7268db5227d1d509e3ce9467429) Partially addressed review 1 - [`781851a`](https://github.com/community-scripts/ProxmoxVED/commit/781851a0b7d855839befaa3a45faa71d8d8b102a) Fix: Avoid .env generation error - [`1135f85`](https://github.com/community-scripts/ProxmoxVED/commit/1135f85aaa31cfe5e09c83e896d392778ff63cef) Add execute right on image scripts - [`7050bed`](https://github.com/community-scripts/ProxmoxVED/commit/7050bed860b60351323cf742051ec39f3f05a43a) Fix: Force transmission home var - [`9017776`](https://github.com/community-scripts/ProxmoxVED/commit/9017776245b80e0b01951614228e88b54c9c3858) Fix: unsupported custom app path - [`7f6ce18`](https://github.com/community-scripts/ProxmoxVED/commit/7f6ce183144e25575360bbafd2baf46584f96078) Review: Make .env generation simpler - [`4ad7f58`](https://github.com/community-scripts/ProxmoxVED/commit/4ad7f58cdcd086befe77bdc396066d75f435c78b) Fix: Change cron command causing error due to crlf - [`27a8345`](https://github.com/community-scripts/ProxmoxVED/commit/27a834536524d53ad0fe6da896bc4506f80608bf) Review: Rework fetching WebUI - [`43ce133`](https://github.com/community-scripts/ProxmoxVED/commit/43ce13386c1854cf1a2e813365ef2bb227094c7c) Improve cleaning up ### 📊 Changes **3 files changed** (+318 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `ct/transmission-openvpn.sh` (+111 -0) ➕ `frontend/public/json/transmission-openvpn.json` (+40 -0) ➕ `install/transmission-openvpn-install.sh` (+167 -0) </details> ### 📄 Description 🛑 **New scripts must first be submitted to [ProxmoxVED](https://github.com/community-scripts/ProxmoxVED) for testing.** PRs for new scripts that skip this process will be closed. --- ## ✍️ Description <!-- Briefly describe your changes. --> Create ct maker script Create installation script Create web json config file Add version in version.json => Need to create header ## 🔗 Related PR / Issue [Script request]: docker-transmission-openvpn => transmission-openvpn #7402 Link: # https://github.com/community-scripts/ProxmoxVE/discussions/7402 ## ✅ Prerequisites (**X** in brackets) - [x] **Self-review completed** – Code follows project standards. - [x] **Tested thoroughly** – Changes work as expected. - [x] **No breaking changes** – Existing functionality remains intact. - [x] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [ ] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [ ] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [X] 🆕 **New script** – A fully functional and tested script or script set. - [ ] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [ ] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs. --- ## 🔍 Code & Security Review (**X** in brackets) - [ ] **Follows `Code_Audit.md` & `CONTRIBUTING.md` guidelines** - [ ] **Uses correct script structure (`AppName.sh`, `AppName-install.sh`, `AppName.json`)** - [ ] **No hardcoded credentials** ## 📋 Additional Information (optional) <!-- Add any extra context, screenshots, or references. --> I could not test with my fork because of hardcoded url referencing official ProxmoxVED. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
giteasync added the pull-request label 2025-09-09 19:44:26 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
In Progress
Migration To ProxmoxVE
Ready For Testing
Ready For Testing
Started Migration To ProxmoxVE
Started Migration To ProxmoxVE
Started Migration To ProxmoxVE
addon/pve
awaiting external
not planned
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Octech6711
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: community-scripts/ProxmoxVED#153
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?