[PR #876] Add amdgpu_top build scripts #142

Open
opened 2025-09-09 19:44:24 -05:00 by giteasync · 0 comments

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVED/pull/876
Author: @PeterSuh-Q3
Created: 9/9/2025
Status: 🔄 Open

Base: mainHead: main


📝 Commits (1)

  • d47a3d2 Add amdgpu_top build scripts

📊 Changes

1 file changed (+214 additions, -0 deletions)

View changed files

tools/addon/amdgpu_top-build.sh (+214 -0)

📄 Description

The provided script automates the installation and build process of the AMD GPU monitoring tool called amdgpu_top on Linux systems such as Ubuntu. The main workflow includes:

  1. Installing required build packages via apt, including build-essential, git, curl, and development libraries like libdrm.

  2. Installing the Rust programming environment via the official rustup script, which provides the latest Rust compiler and Cargo.

  3. Setting Rust environment variables for the current shell session by sourcing $HOME/.cargo/env.

  4. Cloning the amdgpu_top repository from GitHub and building it using cargo.

  5. Copying the compiled binary to /usr/sbin for system-wide availability.

🛑 New scripts must first be submitted to ProxmoxVED for testing.
PRs for new scripts that skip this process will be closed.


✍️ Description

Link: #

Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No breaking changes – Existing functionality remains intact.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔍 Code & Security Review (X in brackets)

  • Follows Code_Audit.md & CONTRIBUTING.md guidelines
  • Uses correct script structure (AppName.sh, AppName-install.sh, AppName.json)
  • No hardcoded credentials

📋 Additional Information (optional)

487087700-f17ee3b8-9391-434e-84f4-9e670b2cc3bc 487087733-e011b5c2-ee3b-4d13-b9d4-466999d85911 487087759-040d0458-19b7-48fb-ac71-ab4d9d8c2019 487087823-6207f0cb-86fe-4889-8454-369a90db3924

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVED/pull/876 **Author:** [@PeterSuh-Q3](https://github.com/PeterSuh-Q3) **Created:** 9/9/2025 **Status:** 🔄 Open **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`d47a3d2`](https://github.com/community-scripts/ProxmoxVED/commit/d47a3d2449965ef5cda725ffc8b0d78610505fbc) Add amdgpu_top build scripts ### 📊 Changes **1 file changed** (+214 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `tools/addon/amdgpu_top-build.sh` (+214 -0) </details> ### 📄 Description The provided script automates the installation and build process of the AMD GPU monitoring tool called amdgpu_top on Linux systems such as Ubuntu. The main workflow includes: 1. Installing required build packages via apt, including build-essential, git, curl, and development libraries like libdrm. 2. Installing the Rust programming environment via the official rustup script, which provides the latest Rust compiler and Cargo. 3. Setting Rust environment variables for the current shell session by sourcing $HOME/.cargo/env. 4. Cloning the amdgpu_top repository from GitHub and building it using cargo. 5. Copying the compiled binary to /usr/sbin for system-wide availability. 🛑 **New scripts must first be submitted to [ProxmoxVED](https://github.com/community-scripts/ProxmoxVED) for testing.** PRs for new scripts that skip this process will be closed. --- ## ✍️ Description <!-- Briefly describe your changes. --> ## 🔗 Related PR / Issue Link: # ## ✅ Prerequisites (**X** in brackets) - [x] **Self-review completed** – Code follows project standards. - [x] **Tested thoroughly** – Changes work as expected. - [x] **No breaking changes** – Existing functionality remains intact. - [x] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [ ] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [ ] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [x] 🆕 **New script** – A fully functional and tested script or script set. - [ ] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [ ] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs. --- ## 🔍 Code & Security Review (**X** in brackets) - [x] **Follows `Code_Audit.md` & `CONTRIBUTING.md` guidelines** - [x] **Uses correct script structure (`AppName.sh`, `AppName-install.sh`, `AppName.json`)** - [x] **No hardcoded credentials** ## 📋 Additional Information (optional) <!-- Add any extra context, screenshots, or references. --> <img width="880" height="551" alt="487087700-f17ee3b8-9391-434e-84f4-9e670b2cc3bc" src="https://github.com/user-attachments/assets/693a621a-a548-44ad-9783-30936f912430" /> <img width="570" height="365" alt="487087733-e011b5c2-ee3b-4d13-b9d4-466999d85911" src="https://github.com/user-attachments/assets/095d0f1d-d6f3-4ca5-8174-095875f1060b" /> <img width="616" height="342" alt="487087759-040d0458-19b7-48fb-ac71-ab4d9d8c2019" src="https://github.com/user-attachments/assets/7687bd89-16aa-48b2-be78-97fc88cb99bd" /> <img width="721" height="682" alt="487087823-6207f0cb-86fe-4889-8454-369a90db3924" src="https://github.com/user-attachments/assets/7933afbc-3a90-4c40-bea2-e5263266c0ea" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
giteasync added the
pull-request
label 2025-09-09 19:44:24 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: community-scripts/ProxmoxVED#142
No description provided.