It has been broken for a long time (No available formula with the name
"code-server") but it looks like they have their own bot publishing
updates anyway.
Mostly because express-serve-static-core is an implicit dependency. We
could make it explicit, but the type we imported from it is just an
alias for qs.ParsedQs anyway.
It seems Chromium cannot use maskable icons. It complains that the
"purpose" must contain "any", however maskable icons are not suitable
for the "any" purpose.
So, add pre-masked icons to be used for the "any" purpose.
It can be set either:
1. In the product.json (normally the product.json is embedded during the
build and not read at run-time).
2. With the --link-protection-trusted-domains flag.
We are getting an issue importing __future__ from annotations in one
case and "invalid syntax" in another with `if CC :=`.
There does not seem to be a reason to maintain a separate step for the
amd64 build since the glibc version is the same.
We are trying to update Express to fix a vulnerability.
We would have to update the plugins as well, but since we are no longer
using the plugin system, we can just delete it instead.
* Update Code to 1.98.0
* Avoid sudo when launching caddy
It is erroring about needing a password, but also do we even need to run
this as root considering we are not binding to privileged ports?
---------
Co-authored-by: Asher <ash@coder.com>
* Update Code to 1.97.0
* Update flake
This is to get a newer version of Node since we need > 20.18.1.
* Hijack new base path var
* Update test path matchers
While trying to set up code-server on Alpine, I ran into build errors. To solve them, I had to add Kerberos development libs. Also, it looks like npm config doesn't work in recent version of Node and doesn't seem to be necessary. These instructions were tested in the Docker `node:20-alpine` image.
server-main.js runs itself outside a code-server context, which is
determined using the CODE_SERVER_PARENT_PID environment variable. This
is set by the wrapper, but there is no wrapper when running the
cli (only for the server), so this resulting in the cli running
twice (one self-run on initial import, again when we run spawnCli).
This might fix https://github.com/coder/code-server/issues/7042
* Update Code to 1.95.1
* Update Node to 20.18.0
* Update build.yaml to use Ubuntu 22.04
This is to resolve a gcc error. Might have to address
the release step later as well.
* Fix --stdin-to-clipboard
With the switch to esm, the fs require is failing. fs is already
imported, so we can just use it anyway.
* Fix mangled exports
* Update CSP hashes
* Update Code to 1.94.2
* Convert from yarn to npm
This is to match VS Code. We were already partially using npm for the
releases so this is some nice alignment.
* Update caniuse-lite
This was complaining on every unit test.
* Update eslint
I was having a bunch of dependency conflicts and eslint seemed to be the
culprit so I just removed it and set it up again, since it seems things
have changed quite a bit.
* Update test dependencies
I was getting oom when running the unit tests...updating seems to work.
* Remove package.json `scripts` property in release
The new pre-install script was being included, which is dev-only.
This was always the intent; did not realize jq's merge was recursive.
* Remove jest and devDependencies in release as well
* Update test extension dependencies
This appears to be conflicting with the root dependencies.
* Fix playwright exec
npm does not let you run binaries like yarn does, as far as I know.
* Fix import of server-main.js
* Fix several tests by waiting for selectors
This reverts commit 1abb2ee567d8081d9e8935e1193b2e31f0d8e834.
Trying to see if this fixes the release making separate drafts instead
of a single draft.
* Update VS Code to 1.92.2
* Use server-main.js to load VS Code
It looks like the bootstrap files are now bundled so we can no longer
require them. We could make them included again, but maybe it is better
to go through the main entrypoint anyway because it includes some nls
stuff which is maybe necessary.
This also fixes what looks like a bug where we could create two servers
if two requests came in. I am not sure what the practical consequences
of that would be, but it will no longer do that.
* Drop es2020 patch
Unfortunately, VS Code will not load with this. It seems to be because
`this` is being used in static properties, and it becomes `void 0` for
some reason under the es2020 target. For example:
static PREFIX_BY_CATEGORY = `${this.PREFIX}${this.SCOPE_PREFIX}`;
becomes
AbstractGotoSymbolQuickAccessProvider.PREFIX_BY_CATEGORY = `${(void 0).PREFIX}${(void 0).SCOPE_PREFIX}`;
Which, obviously, will not work.
Older versions of Safari (and maybe other browsers) are likely affected.
* Fix display language
* Update Playwright
I think maybe because of the dropped es2020 patch that Webkit is now
failing because it is too old.
* Do not wait for networkidle in e2e tests
I am not sure what is going on but some tests on Webkit are timing out
and it seems the page is loaded but something is still trying to
download. Not good, but for now try to at least get the tests passing.
- We have a labeling bot that is marking issues as upstream (so far
correctly) now Ranger is closing them right away and it felt too
aggressive to me.
- It keeps posting its comment twice. Not sure how to fix that.
There is a `yarn ci` script which was using audit-ci but this does not
appear to be called anywhere.
The security worflow uses `yarn audit` and `npm audit` which seem fine
enough anyway.
It is not working. I test this manually anyway so for now just remove
the test, but I think maybe we have to watch for code-server to extract
the language files, and then reload the page, or maybe we have to
install the language from the UI.
Ideally we can drop our patch in the future anyway...
The first argument is a file name, not a path. When the log gets
rotated it prepends the date which ends up creating a path in the
current working directory.
Might make sense to cache the rest as well, and evict from the cache
periodically. For now this is enough to fix a hang I often see in our
deployment of Coder. Might only be surfacing now because new telemetry
calls were added to startup.
Additionally:
- Update Node to 20.11.1
- Update documentation
- Disable extension signature verification
This works around an issue where the Open VSX is not returning the
expected zip. Verification is skipped later anyway because
@vscode/vsce-sign is missing in the OSS version.
It seems that * matches a literal * now, so we have to use a regular
expression.
Parentheses around a parameter no longer works (it causes it to match on
the parameter name literally) and I am not sure why we had it anyway as
it had no effect previously.
Matching with a leading / does not appear to work either, but we do not
need the leading / anyway since the proxy logic was changed to use the
whole path. Consequently it will never be / anymore from what I can
tell but I left that check in just in case. I turned it into a named
parameter as well, because that seems better.
- Remove the redundant title prefix.
- Remove outdated assignees.
- Improve reproduction step description (trying to get folks to submit
more specific/detailed reproductions).
- Render logs with shell (not sure if this actually changes anything).
- Use dropdowns for testing in VS Code and Codespaces. I think the
existing checkboxes are still confusing so hopefully this sorts it.
These checkboxes keep getting checked despite the submitter using an
insecure context or not having tested upstream. I think two things are
at play here:
1. Folks might be interpreting "cannot reproduce" as "did not
reproduce" or "did not have time to reproduce".
2. The checkboxes are required to submit the issue so folks might be
marking them just so they can get their issue submitted; maybe they
are not even reading the checkboxes and are just seeing the error
that they need to be marked and blindly marking them because while
in some cases folks will add "I had to check this but it is not
true", usually they say nothing.
In any case, hopefully these changes make the checkboxes more accurate,
and then if they are unchecked we can ask them to go reproduce in VS
Code or use a secure context or whatever the case may be.
This is just a guard in case there are paths where the workspace is
already marked as initialized but the workspace configuration is not and
we end up actually un-initializing it.
And fix the workspace bug. It is caused by an issue with how some
global variables are being used asynchronously and is exacerbated by the
delay reading settings from the remote introduces.
1. The workspace is created and is marked as not initialized.
2. The configuration's change handler is triggered, and now
initialization is complete.
3. The handler tries to set the global workspace variable to initialized
but the workspace has not been set yet so we get an undefined error.
4. The workspace global is now set, but it is set to the old value with
initialized still set to false.
5. Workspace is never marked as initialized until something else
triggers the on change handler again.
Fixes#3061, and closes#6546.
My guess is this logic changed in one of the VS Code updates,
introducing this async bug but never getting caught probably because for
them the settings are always local thus minimal delay.
The main goal of this patch was to make user settings stored on disk
instead of in the browser, but this stopped working some time ago. Not
only that but it is causing a bug where a workspace will not fully open.
A secondary goal was to fix the Vim extension but the extension appears
to work just fine without this change now (both the server and browser
versions).
This patch is not useful anymore anyway because there are remote-level
settings that *do* get stored on disk and can be used instead of
user-level settings when necessary.
Fixes#3061, and possibly #6153.
This should make it much easier to update. Also use 18.15.0
specifically since that is what VS Code ships with.
Additionally, it fixes the post-install script being skipped due to
a Yarn v1 bug that happens when Yarn installs node-gyp, which
it does because 18.18 onward stopped bundling node-gyp.
* Update Code to 1.83.1
* Patch out lookbehind for Safari support
Not sure why it needs a lookbehind unless a number followed by a capital
letter is not supposed to be considered a new word, which seems wrong to
me. The tests do not contain any numbers so I can only guess.
---------
Co-authored-by: Asher <ash@coder.com>
Since the release of code-server v4.17.0 (Code 1.82), "Command Center" has become a default option. However, the current code-server PWA app lacks support for the Windows control overlay, resulting in an untidy appearance of the title bar. This commit introduces modifications to the manifest file to enable support for the window control overlay.
Also remove github.com from the trusted domains. This causes the
browser to block the popup instead (probably because the space between
interaction and popup is too great), which is difficult to notice in
Chromium. Even in Firefox with the extra bar they add at the top it can
be easy to miss.
* Fix building from source on arm
Not building from source causes argon2 to pull the wrong arch, so we
have to build from source.
But building from source is causing the new Kerberos module to fail on
arm64 and keytar to fail on both.
The latter has been very difficult to debug because the GitHub image
provides a different result to containers based on Ubuntu 20.04.
Because of this, use a container instead.
Use debian:buster as the container because it is easier to set up the
architecture sources (no need to modify the sources) and because it
seems to come with glibc 2.28 rather than 2.31.
Also use the exact version of Node (18.15.0) for reproducibility.
* Set owner and group during tar to zero
Otherwise you get IDs that can cause (benign) errors while extracting,
which might be confusing. At the very least, I did not see these errors
from previous tars (although they seem to use 1001).
There is no guarantee what IDs might exist so 0 seems the most
reasonable.
The comment said the issue with argon2 was related to CentOS 7 but the
cross-compile steps never used CentOS 7 so maybe the real issue is with
the architecture.
* Avoid packaging yarn.lock
Since the shrinkwrap is what we want everything to use.
* Build with npm
It seems we stuck with yarn because npm was giving us errors but I will try
sorting it out now so we can build with npm as originally intended.
* Remove build from source
Not using CentOS 7 anymore so based on the comment we no longer need
this. Keytar seems to install fine now.
* Update missed Node version
These numbers are all over the place.
* npm_config_arch must be lowercase
* Patch out Kerberos
I am not sure exactly how it is used but I think it is not a path code-server
worries about, at least not right now. Just going to patch it out rather than
figure out how to build it on armv7l but we can revisit later.
* Update dependencies and force-update qs
This is mainly an attempt to get rid of as many resolutions as possible
since it seems they are unnecessary except for qs (according to yarn/npm
audit).
For qs use 6.9.7 since Express is using 6.9.6 and that matches the most
closely.
Also add overrides since this is npm's version of yarn's resolutions and
we need it for the shrinkwrap to generate with the right dependencies.
Decided to keep pinning @types/node as well although I am not sure it is
necessary. Express is pulling in v20 types. Since this is
development-only we only need it in resolutions.
* Run formatter
Some rules seem to have changed with the dependency updates.
* Replace deprecated bodyParser.json() usage
* Audit npm shrinkwrap as well
* Skip installing dependencies in audit
It seems the tools only require the lock files.
* Fix tests when using ipv6
* Add missing openssl dependency to flake
At least, for the standalone and for anyone running on default Node 18.
If support for 2.17 is needed then one would need to build Node 18 with 2.17 and then build code-server with that version (specifically, the native npm modules).
* Update VS Code to 1.82.2
* Add new libkrb5 dependency
* Update patches
The only changes were to context except:
- The URL callback provider uses a new _callbackRoute argument and moved
locations.
- The telemetry provider gets passed the request service as the first
argument now.
- CSP hash changed, as usual.
* Update Node to v18
* Revert back to es2020
es2022 is breaking Safari.
The tilde is ambiguous and it can be helpful to know exactly what paths
code-server is trying to use, especially if it is running as a different
user than you expected.
Added a guide on proxying to a Svelte app since there wasn't one already. Used the vue and angular guides as a template and included a link to an issue post on sveltekits website which adds some context.
* Avoid spawning code-server with --reuse-window and --new-window
These flags mean the user explicitly wants to open in an existing
instance so if the socket is down it should error rather than try to
spawn code-server normally.
* Set session socket into environment variable
While I was at it I added a CLI flag to override the default. I also
swapped the default to --user-data-dir.
The value is set on an environment variable so it can be used by the
extension host similar to VSCODE_IPC_HOOK_CLI.
* Add e2e test for opening files externally
The indented logs technically apply to the HTTP server so move the
session server log afterward to avoid making them look like they apply
to the session server.
Mostly just the usual shifting or changing of the surrounding context
but I did refactor the getting started block we insert because it keeps
getting mangled on each update. Instead of shifting things around the
columns I just prepend it to the right column.
Getting 404s on some vsda module but everything seems to work
without it and I do not see it referenced in the package.json nor a
nywhere on npmjs.com so it seems to be optional.
This is not a valid ID (to install a specific version you use @) and,
quite strangely, Code is now returning an "extension not found" error if
the ID is invalid, breaking the test since we expect it to error about
the marketplace not existing.
* Update to 1.78.1
No changes needed in the patches other than moving some lines around and
updating the CSP hash as usual.
The flake had to be updated as it was using Node 16.16 and 16.17 is
required at minimum now. Also python seems to install python2 which is
marked as deprecated so explicitly install python3.
* Update to 1.78.2
Patches applied without any conflicts.
* Update commit environment variable
This was causing the commit not to be set. It broke display languages
since that has a hard dependency on the commit for directory names.
Possibly broke other things.
Extracted host detection into a separate function to avoid multiple log
lines on each return and went with a thrown error to consolidate the
common log text.
* Update Code to 1.76.1
- worker-src already contains blob so we can avoid patching that.
- localeService moved.
- Remaining changes were just line changes.
* Make language extensions installable again
Still might want to look into making the native language support work
but for now it seems better not to break backwards compatibility since
the native implementation is quite different.
* Avoid "install in browser" for language packs
It will not work.
* Import correct locale service
I believe before the contributions imported this but now we have to do
it here.
Looks like the images got updated to v18 so they started failing. For
npm install v16 and for Docker just run the script directly, it seems
silly to waste time installing v16 just to run a script through yarn.
* Move splitOnFirstEquals to util
I will be making use of this to parse the forwarded header.
* Type splitOnFirstEquals with two items
Also add some test cases.
* Check origin header on web sockets
* Update changelog with origin check
* Fix web sockets not closing with error code
- Move differences to the Codespaces section since they apply to both
Codespaces and OpenVSCode-Server
- Add some important missing differences
- Exclude settings sync (not being worked on)
- Exclude the plugin API (deprecated)
- Exclude certificate support (browsers these days are starting to
require trusted certs so better not to recommend using this)
This does not seem to actually cause an issue (not resolving ends up
with the same behavior as resolving with false) but I am not sure if the
hanging promises would be a memory leak so seems best to fix.
* Update Code to 1.75.0
- getting-started.diff: The way to get an icon's class changed
- proxy-uri.diff: The product service is passed in so we can get the
proxy URI from that now instead of passing it in separately.
* Remove workspace trust test
Something in how/when Code displays the trust dialog appears to have
changed, failing the test. I am not sure it makes sense for us to be
testing upstream code anyway.
* Use regular Node for watch
Since we spawn the watch script with ts-node it was using ts-node for
the web server spawn as well. With latest Code there are for some
reason type errors (it cannot find @types/node) but this is already
compiled code which already passed type checks; any type errors here are
useless. To fix spawn with regular Node.
* Fix some workers not loading
This is failing CI on Dependabot PRs. Opted to just remove it since
most (all?) PRs will be from forks and this workflow will not run
anyway. If we figure out the secret situation we can add it back.
It is causing CI to fail for Dependabot (no access to the token) and it
does not work with forks and currently there is no one who pushes
straight to the repo so this will never be used.
Can always add it back if we figure out how to make the secrets work.
* docs: add difference between Coder
Add a short block explaining the difference between code-server and
Coder.
* docs: add new doc coder.md under Install
This adds a new doc explaining how to install code-server in a Coder
workspace using Terraform.
* feat: add i18n in login page
* fix: add word space and put the app name into the title
* fix: remove duplicate replace title
* fix: prettier format code
* fix: fix typescript check warning
* fix: add zh-cn locale file code owner
* fix: use existing flag locale to the login page
Co-authored-by: Joe Previte <jjprevite@gmail.com>
* feat(ci): add lint-actions step to build.yaml
This adds a new job to the Build CI pipeline to lint our GitHub Actions.
By doing this, we can prevent typos from slipping in.
Fixes#5776
* fix: disable shellcheck in actionlint
I don't think we want to enable this for now.
* fix: ignore set-output warnings for now
It's deprecated but there isn't a reason to move away from using it yet.
* chore: update renovate.json ignoreDeps
ansi-regex, env-paths and limiter all switch to ESM which we can't
support at the moment so ignore updates for now.
* chore: update actions/cache@v3
* chore: update minor deps
* chore: add pretteir to renovate.json
* chore: upgrade Code to 1.74.1
* chore: remove require in integration.diff
I don't know what the impact of this is but in 192c67db71
they removed the usage of `require` in `server.main.ts`.
More details in PR: https://github.com/microsoft/vscode/pull/165831
* chore: update marketplace.diff
* chore: update sha hash in webview.diff
* chore: update disable-builtin-ext-update.diff
If my logic is right, then this patch is now simplified thanks to this:
https://github.com/microsoft/vscode/blob/1.74.1/src/vs/workbench/contrib/extensions/browser/extensionsWorkbenchService.ts#L1238
* chore: refresh proxy-uri patch
* chore: refresh local-storage.diff
* chore: refresh sourcemaps.diff
* chore: refresh disable-downloads.diff
* chore: refresh display-language.diff
* chore: refresh getting-started.diff
* docs: update testing notes for cli-window-open
* docs: update telemetry testing instructions
* fix: add GITHUB_TOKEN to build code-server job
Downloading @vscode/ripgrep is failing only in CI so adding this
environment variable to see if it increases the rate limit.
Ref: https://github.com/microsoft/vscode-ripgrep#github-api-limit-note
* refactor: use own cache key build code-server job
* temp: disable vscode test
* refactor: delete wrapper test
* Revert "refactor: delete wrapper test"
This reverts commit 3999279b73c3519c7dbb03dfc7076bf26f717e13.
* refactor: move vscode tests to e2e (#5911)
* wip: migrate vscode tests to e2e
* feat: add codeWorkspace to global setup
* refactor: only use dir in spawn when we should
* wip: migrate more tests
* refactor: move all vscode tests to e2e
* refactor(ci): move unit to own job
* fixup: add codecov to unit test step
* Update test/e2e/models/CodeServer.ts
* Update test/e2e/models/CodeServer.ts
* docs: add note about intercept requests
* refactor: rm unused clean() calls
* refactor: delete duplicate test
* refactor: update 'should not redirect' test
* refactor: rm unused imports
* refactor: rm unnecessary navigate call in test
* fixup: formatting
* wip: update test
* refactor: modify assertion for proxy
* fixup: use REVERSE_PROXY_BASE_PATH
* refactor: add helper fn getMaybeProxiedPathname
* fixup: formatting
* fixup: rm unused import
* chore: increase playwright timeout
* Revert "chore: increase playwright timeout"
This reverts commit a059129252216c5f5cba83e9bca3d90cf658b7be.
* chore: rm timeout
* refactor: remove keytar dep in cross-compile
* refactor: try other keytar package
* refactor: remove keytar step in cross-compile
* fix: manually remove keytar
* try this first
* I think this is it
* Revert "I think this is it"
This reverts commit 5c566b0c0126da1d3baa2f3c69e26fe1cc63fe93.
* okay this is it
* fixup
* try legacy peer
* remove keytar before standalone
* wrong path
* maybe
* revert: change *npm* back to npm*
* revert: don't uninstall keytar
* fix: use npm run standalone-release
* fixup formatting
* Revert "refactor: remove yarn.lock steps (#5850)"
This reverts commit 907747d3949301d8836e71938940f6275b016062.
* fixup: remove the --exclude
* refactor: remove yarn.lock check
* try ddd in postinstall
* refactor: cache before release:standalone
* refactor: add os to cache key in release
* chore: formatting
* Update ci/build/npm-postinstall.sh
* fixup: formatting
* refactor: remove keytar dep in cross-compile
* refactor: try other keytar package
* refactor: remove keytar step in cross-compile
* fix: manually remove keytar
* try this first
* I think this is it
* Revert "I think this is it"
This reverts commit 5c566b0c0126da1d3baa2f3c69e26fe1cc63fe93.
* okay this is it
* fixup
* try legacy peer
* remove keytar before standalone
* wrong path
* maybe
* revert: change *npm* back to npm*
* revert: don't uninstall keytar
* fix: use npm run standalone-release
* fixup formatting
* Revert "refactor: remove yarn.lock steps (#5850)"
This reverts commit 907747d3949301d8836e71938940f6275b016062.
* fixup: remove the --exclude
* refactor: remove yarn.lock check
Co-authored-by: repo-ranger[bot] <39074581+repo-ranger[bot]@users.noreply.github.com>
When I did the last release, `VERSION` wasn't defined which lead to a
blank string in the PR title and the commit message here:
https://github.com/coder/code-server-aur/pull/24
This should fix that.
* refactor: default to npm in postinstall.sh
yarn has a bug where it will try to update dependencies even if
`yarn.lock` is present. Therefore we're defaulting to `npm` to prevent
further issues.
* refactor: exclude yarn.lock in standalone
By excluding `yarn.lock`, we prevent issues where the user must use
`yarn` instead of `npm` to install code-server.
* wip: changelog
* fixup
* fix: add +x to product.json in build-vscode
While testing a pre-release, there seems to be a bug with the file
permissions for `product.json`. Adding `chmod +x` to see if that fixes
it.
* chore: increase timeout
* fix: keep product.json file permissions in release
When we added the change to modify the `package.json` version using `mv`
and `jq` we didn't account for lost file permissions.
This caused a bug only happening in CI.
This should fix it by giving it 755 via `chmod`.
* trigger ci
* chore: update package.json bust cache
* fixup!: fix: keep product.json file permissions in release
* Revert "fix: add +x to product.json in build-vscode"
This reverts commit fc4d2b532f41277d6b93243cd6bd2ba2434f80d6.
* chore: pin ubuntu runner in build code-server
* chore: update prettierignore
* chore: add notes to changelog
* chore: use ubuntu-22.04 for e2e
* chore: pin all jobs in build to ubuntu 20.04
* feat(wrapper): add tests for isChild
* fixup: include description ts-expect-error comment
* chore: update CHANGELOG
* chore: update Helm chart
* fixup: use our childProcess
* Update CHANGELOG.md
Co-authored-by: Asher <ash@coder.com>
Co-authored-by: Asher <ash@coder.com>
This adds documentation for the flag `--edge` which we've had for a
while but forgot to document.
Fixes#5717
Co-authored-by: repo-ranger[bot] <39074581+repo-ranger[bot]@users.noreply.github.com>
* chore: upgrade Code to 1.73.0
This upgrades Code to 1.73.0 via the tag.
* chore: refresh integration patch
* chore: clean up base-path patch
Only change here was they moved
lib/vscode/src/vs/platform/extensionResourceLoader/common/extensionResourceLoader.ts
so I had to update it. Code still looks the same though.
* chore: refresh proposed-api patch
* chore: update marketplace patch
Simlar to a previous patch, the location of
lib/vscode/src/vs/platform/extensionResourceLoader/common/extensionResourceLoader.ts
changed so I had to update this patch.
No changes to code itself.
* chore: update hash in webview patch
I believe there was only one to update but I may have missed one.
* chore: refresh disable-builtin-ext-update.diff
* chore: refresh update-check
quilt couldn't apply it so I had to add one change in manually to
lib/vscode/src/vs/server/node/serverEnvironmentService.ts
* chore: refresh logout patch
* chore: refresh proxy-uri patch
* chore: refresh local-storage patch
* chore: refresh sourcemaps patch
* chore: refresh disable-downloads patch
* chore: refresh telemetry patch
* refactor: re-apply display-language patch
This kinda got removed but I added it back in.
* refactor: drop exec-argv patch
This was accepted upstream! :tada
* chore: refresh getting-started patch
* fixup: add missing slash in marketplace
* fixup: update notes proposed-api patch
* fixup: support this.args.log as string
Seems like upstream now uses a string[] for this. For now, support
string.
See
2b50ab06b1
* Revert "fixup: support this.args.log as string"
This reverts commit 78c02a1f137655e27f3137e1d07a274e482baf6b.
* fixup!: add log to toCodeArgs
This was changed upstream from `string` to `string[]` so now we convert
to an array in `toCodeArgs`.
See 78c02a1f13
* fixup: update telemetry description
* refactor: get version dynamically
* chore: remove version
* fixup: missing quotes
* refactor: drop global VERSION
* wip: updating ersion in publish
* refactor: update publish.yaml with version changes
* refactor: release.yaml with new version changes
* refactor: update build.yaml with version changes
* chore: update maintainer
* fixup: update version in build-vscode
* fixup: fix github env version
* try macos only
* try again
* last resort
* joe again
* this oneee
* fixup: this should work
* try using inputs
* docs: update release notes
* fixup!: use env.VERSION in docker step
* fixup!: comment get and set version
* fixup!: remove compress release package comment
* fixup!: use $VERSION in npm-version
* refactor: set VERSION in build VS Code step
* refactor: use 0.0.0 in package.json version
* refactor: delete release-prep script
* Update ci/build/build-vscode.sh
* fixup!: remove extra VERSION set in aur
* Improve getting started Coder CTA
This wasn't very standout-ish before, and I think it's
wise for us to experiment with directing users to Coder.
* Update nix flake
* Update diff
* Add advert to code-server install
* Fix patch to reset columns if getting started is disabled
* Update text for advert
* chore: bump version to 4.8.2
* chore: update CHANGELOG
* docs: add back line in publishing release
See https://github.com/coder/code-server/pull/5732#discussion_r1010685933
* Revert "chore: bump version to 4.8.2"
This reverts commit 5d70994f22e461602a64f39771b27c78d6c38dcf.
* fixup: use 4.8.2-rc.1
* docs: add release candidate notes
* refactor: warn plugin range incompatibble
* chore: bump version 4.8.2
* fix: use * for test plugin engines
This removes the need to update this version with every version change.
* refactor: use npm-package in release assets
This adds a new job to `release.yaml` to upload the `npm-package` to the
release assets which will also allow us to download it in the
`publish.yaml` workflow.
* docs: update release instructions
* fixup!: use package.tar.gz
* fix: use * for test plugin engines
This removes the need to update this version with every version change.
* refactor: use npm-package in release assets
This adds a new job to `release.yaml` to upload the `npm-package` to the
release assets which will also allow us to download it in the
`publish.yaml` workflow.
* docs: update release instructions
* feat: add getting-started patch
This modifies the text on the Getting Started page to promote
coder/coder.
* feat: add --disable-getting-started-override
This adds a new CLI flag to code-server called
`--disable-getting-started` which will be used in Code to not use
Coder's custom Getting Started text.
* refactor: conditionally show coder getting started
This modifies the getting started patch changes to work with the new
`--disable-getting-started-override`.
The flag is false by default meaning the Coder getting started is shown.
By passing the flag to code-server, it will not be shown.
* docs: update faq for getting started override
* docs: update getting-started patch description
* fixup!: update patch
* fixup!: unit test
* feat: add more tests
* fixup!: use correct env var in tests
Co-authored-by: repo-ranger[bot] <39074581+repo-ranger[bot]@users.noreply.github.com>
* fix: update hashes in webview patch
We missed a hash update and also had the wrong hash for another HTML
file which caused issues in 4.8.0.
* refactor: move parent-origin into webview
Not sure why but we were seeing argon2/node-gyp issues after this
upgrade while running `yarn release:standalone`. For now, downgrading to
0.29.0 seems to fix the issue when testing locally.
Co-authored-by: repo-ranger[bot] <39074581+repo-ranger[bot]@users.noreply.github.com>
* feat: enable ports panel in proxy-uri patch
This makes the forwarded ports panel enabled by default.
* feat: add tunnelProvider in proxy-uri patch
This adds a `tunnelProvider` along with a `tunnelFactory` so that ports
are forwarded and use code-server's built-in proxy.
* fixup!: update import
* fix: skip uri modification if authority host match
This adds a check in our `resolveExternalUri` patch to skip modifying if
the `authority` and the `location.host` match to prevent
`localhost:<port>/proxy/<port>` from being modified.
* fixup!: refresh patch
* fixup!: move authority check up
* fixup!: remove comment
* fixup!: add trailing slash
* fix: add handle for resolveExternalUri
This adds a fix to properly handle `resolveExternalUri` which is used by
extensions like Tabnine.
* fixup!: update patch
* fixup!: force update proxy patch
* fixup!: use proxyEndpointTemplate else manually add
* fixup!: throw error if productConfiguration missing
* feat(testing): add asExternalUri
This modifies the test extension used in e2e test by registering a new
command for testing `asExternalUri`.
* feat: add e2e test for asExternalUri
* docs: update playwright setup comments
* feat: add support for VSCODE_PROXY_URI
* chore: refresh patches
* feat: add test for VSCODE_PROXY_URI
* chore: add metadata to lang extension
* fixup!: fix part of service-worker patch
* fixup!: remove e2e test, update patch notes
* fixup!: refresh disable-downloads
* fixup!: formatting
* add customization options for the login page
* add unit tests
* add test for correct welcome text when none is set but app-name is
Signed-off-by: niwla23 <46248939+niwla23@users.noreply.github.com>
* add test for no app-name set and check in title too
Signed-off-by: niwla23 <46248939+niwla23@users.noreply.github.com>
Signed-off-by: niwla23 <46248939+niwla23@users.noreply.github.com>
Co-authored-by: Joe Previte <jjprevite@gmail.com>
* docs: add toc to CODE OF CONDUCT
* chore: add prettier ignore blocks to docs
* chore: update styles for Dockerfile
* refactor: separate prettier, doctoc
This does a couple things:
- update `.prettierignore`
- split `prettier` and `doctoc` commands. you can still run with `yarn
fmt`
- delete `fmt.sh` and add `doctoc.sh`
By doing so, we can run tasks in parallel in CI and we should also have
less false positives than before with `yarn fmt` locally.
* refactor: update prettier job, add doctoc
This modifies the prettier job to use actionsx/prettier. It also adds a
job for `doctoc`.
* chore: upgrade to prettier 2.7.1
* chore: pin doctoc to 2.0.0
* fixup!: add .pc to prettierignore
* feat: add --cache to prettier cmd
the link for installing with NPM on line 103 was written as
[installing with npm][./npm.md](./npm.md) `[installing with npm][./npm.md](./npm.md)`
I fixed it to look like
[installing with npm](./npm.md) `[installing with npm](./npm.md)`
In freebsd, su -c expects a login class argument instead of a command, if -c is preceded by a username, then -c and the arguments that follow will be passed as shell arguments
* chore: update code to 1.71.2
* chore: update telemetry patch
It appears part of the fix has been implemented upstream.
* refactor: drop safari-console patch
This has been fixed upstream.
* refactor: remove stylelint
* refactor: move shellcheck to separate job
* refactor: add helm script and job
* refactor: add eslint job and yarn script
* fix(test/tsconfig): exclude test-plugin
* refactor: delete lint, add typecheck job
* refactor: remove prebuild
* wip: add notes about unit test refactor
* refactor: delete buggy socket test
This test was really added to in get cover specific lines but it's buggy
and only passes sometimes locally. I think it's okay to remove because:
- it's an implementation detail (not user facing)
- not preventing any specific regressions
* refactor: move test-plugin to integration suite
This seems more appropriate given this tests how a plugin might work
within code-server.
* wip
* wip: refactor vscode integration tests
* refactor: move unit tests to separate job
* fix: formatting
* Revert "wip: refactor vscode integration tests"
This reverts commit 13286bf4c9762b7d6c6176464d94b1fc316fb568.
* Revert "refactor: move unit tests to separate job"
This reverts commit 6c87b540b49c8d56266c8925c4fd32ed760b23bf.
* feat: collect codecov integration tests
* fixup! feat: collect codecov integration tests
* fixup! feat: collect codecov integration tests
* fixup!: move helm step
* fixup!: update ids for caching
* trigger ci
* trigger ci
* chore: clean up names in security.yaml
* fixup!: remove .tsx
* fixup!: change to src/**"
* fixup!: move helm cmd to yaml
* fixup!: always build test plugin
* fixup!: fix plugin typings
* fixup! add back flakey test
* fixup!: only install helm deps if changes
* fixup!: revert node mod caching
* dont keep, test for asher
* fixup!: add make to centos
* refactor: add test:native
This adds a new script to run native tests (i.e. --help which should run
in ci on all platforms).
* try updating glibc
* try 2.25
* Revert "refactor: move test-plugin to integration suite"
This reverts commit bc02005dc097a10b5216b616ff0bd7a911240748.
I couldn't get past some GLIBC errors in CI so moving back to unit
tests.
* Revert "try updating glibc"
This reverts commit 02ed560f223a8505cb5e6e2014055cb256a407b0.
* fixup!
* asher: again
* try this for ts changes
* fixup
* refactor: scripts.yml -> scripts.yaml
* fixup!: move lint-sh to scripts.yaml
* fixup!: use apk for lint scripts
* fixup! fixup!: use apk for lint scripts
* fixup!: remove typecheck step
* fix: pattern for lint ts files
* test: lint should fail
* fixup! fixup!: use apk for lint scripts
* Revert "test: lint should fail"
This reverts commit 158c64db044c24f2f8ffd082cc769f06876d6957.
* fixup!: skip cancel workflow on forks
Looks like the cancel action workflow can't run on forks due to secrets.
See https://github.com/andymckay/cancel-action/issues/4
* fixup: remove cancel-workflow
* fixup! fixup! fixup!: use apk for lint scripts
* fixup! fixup! fixup!: use apk for lint scripts
* fixup!: fix yarn key
* fixup!: add fetch-depth 0
* docs: update MAINTAINING
* refactor: use branch name in release-prep
This makes a minor improvement to the `release-prep.sh` script to grab
the version to update to from the branch name.
* chore(release): bump version to 4.7.0
* fixup: bump version
* docs: use latest instead of version
* fixup: bump Chart version
* chore: update CHANGELOG
* chore: add license to test package.json
* chore: bump @coder/logging to 3.0.0
* fix: change level to Warn
* chore: update upstream code
* update patches for vs 1.71.0
the cli fix seems to be fixed in upstream, the telemtry patch requires (again) some fixing and adjustments.
* add safari fix.
* increase ci timeout
Co-authored-by: Joe Previte <jjprevite@gmail.com>
* feat(e2e): add language extension to setup
This adds a slimmed-down version of the Spanish Language Pack and also
adds a `languagepacks.json` to the e2e `workspaceDir` which allows use
to run a test suite passing the `--locale es` flags to simulate a
different display language.
* feat: add e2e test for display language patch
This tests loading code-server in Spanish using the `--locale` flag.
* fixup!: use JSON.stringify for readability
* fixup!: add comment about langaugepacks temp fix
* fixup!: slim down translations
* fixup!: slim down package.json for lang. ext
* Use fork instead of spawn
We no longer do in-place updating so no need for the spawn. The
advantage of a fork is that it preserves flags like --prof which you can
use to profile code-server.
Also I am not sure the comment about not being able to reload in place
with fork was even true to begin with.
* Refresh heartbeat patch
Seems to have gotten out of date a little.
* Propagate execArgv to extension host
This will let us profile the extension host.
* chore: clean up logging in npm script
* fix: catch error if npm version missing
npm changed the way the `npm view` command handles missing versions.
Before it exited with a non-error. Now it errors.
Ref: https://github.com/npm/cli/pull/5035
This modifies the script logic to handle those new changes.
This adds a new job called aur which checkouts code-server-aur, updates
the files with the new version then opens a PR into the repo.
Co-authored-by: repo-ranger[bot] <39074581+repo-ranger[bot]@users.noreply.github.com>
* Update upstream Code to 1.70
* Update CSP hashes
* Update comment on remote authority
Also remove it from script-src since it is invalid anyway.
* Use absolute path for disable download patch
Just to keep it consistent with the other imports. We initially added
the patch like this so it was not part of the upgrade but might as well
fix it now.
* Fix inability to change language while code-server is running
Co-authored-by: Asher <ash@coder.com>
`proxy` should `await` for result of `authenticated` call otherwise since otherwise it will always appear to be authenticated as the promise is truthy.
Co-authored-by: Asher <ash@coder.com>
Now that we have a test for `--help` which checks to make sure native
modules are working as expected, we don't need the `--install-extension`
test or the `--list-extensions` test.
We can also remove the `.vsix` fixture since we're not using that
either.
* Update Node types to 16
* Update Express core types
Fixes a number of conflicts it has with Node 16.
* Fix websocket router types
It seems req was `any` before so now we have to handle the types. Also
it seems the socket is of type `stream.Duplex`, not `net.Socket`.
The ws types had to be updated to support the new type.
Unfortunately Code still uses the old type so cast for now.
In the web socket router just use a cast for the extra properties we
add. We could add the types to the Express namespace but I am not sure
we really want these commonly accessible so keep with the casts for now.
Likely we should use Express's `locals` or something instead.
* Add missing return
Not sure why it only just now started complaining though.
Co-authored-by: Asher <ash@coder.com>
* refactor: add env arg to runCodeServerCommand
This allows yous to pass environment variables to code-server's helper
when running integration tests.
* feat: add EXTENSIONS_GALLERY integration test
This test ensures EXTENSIONS_GALLERY is read when set and using the
`--install-extension` flag.
Co-authored-by: repo-ranger[bot] <39074581+repo-ranger[bot]@users.noreply.github.com>
* docs: update maintaining
* chore(e2e): add maxFailures to playwright
* fix(ci): skip submodule in e2e job
We don't need the submodules for the e2e job. This will speed up the
checkout step.
* feat(ci): add test-e2e-proxy job
This adds a new job to CI to run our tests behind Caddy and simulate
code-server running against a reverse-proxy.
* refactor: make e2e work with reverse proxy
This refactors the e2e test in a couple ways:
- remove setting cookie in localStorage (instead we pass --auth none)
- refactor address() method to account for reverse proxy logic
* Update test/e2e/models/CodeServer.ts
* Update test/playwright.config.ts
* Update test/utils/constants.ts
Co-authored-by: Asher <ash@coder.com>
* Update test/utils/helpers.ts
Co-authored-by: Asher <ash@coder.com>
Co-authored-by: Asher <ash@coder.com>
* Include bin scripts for all platforms
These will get symlinked as part of the postinstall. These scripts
provide everything ours does inside the integrated terminal plus more.
* Improve OS detection
Specifically for Windows although we do not yet support Windows.
Also standardize the duplicate arch functions since they had drifted
from each other bit.
* Remove duplicate asar symlink
Since standalone releases run the postinstall they will get the asar
symlink there. That means the symlink will not exist for the npm
package and we will not need to ignore it.
The symlink portion is split out so it can be re-used for other
symlinks (for example linking bin scripts).
* Add symlinks to bin scripts
* Add test for opening a file from the terminal
* Add global Playwright timeout
Otherwise it will exceed the Actions timeout and get rudely killed
without any output.
* Make sed work on macOS
* Fix Node path in bin scripts
* Disable shellcheck expansion error
* Make scripts executable
* Remove .bak files created by sed
* Include Code build script in cache hash
Otherwise if we change the script it will not rebuild Code.
* Make sure the terminal opens
The selector was timing out even though it matched more than one element
but matching on the focused one appears to work.
In addition add a loop so it can keep trying to open the terminal
if something goes wrong with the focus.
* chore(release): bump version to 4.5.1
* chore: bump helm chart
* chore: update CHANGELOG
* Revert "chore: bump helm chart"
This reverts commit 703b03b665bddc252d80ae674eb92e1bfbdec6ad.
* chore: bump helm chart to 3.0.0
* revert: remove bad change to manifes.json icon
* fix(ci): add package.json.version to code cachekey
Before this, creating a release sometimes prevented vscode from
rebuilding and using the cache instead. Now we use the
package.json.version in the cache key to "bust" the cache if the
package.json version is updated (aka a release).
Fixes#5316
* Update .github/workflows/ci.yaml
Co-authored-by: Asher <ash@coder.com>
* fixup: formatting
* Revert "refactor: remove version check e2e test"
This reverts commit b23c398b7d725e46b4b7a0bbc900aebc6bd277f3.
Co-authored-by: Asher <ash@coder.com>
Having NODE_OPTIONS set is unexpected and although the later flag should
override the previous flag it is not certain that will always be the
case.
Also some users are having issues with the 2 GB limit.
We were using an overrides command in our `.prettierrc.yaml` which
quickly became out of sync with Code's Prettier styles.
Instead, we simply tell Prettier to ignore `lib/vscode`.
This way, if you have `formatOnSave` on and you save inside
`lib/vscode`, you won't convert the file to use code-server's styles.
When using `window.location.origin` to create a new URL for loading
web packages, it constructs a URL that is not relative, leading to the
terminal breaking when code-server is served not via the root (i.e. /ide
instead of /).
* chore(release): bump version to 4.5.0
* chore: update CHANGELOG
* chore: bump chart version
* docs: update MAINTAINING
* fix: add VSCODE_DEV=1 to e2e script
I'm not sure what changed in the latest version but without setting
VSCODE_DEV=1, code-server won't load. This fixes that.
* Revert "fix: add VSCODE_DEV=1 to e2e script"
This reverts commit 58c4826af82c12d3bc79340945204e6b7dc8cf04.
* fix: try setting VSCODE_DEV=1
* Revert "fix: try setting VSCODE_DEV=1"
This reverts commit 902f5f2f30d2e43a7c3b95decc85f82e98814145.
* refactor: remove version check e2e test
I am not sure why this is passing locally and failing CI. I need to
further investigate this since it fails depending on where you test.
* refactor: switch to codecov-uploader GitHub Action
codecov deprecated their Node wrapper for uploading coverage reports.
This removes that and uses their new uploaded along with the v2 GitHub
Action they maintain.
* fix: update broken integration test
* feat: add installExtension integration test
This adds a new helper function called `runCodeServerCommand` along with
a test for `--install-extension`. We can use this approach for writing
integration tests (i.e. testing a real code-server build, CLI commands,
etc).
* refactor: s/ test:standalone with test:integration
This replaces our integration approach to use Jest instead of a single
bash script. By doing this, we will be able to easily maintain and add
to our integration test suite.
* refactor: filter unit tests
Now that our integration tests also use Jest, we need to update our unit
test script to ignore `test/integration`.
* refactor: add SKIP_SUBMODULE_DEPS to postinstall
* refactor: add SKIP_SUBMODULE_DEPS to postinstall
* fixup!: skip submod deps
* refactor: move runCodeServerCommand into sep. file
When Jest runs a test, it loads all the files and imports for that test.
This means you might be "requiring" code that's unrelated to your tests.
This leads to unexpected errors depending on where the code runs.
Moved this file to avoid GLIBC and other errors relaed to argon2 when
running integration tests in CI.
* fizup: formatting
* fizup: increase timeout
* refactor: use fixture in installExtension test
Instead of relying on a network to install an extension, we use a
fixture - vsix file in the repo. This is also faster.
* feat: add integration test for listExtensions
* chore: ignore integration fixtures
* fixup: formatting
* fixup: remove custom-hacks.css
* fixup: formatting
* Update test/integration/installExtension.test.ts
Co-authored-by: Asher <ash@coder.com>
* Update test/integration/listExtensions.test.ts
Co-authored-by: Asher <ash@coder.com>
* Update test/integration/installExtension.test.ts
Co-authored-by: Asher <ash@coder.com>
* Update test/integration/listExtensions.test.ts
Co-authored-by: Asher <ash@coder.com>
* fixup: contributing integration tests section
* fixup: update ci/readme
* fixup: use RELEASE_PATH in test-integration.sh
* refactor: unzip vsix for listExtensions
* refactor: use exec instead of spawn
* Update docs/CONTRIBUTING.md
Co-authored-by: Asher <ash@coder.com>
* Update test/integration/listExtensions.test.ts
Co-authored-by: Asher <ash@coder.com>
* Update test/integration/listExtensions.test.ts
Co-authored-by: Asher <ash@coder.com>
* Update test/integration/listExtensions.test.ts
Co-authored-by: Asher <ash@coder.com>
* refactor: use different default binary path
* fixup!: formatting
Co-authored-by: Asher <ash@coder.com>
* chore: update Code to 1.67
Was able to remove our changes to common/webview.ts since they are
upstream now.
Other than that no serious changes, just context diffs.
* chore: update Code to 1.68
- Upstream moved the web socket endpoint so change the Express route
from / to *. That will let web sockets work at any endpoint.
- Everything in the workbench config is basically the same but
de-indented (upstream extracted it into a separate object which
resulted in a de-indent), the ordering is slightly different, and
instead of vscodeBase we now need vscodeBase + this._staticRoute since
everything is served from a sub-path now.
- Move manifest link back to the root since that is where we host our
manifest.
- Change RemoteAuthoritiesImpl to use the same path building method as
in other places (+ instead of using URI.parse/join).
- Use existing host/port in RemoteAuthoritiesImpl and
BrowserSocketFactory instead of patching them to use window.location
(these are set from window.location to begin with so it should be the
same result but with less patching).
- Since BrowserSocketFactory includes a sub-path now (endpoints were
changed upstream to serve from /quality/commit instead of from the
root) the patch there has changed to prepend the base to that
path (instead of using the base directly).
- The workbench HTML now natively supports a base URL in the form of
WORKBENCH_WEB_BASE_URL so no need for VS_BASE patches there anymore.
- Upstream added type="image/x-icon" so I did as well.
- Move the language patch to the end of the series so it is easier to
eventually remove.
- Remove the existing NLS config in favor of one that supports
extensions.
- Upstream deleted webview main.js and inlined it into the HTML so move
that code (the parent origin check) into both those HTML files
(index.html and index-no-csp.html).
- The remaining diff is from changes to the surrounding context or a
line was changed slightly by upstream (for example renamed files or
new arguments like to the remote authority resolver).
* fix: modify product.json before building
Code injects this into the client during the build process so it needs
to be updated before we build.
* fix: update inline script nonces
* Update HTML base path test
* fix: missing commit
Code overrides it with nothing.
The date is also already injected.
* fix: web extensions breaking when the commit changes
By just using the marketplace directly instead of going through the
backend. I am not sure what the point is when searching extensions
already goes directly to the marketplace anyway.
But also remove the prefix that breaks this as well because otherwise
existing installations will break.
* refactor: fix type annotations in open
There was no clear reason as to why we needed to use type assertions
when initializing both `args` and `options` in `open` so I refactored
them both.
* refactor: create constructOpenOptions
* refactor: add urlSearch and remove options
* feat: add tests for constructOpenOptions
* fix: install nfpm straight from GitHub
install.goreleaser.com appears to no longer be available.
* Add -f to curl commands
This might have made it so we got the right error rather than erroring
on the envsubst step.
Applies Caddy installations documentation fixes and also resolves the following issue when trying to install Caddy:
W: GPG error: https://dl.cloudsmith.io/public/caddy/stable/deb/debian any-version InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY ABA1F9B8875A6661
See:
- 930109ec33
- 2e255b1ee3
- 0f4885e592
* feat: set up new test for beat twice
* refactor: make Heart.beat() async
This allows us to properly await heart.beat() in our tests and remove
the HACK I added before.
* refactor: bind heart methods .beat and .alive
This allows the functions to maintain access to the Heart instance (or
`this`) even when they are passed to other functions. We do this because
we pass both `isActive` and `beat` to `heartbeatTimer`.
* feat(heart): add test to ensure no warnings called
* fixup!: revert setTimeout for heartbeatTimer
* fixup!: return promise in beat
* chore: upgrade Code to 1.66
* docs: update docs for Code upgrades
* fixup!: docs
* chore: update vscode submodule
* chore: update integration patch
* chore: update node-version patch
* chore: update github-auth patch
They completely changed how auth is handled for GitHub in
https://github.com/microsoft/vscode/pull/145424 so our patch may not
work. Will need to test and revisit.
* refactor: remove postinstall patch
It appears they renamed postinstall.js to postinstall.mjs and removed
the use of `rimraf` which means our patch is no longer needed! 🎉b0e8554cce
* chore: refresh local-storage patch
* chore: refresh service-worker patch
* chore: bulk refresh patches
* fixup!: docs formatting
* refactor: remove unused last-opened patch
* fixup!: formatting docs
* fixup!: formatting docs
* refactor: remove rsync postinstall
* Revert "refactor: remove rsync postinstall"
This reverts commit 8d6b613e9d779ba18d0297710614516cde108bcf.
* refactor: update postinstall.js to .mjs
* feat(patches): add parent-origin bypass
* docs(patches): add notes for testing store-socket
* docs(patches): update testing info for node-version
* refactor(patches): delete github-auth.diff patch
* docs(patches): add notes for testing connection-type
* fixup!: delete github-auth patch
* fixup!: update connection type testing
* docs(patches): add notes to insecure-notification.diff
* docs(patches): add nots for update-check.diff
* fixup!: remove comma in integration patch
* fix(e2e): disable workspace trust
* refactor: add --no-default-rc for yarn install
* feat(patches): remove yarnrc in presinstall
* fixup!: silly mistake
* docs: add note about KEEP_MODULES=1
* docs(patches): add testing notes for node-version
* refactor(patches): remove node-version
It appears this is no longer needed due to the `remote/package.json` now which
targets node rather than electron.
* fixup!: add cd ../.. to code upgrade instructions
* fixup!: add note to yarn --production flag
* fixup!: make parent-origin easier to upstream
* Revert "refactor(patches): delete github-auth.diff patch"
This reverts commit 31a354a34345309fadc475491b392d7601e51a32.
* Revert "fixup!: delete github-auth patch"
This reverts commit bdeb5212e8c7be6cadd109941b486a4bcdae69fa.
* Merge webview origin patch into webview patch
* Remove unused post-install patch
* Prevent builtin extensions from updating
* Refresh sourcemaps patch
* Update Node to v16
This matches the version in ./lib/vscode/remote/.yarnrc.
I changed the engine to exactly 16 since if you use any different
version it will just not work since the modules will have been built for
16 (due to the .yarnrc).
* Replace fs.rmdir with fs.rm
Node is showing a deprecation warning about it.
* Update github-auth patch
The local credentials provider is no longer used when there is a remote
so this code moved into the backend web credential provider.
* Prevent fs.rm from erroring about non-existent files
We were using fs.rmdir which presumably did not have the same behavior
in v14 (in v16 fs.rmdir also errors).
* Install Python 3 in CentOS CI container
Co-authored-by: Asher <ash@coder.com>
This is because Node uses SIGUSR1 to enable the debug listener so even
if you just want to restart code-server you end up enabling the debug
listener as well.
Opted to leave the SIGUSR1 handler in to avoid breaking existing
workflows even though it does mean even if you only want to enable the
debug listener you will end up restarting code-server as well. We could
consider removing it after a transition phase.
After some feedback, we realized it is more intuitive to disable file
downloads by setting the environment variable
`CS_DISABLE_FILE_DOWNLOADS` to `true` than `1`. This commit adds support
for both.
* refactor: add timeout for race condition in heart test
* fixup!: set mtime to 0 and check for update
* fixup!: use utimes directly instead of file open
* fixup!: remove import
* refactor(heart): extract logic into heartbeatTimer fn
To make it easier to test, I extract heartbeatTimer into it's own
function.
* feat(testing): add tests for heart.ts
* fixup
* fixup!: remove unneeded heart call
* Update src/node/heart.ts
Co-authored-by: Asher <ash@coder.com>
* fixup!: use mockResolvedValue everywhere
* fixup!: add stat test for timestamp check
Co-authored-by: Asher <ash@coder.com>
We tried to switch from `yarn` to `npm` because `yarn` ignores lockfiles
but learned that we missed a few key things.
For now, we are reverting docs and a few other changes that suggested
using `npm` instead of `yarn` until we fully remove `yarn` from the
codebase.
t Please enter the commit message for your changes. Lines starting
* Update termux.md
1) Updated information to use PRoot (simpler than Andronix and the way supported by Termux) to create and access the Debian distro.
2) Added helpful information on using PRoot with your dev environment.
3) Cleaned up spelling, grammar, and made documentation more consistent between sections.
* docs: Termux correct packages to install
Updated some erroneously missing packages (vim and sudo) necessary for multi-user setup.
* docs: cleaned up verbiage
Co-authored-by: Joe Previte <jjprevite@gmail.com>
* docs: corrected punctuation
Co-authored-by: Joe Previte <jjprevite@gmail.com>
* docs: correct punctuation
Co-authored-by: Joe Previte <jjprevite@gmail.com>
* docs: clarify pkg command shorthand
* Ran yarn fmt on docs
Co-authored-by: Joe Previte <jjprevite@gmail.com>
* Link upstream sync section in MAINTAINING to CONTRIBUTING
* Update MAINTAINING.md table of contents
Co-authored-by: Joe Previte <jjprevite@gmail.com>
* Fix code-server version not appearing in other languages
It needs to be separate from the localize call since the language
version of that string is used and it will not include a spot for the
code-server version.
I also moved the "v" so we do not get "vUnknown".
* Add code-server version to product configuration
Before 1.64 the entire product configuration was sent to the client but
that was removed so we have to add anything we want to use on the
client, like the code-server version (used in the about dialog).
Fixes#5027.
* Refresh patches
* Change version test to look for specific version
This will catch if we are not sending the actual version to the client.
* Use --exclude to skip node_modules
Instead of copying and then deleting them. This will also catch some
node_modules directories that were missed.
* Remove per-extension dependency install
Code packages all the dependencies using webpack for each extension so
there are no dependencies to install.
* Include source maps
I also moved this to its own patch because it feels sufficiently
standalone.
Fixes#5026.
* Refresh language patch
The base is slightly different so it needed to be refreshed.
* Add missing package.json
This was caused by switching to Code's package step which does not
include the package.json.
Fixes#5019.
* Include keytar
It seems this actually is used now.
* fix: source lib.sh in docker-buildx-push for tagging version
* chore: use ubuntu and update git config homebrew job
* refactor: simplify brew-bump.sh script
* Revert "fix: source lib.sh in docker-buildx-push for tagging version"
This reverts commit 2f7a3610cb1efa6bca7794d8b265001ea347cccb.
* Regenerate last opened patch
The lines were a bit off.
* Remove packaged .gitignore files
Fixes#4964.
* Remove extra Node binary
This gets overidden in the standalone but it was getting uselessly
included in the npm package.
* Move integration types into code-server
This will be easier to maintain than to have it as a patch.
* Disable connection token
Using a flag means we will not need to patch it out. I think this is
new from 1.64?
* Add product.json to build process
This way we do not have to patch it.
* Ship with remote agent package.json
Instead of the root one. This contains fewer dependencies.
* Let Code handle errors
This way we will not have to patch Code to make this work and I think it
makes sense to let Code handle the request.
If we do want to handle errors we can do it cleanly by patching their
error handler to throw instead.
* Move manifest override into code-server
This way we will not have to patch it.
* Move to patches
- Switch submodule to track upstream
- Add quilt to the process
- Add patches
The node-* ignore was ignoring one of the diffs so I removed it. This
was added when we were curling Node as node-v{version}-darwin-x64 for
the macOS build but this no longer happens (we use the Node action to
install a specific version now so we just use the system-wide Node).
* Use pre-packaged Code
* refactor: checkout homebrew-core in action instead of script
This moves the git clone step from the `brew-bump.sh` script into the
`npm-brew.yaml` as part of the job using actions/checkout instead.
* refactor: clean up brew-bump.sh script
* fixup
* fixup!: remove step to clean up homebrew repo
* fixup!: use correct ./ci path steps-lib.sh
* fixup!: add exit code 0 for duplicate PRs
* fix(ci): correctly download npm artifact
* fixup! fix(ci): correctly download npm artifact
* docs: update MAINTAINING
* fixup! docs: update MAINTAINING
* fixup! Merge branch 'main' into 4949-chore-fix-npm-workflow
* chore: get ci to run
* refactor: use vVERSION branch name instead of release
* refactor: use new download artifact in docker workflow
* refactor: clean up release-github-assets script
* fixup: remove extra v
* fixup! fixup: remove extra v
* feat(npm): use DEV_PACKAGE_NAME for development
* feat(ci): use npm v7 in npm job
* fixup: add npm version
* fixup: always set package name
* wip
* fix: check for npm and npm v7
* fixup
* fixup: move after release dir created
* fixup: use jq
* fixup: use jq correctly
* Move Code to a submodule
Closes#4901.
* Base Code cache on hash and re-enable node_modules cache
The current setup appears to only rebuild VS Code if the dependencies
change but we need to rebuild it if anything changes.
I also re-enabled the commented out node_modules caches. They look like
they should work to me with the submodule method. I think the problem
occurred because Code itself was being installed in the yarn step.
* Merge setup and navigate functions
Whenever we navigate we probably want to make sure the editor is ready
so might as well just have one function.
* Add customizable entry and workspace directory
* Add test for state db migration
* Update Code
This contains the state migrations.
* refactor: remove folder/workspace from vsCodeCliArgs
Since we handle this in the vscode.ts route, we no longer need to pass it to VS
Code as a CLI arg since it's deprecated on that side.
* feat(vscode): redirect to folder from cli
* Update src/node/routes/vscode.ts
Co-authored-by: Asher <ash@coder.com>
* fixup!: update _: type
* fixup!: move vars to lower if block
* fixup!: share redirect block
* fixup!: mmove req.query.ew block into if
* fixup!: refactor vscode tests
* refactor: make vscode.ts logic easier to read
* fixup!: fix broken tests and clean up logic
* chore: upgrade vscode version
* fixup!: delete unnecessary if closed block
* Update src/node/routes/vscode.ts
Co-authored-by: Asher <ash@coder.com>
* fixup!: rename to FOLDER_OR_WORKSPACE_WAS_CLOSED
Co-authored-by: Asher <ash@coder.com>
* feat: github-auth flag
This will allow injecting credentials into code-server if you already
have them.
* Update Code
Contains the GitHub auth changes.
* Add e2e test for GitHub token
* Configure build jobs to cancel previous builds when new changes
are pushed to a pull request branch, and serialize builds when
running in a branch from a push event
* Reduce privileges of GitHub token for scripts workflow
Show the bundled version of Code OSS in the text-based output
for --version and --help, in addition to the JSON output
(--version --json)
Closes: #4874
* refactor(http): extract logic into constructRedirectPath
This allows us to easily test our redirect path construction logic where we get
the relative path, the query string and construct a redirect path.
By extracting this from `redirect`, we can easily test this logic in a unit
test.
I did this so we could test some logic where slashes in query strings should be
made human-friendly for users.
* feat(testing): add tests for constructRedirectPath
Co-authored-by: Asher <ash@coder.com>
Introduce helper functions for getting human- and machine-readable
version strings from the constants package, and cover it in unit
tests.
This is a first step to resolving #4874.
* Add helper for navigating the quick picker
This has problems similar to the menu except instead of closing it gets
re-created which interrupts the hover call and causes the test to fail.
Now it will keep trying just like the menu.
* Add a test for opening a file
* Add test for colliding state
* Update VS Code
This contains the colliding state fix.
* add support for imagePullSecrets
* Add doc and example value for imagePullSecrets
* simplify syntax for imagePullSecrets
Co-authored-by: Joe Previte <jjprevite@gmail.com>
* feat: add isAddressInfo helper function
* feat(update): add test for rejection UpdateProvider
* feat: add more tests for UpdateProvider
* fixup! move isAddressInfo, add .address check
* fixup! remove extra writeHead
* fixup! use -1 in redirect logic
* fixup! remove unnecessary String call
* fixup! use /latest for redirect
* fixup! use match group for regex
* fixup!: replace match/split logic
* revert: partial revert of 723469ab5bed3ba9fbb3e8d5ecbfcd9a3bee2d88
This reverts part of the changes introduced in refactor: migrate from argon2 ->
@node-rs/argon2 (#4733)
Switching to @node-rs/argon2 introduced bugs that we couldn't solve due to
limitations in npm.
see here
https://github.com/coder/code-server/issues/4804#issuecomment-1030338395
* feat: refactor npm workflows to use download-artifact
This refactors the npm workflows to use the download-artifact GitHub Action. We
had problems in the past with our download_artifact custom bash function. This
also fixes an issue where we weren't downloading the correct artifacts when
publishing beta and dev tags to npm.
* fixup: remove unused env var
* fixup! add download-artifcat to npm-brew"
* fixup! remove unnecessary code comment
* fixup! move NPM_ENVIRONMENT logic to script
* Update links in package.json
I will try checking the docs too
* docs: Update links in triage.md
* docs: Update links in npm.md
* docs: Update links in whatever files that have `cdr`
* Replace globally, thanks @bpmct!
* fix: coderer instead of coder
I should've used all three toggles in the Search/Replace tab in the GItHub.dev editor.
* Code Formatting
* Disable BROWSER env var
Right now the browser helper script does not actually work. It seems
safer to skip this until we can fix it.
* Bump to 4.0.2
* Update changelog for 4.0.2
This extracst the publish on npm workflow from ci.yaml and adds a new workflow
called `npm-beta.yaml`.
Now we have three workflows that publish to npm.
- `npm-beta.yaml` only runs on pushes and merges into `main`
- `npm-dev.yaml` only runs on PRs into `main` with approval from
code-server-reviewers team
- `npm-brew.yaml` only runs on releases
This should fix problems we had previously where anyone could open a PR and
publish under the code-server namespace. It also separates out the workflows
based on environment and when they should run.
* feat: add logic to publish beta/dev npm
This adds new log to publish the npm package both while working on PRs and when
PRs are merged into main, allowing us to easily test changes in a
production-like setting.
Co-authored-by: Asher <ash@coder.com>
* docs: Change `cdr` to `coder`, read desc please
Yeah, includes links.
* docs: Update README (links and the extra comma)
Co-authored-by: Joe Previte <jjprevite@gmail.com>
* chore(deps): replace argon2 w/@node-rs/argon2
* refactor: clean up hashPassword functions
* refactor(util): pass in process.platform
* fix: use correct settings for test-extension
Before, it was running into errors with an @types package.
Now, we're correctly running `tsc` so it picks up our `tsconfig.json` and we're
telling TypeScript to not typecheck our lib and exclude `node_modules`
* Add test extension
This will let us test extension-related features (like the proxy URI).
I removed the environment variables in the script because they override
the ones you set yourself. We still set defaults in constants.ts.
* Add changelog entry for VSCODE_PROXY_URI
* Add terminal test for VSCODE_PROXY_URI
* Update VS Code
This adds the VSCODE_PROXY_URI environment variable.
I think the problem is that when a proxy is not in use proxy-agent
returns the global agent...which is itself since we set it globally,
causing the loop.
VS Code already covers proxies meaning we only need to do it in our own
requests so to fix this pass in the agent in the version fetch request
instead of overidding globally.
Also avoid proxy-from-env and pass in the proxy URI instead as both
http_proxy and https_proxy can be used for either http or https requests
but it does not allow that.
* Implement last opened functionality
Fixes https://github.com/cdr/code-server/issues/4619
* Fix test temp dirs not being cleaned up
* Mock logger everywhere
This suppresses all the error and debug output we generate which makes
it hard to actually find which test has failed. It also gives us a
standard way to test logging for the few places we do that.
* Use separate data directories for unit test instances
Exactly as we do for the e2e tests.
* Add integration tests for vscode route
* Make settings use --user-data-dir
Without this test instances step on each other feet and they also
clobber your own non-test settings.
* Make redirects consistent
They will preserve the trailing slash if there is one.
* Remove compilation check
If you do a regular non-watch build there are no compilation stats so
this bricks VS Code in CI when running the unit tests.
I am not sure how best to fix this for the case where you have a build
that has not been packaged yet so I just removed it for now and added a
message to check if VS Code is compiling when in dev mode.
* Update code-server update endpoint name
I have been wondering why my editor is not defaulting to two spaces and
it is because indent_size was removed from the * block.
I am not sure why we would need a separate block for package.json and
yaml anyway since they use the same settings as the rest of our code.
I would revert the commit but this change was made in a larger commit
with a bunch of unrelated changes.
* Support browsers from before 2020
As reported in #2825, #2826 and #3051, almost everything works in older browsers. This setting here prevented me from updating and I think it is an obvious enhancement to not restrict to browsers from 2020+. There should not be any measurable downsides of this change since es6 and es2020 are pretty similar with only minor differences.
* Include lib (polyfills) for <es2020 targets
* Assume all modern dom features despite es6 syntax
* Add modern dom iterators to es6 environment
Co-authored-by: Joe Previte <jjprevite@gmail.com>
Co-authored-by: Asher <ash@coder.com>
* Added instructions to install it on iOSi (#4614)
* Added instructions to install it on iOS
* Update ios.md
Co-authored-by: Joe Previte <jjprevite@gmail.com>
* docs: add ios to manifest
* docs: clean up ios docs
Co-authored-by: The AliX Legend <alixgamer175@gmail.com>
The problem before was that the pop() caused the open in existing
instance functionality to break because the arguments no longer
contained the file.
We could simply remove the pop() but since `workspace` and `folder` are
not CLI arguments I think it makes sense to handle them in a separate
function which can be called at the point where they are needed. This
also lets us de-duplicate some logic since we create these arguments in
two spots and lets us skip this logic when we do not need it.
The pop() is still avoided because manipulating a passed-in object
in-place seems like a risky move. If we really need to do this we
should copy the positional argument array instead.
* Add tests for relativeRoot
* Remove path.posix.join
Since this is for file system paths it feels incorrect to use it on
URL paths as they are different in many ways.
* Rewrite cookie path logic
Before we relied on the client to resolve the base given to it by the
backend against the path.
Instead have the client pass that information along so we can resolve it
on the backend. This means the client has to do less work.
* Do not remove out directory before watch
This is re-used for incremental compilation.
Also remove del since that was the only use (and we can use fs.rmdir in
the future if we need something like this).
* Remove unused function resolveBase
* Remove extra VS Code CLI spawn
We already spawn VS Code's CLI when necessary in the lines below.
Having the CLI spawn unconditionally when in a VS Code environment makes
it impossible to run code-server within code-server (for example to
develop it).
* Update VS Code
This sanitizes our environment variables so code-server does not always
think it is a child spawn.
Fixes https://github.com/cdr/code-server/issues/4519.
The watch script was reloading the web server after every extension
compilation which is not necessary plus VS Code will not even be ready
at that point anyway.
Instead restart when the main compilation is finished. The string to
match with includes a "with" because otherwise it would match "Finished
compilation extensions" which is not the main compilation task where we
actually need to restart the web server.
I also replaced this.log with console.log because the former does not
include a newline and it appears we want newlines with all
these (otherwise the next log starts on the same line which looks odd).
I removed the cache clean as well because the cache is meant to stay
there to speed up builds.
* docs(CONTRIBUTING): update workflow based on vscode changes
* docs(MAINTAINING): add section for syncing VS Code upstream
Co-authored-by: repo-ranger[bot] <39074581+repo-ranger[bot]@users.noreply.github.com>
* Fix issue where HTTP error status codes are not read.
* Fix issues surrounding sessions when accessed from a proxy.
- Updated vscode args to match latest upstream.
- Fixed issues surrounding trailing slashes affecting base paths.
- Updated cookie names to better match upstream's usage, debuggability.
* Bump vendor.
* Update tests.
* Fix issue where tests lack cookie key.
Co-authored-by: Asher <ash@coder.com>
The "Starting watch-client" string no longer appears in the latest build
output. We could look for "Finished compilation with" to avoid
restarting when other tasks restart (since they also include the name
i.e. "Finished compilation extensions with 0 errors") but I figure we
might as well restart code-server when any compilation task completes in
case other tasks include changes that need to be reloaded.
* Refactor vscode router to load async.
* Bump vscode.
* fix volumes (#4497)
* Fix : recreate the termux guide to adapt the recent changes (#4472)
* Fix : recreate the termux guide to adapt the recent changes
Termux nodejs-lts changed from v14 to v16 and there are many issues people are facing such as with argon2. Hence I recommend changing it to this install process which is comparably better and has one less issue :^)
I've also added some extra things such as installing GO and Python, idk about the TOC tree but this is pretty much it.
* yarn-fmt and minor typos
https://github.com/cdr/code-server/pull/4472#issuecomment-964752180
* Fix : replace unnecessary steps to be linked to a guide
* Change from private gist to a section in Extra
* Remove reference to non-existent step
* ready to merge!
Co-authored-by: Joe Previte <jjprevite@gmail.com>
Co-authored-by: Jinu <jlandowner8@gmail.com>
Co-authored-by: Han Seung Min - 한승민 <hanseungmin.ar@gmail.com>
Co-authored-by: Joe Previte <jjprevite@gmail.com>
* Fix : recreate the termux guide to adapt the recent changes
Termux nodejs-lts changed from v14 to v16 and there are many issues people are facing such as with argon2. Hence I recommend changing it to this install process which is comparably better and has one less issue :^)
I've also added some extra things such as installing GO and Python, idk about the TOC tree but this is pretty much it.
* yarn-fmt and minor typos
https://github.com/cdr/code-server/pull/4472#issuecomment-964752180
* Fix : replace unnecessary steps to be linked to a guide
* Change from private gist to a section in Extra
* Remove reference to non-existent step
* ready to merge!
Co-authored-by: Joe Previte <jjprevite@gmail.com>
I added the missing versions and some changelog entries for the latest
version. I also added some extra details to the entries that should
help users understand what changed and what they need to do about
it. The overall format is based on keepachangelog.com.
In that same spirit I removed entries that do not affect
users (documentation and development changes).
I removed the names because it seems unlikely users will be interested,
that information can be found in the PR, and code is really the work of
multiple developers (even if only one is writing code and the other is
reviewing) which is not something that is reflected in this document.
* docs: update FAQ with extension gallery info (#2672)
* Update app to reflect Open VSX switch.
- Remove extension related github configs.
- Update tests to reflect new upstream behavior.
Co-authored-by: Akash Satheesan <akash@coder.com>
* Flesh out fixes to align with upstream.
* Update route handlers to better reflect fallback behavior.
* Add platform to vscode-reh-web task
Our strategy has been to build once and then recompile native modules
for individual platforms. It looks like VS Code builds from scratch for
each platform.
But we can target any platform, grab the pre-packaged folder, then
continue with own packaging.
In the future we may want to rework to match upstream.
* Fix issue where workspace args are not parsed.
* Fix issues surrounding opening files within code-server's terminal.
* Readd parent wrapper for hot reload.
* Allow more errors.
* Fix issues surrounding Coder link.
* Add dir creation and fix cli
It seems VS Code explodes when certain directories do not exist so
import the reh agent instead of the server component since it creates
the directories (require patching thus the VS Code update).
Also the CLI (for installing extensions) did not seem to be working so
point that to the same place since it also exports a function for
running that part of the CLI.
* Remove hardcoded VSCODE_DEV=1
This causes VS Code to use the development HTML file. Move this to the
watch command instead.
I deleted the other stuff before it as well since in the latest main.js
they do not have this code so I figure we should be safe to omit it.
* Fix mismatching commit between client and server
* Mostly restore command-line parity
Restore most everything and remove the added server arguments. This
will let us add and remove options after later so we can contain the
number of breaking changes.
To accomplish this a hard separation is added between the CLI arguments
and the server arguments.
The separation between user-provided arguments and arguments with
defaults is also made more clear.
The extra directory flags have been left out as they were buggy and
should be implemented upstream although I think there are better
solutions anyway. locale and install-source are unsupported with the
web remote and are left removed. It is unclear whether they were used
before anyway.
Some restored flags still need to have their behavior re-implemented.
* Fix static endpoint not emitting 404s
This fixes the last failing unit test.
Fix a missing dependency, add some generic reverse proxy support for the
protocol, and add back a missing nfpm fix.
* Import missing logError
* Fix 403 errors
* Add code-server version to about dialog
* Use user settings to disable welcome page
The workspace setting seems to be recognized but if so it is having no
effect.
* Update VS Code cache step with new build directories
Co-authored-by: Asher <ash@coder.com>
* Add a gist of the difference
* Update the gist
* Update README.md
As told by @tmikaeld here: https://github.com/cdr/code-server/discussions/3102#discussioncomment-1565789
* Update docs/README.md
Co-authored-by: Joe Previte <jjprevite@gmail.com>
* `yarn fmt` results
Co-authored-by: Joe Previte <jjprevite@gmail.com>
Co-authored-by: Asher <ash@coder.com>
* Drop duplicate Helm values from values.yaml
* Use frozen lockfile for test dependencies in CI (#4442)
* Use frozen lockfile for test dependencies in CI
This might be causing more Playwright issues.
* Bump Playwright
Mostly just to trigger a reinstall of dependencies since it is cached
and still failing.
Once updated it errors saying install needs to run so add that too.
* Drop duplicate Helm values from values.yaml
Co-authored-by: Asher <ash@coder.com>
* Use frozen lockfile for test dependencies in CI
This might be causing more Playwright issues.
* Bump Playwright
Mostly just to trigger a reinstall of dependencies since it is cached
and still failing.
Once updated it errors saying install needs to run so add that too.
It was causing version mismatch errors.
It might make more sense to have this in the postinstall but for now I
have foregone that as it would be installed in every step including
those that do not run e2e tests.
* fix(testing): revert change & fix playwright tests
* fix(constants): add type to import statement
* refactor(e2e): delete browser test
This test was originally added to ensure playwright was working.
At this point, we know it works so removing this test because it doesn't help
with anything specific to code-server and only adds unnecessary code to the
codebase plus increases the e2e test job duration.
* chore(e2e): use 1 worker for e2e test
I don't know if it's a resources issue, playwright, or code-server but it seems
like the e2e tests choke when multiple workers are used.
This change is okay because our CI runner only has 2 cores so it would only use
1 worker anyway, but by specifying it in our playwright config, we ensure more
stability in our e2e tests working correctly.
See these PRs:
- https://github.com/cdr/code-server/pull/3263
- https://github.com/cdr/code-server/pull/4310
* revert(vscode): add missing route with redirect
* chore(vscode): update to latest fork
* Touch up compilation step.
* Bump vendor.
* Fix VS Code minification step
* Move ClientConfiguration to common
Common code must not import Node code as it is imported by the browser.
* Ensure lib directory exists before curling
cURL errors now because VS Code was moved and the directory does not
exist.
* Update incorrect e2e test help output
Revert workers change as well; this can be overridden when desired.
* Add back extension compilation step
* Include missing resources in release
This includes a favicon, for example. I opted to include the entire
directory to make sure we do not miss anything. Some of the other
stuff looks potentially useful (like completions).
* Set quality property in product configuration
When httpWebWorkerExtensionHostIframe.html is fetched it uses the web
endpoint template (in which we do not include the commit) but if the
quality is not set it prepends the commit to the web endpoint instead.
The new static endpoint does not use/handle commits so this 404s.
Long-term we might want to make the new static endpoint use commits like
the old one but we will also need to update the various other static
URLs to include the commit.
For now I just fixed this by adding the quality since:
1. Probably faster than trying to find and update all static uses.
2. VS Code probably expects it anyway.
3. Gives us better control over the endpoint.
* Update VS Code
This fixes several build issues.
* Bump vscode.
* Bump.
* Bump.
* Use CLI directly.
* Update tests to reflect new upstream behavior.
* Move unit tests to after the build
Our code has new dependencies on VS Code that are pulled in when the
unit tests run. Because of this we need to build VS Code before running
the unit tests (as it only pulls built code).
* Upgrade proxy-agent dependencies
This resolves a security report with one of its dependencies (vm2).
* Symlink VS Code output directory before unit tests
This is necessary now that we import from the out directory.
* Fix issues surrounding persistent processes between tests.
* Update VS Code cache directories
These were renamed so the cached paths need to be updated. I changed
the key as well to force a rebuild.
* Move test symlink to script
This way it works for local testing as well.
I had to use out-build instead of out-vscode-server-min because Jest
throws some obscure error about a handlebars haste map.
* Fix listening on a socket
* Update VS Code
It contains fixes for missing files in the build.
* Standardize disposals
* Dispose HTTP server
Shares code with the test HTTP server. For now it is a function but
maybe we should make it a class that is extended by tests.
* Dispose app on exit
* Fix logging link errors
Unfortunately the logger currently chokes when provided with error
objects.
Also for some reason the bracketed text was not displaying...
* Update regex used by e2e to extract address
The address was recently changed to use URL which seems to add a
trailing slash when using toString, causing the regex match to fail.
* Log browser console in e2e tests
* Add base back to login page
This is used to set cookies when using a base path.
* Remove login page test
The file this was testing no longer exists.
* Use path.posix for static base
Since this is a web path and not platform-dependent.
* Add test for invalid password
Co-authored-by: Teffen Ellis <teffen@nirri.us>
Co-authored-by: Asher <ash@coder.com>
We pipe the child's stdout and stderr to the log file (and to the parent's streams) but since we used `inherit` for `stdio` this caused the child to use the parent's streams directly which made `child.stdout` and `child.stderr` non-existent and thus we had no file logging.
Using `pipe` creates stdin and stderr on the child.
I updated the CodeTogether description to include some enhancements that we just shipped in CodeTogether 4.2. I also added a bit more detail to the feature list and provided some hyperlinks in a couple of places where people would likely appreciate more detail.
I made no changes to the other sections.
We've had two patches to the helm-chart since the last time we bumped the Chart
version.
- 1ffca5751c
- 5a36627aae
This version bump ensures that chart version has the correct date.
feat(script): add steps-lib, is_env_var_set & test
feat(brew-bump): add check for VERSION
feat(brew-bump): check HOMEBREW_GITHUB_API_TOKEN
feat(steps-lib): add directory_exists helper fn
fix(brew-bump): check that git clone worked
feat(brew-bump): add check for remote upstream
fix: remove upstream command thing
feat(steps-lib): add file_exists helper function
feat(brew-bump): add check for git-askpass.sh
feat(steps-lib): add is_executable function & test
feat(brew-bump): add check for is_executable
refactor: use GIT_ASKPASS as variable
With #3895, we caused a regression where the Content-Security-Policy prevented
images in the previewer to not work due to the ports in the resource URI.
This modifies the CSP in the webview to make sure images are not blocked by CSP.
I assume once we upgrade VS Code, we will revert this change.
Currently, Windows default script-shell (cmd) fails to run the postinstall script. This commit fixes the problem by running postinstall.sh explicitly with the default bash executable of the OS.
Related: #1397
This reverts commit 50494472250cbfeb483aa2a4440efe408a30f190, reversing changes
made to 741b834b640be0103cd86e76bac7ce4ea5bb2572.
We still need the symlink for the standlone packages which means we need to redo
how the symlink is removed, ensuring it's only removed in the npm package.
We do this because resources in webviews don't load properly
when the port is used in the resource uri.
We're not sure why this is happening but adding this fix
to get webviews working like before.
CodeQL caught a path where we were passing in req.query.path
to pathToFsPath, which may not have been a string.
So we refactored some things to ensure we only pass it a string
which also let us change the parameter type to string
instead of string | string[].
There was some confusion with the "and" since it can be interpreted that
you can only try logging in twelve times per hour in total but actually
you get two attempts per minute and then twelve per hour on top of that.
* Squashed 'lib/vscode/' changes from cfa2e218100..2064d4c301c
2064d4c301c fix issue reporter unit tests
d99a697eb52 Fix#125503
b098b10a77e Merge branch 'notebook/dev' into main
a57e41b7a43 notebooks: more accurately detect old style of renderers
c8a447f93b8 Fix#125507
ae4124aa7e1 Fix#122570
2bcdb95e7df update distro
89d750cd687 add restricted mode to created issues (#125537)
5f7166fd915 Put run menu above output container, Fix#125188
d9cf45e0dba Fix#125526
ab0bd774c91 Pass profiles, defaultProfile, isWorkspaceTrusted from renderer to shared process (#125450)
061403c7458 Switches to new RemoteHub authority separator
0e6d07052c8 remove untrustedWorkspace search for now
1c5b5a632f9 Hide "Customize Notebooks" in getting started behind setting
f843c51bca8 Update lock file
2456872bcaa Bump distro
12547c1de87 remove virtual workspace information from banner (#125512)
6de86dcd840 update notebook layout default values.
0f0abb3dc87 trust vfs (#125523)
8d87a664274 Bump es build
bcdfe884a3c Fix window reload with an empty remote window
a0bc15ff6fc Close Remote Connection shows up in local windows
fe1eafc80c0 Merge pull request #125498 from microsoft/hediet/fix-125034
5eb636f22fc Renames InlineSuggestionActions back to InlineCompletionsActions.
e8ad99de2b3 Merge branch 'main' into hediet/fix-125034
dcf62e3a1e4 Merge pull request #125501 from microsoft/hediet/add-accept-action
fe6fc208e9d Puts EditorOption.inlineSuggest to the right spot.
c6777d5c6c9 Reverts menu rename.
c5bbe0a35ea Merge pull request #125484 from microsoft/hediet/fix-125478
20cb29b076b Fixes#125430: Add a lock around the extension registry.
383ae36449b restricted mode hover: added a link to manage trust. For #125408
1a8285a9654 Adds accept action to inline suggestion hover. Fixes#125472.
2ba1dcb0c9c Removes setting ghostTextExpanded. Fixes#125037.
3300006ee17 * Renames command ids, context keys and command titles to Inline Suggestion. * Renames menu item, makes it proposed API.
f8c061e73d7 restricted trust status bar item should use rich hover. Fixes#125408
620434543f5 * renames editor.suggest.showSuggestionPreview to editor.suggest.preview * renames editor.suggest.showInlineCompletions to editor.inlineSuggest.enabled
4b0c17e1808 fixes#115535
93e61e267ca fix compile error
54dd1429b64 startup timings uses now `exit` and not `quit`, fyi @bpasero
922f866a282 run menu: more precise context keys
f207b383071 inline `NotebookExecuteHandler` type
fa1694c8afb Merge pull request #125465 from microsoft/menubarFix
5efc2e7abcd 💄
7954c27d2d9 Fixes#125478.
f99e1c358f0 fixes issue with asExternalUri API
8163cfd8c54 Make sure we layout editors in sideBySideEditor after they are created (#125445)
387e2f39ebb Properly complete notebook profile step
11f86fefb46 Track opening notebook separately from showing notebook GS page
a2ef11ff553 fixes context keys with menubar
fd2ed91612c Fix wrong CKS on output toolbar Fix#125109
f95fb77f22a Fix cellstatusbar layout issues from "visibleAfterExecute" Fix#125403
0acf7df100e Fix showCellStatusbar default #125403
a244a4ccc65 improve messaging with remote
5d58be33080 switch to a switch for localization edge cases
ae0e8f04468 uppercase h in localization
885ac7f1c11 fixes#125406
b519331a06b fix#125458.
4c12628b2b5 fix#125234.
0c7e7cf21d6 disable notebook layout getting started.
4cae6713714 fix#125452.
72d325b4bc9 fix#125027
df59dc8470a don't show status bar entry until files are opened
d3db92b7a2e Fine tune image styles. Fix#122680
72a67899410 add settings links to improve understanding of workspace trust
c9e683d6c78 fix#124405
827398db432 fix#125444.
f004a398e0b Fix#125313
b26e1aba58c Remove hashes from override
41b1406d3a8 Revert parts of "Fix #125395" Re-enables GitHub extension in untrusted workspaces
eab8d0403f2 Revert "Fixes #125350: disallow in untrusted ws"
0006964091a Change cell type contextkey to markup Fix#125378
5ea26044187 Fix#124531
0a5d652bdfd Fixes#125332.
f73f263c6bf Needed localization changes for converting xlfs to json (#125442)
0f0f066b392 Remove codespaces walkthrough from Getting Started
96004bc2c97 icon hover: add pointer for element hovers
11debc38469 Merge branch 'notebook/dev' into main
b80011a819c Fix#124049
fd430418a01 Refine `CellInfo` type (#125351)
b2cc8487aed Flip positioning of steps and media in narrow layouts. Closes#125246
5966e9dfec0 Check to see if there are any artifacts that haven't been published (#125428)
a56ef182474 notebooks: fix default selection of untrusted renderer
788e39aad86 #125395 Improve the prompt
062401745a2 Switch loglevel to trace
73de22af596 Close#119722
be1cf4bddb5 Focus contributed profile terminals after creation
60651a0c4de Fix#125030
8f9eedf0019 Merge branch 'main' into notebook/dev
01c6fb557d0 Fix#125395
41163014f8c 💄
490cef7c075 Revoking trust in the remote scenario will reload the window
3f8672be8a4 fixes#124051
6d66648c51b Add snippets for ports attributes to settings helper Fixes#125081
e43c3957f64 rename onDidChangeNotebookAssociation to onDidChangeSelectedNotebooks
732769073a2 Workspace trust - add --disable-workspace-trust flag (#124998)
499e4948c7d Fix typo
41f117753ed debug: update js-debug
20df87725d3 fix build again
15aca96cd5c build - unblock lauching
8b4bc01166a Removes RemoteHub
0f2f7c7f04b Update notebook getting started images
b2a64b1379c Merge pull request #125352 from microsoft/tyriar/migrate
515b7125255 revert a change
fa19cd28adb fix build errors
6f0ce2e7508 Fix#125250
884b1e7a0d0 Fix "Trying to add a disposable to a DisposableStore that has already been disposed of." ref #125354
c8b7aaf2c29 Merge pull request #125340 from microsoft/merogge/onExit
7fd324944d3 Fix selected notebook profile highlights
99665d0b4ac Merge cell statusbar settings Fix#125173
2974dcbd985 Fix bugs causing walkthoughs to not open on install
ab1c9202003 Try setting gettingStarted as default editor (#125321)
ebde979a485 fix cell top/bottom border always active.
7dacb10b591 fix#125339.
e6aaf493989 Move notebook getting started walkthrough to its own section
f473e3dc9f8 fixes#125047
6cc80fea815 fix#125338.
66917f41795 fix#125334.
2356d7c5b76 fix init layout interrupted by editor group resize.
a2a61127667 Hide execute actions from markdown toolbar Fix#125336
0f8c499d101 Migrate profile setting and fallback properly
272208523b5 register the extension request handler once workspace is resolved fixes#125342
4c57cf40313 fix#125175.
bbc4995eca7 fix#125176.
195477a0e96 remove unused import
68e862e1d62 skip flaky window test.
9bd7cbd1403 notebook.insertToolbarLocation
769e7080f4b Fixes#125350: disallow in untrusted ws
ae2f0b39e63 Fix#122741
8f3a47cc88c add singleTerminal argument
6ef81b30370 add safeDisposeTerminal to terminal service
b295408c303 tweak wording
fa8a7a84a13 Merge branch 'main' into merogge/onExit
895dbf4dfd0 fix#125069
60dd761211b update the layout based on treatment.
26cd18321bd remove backwards compatible tests.
d215fc72380 Fallback to active editor if no webview is focused
c5a4158a651 fixes#125247
3d0d203bb02 fix#124849
509906cd916 Merge branch 'notebook/dev' into main
4d4f0b528a2 fixes#125319
093b03bb39e fix#124854 Co-Authored-By: Daniel Imms <daimms@microsoft.com
c4da8f4ab15 Improve terminal drag feedback
55f01b11fa0 fix#125067fix#125039 Co-authored-by: Daniel Imms <daimms@microsoft.com>
941a603ccd0 Revert "Try fix getting started as default crashing integration tests"
0206b2ee43f Try fix getting started as default crashing integration tests
d0ba023c71e Fix#122680
48fcde4048c Fix#123476
0543065c41a Don't commit inline completions on tab when "tabMovesFocus" is active.
e2ad6d2c9a8 Merge pull request #125126 from microsoft/hediet/make-hover-unselectable
b49731160d3 Add henning to my-endgame notebook
1fee13180b7 Vertically center notebook profile list
09a3fa687a9 Resets context keys properly when editor is disposed.
c324c61ad57 add closing tags
e92e3d1a9ea Reset context keys when Ghost Text Controller is disposed.
ec5bf6733ca Fixes "Ctrl+Z doesn't retrigger inline suggestions"
26ff863e3d4 Merge pull request #125221 from jeanp413/fix-125035
ce8d2e86028 make IHoverDelegate.placement optional
32e6054985c Adds more documentation to the proposed inline completion API. Fixes#125267.
20be2c8eaa2 icon label hover: allow element placement. Fixes#125090
232412ff87b adopt terminalTabList
60a36219813 Revert "icon label hover: allow element placement. FIxes#125090"
4aa9f8271b8 Merge pull request #125292 from microsoft/tyriar/themeicon
8223d3d5c7f Fix#125156
0a32357e6d7 Fix filter.filterQuery initialization
3099c6f1c1b ios: trigger list/tree/table context menus
3a388466b85 tree viewer hover delegate: command handing now comes from hover service
1d471214fb3 icon label hover: allow element placement. FIxes#125090
0ee6895a6b8 Convert vscode ThemeIcon to internal type
e040c0881f7 Workspace trust - calculate trust before extension host starts (#125283)
ea339694fc7 fixes#125272
727caa7f238 Merge branch 'main' into notebook/dev
e0131062c84 bail on standard start when workspace isn't trusted
0bf73ff15ab make sash work better on ios
9764a02c5d3 sash: use DomEmitter
df709ddd3d5 Fix otherPortsAttributes protocol not updating correctly Fixes#125079
ef0fb8afb89 Revert "use associatedResource instead of untitledResource, https://github.com/microsoft/vscode/issues/125028"
073c4ffd7da remove deprecated notebook-namespace, notebooks is the future
a24c1495208 Merge pull request #125281 from microsoft/hediet/allow-inline-completion-array
2e53913b637 Separator in remote indicator can appear/disappear. Fixes#122309
d71e5718c90 Fix ctrl+click to open link in ports view Fixes#125076
f32b38aa216 Allows to directly return an array of inline completions instead of an InlineCompletionList.
b5bdc48d553 use vscode.notebooks not vscode.notebook
3d2309d4e74 Set icon for custom pty terminals
e537c47c63c Fix double extension terminal profile creation
a3337d01bb0 more api polish
17da5e37217 use associatedResource instead of untitledResource, https://github.com/microsoft/vscode/issues/125028
7051f7db889 Sort content of XLF files
109c9d9486b adopt viewType everywhere and drop support for it, fixes https://github.com/microsoft/vscode/issues/125163
b1e613481bb fix https://github.com/microsoft/vscode/issues/125163
9796ac82c3f (re)move NotebookCellOutput#id into proposal, also remove ctor overload that allows to set id
a14600c325f editor trust - limit trust validation in `openEditors` to the places we want
39e7fd6a779 Merge pull request #125128 from microsoft/alex/ghost-text
a1e7ce9cde2 tackle more todos, change ctor of NotebookCellData
0c3646199aa editors trust - support opening diffs into new window (#124618)
592ae5a1f53 editors trust - make sure diff editors bring up trust dialog too
a286059b90d macOS - workaround fullscreen window regression (#125122)
82acbe807f2 updated todo search file
ac05ae7b6f0 move file'ish things into workspace namespace
e57462fd1f6 dnd - only add file system resources (for #125187)
0b6e70302f8 remove deprecated API
dfc47c79571 rename notebookViewType context key to notebookType
542655758b4 fix https://github.com/microsoft/vscode/issues/125138
f2d6da27d01 make sure appendOutputItems and replaceOutputItems return something
ee87b2bd432 missing adopting for end-call
d487b379bae Merge branch 'main' into notebook/dev
7865b99b44e Fixes#125035
febc20e8d39 safari - disable clipboard error notification
e7b9f3a1a40 Show a confirmation notification when installing/uninstalling shell commands (fix#125145)
217f1a2f60a Workspace trust - extension enablement (#125179)
b154a3d3043 skip view column test.
322c81122dd Add "move cell up/down" to the cell context menu when drag and drop is disabled
a90729cb6f0 show notebook profile the first time when a notebook is opened.
c55d8a0e16c select notebook layout action.
b2da4119928 Add undo/redo per cell for jupyter profile.
7aa8c5ec4a7 Fix profile contribution schema
2d97edd98f2 Update QuickPick api doc (#124485)
8df0f068588 Group startTime and endTime into a single object
ef28d1663d9 Inline parameters to execution task start and end
5c6ae4fc5ac Update NotebookCellStatusBarItem constructor
872bbcc8c1c Update provideCellStatusBarItems
28bf10376c3 Add 'notebookLayout' tag to suggestions
4dd5ccb1566 Make registerWalkthrough public
d2561813a8d Merge branch 'notebook/dev' into main
dc9dc66109d tweak fix
ac7bb556e8f Disable "consolidated run button" in Jupyter profile
4449461cae4 fix#125121
a296485f007 fix#125045
8e86a3c6b16 Enable consolidated run button by default, now that Jupyter has caught up
515c64f05e6 fix#125125
5e27fb3ba85 Fix to make @recommended:languages search work
84196c8b8d3 fix: update colors
950ad4ffec5 colors: add support for exporting colors
2c503281922 Add import to pull notebook getting started content into build
9bd78a8bf53 notebooks: restore renderer messaging generic
088e0d282ee Revert "fix #125137"
d6d3091cbd3 fix#125137
c7f8b301938 Revert "fix #125137"
67e64a8fc86 Merge pull request #125083 from microsoft/ben/69349
80a899d8d67 fix#125040
aeecc7c03ff notebook: messaging api polish
4df863a28da Remove extra notebook images
092a2242ce5 fix#125137
2e8e888989a editors - more tests for capabilities
b743bf63de1 fix#125124
d6d9200832a notebook: fix mimetype switcher not working between custom renderers
ebcbe001591 update todo search file
6dbbcc2eee7 fix compile issues...
e8d8e53752a update/tackle todos
6fe84c402bb Merge pull request #125106 from microsoft/joh/api/noMetadataType
553893e940a Merge pull request #125104 from microsoft/joh/api/noItemMetadata
632f2156f2e remote indicator: remove vscode-vfs workaround
5a49e6a283e Focuses the editor after showing next/previous inline completion.
1bab611b73b Sets user-select: none to the hover actions so they cannot be selected anymore.
103d3edfdc0 Fix text replace case operation false positive Fix#123483
a3bad5878ef Add a protocol property to tunnels that corresponds to the attributes for that tunnel and is reflected in the UI.
bd8a0fb3d76 Fix#124779
0115c74d4af update todo@api search file
8dd2e53e247 bump versions
a476c9d4f08 fixes#124850
0580a6bae45 Settings: remove notification that changes are saved (fix#69349)
545b931b96b remove dedicated types for notebook and cell metadata
b1457fa4b6d remove NotebookCellOutputItem#metadata
e7b775adebf Revert "fixes #115535"
ae86512bf07 Fix automatic task timing Fixes#125044
6a02e8333c1 small jsdoc and todo tweaks
952e39f9d2d fixes#125026
d163f3f3d45 tooltip text grabbing broken. Fixes#124457
e9d05647b3b update distro
122df438a80 Run OSS Tool
89157c1a87a notebooks - tweak description for untitled files
1e446dfadf5 Don't hide suggest widget when expanding ghost text
ab80101db2d Revert "Fix regression with extension enablement"
24e1234559d [json/css/html] update services
a8a57c3fc67 Merge pull request #124288 from huszkacs/bug/issues_with_backspace
a4e1a259a2b Fix tests that were not updated
91b7e6027ad Move vscode.newWindow & vscode.removeFromRecentlyOpened out of apiCommands. For #110583
2ae32273fd2 update my-endgame notebook
0a1046ada41 Merge branch 'notebook/dev' into main
2f253fcc220 more todos
4093effb9b0 Merge pull request #124964 from microsoft/alex/ghost-text
79048992ef1 Adds leftTrim function, fixes bug in inlineCompletionToGhostText.
b1da1fbc8c4 Merge pull request #124972 from microsoft/hediet/fix-negative-overwriteAfter
3a259a7a6ae The replaced text does only need to be a prefix of the insert text after removing all leading whitespace.
1176faf27f2 Fix#119265
78c865d70d4 polish remote menu control actions
4ebf68103e6 readonly [] over ReadonlyArray...
67a85487125 Expose the inline completions provider in the monaco editor.
1eef15f0d54 more todos for notebook API...
552d457b718 updated code search file
f700cab7c36 💄
2031df26538 rename hasExecutionOrder to supportsExecutionOrder
f2fb2b8cbe3 rename viewType to notebookType, https://github.com/microsoft/vscode/issues/122922
ae17cc95591 Improve autocompletion for statusBar/remoteIndicator contribution point. Fixes#122566
efcf0eea9bc Remove default support from vscode-translations-import
b55d4384260 Fix regression with extension enablement
b7be98705fd Update descriptions
220f89ba3c6 jsdoc and todos
1e57955c798 Remove handling of Default inno setup file
e1928efbb63 notebook API finalization part1
cc8ff11f574 Fix recursion exit condition in variable resolver
2e026cf7c28 more API todos
0fde806bf85 Add limited support for variables that resolve to other variables Fixesmicrosoft/vscode-remote-release#5007
355df0eccb6 move renderer script and IPC into proposed and merge with general renderer IPC, https://github.com/microsoft/vscode/issues/123601
da851abcd6f jsdoc 💄
8d244362832 remove resolved todo
83d5e2bda06 rename namespace to notebooks, https://github.com/microsoft/vscode/issues/122922
594fc814bca update untitled hint to work, use the correct setting name
f68ee48c524 Fixes#124742 by ensuring that overwriteAfter is not negative.
edf85f1711d fixes#122402
3b407e0b6c1 move onDidChangeNotebookCellExecutionState into proposed, https://github.com/microsoft/vscode/issues/124970
e9579534bb2 Only trigger session when typing, not when the model context changes.
6832b7ec4b0 Disables rendering visible whitespace due to feedback. This makes ghost text less real.
7cd53df7d72 Swaps previous and next inline completion actions in the hover menu.
427f48b8d17 Add prebuild commands
dea978dd1c1 custom hover for remote indicator
8d41153ffc5 support custom hover on status bar entries
d4161177d98 don't use console.trace for all...
692fb8ab211 print trace for potential cycle, https://github.com/microsoft/vscode/issues/124723#issuecomment-850674813
f55a5243a43 don't use console.trace for all...
910d70bb88d print trace for potential cycle, https://github.com/microsoft/vscode/issues/124723#issuecomment-850674813
8b04a825b49 Merge branch 'main' into notebook/dev
94f47f44c98 Merge branch 'main' into alex/ghost-text
d776f0c1eba Fixes border color. Renames to ghostTextBorder/Foreground.
85f9447b720 Call adjustWhitespace on snippet.
db1bd650dcc Don't compute ghost text that is not supported. Thus, no space is reserved for unsupported ghost text.
4f3d865a6b4 refactor for cleaner initialization (#124904)
ccb0a8c2d93 Revert change in default due to build failures
6737ea008ff Change executionState to state
6949856b195 Remove API todo
038bac01c41 jsdoc for notebook cell statusbar API
667e3dd844a Tune getting startred color picker
bb5b6afdce4 Remove "primary" in favor of alway opening the first applicable walkthrough
6adfa8b3135 Enable getting started as default startup editor
b2f203113c1 editors - more alignments across editor inputs
ada71479023 Open getting started the first time a notebook is opened
08eedafbd60 Finish getting started content
b0862e99074 Don't include our loader in notebooks (#124864)
26b9218d64f Merge branch 'josola-edit-devcontainer-readme-markdown' into main
ad52b3f4583 Fix merge conflicts
09d1935b4cd Correct dev container info in README
1605d16ee3d Refresh dev container content
d7a79f0393f Add notebook profiles to Getting Started
887ff91a14a Merge branch 'notebook/dev' into main
5e7cd998762 Bump TS build version
e3354e26eff Whitespace characters are near invisible in High Contrast theme (Fixes#124612)
bb4e83a19a8 Improve hover stability and handle case where mouse is directly over inline ghosted text
aada268951a update distro
5fe858a229c Workspace trust explainer in getting started
f568f5aec3a Avoid scaling down SVGs in Getting Started
eb65a93f4bb Include import ref to markdown so it gets included in bundle
bbc7af71930 fixes#115535
3772aeec10b Typo
24143e91320 Merge pull request #124828 from microsoft/alex/ghost-text
868b84ceb99 fixes#124850
f509e7552a9 update classifier
676340ffad9 Get expected service worker version from renderer instead of main.js
3bfa3455a6b Fix incorrect reference when 404 on webview resource
445dc50f737 Use unique id for releaseNotes webview
1380c0c5e0b Remove unused code for rewriting endpoint
8058ab1a966 Disable consolidated run button by default
15616f8d936 refactor codeExchangeProxy to use same route and use it for refresh token as well
a6f4d96b826 Fix#124049
44a24280846 editors - unset preferred mode/contents before attempting to resolve
c784a74b8ba send Output metadata, not just OutputItem metadata, to renderer
ea02f214c74 Merge remote-tracking branch 'origin/main' into alex/ghost-text
dca2b9e2db8 Show hover over multiline ghost text
ab1cf30d883 add api-todo code search file
affbf49ccca Introduce `HoverAnchor` to allow hovering on something other than a range
4202ab071a6 rename NotebookCellOutput#outputs to #items
b16b45fecb8 Tweaks the effect of showSuggestionPreview and introduces showInlineCompletions. Explicitly triggering inline completions will now work even if settings are disabled.
d2854fd7877 fix#124842
d9f1e27aeb9 more API todos
394a1ce2dbc Merge pull request #124752 from microsoft/tyriar/term_trust
2f0a9160d0a more jsdoc, also more API-todos...
9eb940e243f Remove padding left (#124823)
42af32d16a0 do not use shadow dom for editor context menu for iOS
6c10a5334ee add jsdoc placeholder everywhere
e7776ccdcc3 Setting for specifiying the local host for port forwarding Fixes#124581
e15f4026511 Add `mightBeForeignElement` detail for `CONTENT_TEXT` mouse target types
a2d1bd0d158 Adds menu 'editor/inlineCompletions/actions' that extensions can contribute to.
098dfd56e3c Changes shortcuts of next/previous inline completion to Alt + Open/Close Square Bracket.
00de32d013a Keep track of the span node used for hit testing
8e54aed67b7 Remove `IHoverPart.equals`
ccfda77c8e6 Reorder participants to improve stability
77bc8745b29 jsdoc for NotebookController
71fafe39464 update jsdoc for `NotebookCellExecution`
541a5d4fa70 smoke: trust dialog should appear in 5 seconds, and we can ignore if it doesn't
5b642616ef3 Use loading + spin codicon for task terminals status Part of https://github.com/microsoft/vscode/issues/121659
04e09dacdfd refine output modifications of NotebookCellExecution
3a857fc436d editors - add tests for capability change events
004f6609f8c Fix problems with port protocol
903e219ccb8 files - need to track individual readonly stats everywhere (#124524)
466dd4e490e files - provide access to stat object from not modified error
872fac207ee Merge branch 'main' into notebook/dev
d5c73cc952d fix https://github.com/microsoft/vscode/issues/123570
3ac57c71329 Fix NPEs caused by extension that is not in the marketplace
df03e4caadc Removed unused MarkdownString.
e5f70e8e2a2 fix smoke tests (#124814)
47d3d743cad set max zoom to 8 (#124769)
b2da15ea2d8 Merge pull request #124745 from microsoft/alex/ghost-text
a9c54044e50 Refactors inline completions model.
ccedcbdf5ec Do not accept suggestion on tab if indentation is suggested.
a2944c32ea9 Fixes rendering of whitespace in the inline decoration.
8a3f351eb9c Use explicit context when the user cycles through suggestions.
1fa3397c48c fix post-merge hickup
a97ebdbabc8 Merge branch 'main' into notebook/dev
8715d80695f fixes#124809
7a767570e85 editors - more tweaks to dnd behaviour
07ff28c58d2 Dont center markdown content
3ea0bf8fbca Implement run button with extra actions, and "run above"/"run below" actions
970858ef6dd Add first pass of color theme selection markdown content
29cad8fb5e6 Merge pull request #124754 from microsoft/tyriar/profile_api
e0c8a76b7ad don't sort scope list. FixesMicrosoft/vscode-pull-request-github#2751
c1448f3161e Remove ansi escapes from localized string
9eeb092206f Re-enable skipped test
9b609ab1e11 Clean up profile provider api
e8758933d80 Disallow custom profiles as default
e037348d272 Support launching contributed profiles from dropdown
280e0070733 Add undocumented always syntax only TS server mode
866ecdd45a0 Merge branch 'notebook/dev' into main
1c3cc87bccb Add an `InlineCompletionsHoverParticipant`
7ce379e3f2b Merge branch 'main' into tyriar/term_trust
d9e043161fb Bump sw version
73ff24e451d Fix de/encoding for rewritten vscode-resoruce uris
b8f11107f72 Use @types/vscode-webview
decb1ab6a89 update left aligned plus button margin.
484b04df64b fix#124774
902bb43b3b1 testing: move back to proposed
31aef10814f testing: hotkey for opening output peek
14a013e7f3c Support contributed profiles in dropdown
dd61b26f33a enable workspace trust by default #wt
5338cc32da7 fix build.
4403b9010e5 Tweak remote workspace trust calculation
e3d4313714f support editor options override.
384f42bca76 Tweak wording, fix#124724
0dd52e2d77f Update distro
b157bc7e5c3 Support for @recommended:languages search (#124546)
9224159b004 Migrate users from shell -> profile settings (#124615)
d2a0bfb2866 editors - log error when opening fails
61f3ac6e07b support context keys in menu bar (#124726)
0de0faecee5 fix https://github.com/microsoft/vscode/issues/122376
f523f65f398 Add a `description` field to decorations to be able to find leaks
4c5a061df61 rename NotebookKernelPreload to NotebookRendererScript
9ef57b5c216 remove NotebookCellOutputItem#value, https://github.com/microsoft/vscode/issues/123884
4ad3265cbed Support workspace trust in terminal
a56fe2b397e use isVirtualWorkspace
ed611d0ec39 Minor tweaks
4edb0110f6b Small tweaks
7bd0337d940 Move parts of the triggering logic into the widget
2508b33f0d3 Wait for listen when making tunnels
7a83e5aa627 workbench API: assumeGalleryExtensionsAreAddressable
e94e8ed3998 Show default profile on top of term dropdown
693677c8a24 babel.config.json language mode should be 'jsonc'. Fixes#124683
cd501b2e5bb Merge pull request #124741 from jeanp413/fix-124735
9dd89100b49 Improve editor DND to work with untyped resource editor inputs (#124749)
14a4548e4ab editors - use preferred content only once
da1193950a1 some jsdoc for NotebookCellExecution
30074591eea editors - input 💄
55d91bbed87 editors dnd - more 💄
9d907212baf rename NotebookCellExecutionTask to NotebookCellExecution
5d534b94f83 dart: fix language configuration location
d0d80ec337f fix build
23fb4207373 Merge branch 'main' into notebook/dev
0637663fcfe fix isNoCorsEnvironment
9095b835bbf editors dnd - fix dirty contents in files diff
c870d75473c editors dnd - enable diff editor transfer
70418f0aced editors dnd - fix untitled transfer
bba59424f56 Merge branch 'main' into ben/better-dnd
367a0b809ab editors dnd - towards allowing any untyped editor input
6ba7093a8a1 Fix window/folder/workspace terminology for status bar entry and banner
9638534dd51 Fixes#124735
c1d4497a31e Merge pull request #124664 from microsoft/aeschli/dart
1082913dd01 fix config default value.
433c801dcc3 editors dnd - some more cleanup
cbbdb17b80d editors dnd - rework to allow to set contents to untyped editors
b5b059d2e2b fix typo in files.ts (#124693)
5eec3c86e3c smoke test - disable experiments
85d8f223c70 Remove keymaps from getting started walkthrough
02968bc2503 Call post message to all parent clients
1fd2b4ed1e3 Rename keys and support full context key expressions for check offs
14b31425b90 Fix#124531
bfb94c85fa3 fix build.
c95af9ae460 fix build.
8519a42c5f6 notebook options respond to view type specific cell toolbar position.
e3c8ff57849 try showing the banner only after some files have been opened
561b8364008 testing: fix hidden tests not being un-hidable
ade83f05895 update context based on outputs.
574696980c9 notebooks: update state of messaging spec internally
c4fda24034a testing: fix terminal being shown inappropriately, use beaker
0feee9edefc Remove `instanceof` check
641c2b175ca Merge pull request #124707 from microsoft/alex/ghost-text
e0a52df1695 Merge branch 'notebook/dev' into main
c3d63c1a1b2 fixes#124692
8e9405e7a9b Keep the `ColorPickerModel` alive between repaints in the `ColorHover`
35b43a410b0 Help TS understand the code
ebdd548be22 fixes#124702
c538781d780 add notification if tsserver logs are left on for more than 7 days (#124149)
363e8f25f6f bump distro
244b48af73d testing: additional actions and better theming for peek
a5bbc53e882 Extract more color picker related logic to `ColorHoverParticipant`
4e6fe2dc51e Extract pieces of the Color Picker logic to a new `ColorHoverParticipant`
fd7c71a2eea 💄
c88d5756213 update compact view default value.
1e6b6cb6843 Pick up TS 4.3 final
6a12866c3e9 💄
1abeaf97753 Workspace trust - remote workspace (#124617)
a430e8f9692 Fix settings dropdown hover style Fix#124207
b6acb191fac Fixes#124665.
99bcc8e2458 Show clear outputs only when there is kernel.
9252be4f90a distro
21bf10d4977 Removed unused member.
54ebd819176 distro
f1a5d40aa75 refactor getCallbackEnvironment to return authority by default
5eddbd9d207 Properly support splitting ext profiles
08cf3df7457 Pass object instead of unwrapped args for term create
d7779916566 move buildExtensionMedia to lib
62e8b545f7a missing build
51a5caf3f23 Simplify terminal creation
bf5f7dd5ec1 Get split terminals working
d1ed9c8bf35 Adds proposed API for window.getInlineCompletionItemController(...).onDidShowCompletionItem.
3ff91e7621b Merge remote-tracking branch 'origin/main' into tyriar/profile_api
7f21b1af485 Revert "Allow extensions to create multiple sessions from the same provider (#124640)" (#124705)
4583ef442b0 Fixes bug that "show previous inline completion" actually shows the next one.
8f0589da177 Set suggestionPreviewExpanded to true by default.
9464d14f317 Make notebook renderer activate potentially async (#124647)
5eb64c54ca4 Modified markdown preview nested list styling (#124445)
23e1f261dc8 Remove `HoverPartInfo`
84bc432011c Add `IHoverPart.owner`
31a59b5970d bump distro
e6a1cc38437 Update commands.json
e29194ad0d3 Activation event, register api
6a7c700a12d file working copies - do not throw from ctor anymore when schemes are unexpected
bfccdcb9581 disable fullscreen on ios
764d8fdc3dd test: add test for event Relay (#119070)
a7ab347c2b3 remove old notification
d662cc56549 remove old license notification
c704e43d5dc Check that the /build/ folder compiles
0e3459b0b9f expose Grid.onDidScroll
0a4bfb31c90 fix naming
a628237458f Web: "Open Folder" on empty workspace does nothing
4cda850edf5 disable welcome editor in smoke tests (fix#124674)
0688745e82e Color.Format.Css.format does not return null, so the return type can be made more strict. (#124568)
dff33d73244 use actual object
0d44b63c1c1 fixes#124407
9cba86888c9 update node version in optimize
0a7a69f1908 fix build compilation
9eb4eff77b8 some more jsdoc, https://github.com/microsoft/vscode/issues/124357
d63a69abf3d some enforcement of unique mime types in the extension host, https://github.com/microsoft/vscode/issues/124357
24ca9e0d7c7 Merge pull request #124654 from ValidMelvin/main
a961587ecf7 dart as built-in language
98dc73a3296 unnecessary space in in julia cgmanifest
c97189d9d06 some more :lipstsick: and simplifications
a48d92d0fd8 only pick the first occurrence of an item per mimetype, ignore others, https://github.com/microsoft/vscode/issues/124357
18b6620bc39 fixes#123543
c2cc9b11afe Update README.md
14f61093f43 fixes#124507
69259e84a0a some 💄 for https://github.com/microsoft/vscode/issues/124357
44b470c99ff fixes#124576
47d00215aff editors - cleanup untyped editor interfaces for text capabilities
04f585a580a cleanup interfaces
e12f21f498d Merge pull request #124549 from DonJayamanne/createNb
5e146d257b5 Update classifier.json
d0884f4a1ec webview - clear group listener when it gets disposed
fe1547c251b Merge pull request #124621 from microsoft/roblou/diffNotificationMessage
5cc9ec944d8 sandbox - bring in iframe based webview service
3084319750b Get rid of classes for workbench editor options (#124589)
b82b90c1000 editor options - more 💄 before merge
a18ea9c9ec2 Allow extensions to create multiple sessions from the same provider (#124640)
21162bfb68c Shift execution count label down just a bit
68efd480d0e Explicitly convert properties to strings before uploading
ad41b3a12b5 Mark a few more props as readonly
0a7061ed002 ReadonlyArray -> readonly arr[]
24a23a8ea05 Mark array params in vscode.d.ts readonly (#124599)
7d50ce2061e fix tests
2521499104b testing: add clear test button to peek view title
57af60a7b7f testing: initial test message split view
473cfe28bfa Revert "Revert "Merge branch 'main' of https://github.com/microsoft/vscode into main""
8822790908b Merge pull request #124622 from microsoft/gettingstarted/navigateToStep
7c01395da16 Revert "Merge branch 'main' of https://github.com/microsoft/vscode into main"
7a976501eb3 Merge branch 'main' of https://github.com/microsoft/vscode into main
22576768342 Applied new style to first getting started walkthrough
8ccc1243fc0 Fix notebook unit test
b0f67df65d7 Fix build
bb19c28fe2c Getting started layout polish
2d9aa1868ae Fix broken @tag in settings editor Better fix for #124520
0b2d890624c fixes#124619 #wt
20ce9d57629 fix weird border rendering on windows.
b4f4839da5e fix integration test
6bcd590a706 Merge branch 'notebook/dev' into main
e1731e91048 fix build
f378cff1a8e dropAndDrop -> dragAndDrop
032920fa2ee vfs -> virtualfs
72c4bd69c04 remote menu: sort entries of current remote first
757fd91f040 Hide TestReolver.newWindow when in virtual workspace
cf2a866b7dd test resolver: supports untrusted workspaces
68ba0141fbd fixed notebook focus indicator margin
5926c50d6c4 fix missing markdown height update
33209f104db update markdown height on options change.
7fd8f828c02 fix pwsh profile test failures (#124613)
8f18f3c5ff2 oops
771446e4a21 Make showCellStatusBarAfterExecute not experimental
71cc917274f Add option to show cell statusbar after execution
3ccbe2a6b1b Fixes#124247
789a91a487d wip
db6ffb43b90 fix#124583
c351b396cac Support terminal renaming inline in the tabs view (#124533)
33eb149bada Add reset to default to terminal tab color selector
18b30e5b494 Fix default shell args for debugging
a8b63f564af Merge pull request #124585 from microsoft/alex/ghost-text
19c88bc3c7a editors - more EditorOptions cleanup
5254e33173d Removes unused const.
af0078d44d5 editors - more EditorOptions cleanup
de08dcdf276 remove folding classes first when config change.
c17917e6ba4 Enable notebook renderers on web (#124557)
f2b1f78ad45 editors - remove EditorOptions
a21b824704b Enable notebook renderers on web (#124557)
0249ae32871 clarify that NotebookController#id should be stable, https://github.com/microsoft/vscode/issues/124535
080f8b5e35f editors - remove TextEditorOptions
8adc16d6c50 editors - remove TextOptions#create
b10db1828d0 editors - remove TextOptions#from
9bdb8f88816 editors - remove TextOptions#fromEditor
593a25d41e1 editors - remove TextOptions#apply
741beb8f264 TestResolver, use 127.0.0.1, not localhost
3de3141ff56 Implements basic cycling through completions.
4d4ebbee5fc Clear inline suggestions cache on commit.
f89fc476de3 Fixes colors for dark & white theme.
a78bc1aa96d icon label: supportIcons implies LabelWithHighlights
d4307f8d534 missing validation for top-level token color object
b6551f8e4e3 Workspace trust - no need to call setWorkspaceTrust (#124566)
afc2b062703 editors - start to remove typed editor options (notebooks, search)
64b0c65b8cb editors - fix cyclic dependencies
5880a6a4eeb Merge pull request #124570 from microsoft/hediet/ghost-text-expanded-by-default-setting
ce8b0049619 Merge pull request #124353 from microsoft/chrmarti/localinterface
97d576cb085 editors - more cleanup of large files
43b7187c3df Force inheritEnv in ext debug terminals
0685a4af28b Default bash, zsh and fish to login shells on macOS
a26ecef44b5 Add self to workbench-diagnostics
8a1de4b022a Merge pull request #124567 from microsoft/hediet/fix-after-decoration
0efc03fb168 Removes unused import.
5364a9351fd Adds option "editor.suggest.suggestionPreviewExpanded" to toggle whether suggestion previews are expanded by default.
8bd49ffd50b update distro
eff82a3cef1 rename trusted types CSP from notebookOutputRenderer to just notebookRenderer
ffd1f84ea9f rename notebookOutputRenderer to notebookRenderer, https://github.com/microsoft/vscode/issues/121819
fd212e712ea validation 💄https://github.com/microsoft/vscode/issues/121819
52df34dcf19 Fixes invalid cursor position around after decorations.
eebf8e876ab editors - extract input and side by side to own classes
42e59bd3777 more complete cell info for markup renderers
e11764f8420 add ICellInfo#data to eventually replace bytes
b5fc2b0a398 NotebookCellOutputItem factories allow for metadata, expose "bytes" as data property, deprecate value-property, fix converter issues, https://github.com/microsoft/vscode/issues/123884
856fb393cb4 editors - more dnd code polish towards any editor dnd
f2248508a68 fix tests on windows
ab793cf02ac editors - make dnd code ready to delegate serialisation to respective editors
59f5bbaf253 editors - cleanup editor descriptors and 💄
dee37c6e765 web - offer upload action only for editable folders
e0f751f1287 editors - introduce and adopt capabilities
71d00b3b993 Merge branch 'main' into notebook/dev
0bada155580 more API todos
76523deb91e Bump browserslist from 4.16.1 to 4.16.6 (#124550)
963f30f0871 💄
b1823157d54 Fall back to existing published webview commit (#119295)
286b643ecd2 chore: bump electron@12.0.9
c3c2113c368 Preserve execution summary when converting dto
8173a0e0398 Fix hang when typing incomplete @feature in settings editor Fix#124520
28803975a1a Add @feature/notebook
e9f3fe9f301 rename markdown layout section.
fe41fcc58d6 💄
fe3cab25c5f compute position/width of output action bar.
af14bf673ab remove kernel picker config in menu contribution
1da9f2d2e6a Update subscribers.json
d28d8802e42 testing: add default keybindings
8b9f8595cc2 Remove unused
6cfad71ce61 notebooks: remove deprecated vscode css vars from webview
196e79256dc Add workspacePlatform context key for getting started items Closes#123824
6ed2584f390 fix unit tests.
46ef54c20e9 Merge branch 'notebook/dev' into main
8a41d85d1be notebook open layout settings.
f88c007f6c6 👋 Rachel, 👋 Tyler
d7ead317dca Close#122570
41d869f5514 move nb layout settings out of experiments.
79762396a06 Respect soft revert for custom editors (#115658)
78251f8e016 Update distro
7e0d8cd80ee Merge pull request #124511 from microsoft/tyriar/color_config
9993eb9d1ae testing: improve support for markdown messages
b168ece8de3 markdown: add nbsp to unescaped sequences
b04c9668927 Fix test resolver with trusted workspaces
dbdc7a259e2 added bottom spacing for table in markdown preview (#124385)
5cbd4bc4691 Fix color of single tab status icon
a8d2a3a87c5 Resolve todos
47b7320c1f4 Show tab prefix before icon is ready
a31d9ca6993 Don't show icon until its resolved
f7f6956554a Share profile property schema
17e82898ed1 Remove show all colors, add settings intellisense
a8e7253de09 fix scroll in table widget #wt fixes#124314
2b9f22631f5 Support terminal link word wrapping (#124514)
cdbf46815c6 update distro
fe1af896d5d Use remote reconnection constants (#124517)
2b6564c1015 insert toolbar on the left.
df3c2c48755 testing: move apis to stable
b6dad5d1437 Support any theme color
3c2ffadf29c Dynamically generate terminal color css
9eaba8944ff Support colors in terminal profile setting
7a0ce574da6 Fix test output pty usage
777f09d4569 Fix safe config provider fallback to default
d63078aaf04 Merge pull request #124317 from jeanp413/fix-124127
a8397d15299 Merge pull request #124480 from nrayburn-tech/fix-122348
934a4244e27 Remove overrides from editor service (#124375)
b47569400a3 option to hide terminal tabs if there is only a single group fixes#122348
5319757634f Add fallback webviewExternalEndpoint in code
8f11975c47c Close#119722
d6b5df5e199 retry logic for setting password (#124390)
12fa7b04257 Increase timeout for webview focus change
4c4ec402e7e return early
b314536e56a Move find file references into the search group
18296326a9a Set proper context on new cell output toolbar
28767c88f0a Close#122795
cd8bf7ba536 fix zero height output height.
7bc2019b8d5 Updating pinning test
be8745ac9e0 Fixes#123228 (#123584)
6ee883bfa32 Split href before decoding instead of after
6af49913c2a title for notebook label in notebook toolbar
77ff6eb03bc Add image specific link normalizer (#124400)
e9b8c129155 Add types
a03daaf8506 Merge branch 'notebook/dev' into main
4ba27602740 fix#119214.
8afcdfaad8b extract complex options parsing.
9996e32bc9c testing: improvements when running a previously un-run test
6507d05310f freeze layout config.
6cda8d2373d extract configuration update
f38f3bb8e78 Merge pull request #124044 from microsoft/alex/ghost-text
51aa5402d63 Allow single line decorations that are not at the end of the line
06a86116b73 Fix firstHostSegment logic
827dec3a0df Use better logic for getting scheme and avoid extra decoding for authority
44fe867eddd fix tests
c23c9e448e6 Implement dragAndDrop enable setting
021071ff74a Avoid double encoding authority
22dc518a210 Remove unused type
97bbacd8087 Remove extra call to with
82d18a42fa2 testing: fix auto run triggering test multiple times
17f3a69e243 Allow toSide #119725
86cb6d6b337 Close#119725
4d53b454283 Fix local term warning in remote
5ac4f5f5be4 Fix didn't work
af3fbd968c9 Make sure we decode uri path
84f5040b3db Remove unused member
91fdd52d17b Merge remote-tracking branch 'origin/main' into alex/ghost-text
8b709a2f55a testing: provide test IDs in menu contributions, rather than internal elements
231c155d31f Refactors the inline completion feature.
852b70eafed Try fix (#124384)
c5da7f33a70 Fix wsl detection in profiles tests
b6387e477be Tweak output toolbar position
b78754e1e46 fix incorrect links (#124203)
a0d7f6292e9 Remove a few instances of 'vs code' in d.ts
b0683f58a5a fix#124360
9847783f62d Remove uuid from webview resource uris
79dea51e79a Rewrite webview urls to be more url-ish
8a4bf3081a8 update folding on mouse over
70c87f0db9b Fix#124240
adf68a52d56 editors - some type 💄 around setInput
effac5be7f9 drop as-prefix for ICreateCellInfo
8f093359f07 editors - simplify some serialized editor input
8aff8020dae Improve guard against unexpected URI call
82cd4f027ad fix leaking of NotebookCellOutputTextModel and NotebookCellOutputTextModel#_onDidChange, fyi @rebornix
c5b9b6c48c7 Fix missing async
5807530e3ae more jsdoc
85f518b2552 Add `RemoteAuthorityResolver.getCanonicalURI`
c650993dd39 Add `ResolvedOptions.isTrusted`
49e96be2fc1 💄 prefer `readonly` over `public readonly`
1087876df86 Use vendor-prefix for notebook specific mime-types, e.g application/vnd.code.notebook.stdout
045e5d2f568 Store conflicting defaults in storage service (#124366)
fc0b6f5e5ab fixes#122653
8b25f922b6b builtin support image/gif mime type
61aca51a322 consolidate SVGRendererContrib and HTMLRendererContrib - both were the same...
fb6f0d95fad consolidate JSONRenderer and CodeRenderer
103892d1eb4 fix code renderer layouting issues
32a06b9be2c [typescript] add limited description
bbe3b2266b5 allow to signal limited functionality in virtual workspaces
d65dace8ea0 Merge pull request #123351 from nrayburn-tech/fix-77239
b9f20119393 Bump distro
815f217174a jsdoc for factories, some unit tests, https://github.com/microsoft/vscode/issues/123884
8268bd46e7f 💄
375a15f07e9 Merge branch 'main' into notebook/dev
996dfffd637 enforce proposed API for shortTitle proposal, https://github.com/microsoft/vscode/issues/124355
c5637229dda Merge pull request #124289 from microsoft/command/shortTitle
2b959fdadc1 Listen on local interface only (#124350)
494e827e351 expose output item bytes to renderers and provide util functions: asText, asJSON, asBytes, asBlob, fyi @connor4312, https://github.com/microsoft/vscode/issues/123884
100a70731db SVG images are not render in the tooltip (fix#123688)
949f60498ae Merge pull request #124346 from microsoft/ben/pfs-promises
063be236f34 scm do not auto focus input box on iPad
f19843b0a3e editors - some 💄 and tests for workspace trust in openEditors
9086ecd9f08 Renames Suggestion to Completion and cleans up API
a6f7aa5e4c5 handle workspace uris
73c6f34f9ec Do not recognize Debian's .install file as a shell script. Fixes#124295
90b9e04f951 try to use suffix for view type when creating untitled notebook, fyi @brettfo, https://github.com/microsoft/vscode/issues/121974
779f9876bc0 debug: properly read the debug.saveBeforeStart respecting activeEditorMode
79e642a5ddb move and simplify renderer registry
bbc293839d4 declare IRenderMainframeOutput#dispose and adopt it for builtin renderer
55059ffe214 todo
e6dd819bf08 first cut of "bytes only" output items
4b5db9098c2 smoke test - disable failing search test
17459a4abd1 notebooks - add test for NotebookWorkingCopyTypeIdentifier
43b51ce8e76 notebooks - fix type identifier compute
703ca68ea6b fix typo
b8fe2db4392 fileworkingcopymanager2 => fileworkingcopymanager
0e58bef15cd file working copy => stored file working copy
78fbc51ad75 Close#124325
633ea857088 notebook working copy - some cleanup before refactorings
d0c5675f6f2 editors - less group.openEditor usage
e66c62f38a2 Generalize smoke text
89c8f919884 Add smoke test for #124146
4fd4e10e99e Fix#124146?
bfb822e4cf0 fix#124284
0989449a055 Fixes#124127
2f2b6b528d0 testing: show duration for test results, handle state computation better
3e5faf69c14 Remove console.log
9e04a67d125 Switch to use vscode-webview.net as default webview endpoint
acc07bd9591 Mark properties readonly
bf4c7042a3a cell toolbar overlap with notebook toolbar.
f29bd6f18dd Dont autofocus input on ipad Fix#122044
5b0fc94e6af fire event when trust is change in empty window #wt
c1b809ef221 Fix#124307
cd27f1fcb91 update text for loose file button #wt
07a2aab8f2c Remove duplication around checking isRemote
55c2fc5604e add setting and checkbox for untrusted files #wt
d3f040fe017 Fix notebook cell statusbar items duplicating. Cancel tokens on dispose, and dispose the timeout properly
894b7782cce Merge branch 'notebook/dev' into main
9627b4ea63e Emmet identify CDATA for wrap, fixes#123136
97740a7d253 Revert "Revert "Revert "Closes #122433"""
ddf8cc42616 Dispose CKS
4c1474b458d debug: finalize parentSession
514d3162bc8 Persist title source and set after reconnect
604b27db1bf Fixes android screen-keyboard backspace issue.
af0c01b1e36 Short title for command contribution.
18ea5ac15e6 Use isRemote instead of remote authority to determine where to load from
6f2381e33d7 Terminal tab icon API (#124004)
d0cea47ae39 Merge pull request #124194 from microsoft/dev/t-andreamah/outline-reveal-editor-switch-fix
dae2a9d4ebc do not auto focus on ios extensions input and keybindings
6b097212e69 Revert "Revert "Closes #122433""
bd934d89ea0 Use untyped editors for workspace trust
59abb887f6c notebook: address messaging api changes
5b17052a5b3 Fix webview tests
2270c36cff9 Use extension location instead of remote for asWebviewUri
9ffac783be4 Merge branch 'main' into dev/t-andreamah/outline-reveal-editor-switch-fix
22f7f470b69 Apply Logan's suggested changes
0b355ffc89b notebook: fix certain kernels/output not working
f75152cd815 notebook: fix certain kernels/output not working
ab5df442eb3 Merge pull request #123727 from microsoft/dev/t-andreamah/markdown-static-preview-scroll-state
18c254987cd Merge branch 'main' into dev/t-andreamah/markdown-static-preview-scroll-state
2ab6e9cdd26 Debounce invoking the inline suggestions provider
99be6bad750 Add a command to hide the inline suggestions
62bbbcc7bf4 Remove log
875ada9bfad experimentalUseTitleEvent -> titleMode
76154be4d4b Truncate Windows path from sequence, do title handling based on remote OS
8a6cc9cba7c Fix dynamic title for reconnected terminals
74849362b2e Render only one line of ghosted text by default
713d5861404 💄 less casts
1718a6e2ac8 Hide hover on target element(s) click
224b0f22922 Fix category and max-memory option args
5ae8db2ae0e Render the suggest widget above when rendering a multi-line preview
8c194abb5e7 Do not shrink the additional lines once a shorter suggestion is displayed
da4fcc266fc file working copy - avoid ugly casts
aea7c1a3343 Merge pull request #124196 from microsoft/tyriar/dnd_2
e538fd90c0e Hover hover when context menu is shown
4a679df5312 Hide ghosted text when it wants to be displayed in the middle of a line
e91d5475acf Merge remote-tracking branch 'origin/main' into tyriar/dnd_2
c6d2254b2fd Create a `InlineSuggestionsSession` also when showing suggestions
b5a9a026068 Invalidate current suggestion based on cursor position
49339aba513 Only start a session after a content change (with debouncing)
fdbcef0a842 Add `editor.suggest.showSuggestionPreview` to turn on/off inline suggestions
c8410ece147 node-debug@1.44.28
234136b6c28 💄 acceptsNonWorkspaceFiles -> acceptsOutOfWorkspaceFiles
91bf9326334 fixes#123469
2cc3b168fde Do not force the instantiation of the `SuggestWidget`
1543754dcab Tweak loose file dialog warning
669b0b3f719 working copy manager - clean up some types add some new APIs on manager2 for unified access: - get(resource): working copy - workingCopies: workingcopy[] - onDidCreate: Event<working copy>
3234403c5d2 Merge pull request #124191 from microsoft/aeschli/virtualWorkspacesInExtensionView
19574448d0e Fix rendering snippets
5f7cfa3a54e Introduces a GhostTextWidget model to enable data binding.
a6f89f58a9e Workspace trust - empty workspace (#123811)
0c996a39b65 Implement consolidated output toolbar
f583b4b3367 Merge branch 'main' into notebook/dev
29c61570a5b Revert "Closes #122433"
34180ac9bef Remove code allowing multiple ids for a command
35eafb78732 Add sort imports command
e65a227c829 Test using readonly[] syntax in vscode.d.ts
1ddc623e585 Simplify logic for webview resource uris (#123740)
93be0a6fa03 Update simple service
46a1ca78249 notebook: initial renderer communication
1ecba0426a9 Make `reload webviews` support webview-views
b3ed595dde7 Extract isRequestFromSafeContext
39d1a94e86f Allow loading svgs from xhr
4fbd548d72c Merge branch 'main' into dev/t-andreamah/markdown-static-preview-scroll-state
40592a274c9 fix test suite.
4fcc2720826 use custom shield dialog #wt
a65d55e9c48 Strict null fixes in webview
f822083cb70 Check `defaultPrevented` before showing built-in webview context menu
f594bb47e59 removing more unecessary whitespace
41606da2dc0 removing unecessary spaces
920c9a3a0d5 improve banner for virtual workspace
9ee1906718d pr feedback and combining prevEditor info for preview and non-preview
f433b4781a0 Pick up TS 4.3.1-rc
d921cc41fc0 Update markdown grammar
1642d4cd0ad Merge groupBy and groupByNumber utils Fix#123569
c1d6e44262e Avoid listener leak warning due to reusing cancel token for many RPC calls
0d338068034 Add suiteRepeat test util
5b3cf7cc2ae Merge branch 'notebook/dev' into main
c936add6013 hide kernel status bar item if it is already rendered in notebook toolbar.
b8c7d75e465 Avoid illegal line numbers in case of undoing a completion at the end of the file
63348b4a395 Improve contrast
de89605adfe Do not invoke provideInlineSuggestions when just moving the cursor
08f4a36de15 notebook toolbar container display none by default.
6956a38b674 Have the `InlineSuggestionsModel` listen to events directly
26194faa8be fix focus indicator default value.
2fbf0cd977e Respect the suggest widget only when there are suggestions
8c27c1f257b Update list focus highlight color in standaloned editor Refs #123703
0ec51535fa2 Rearrange actual group splits, not just instances
25bdb018483 Add theme key for terminal dnd
15f772fae32 notebook: include script url in back compat patch
b79825e7c4e Clean up
a3e72ce1d06 Reinit dnd observer after reattach
72b01fea379 Avoid selecting accepted text
d7f6d7e735d Fix markdown cell drag indiciator having wrong position in scrolled documents
de1c8ad93a9 Give clearer names and add comment
40a26850575 Fix shift for markdown cell selection only selecting current cell
3c417665643 Fix strict null errors in webview main
b8a0123cfc9 Fallback to fetch if localhost resolve fails
f0ef8dfd913 Add explicit null typings
c63ac2f6388 Use searchParams to get id
c13c6d8e468 Throw error when trying to reload/navigate within a webview
05f83d95d2b Fix issue reporter not debounce submissions (#123340)
8e87fea2f15 Support dragging to unsplit
40fbf5d915b insertToolbarPosition
e071cefa4df Support creating splits in different groups
f1a372c15f8 Support rearranging splits
2b30689ab00 Close#123935
25a12c75c5a use dummy uri
568bb89fadb Merge remote-tracking branch 'origin/main' into tyriar/dnd_2
5266a5fae3f Improved hover feedback
44d135e94f3 Merge branch 'main' into dev/t-andreamah/markdown-static-preview-scroll-state
f4e05837d01 Remove custom height, use default from menu service #123869
134d9b187bb Closes#122433
a796ebfb8b4 update actions column width #wt
f36c7a0860b Terminal dnd feedback
3804c98d6f7 fix padding for table #wt
5442f154ef6 fix issue when not connected to remote #wt
6356613d809 Update according to suggestion
49187c4e785 Replace flush with setFlushOn with loglevel info, fixes#123856
45e5c50dbfd Partially implement terminal drag and drop
283180b64b2 don't show action icons all the time wte
9716c27e068 slightly better uri for untitled notebooks, https://github.com/microsoft/vscode/issues/121974
1256b258a6f Honor the selection suggestion in the suggest widget (when it is visible)
d553c21d5e0 fixes#123869
52c8fced385 focus indicator border or gutter
81c6572671c added default editor override for symbol reveal
9326ded502b show extensions limited due to virtual workspace
b02acf39081 Merge pull request #123738 from microsoft/dev/mjbvz/unify-renderers-api
284c21a588e tweak terminology for wt entries
9a322a0d62a use folder terminology due to windows/linux limit
dc8844925ab Part of #122996
b63ad124d2e mark untitled notebooks as dirty by default, don't hold on to untitled notebooks eagerly, https://github.com/microsoft/vscode/issues/121974
09ab8ad2029 wip
eaf5a49200b status - update description of `name` property
1f912dfa3d5 Fix#123617
ff6d8771c94 fixes#124085
88d9a3aaf5c Support command links in trusted tree hovers Fixes#123723
eb5874237eb Improve task terminal status message Fixes#124062
53b58c89d44 Fix loop in port forwarding
37a11814295 do not include non configured deprecated restricted settings
53352a29540 add API to open an untitled notebook, https://github.com/microsoft/vscode/issues/121974
b7058688ad3 Fixes#124143
a0819ed4fea Add ending period to --sync
faa3146a310 Add ending period fto prof-startup
159479eb5ae Allow to show status bar entries with an id and name (fix#74972)
f23f011f552 untitled - clarify resolve methods
734b79dadae fix#124102
08618458110 fix ExtensionRecommendationsService test (for #124119)
e5bf21393bf Additional navigation keys
99f3a3726eb Additional details in the aria label
06ee4764a4c untitled file working copy - test 💄
1cc2f71a1ff untitled file working copy - tests for new unified manager
8c6db097ac7 untitled file working copy - add new manager that unifies file and untitled working copies
bc37b284431 untitled file working copy - shared dispose handling
0d92cb9dd88 untitled file working copy - poperly resolve target
37fbfa61251 untitled file working copy - set visibility
5835fbc9f1d untitled file working copy - some code 💄
a47fc96766a untitled file working copy - fix tests
1edef157350 untitled file working copy - wire in save support
8173bd132fb untitled file working copy - add workingcopyservice#get
a3ee06b3e03 untitled file working copy - extract common super type for manager
02c72e2bd64 untitled file working copy - extract reusable interfaces
44dec56af8c untitled file working copy - 💄
103ba104a56 untitled file working copy - tests
9f990bbb6ec untitled file working copy - first cut manager
4173ced659c untitled file working copy - first cut
825f6c7ab84 valide URIs created via from, https://github.com/microsoft/vscode/issues/121198
b1349b64a64 update color registry names for inline values
677f2a3be12 remove excess whitespace
0e4159cb7aa fix localization key/description for debugInline colors
df308a9a81b add color customizations for inline debug values
a9c5e37ea0d fix#124102
c5611075cad fix ExtensionRecommendationsService test (for #124119)
501b691dd06 Additional navigation keys
6034e35043e Additional details in the aria label
e878f5a3ee4 Add support for untitled file working copies (#124120)
13aff6aa7d3 untitled file working copy - test 💄
a48180b6e6d valide URIs created via from, https://github.com/microsoft/vscode/issues/121198
f22eb7ee29d untitled file working copy - tests for new unified manager
5f6d4786857 Merge pull request #123065 from nrayburn-tech/120936
2ecf53bf79a untitled file working copy - add new manager that unifies file and untitled working copies
32d4df9b823 untitled file working copy - shared dispose handling
3a1b950c147 Merge branch 'main' into ben/untitled
97518f5e869 Copy testRepeat helper to extension integration tests
721cdd6472b Fix data loss when renaming custom editors (#124057)
bbb89b86f56 remove hover bg color on notebook toolbar icon.
8f140828107 fix mouse click double background
c59f782cc7d adopt table widget for workspace trust editor
616e0fd9927 refactor: polish
4815c9e9954 fix notebook toolbar scrollbar
a069768c9b6 Remove disposing of editor input in override service
0026416a7ea move showDeprecated suggest to be a CompletionOption option
2a9f02348f6 Make notebook toolbar cell visible on click (change notebook.cellToolbarVisibility default)
df93e53dfb6 Merge branch 'notebook/dev' into main
4486788c81c allow the left toolbar to overflow.
d501abe922d contribute actions to the toolbar.
bf9f6837d14 NotebooKernelActionViewItem accepts notebook editor widget.
9063312f9c1 keep ref from cellVM to outputVM for now.
5913c5b070e Merge pull request #124125 from microsoft/tyriar/join_terminals
9b1ba3f31f0 Adds Memento.keys #87110
8b726fc9f51 update color registry names for inline values
25873bb34c4 Adds Uri.from #121198
5c4fae91762 Merge remote-tracking branch 'origin/notebook/dev' into dev/mjbvz/unify-renderers-api
79bd573d9e4 Move OpenIssueReporter api command registration out of extHostApiCommands (#124068)
73cce9a080e Fix vertical terminal margin left/right
e657d422814 debug: expose parent session on DebugSessions
25967171f17 Delay workspace recommendations as remote extensions installations are ongoing For #124119
b84a8c4215a Re-enable selectionNavigation in terminal tabs
84c23ab5bd7 debug: bump node-debug2 version
b3c56f52813 testing: bad rendering of inline decorations for markdown messages
2bc36bec9dc breakpoints select on stop
71f4934a0c6 use enum
21e0fab8b87 Don't show join in command palette
1243a51d59b Support join terminals
4e7029f593b workbench web api: builtinExtensionsFilter
34775b7d660 add requestOpenUris api
fc76d8b6b44 fix#124113
455a8b6949b List focus colors are too dark (Fixes#123703)
aee486cd293 untitled file working copy - poperly resolve target
e02714b5775 Polish for some workspace reuse (#123519)
daaa8a98bf3 debug: focus breakpoint on debug stop
f113243a516 Close and reopen tunnel when protocol changes
960af85cd93 Reduce number of calls to get port attributes
fb9d3f3e501 Fix all ports showing as user forwarded
4726abdcfa8 explorer: do not remove dotes at end of filenames before validation
026e6239be9 Merge pull request #123895 from danielgary/wmic-replacement
8f78655dbe3 untitled file working copy - set visibility
615bb082c11 Tunnel -> Port
0f5ceb2f1db Add context menu for tunnel protocol Fixes#123750
414e5dbf1f8 install additional debuggers only when at least one debugger present
1c6e481373e untitled file working copy - some code 💄
b0272010af8 Disable bell sound completely
f3cca6236e0 remove todos about ipynb cell ids
3f6e29238c5 Show status icon in tooltip
f8054f260ee Merge remote-tracking branch 'origin/main' into alex/ghost-text
2d80cb75c4b Fixes#124038: Render a `<span>` for each `::after` decoration at end of line
cdeaebbd3be Show info terminal statuses in narrow view
3467760399e Merge pull request #123867 from hediet/hediet/fix-123178-leading-ws-in-wrapped-line
71e729d1222 Merge pull request #122785 from tejasvi/patch-1
1b591be32b2 Merge remote-tracking branch 'origin/main' into pr/tejasvi/122785
49ded4d7e11 Fixes#122825: Dispose proxies when the extension host terminates
7c07550dbc5 Log errors encountered during deactivate
e4159c8f892 Add protocol to portsAttributes Part of #123750
b2c32980765 untitled file working copy - fix tests
b94b2d2cf01 untitled file working copy - wire in save support
fe2761a026e untitled file working copy - add workingcopyservice#get
956347c4edc better logic for "notebook open/close, notebook ready when cell-document open event is fired", https://github.com/microsoft/vscode/issues/123655
191ebfabe65 Merge branch 'main' into notebook/dev
2f2f8d7b0f4 untitled file working copy - extract common super type for manager
102433ffbef untitled file working copy - extract reusable interfaces
27d250fa0da Merge branch 'main' into ben/untitled
07cf22f6814 Fix ctrl+enter in code cell editor
45aafeb326d fix#123816
fd7d84a392c Merge branch 'notebook/dev' into main
d51c7f66306 add experiment global toolbar.
079be5f0fd6 remove run all cells constraint
0031e783518 Store tab list width in global storage
e270ff06255 Make default horizontal tabs width 120px
1bd7c329fb2 Move tabs list size constants into const enum
e0ff23866ad 💄
49870fb9fca More accessibility improvements
47c96324ba6 Banner accessibility improvements
7c4a2cb6cc6 Add args to source profile schema
2bf81674ee7 refs #123976
a3fe790a45f Explicitly flush OutputAppender #123856
2c91cc8a7d2 Clean up decorations when hiding ghosted text
ac85998e016 Pipe language edit counts into CES survey (#124006)
22350f3dc54 Change the order for ghost text decorations (use a class name that sorts before)
9916815a187 Merge pull request #124039 from microsoft/tyriar/121278
74372fe5663 Fixes#124038: Render a `<span>` for each `::after` decoration at end of line
a1646e35c36 Remove try catch, clean up
6353aaac13a Share code between dispose instance and remove instance
9719ae6e725 untitled file working copy - 💄
1371a8e0d49 Bulk-edit veto dialog use the correct reason
327690a3cb9 Unsplit terminals
32db232a53a Scaffold ghost text
63b6e6c51d7 untitled file working copy - tests
45769b83189 debug issues assign to Andre
f2640c349b0 untitled file working copy - first cut manager
38dda41eaa0 Merge pull request #123474 from microsoft/tyriar/local_wording
e8dbf0cc9a1 Improve wording, separate for remote and virtual
befed354684 Merge remote-tracking branch 'origin/main' into tyriar/local_wording
509926497c8 sandbox - make CLI commands a native host thing (#123899)
dc85211b159 untitled file working copy - first cut
a6db2795e36 Fix elevateIfNeeded port attribute Fixesmicrosoft/vscode-remote-release#5065
736896527ce Improve npm trust message
d4ca8b7f3a3 icon contribution: add requires (for #117437)
b2273e80745 Merge remote-tracking branch 'origin/main' into main
d8b70e74a88 cleanup link styling
46596757d41 fix icon contribution id validation (for #117437)
9ef2514d701 Merge branch 'main' into pr/121835
aad39f1ea63 untitled editor names 💄
7320c8514c9 status bar - fix compile errors
381e7c2d0bc status bar - use secondary priority as sorting criteria (#123827)
da374067139 state service - do not log expected file not found error
82767cc1d7b add aria description for workspace trust editor refs #122537
cfa977755b1 fixes#122537
5a5d1bc91f8 Add provider label in auth menus (#123922)
ff59c24225a fix#123709
87476adaee7 Merge pull request #123919 from jeanp413/fix-123892
217261cf739 Mitigate #123856
055319001c6 Fixes#123892
802ba30de2e allow managing workspace trust from extension icon
f3277a1e1e9 fix markdown editor position for compact view.
f0e57a781af fix#123819.
12f273e3e07 fix#121056.
6d79421b349 Merge branch 'notebook/dev' into main
7b9bb17ce56 refresh styles after kernel is changed.
e5c7b899cf1 compact view.
d0b6c2d2276 fixes#123858
40d5e6796fb fix#123700.
baccddcd459 Use Windows mode if build # is <= 19041 (#123725)
dcfdc8d2e4e Merge pull request #123429 from jeanp413/file-drop-terminal-tab
18313e82b00 update markdown folding icon padding
fcde284705f Merge pull request #123246 from vibhavsarraf/terminal_link_normalize_path
109f7feb3b0 Trim leading ../ or ./ from quick access query
4e79908dcff Merge remote-tracking branch 'origin/main' into pr/vibhavsarraf/123246
42b1e81d5d5 Merge remote-tracking branch 'origin/main' into pr/vibhavsarraf/123246
e5f3dd9ef82 simplify default view styles.
f4691de9552 remove legacy comments.
1ccd6a07946 Merge pull request #123910 from jeanp413/fix-123891
36e2b3176ee Update distro
c492f13efc4 xterm@4.13.0-beta.1
dff22a07121 Fix double border on vertical splits
c33420d9872 Fixes#123891
8c0ba0b5d79 [remote menu] add command Install Additional Remote Development Extensions. Fixes#123905
6510b614c10 Consistent casing for `Install Additional ...` quick pick entries
22d7f210f79 Fix full path flashing in terminal tab
4946fee0dd1 Alt+click to split single tab
f8a3cef533f debug colors: compress css selectors
828e83defca Merge pull request #123726 from suzmue/hoverText
0f7439bf2e7 Middle click to kill single tab
09b77ba6d8b added comment and removed empty lines
89b4b6c90d1 Replaced wmic call with windows-process-tree
c6525283099 Remove dialog in ChangeLocalPortAction Part of microsoft/vscode-remote-release#4958
c8b4656197f Add requireLocalPort property to portsAttributes Fixesmicrosoft/vscode-remote-release#4958
6aec850c759 Multiroot workspaces on Windows with forward slashes are treated as relative paths. Fixes#123871
27966a2521d Merge pull request #123833 from gjsjohnmurray/fix-123831
b540874d21d Incorporate task terminal status feedback
67133f048d5 Add tooltips to task status Fixes#123730
5446…
* chore(deps): fixup lockfiles
* chore: restore .gitignore
* fix(vscode): redo extra extension paths
* fix(vscode): add setSocket to PersistentProtocol
* fix(vscode): restore server files
* fix(vscode): restore typings
* fix(vscode): restore proxy_agent.ts symlink
* fix(vscode): use ptyHost.getEnv
* fix(vscode): uriTransformer refactoring
* fix(vscode): add new terminal listener
* fix(vscode): fix + enable layering lint
* chore: format file
* Squashed 'lib/vscode/' changes from 2064d4c301c..b4c1bd0a9b0
b4c1bd0a9b0 Merge pull request #125817 from microsoft/aeschli/125786
33d504f8455 clarify nls comment
d5fbc9f45fa fix localization strings with `command:`. For #125786
f8b576c274b trust the empty window by default (#125788)
c5e845182bf Dont use exp service for choosing first content behaviour (#125780)
78429fb8736 Use interpolation to keep special syntax out of strings to be translated (#125790)
47c2272a70d candy/125576 (#125787)
1e7b9242e89 Merge pull request #125773 from microsoft/roblou/fix122768
134cc8b7711 Update values for keybinding query context to match real keybindings. Fix#122768
26317e8dccd fixes#125722 (#125768)
629091038fc allow a 3rd character for first part of language id (#125761)
5e6379fd7a9 Merge pull request #125741 from microsoft/tyriar/r157_125729
098c99e2237 Set terminal title in ctor for custom pty terminals
c7119ae8b63 Merge pull request #125679 from microsoft/isidorn/fixRunMenu
0ef242cb5cc Merge pull request #125728 from microsoft/joh/fix/125716
c188ea91a64 make sure to transform notebook data metadata
e27b85b9958 fix#125702 (#125703)
008c3ecf4cd Port fix for git diff paths in webviews to 1.57 (#125704)
c926ecf021a Clone object before applying migrated setting (#125696)
6d4a8af5cfc Hide terminal menu if no process support is registered
2c9833b549d better context key for run menu
bf84ee619e0 #125527 (#125651)
2c4bd4f2b3c Merge pull request #125654 from microsoft/hediet/reduce-flickering-of-inline-completions
2e9321da48b Merge pull request #125657 from microsoft/hediet/adjust-inline-completions-color
b915673f7b2 Fix#125569 (#125650)
1c5f331fa08 Merge pull request #125653 from microsoft/hediet/fix-no-focus-after-accept
9bde5523814 Adjusts inline completions color. Fixes#125646.
7b724945310 Reduces flickering of inline completions & fixes context key.
5ba2e425f31 Fixes#125524 by focusing editor after commit.
6cdc6160057 Merge pull request #125649 from microsoft/joh/fix/125550
b3d2cd902b7 re-throw and dispose reference when resolving failed
dcc182fe3d2 Revert ESBuild updates and fix#125518 (#125574)
bdafbc3b5f2 Merge pull request #125552 from microsoft/roblou/disableRunToolbar
ce8505d5580 Add "hostRequirements" to schema (microsoft/vscode-remote-release#5144)
de98ebbc81e only show notification once per window reload (#125548)
31a11d3b786 Disable consolidated run button by default. Fix#125544
git-subtree-dir: lib/vscode
git-subtree-split: b4c1bd0a9b03c749ea011b06c6d2676c8091a70c
* fix(lib/vscode): restore product.json
* fix(vscode): backport resources hotfix
* refactor(lib/vscode): reorganize code to fit vs rules
* fix(ci): remove stray symlinks
* cleanup(lib/vscode): format .gitignore
* chore(vscode): fix formatting
* refactor(vscode): remove parsePathArg in envService
* fix(vscode): add missing terminal commands
* fix(vscode): update .eslintignore paths
* chore: document uriTransformer hacks
* fix(lib/vscode): restore patches
* fix(lib/vscode): restore more patches
* Squashed 'lib/vscode/' changes from b4c1bd0a9b0..507ce72a446
507ce72a446 Merge pull request #126577 from microsoft/sandy081/recovery/fix125970
3f4baf46c6f move focus check while converting
d95f6de445f - migrate only from active window - respect old value while reading
08bca485860 Fix race that causes auto port forwarding setting to be ignored (#126481)
2650c2e51d3 Merge pull request #126413 from microsoft/inline-suggest-prevent-auto-suggest
45c13db2195 Do not auto-trigger suggest when typing exactly the inline suggestion
20a512db915 Fix#126178; fixes markdown scrolling bug
3300069a2b7 separated editor scroll info by type and consume entry on access
92c259a77f5 Update package.json (#126283)
d21d7d9d3e8 Port fix#126057 (#126215)
d9b1d6b8c17 Merge pull request #126234 from microsoft/tyriar/157_125985
a16b9181915 Pass config to external terminal service
6bca69fc6fb macos - restore Cmd+W to close window when no editors opened (#126045)
b9f4ab00ba8 linux - restore `--no-sandbox` for startup scripts (#126028)
ca66517cf90 Revert back to Electron `12.0.7` (#126026)
6370d95598d Set visibility of markdown cells before rendering it (#126099)
git-subtree-dir: lib/vscode
git-subtree-split: 507ce72a4466fbb27b715c3722558bb15afa9f48
* fmt(docs): remove trailing whitespace
* fix(test): fix e2e tests
* chore(deps): update vulnerable vscode deps
* fix(test): clean up terminal test
* Retry menu navigation in e2e tests
* Update VS Code loader with trusted types policy
* Update build resources with renamed file
* Restore proposed API patch
Without this it is impossible to enable the proposed API for extensions.
To replicate the issue run a build or search for enableProposedApiForAll
and set it to false (it is set to true during development) then try
running an extension that uses the proposed API like the GitHub pull
request extension and look for an error in the browser console.
* Restore async storage write patch
This issue can be reliably replicated by creating an extension with the
following code:
await context.globalState.update("key", "value")
vscode.commands.executeCommand("workbench.action.reloadWindow");
If you do this the global state will never update. This can be seen by
logging with a notification or browsing the global state manually.
This is probably a bug with upstream because without this patch it is
impossible to wait for the actual storage write.
This actually required more patching than we previously had; I don't
think it was working in 1.56 either.
* Remove duplicate telemetry service registration
We no longer comment out the telemetry service in the workbench so ours
is redundant.
- logTelemetry call was slightly wrong (uses an object rather than an
array)
- No longer need the telemetry channel since the default uses the
extension environment channel.
- No longer need disableTelemetry since we don't create the setting.
This does mean the setting is not toggled off when the disable flag is
set (it does of course still prevent telemetry) but that appears to be
the same with upstream.
* Use service in terminal channel instead of interface
This allows us to avoid checking whether some functions exist when we
know they will. This means we can't use this for other pty services like
the browser one but that won't be necessary as this strictly runs on the
Node end anyway.
* Rename uri transformer using camel case
* Update yarn.lock
I got changes when I ran yarn so I reverted to 1.57 then ran yarn again
and here is the result.
* Restore .yarnrc patch
Delete .yarnrc and update the build process where that file is read
since it no longer exists.
This should resolve the issues we keep having with mismatched Node
versions. This can be consistently replicated by spinning up a new
environment (no previous modules or cache), running yarn, then running
yarn watch.
Also use process.versions.node instead of process.version as the latter
has an extra v at the beginning.
* Remove gulp-tar dependency
It's pulling in a security vuln and we don't need it anyway.
* Cancel current menu navigation on retry
* chore(docs): update docs with patches
* chore(ci): increase timeout to 15 minutes
Co-authored-by: Asher <ash@coder.com>
There's a chance this function can be called with a path that is not a string.
To catch that, we check if path is of a different type and throw an error if it
is.
This also adds a couple tests for this function.
This can be used to escape any special characters in a string with HTML before
sending from the server back to the client. This is important to prevent a
cross-site scripting attack.
Previously, we used argon2 to verify the hash with the password.
If the hash didn't start with a $, then it would enter the catch block.
Now we check the hash before trying to verify it and we also throw an Error if
the verify fails.
This makes the isHashMatch function more robust.
It seems a dialog sometimes appears asking if you want to lose
changes (even though we have no changes; it seems based on timers in
some way). Playwright defaults to dismissing them (so quickly you might
not even see them) so accepting instead fixes navigation to the logout
page getting canceled.
My thinking is that this may reduce the cognitive overhead for
developers writing new test suites.
This also allows us to perform different setup steps (like ensuring the
editor is visible when authenticated).
This uses the current dev build by default but can be overidden with
CODE_SERVER_TEST_ENTRY (for example to test a release or some other
version).
Each instance has a separate state directory. This should make
parallelization work.
This also means you are no longer required to specify the password and
address yourself (or the extension directory once we add a test
extension). `yarn test:e2e` should just work as-is.
Lastly, it means the tests are no longer subject to yarn watch randomly
restarting.
This PR refactors part of vscode.ts and adds a function to get the NLS
Configuration.
This makes the code more readable and easier to test.
And it adds multiple tests for this part of the codebase.
Node needs be v14.x not greater. If installing the standard version ‘brew install node’, both ‘yarn’ and ‘code-server’ (release version) complains.
Newest version is v16.x so we are pretty far behind.
There was a case with the hashed-password which had multiple equal signs in the
value and it wasn't being parsed correctly. This uses a new function and adds a
few tests.
Since this checks if they are authenticated using the hash/password and it's
async, we need to update authenticated to be async, which means we have to
update it everywhere it's used.
* chore: update CHANGELOG
* fix: use openFolder in welcomePage
In 1.56.2, they modified the WelcomePage use of OpenFileFolder in
src/vs/workbench/contrib/debug/browser/welcomeView.ts to only use on macOS +
Desktop (i.e. not Web). This caused the "Open Folder" to not work on macOS +
macOS-like environments.
Instead, we use OpenFolder which is a registered command and works as expected.
New extraInitContainers configuration added.
It allows to pass template with a list of containers to execute before
main code-server container started. Main container will only start when
all init containers are completed (exited with 0 code).
Additionally changes the way extraContainers is used - instead of
toYaml use tpl, because this allows to
reference any values from extraContainers string.
This was added a long time ago but accidentally lost when we reverted
the retry changes to this file after one of the VS Code updates that
added their own retry (we reverted everything not realizing we had other
unrelated changes in here).
Microsoft publishes updates to this action using the same scheme
as GitHub, where the v1 tag is updated to the latest release of
the 1.0 series. Therefore, we can manage updates manually.
* Check the logged user instead of $USER
Given that `sudo usermod --login "$DOCKER_USER" coder` and `sudo groupmod -n "$DOCKER_USER" coder` modify the container's disk it'll persist across restarts, but environment variables will be reset to whatever state they had at the end of `Dockerfile`. In this case, `$USER` is set to `coder`, so this branch will always be true.
By checking with the output of `whoami`, which gets it's information from `/etc/passwd`, we make sure to get the real logged user and not the one defined by $USER.
We also move `USER="$DOCKER_USER"` out of the branch, since we always want this to happen at entry-point. If we don't do this assignment, $USER will contain `coder` upon restart.
* Update entrypoint.sh
Check `$DOCKER_USER` was defined before copying it to `$USER`.
Now that we are creating the directories these shouldn't error. If they
are somehow missing (if the user deletes them after VS Code starts for
example) then I think we should surface that to the user.
Most of this was a straightforward replacement of our code with theirs
but I also removed `getDefaultShellAndArgs` since it seems the reference
implementation no longer does that either.
Fixes#2276.
It errors that jest is not defined so put it behind a function instead
of immediately creating the mock (this is probably a better pattern
anyway).
The constant tests had to be reworked a little. Since the logger mock is
hoisted it runs before createLoggerMock is imported. I moved it into a
beforeAll which means the require call also needed to be moved
there (since we need to mock the logger before requiring the constants
or it'll pull the non-mocked logger).
This means getPackageJson needs to be a let and assigned afterward. To
avoid having to define a type for getPackageJson I just added a let var
set to the type of the imported constants file and modified the other
areas to use the same paradigm.
I also replaced some hardcoded strings with the mocked package.json
object.
This is to match the other tests that create temp directories. It also
lets you clean up test temp directories all at once separately from
other non-test temporary directories.
We were accidentally ignoring `node/routes` because we had "out"
instead of "/out" in `coveragePathIgnorePatterns` which caused
us to not collect coverage for those files. Now we do.
cfa2e218100 Make sure we actually update the local resource roots (#122957)
206524cbf6f Merge pull request #122941 from microsoft/roblou/fix122701
0ce07162f07 Use the scoped context key service for notebook editor context keys Fix#122701
4fbe56e36b3 Merge pull request #122933 from microsoft/aeschli/122466
32a743d2af9 [JSON] Schema not found error on opening package.json. For #122279
0676e9a727e Fix port theme color typo (#122915)
85f8ebf1687 Fix context on LabelTunnelAction (#122856)
5913f53cab5 Block windows/iframes from preventing the unload (#122835) (#122869)
acd78c82ac6 Ensure that notebook cell URIs work (#122747)
4e185d89863 Merge pull request #122764 from microsoft/roblou/fix122407
7eb7814b56c Try to block webviews from cancelling unloads (#122758)
25092105030 Hardcode keybinding string to fix#122407
b084e6f4a73 Fix currently active indicator preventing editor switching (#122742)
bc2373aaa54 Merge pull request #122732 from microsoft/r156_tabs
d7a86f269a8 Disable tabs by default
git-subtree-dir: lib/vscode
git-subtree-split: cfa2e218100323074ac1948c885448fdf4de2a7f
631dbe250bc Merge pull request #122730 from microsoft/tyriar/121282
166d7fe44d9 Ensure inline action applies to terminal out of selection
921203d98a5 Revert "Use a menu instead of hard coding actions in tabsWidget (#122461)"
1ed6862c3ea more insights when execution integration tests fail
e1a46ca69b5 fix#122699 (#122712)
6449b6b7253 Fixes#122714: Guard against negative numbers around indentation
f2878212f72 Listen for workspace trust when upgrading tasks Fixes#122535
42cf2286c7a fixesmicrosoft/vscode-remote-release#4970
de6424abd01 remove workbench-web*html
a348d103d12 debug: update companion version
2a9f903edef Fix#122257
c67711fdde3 Fix#120112
f375f7e0aa2 Bumps RemoteHub version
74454818fe9 Use single quotes instead of double quotes (#122703)
78577aa18da Merge branch 'notebook/dev' into main
dd58b1fe2bf fix#121647
502ebdb1930 bump builtin modules
a7dcfd1e2c3 fix#122608 (#122616)
14a3cec0d4a Fix#122360
33a9b2adb7d Add missing scope to settings
24ea8408c3d testing: propoagate timeout option for unit tests
8dcc489fa1b Re-enables Git extension for virtual workspaces
03393445797 pass configuration in from processManager -> remoteTerminalService
e7c0af1137f Revert "Revert "Merge pull request #122540 from microsoft/tyriar/122104""
024251c2be2 fix#120848.
f0394ca9663 Updates endgame notebook repos
160b5509d2b re #120545
f9901cea702 Fix markdown cell folding issue Fix#122675
bdb2324c9da revert change to hide condition
5d5d7389888 fix#122334
ed52d777ef6 fix integration tests
1846aeaf8c7 testing: fix welcome view being shown if tests were synchronously available
62b609670ed Clear lastRunSuccess when clearing output Fix#122645
f5bef964648 change wording back to kernel, https://github.com/microsoft/vscode/issues/122415#issuecomment-829329529
6102a7d2636 Fix running
19c6d913ca9 Add noop command (fixes#122518)
df7aae61657 Add flag on whether a contribution can support a resource (#122658)
de6057e397e fixes#122656
439ec79e6be Fix#122637
3d6f88eb925 fixes#120828
2eb378324d0 fixes#121392
b2d6cab9985 Revert "chore: bump electron@12.0.5"
4b06c752c6a fixes#121425
ae82935e448 fixes#121503
7d51e0b1eb6 fixes#122289
d295d140849 fixes#122353
83c7bc3dbf1 allow controller picker with single item, https://github.com/microsoft/vscode/issues/122415
1cc7abafb0d Drive users to picker when having multiple potential notebook controllers, https://github.com/microsoft/vscode/issues/122415
ed5d4a1329a Revert "do not auto open pasted file"
3bb2d0c3a21 fixes#122354
7fa8cdf44ef fixes#122079
677be5b44b0 change vs select wording tweaks, https://github.com/microsoft/vscode/issues/122415
3162eac1f9b update distro
e6b871d094d show placeholder text for kernel picker, https://github.com/microsoft/vscode/issues/122415
eeceecef81e update doc
780eb163b7a Improve capabilities.untrustedWorkspaces contribution (#122603)
5682823e663 improve virtual workspace disablement wording
0123d26aaa3 tweak setting config
2f915a24b40 Don't label custom editors are readonly if the editor is not editable
28a1bc2f35e Revert "Merge pull request #122540 from microsoft/tyriar/122104"
3915fcfe493 Add some links and small cleanup for JS/TS settings
e8eb44523ef Improve auto-fetch setting display
a4fdb2c3ad0 Make adding overrides an preferred quick fix
9064c909d70 chore: bump electron@12.0.5
7adfba6262f Remove no implicit override task
60f46f2f7a8 Adding JS and PY Azure SDK packages (#122468)
f15ac1527ff fix unit tests for web
75f4c87a854 fix#122548.
c56f5ea118b fix#122359.
2858d5f3a75 remove trust from web
6a841dd8d5a Remove extra padding on h1s in markdown cells
40e0a578a80 Merge pull request #122505 from joyceerhl/dev/joyceerhl/markdown-cell-padding
033f6aac860 Fix missed Previewer.plain call due to adjacent @ts-expect-error (#121975)
f17e1ce19d0 Update distro
f8033ad59a2 xterm@4.12.0-beta26
3719898cb81 Merge branch 'notebook/dev' into main
bf7d8da5f0f Fix#122360
2f5e355bea7 fix#122329 (#122576)
968d6702663 testing: fix welcome view being shown incorrectly
7770708545c Reapply markup renderers change
c8c96aae9d5 Fixes # 122567: regex included .git in capture
5082e72921d Avoid cell execution icon flickering due to rerendering spinner
201063aa2ef Fix missing cell execution icon
d89a35b91fb API TODO
107351bc206 debug: use category instead of tag for search
82399e71c2d Even more port forwarding logging
29b49a03928 fixes#122520fixes#122393
26ce0255947 fixes#122310
1bd250ca513 Set tunnel factory earlier (#122557)
a8a1b0f6db1 fix#122452
3b1b002b039 testing: mark runs complete if trust is not given
606bf316c73 Fix#122544
6f6b8156506 Call cell statusbar providers after changes are sent to the EH Fix#122341
99f8682e29a Fix inherited split cwd
5728f84b8c3 Merge pull request #122399 from solomatov/ext-host-hang
24faa3733fb Resolve profile environment when launching default
13d3c0e7575 Add explicit dispose calls for `DiskFileSystemProvider` in tests (#121857)
e2eb2ec0d75 Add enum descriptions to tabs settings
398a23805b3 Fix#122311
06694a8e577 Merge pull request #122540 from microsoft/tyriar/122104
36fe84236dc Rename hideForSingle to hideCondition
1e9c0a643e4 Fix notebook cell collapse action Fix#122318
935fb2b33c1 Merge remote-tracking branch 'origin/main' into tyriar/122104
1f913a81b16 Revert "better fix for https://github.com/microsoft/vscode/issues/119943"
134f551f210 Revert "remove unused code after changes for https://github.com/microsoft/vscode/issues/119943"
3ea6e11841a requiresTrust -> restricted
a9ad5d9eacc Reinstall sash listener after view swap
b3292e6fff7 Merge branch 'main' into tyriar/122104
85ed0a54d12 Fix#122543
aa1b82bf134 Fix#122477
05658fe91ea remove unused code after changes for https://github.com/microsoft/vscode/issues/119943
0877dc2131f better fix for https://github.com/microsoft/vscode/issues/119943
01a6c000ce4 Fix compile
10a5077e0b9 Bring back workspace shells via setting
c76579365d1 Fix#122533
5f9336443fb Task upgrade requires trust Fixes#122535
d0fceb64b42 fix disposal of extension-triggered document references when file is deleted, https://github.com/microsoft/vscode/issues/119943
8f45bda14f1 Enable some upgrade of tasks with global os config Fixes#122435
0be4e2958f9 Fix#122488
b98c1dd7eb6 Remove no longer relevant comment
d0d615d1e4c Improve plural language in task upgrade notification Fixes#122437
dc5219000dc Fixes#122333
636583b1cd7 Use schema version as task upgrade trigger Fixes#122442
a613882bbdb Task upgrade shouldn't stop if tasks.json.old exists Fixes#122439
e2044db595d Don't include empty arrays in task upgrade Fixes#122445
8420e94d8d2 fix https://github.com/microsoft/vscode/issues/122270
5688d75ef95 update jsdoc for NotebookController#viewType
232b10fb540 more jsdoc for supportedLanguages, fixes https://github.com/microsoft/vscode/issues/122372
5ba42fcf94d fix#122510
811416a13c1 Merge branch 'main' into notebook/dev
f608a090a6a make sure to return options from override handler (or existing options) https://github.com/microsoft/vscode/issues/122480
a6ec48d1597 fix#118423
84ef3183736 Add missing padding-bottom
08605e882e2 Fix#122256
38831ba3626 Fix typo
13f1afffab0 Make sure empty cells clear previous rendered contents
8d1794e91d5 Register config
5ce4e7ca8f3 Bumps RemoteHub version
f727e50c1a8 Use a menu instead of hard coding actions in tabsWidget (#122461)
1f165beac40 Fix unreliable status bar indicator Fix#121194
27b39a13a00 fixes#122310
75615b76275 Fix potential cell statusbar issue
779434d2d11 fixes#122306
ae1c315aa7b tweak wording for disabled extensions fixes#122394
bf7c1f53d94 use label service to provide tooltip fixes#122411
df3ebcc5ef2 use authors always fixes#122382
bea80413c2e add setting to configure trust prompt fixes#122304
782ec1356c0 Add build extension media tasks
b08c521660a Fix#122385
e8c5b7bb8bf Fix#122429
04e57de7248 Fix#122425
eb6a45ae94f Align single tab status size with tabs
aa454714b70 Fix status icon blurriness
db5a53958e0 Fix error message in case of activation failure
051c38cf0f1 testing: trigger relayout on welcome view visibility change
a50793147e6 Fix#122440
d93abcd3d97 Fix#122430
e106db06194 fix#122218
541063725ce update distro
f1c66b6f9bf Set aria label and include split number/total
40983b6a142 fix#122340
283c3035a49 fixes#121148
f4ab7e822f9 Fixes#122361 and 122360
19cda32aafc Another asWebviewUri fix, use the authority of the root that we found the file in.
c193a1ca383 Ensure an invalid icon ID is not used
f637c8fda56 fix#122150.
138be779f34 Terminate in case of ext host IPC timeout
a065a9458d0 Task name updates
912e8aff9c4 fix https://github.com/microsoft/vscode/issues/122328
3a8aefc8006 Use markdownDeprecationMessage
d3d2d113917 Add deprecation message to shell and shellArgs settings
0d5eb683ab7 Ensure tab rerender happens after layout
724172d1349 Show keybindings in inline actions
11a7f9565ea text files - automatically save when reopening with encoding (#122301)
b26b993dafa Make inline actions multi-select aware
87a33e998d8 disable edu telemetry on nocors
b9147d80e5a Set active and focus new terminal on double click
c50ab1e89f6 adopt editorOverrideService for compare (#121668)
3e1a7dc6551 Don't cache the text editor as it doesn't require the ext host
83581ff2b9e Merge pull request #121186 from microsoft/tyriar/ptyhost
f28947fb35f Fix compile
33be8b82f70 Merge remote-tracking branch 'origin/main' into tyriar/ptyhost
a6591d45e04 Add telemetry events for pty host
40c385c4498 web: use tmp as inmemory scheme
f92821bfa34 update distro
aac4cce13e6 Set focus/selection to new term on dbl click
4c24caf5d90 Add ... to rename and change icon
faf54e77e61 Remove console.log in test
dbb1a584992 Hide terminal tab hover on mousein, unless actions
eb141a80257 Use the latest LSIF version for indexing
f247d234d7c Use terminal groups for build Fixes https://github.com/microsoft/vscode/issues/122287
4550c3b454d can change enablement when disabled by trust
c9e8dff24c4 window.title ${remoteName} seems to be "vscode-remote" when not in a remote (fix#122213)
6ef53c31d9c shared process - also log lifecycle state when window errors
d417ef3e79f update distro
d74baa17185 log when using in memory data provider
e2e0d915729 Merge branch 'main' into notebook/dev
1f8e11079ea Revert "Comment out failing integration tests (#122269)"
0317e056bbb Merge branch 'main' into notebook/dev
26cf2a5d624 fix https://github.com/microsoft/vscode/issues/122269
2250b7aa3c0 :chore: allow to use node.js 16 for developing vscode
5346ab1bc3a Merge branch 'main' into notebook/dev
9a4d524f909 Comment out failing integration tests (#122269)
0cbc7217096 Bumps RemoteHub version
f88202aa46f Fix missing cell execution icon
8b22dff166d Updates endgame query
e3476ac1865 API TODO
fe7c5aba015 Revert "Better notebook markup renderer api (#121882)"
4a0a1f2f6f1 Fix replacement for script after it has been optimized
e95ce0a810b do not block webview creation for fetch errors.
fef89de135f remove open editor on startup
9b328b27396 NotebookKernel test, another attempt
98fdb8a9a06 add skipped test for lcs diff.
b1569995f9d testing: allow waiting for server before running unit tests
fc90674374e use parent folder instead of folder name
4cb27d2ec76 Better notebook markup renderer api (#121882)
495d162a4ef minheight
4f6b0a1b7c7 swap button and text
2be7cd82b0d cleanup styling and wording in editor
5c8ab73c2fb Build using newer TS nightly
bf339ba787e testing: allow contributing to test welcome view
6014c7781e3 testing: allow following running test
480f3c0b351 Return undefined if dialog is cancelled (#122234)
8b15a01d8eb [json] update service
5d4454709a3 Fix#122218
82520584efd remove unneeded logic
b466147ca4b fix#122161
e1845803d30 Add telemetry event for failed extension activation
2f946f7d803 fix test. @jrieken.
bf94540cc88 Merge branch 'notebook/dev' into main
893d29c487e Bumps RemoteHub version
553d92817ba Word selection is incomplete for C++ identifiers containing certain allowed characters. Fixes#121343
4f37102dc0a Fix issue with cancelling the dialog
ba7c9491645 web: drop authority usage
51b2521eef6 use prominent status bar theme color fixes#120455
cb7b2e8c375 fixes#120500
37d967e30d9 testing: rename testRunTask to testRun
b9b6a11be76 fix#118073
f6f81128192 Merge pull request #121938 from microsoft/alex/change-default-enable-builtin-extensions
5080d21c0b5 Fix typo
7b0a8177fac Implement workaround for jupyter in codespaces for asWebviewUri issue #121981
aed088f7016 fix#119678 Co-authored-by: Daniel Imms <daimms@microsoft.com>
7971891fa17 Merge pull request #122100 from microsoft/ben/search-editor-backups
c15cb13a383 Add js doc comments
7329a207e09 Merge branch 'main' into notebook/dev
8fa05403b6b Add a cache to the editor override service to allow awaiting ext host (#122067)
08e29e6e890 fix#121317
141c4274d90 update distro
b7e57b93f8f No longer force showing input box for screenreader (#122054)
205a366f1c1 Fix file location pattern in eslint-stylish problem matcher (#117576)
693e3a4aebe browser: register inmemory fs provider
f3cb718a800 more renamed
9a43ef93f70 extract INotebookKernelMatchInfo
db7b52abdc1 Undo task queue change
7135d9d5ea6 Bump ssri from 8.0.0 to 8.0.1
efa9e692e34 Fix narrow terminal tab alignment
25b4a53f67b Fix bad tilda handling in simple file picker Part of #121280
289d46f960d update distro
4212c6f9234 Remove unnecessary entries
c95aaf71a8c Add keybinding for split in tabs
91c41b04db2 Add keybinding for delete terminal tab
b57a9d16c93 Clean up IEditorInput#copy
25787c9584f Add focusMode tab setting
8fac1535178 💄 renames
7a5031487a6 Remove short description for terminal split/kill
5bf77b350f1 Set selection to what is right clicked if outside selection
50b10894ce4 Merge pull request #122179 from microsoft/sandy081/custommHover
acc4bcebcff Adjust active instance in tab on dispose
5d77401e475 debug: restart should be sent to parent session
61472da358d Render tabs on tab widget create
42754baf3a0 relax uniqueness requirement for controller ids, must only be unique per extension, not globally, https://github.com/microsoft/vscode/issues/121902
57f1aa9ae66 update distro
0489b546826 OSS Tool
d90814dab4e make sure alternative goto-command is also a goto-command
5623111a12e correct remoteAuthority description in workspace files. Fixes#119858
0c4663383db Merge remote-tracking branch 'origin/main' into alex/change-default-enable-builtin-extensions
dcd5eaa0b56 remove todo
9129f217050 Merge branch 'main' into notebook/dev
ad372e2f94a more test fixture adoption
6c5613e6972 add test and fixes for https://github.com/microsoft/vscode/issues/121904
16423fad0b5 file working copy - actually use elevated file service
a2656e12606 add doc
ad16e7c2123 round pointer poistion
7c10c7e1e28 Fix remote explorer dropdown alignment Fixesmicrosoft/vscode-remote-release#4945
975e8ba2845 web api - move log level into new dev options
f52952332d1 :chore: some ReadOnlyArray => readonly
974d87948b4 Merge branch 'main' into sandy081/custommHover
7d13ce88e7f improve hover position logic
b8c9fbe5918 store associated notebook by uri _and_ type, send unselect event on kernel- or notebook-remove but keep the memento untouched, https://github.com/microsoft/vscode/issues/121904
f85e69f55d8 file working copy - write elevated support
594b7b07a6a make sure "Open With..." actually works..., maybe https://github.com/microsoft/vscode/issues/121974 or maybe https://github.com/microsoft/vscode/issues/121904
94daaf715a4 win/linux: alt+f4 to close window (#54492)
2cfe0d79121 fix notebook type bindings
5053c82843e adopt api changes
a15a6237c2f Merge branch 'main' into ben/search-editor-backups
d505f37758f file working copy - provide "Save As" support and address some issues
633562da380 Remove some finniky logic causing rendering glitches
2023dd3ce83 Fix#122090
0eccb45395c Fix#122091
7950d3e6210 Support multi select split/ kill in terminal tabs (#122148)
9e9ad5b905f notebook.navigation.allowNavigateToSurroundingCells
08d37a85a3f turn markdown cell into preview mode after hiding find.
27388ab7cf4 fix output edit sequence.
25d716f9006 [html/css/json] update dependencies
cb6e7b383bb fix#122099
6c8875d8bb8 working copy backup - adress some issues before endgame
c2041ceed35 💄 editor extension export
1a46de24eab Improve terminal text shifting when icon is resolved late
fd610ca54bb Improve rendering of very long collapesed titles Ref #119766
c67ea42a683 Restrict space that can be taken up by extremely long contributed items Closes#119765Closes#119766
6ef0f2f1bd4 tabs.enable -> enabled
42851ddb80e Hide description in narrow tab view
7aab1c1714b Update tab sash reset to play nicely with new changes
8251c67121e Merge pull request #122076 from microsoft/tyriar/122010
cec1401b9b9 Fix compile
d7df6a7be04 Support new description in tasks
2c7604e4ad9 Add terminal description to single tab
14919db24dc Remove local title appending
2e191b55ae4 Add terminal local description/initial text
8a426385aef Close#120122
51ea16cd700 No more mr nice guy
47b7fd91d6b [Getting Started] Naming: tasks/items => steps Ref #120049
49ea5ccc13b Fixes#121873 (#121874)
a1d60dcb3bd return terminal icon if one isn't resolved
a87db274dac Make sure we build extension media for integration tests
d690b2d7e21 Fix notebook tests
3faf47d16ee debug: bump js-debug version
b126d45af96 Allow x64 macOS builds to be triggered alone
af58ea10fc1 Show trust dialog when running a notebook cell #118584
013521dd1e6 Accept uid=501(daimms) gid=20(staff) groups=20(staff),12(everyone),61(localaccounts),79(_appserverusr),80(admin),81(_appserveradm),98(_lpadmin),701(com.apple.sharepoint.group.1),33(_appstore),100(_lpoperator),204(_developer),250(_analyticsusers),395(com.apple.access_ftp),398(com.apple.access_screensharing),399(com.apple.access_ssh),400(com.apple.access_remote_ae) icon format only
be42b4b655a Don't autofocus search box in settings on ipad - #122044
3efe6bb4f94 Allow markdown content in getting started (#121960)
afaa4944045 remote indicator menu: cache action groups
aa219c8eb0a Merge branch 'notebook/dev' into main
a0804b66d3a fix#122049 (#122056)
b2c250faeb3 fix build
f0c8fea098d Tweak "switch to insiders" message
6d56e69ba93 fix#121954
b272df7ade8 fix#122051
a729f709a32 Refresh tabs on hideForSingle change
1fcbe3d71d2 update edit mode with source
9c6f4c194f7 notebook find with match count.
5c7d17bf267 Move service registration
3418b95ac34 Introduce copy concept to editor inputs Fix#121429
3b18aed03e7 fix#122039
6c747e75dad Workspace Trust Prop Changes (#121779)
ee3812f51cd fix#122038
d879960af3d send event when affinities change so that status bar can update, fixes https://github.com/microsoft/vscode/issues/122028
80b5eca3c1b add unit test to assert, https://github.com/microsoft/vscode/issues/122028
558b08e7905 fix#122031
fc19fba5ae1 Have single tab act like a dropdown
3cba3d9c4df Merge pull request #122032 from microsoft/tyriar/121601
838b1131985 Have single tab focus the terminal
b9f5e85bc07 Add context menu for single terminal tab
ef64d205b95 Fix missing cell statusbar icon color
89451c134d0 Remove todo
760b84e09f8 Namespace tabs settings
31c946b97ab Catch showTabs = true legacy case
c8807577d4c Hook up new showTabs enum
876dd2782a2 Don't allow multiple tasks runs to start at once Fixes#118238
803d0d62464 Add new settings to control visibility of active terminal
2a384630932 Merge remote-tracking branch 'origin/main' into tyriar/121601
9a978d2f31b working copy - implement backup restore in tracker and keep non restored backups (#117873)
338afacb02d Add additional height to term tabs for dbl click
25cecbe4be9 Fix launching terminal profile via dropdown
4827b266951 Initial single tab view
64f72f290a1 Bump distro
66f0c29ddb3 Fix spelling error
a8755553a71 show selected controller in picker, don't say kernel in the UI
0ee8f4efeda Update my endgame notebook
912259262bd fix build
d95f4c4d8b5 Workspace trust - multi-root workspace file (#121765)
5685e22ba3e Remove soft notification from extension enablement
e51f5015b29 fixes#111350
18c4196f82f Remove soft notification badge
122eac1d743 naming 💄
118c41150c5 Move extension settings for workspace trust
fa0da8322c7 Further improve pasting into simple file picker Fixes#121280
a14e4d060a5 working copy - first cut of a backup restorer that works on new working copy editor service (#117873)
6a16dcf5867 Ensure tabs don't get another split added
f46cebe4666 sandbox - fix running in sandbox mode
cfb866ac533 Show tab actions on focus/selected
d40139dd638 Make typescript problem matcher even more general Fixes#121672
f37cda267a9 show in tooltip if controller was auto picked or not
4106ff45187 Localize empty tabs context menu labels
88e2f94a9d7 Add show tabs dropdown entry, remove others
43247e86159 Add the globe back to the Ports view
b8e2b1b7889 Merge branch 'main' into notebook/dev
68ddcf50e86 Remove bad } from terminal title
97814d10877 node-pty@0.10.1
cf603f67f05 Remove tasks from workbench.desktop.main.ts Part of https://github.com/microsoft/vscode/issues/118201
ef521cc5403 remove bad instanceof check
2437313ca46 Fixes#121535
ca36916a61a update distro
8e0e2199b16 working copy - drop TestWorkingCopyService
abe5e414e70 add onDidCreateNotebookDocument in addition to onDidAdd.
d1b0a469b12 remove kernelProviderAssociations but add a notebook-type 2 kernel association as shared/sync'd memento
05e0899ffd1 working copy - more readonly arrays
52ef3b65268 Pass correct URI to opener service fallback Fixesmicrosoft/vscode-remote-release#4920
31536dd690c editors - make findEditors more powerful
c32f1cc4632 update ref viewlet
ac151b40a57 enable virtual workspace capability
77ac0dc1a5c Merge pull request #119040 from jeanp413/fix-103631
9701c057ef7 refine prompts: using warning when file is too large for formatting, use model for installing formatter, https://github.com/microsoft/vscode/issues/119463#issuecomment-825434820
a668bed63ae add skipped/failing test for https://github.com/microsoft/vscode/issues/121994
abc6cf94729 text file tracker - fix regression with untitled not being tracked
666f3ac3e06 file working copy - provide some basic save error handling (#117873)
0310f02dc5d reset key on focus out and set focus if there was one
4853ea69eb4 Add command and keybinding to focus terminal tabs view (#121978)
66fd0cba91b Enable noImplicitOverride
36591a96a02 Rename
cd9a6a48201 Add telemetry for rendering of markdown path
1ea93521feb fix#121816 (#121957)
afdd217b3bd Create new terminal from profile in multi-root workspace (#121958)
7bf7774d8a6 Add custom editor telemetry
b0b4b814d0a Fix#121793
1b1fa411580 💄 test
274565432ce Merge branch 'notebook/dev' into main
94f28728f76 remoteIndicator menu point: double digit order number. For #121180
c141ca66619 testing: show load errors in tree view
214a1581b7e Make window indicator menu contribution point stable. Fixes#121180
484c5c87338 Fix tests
8e51485f45f Debounce cell output edits from EH Fix#119832
ddbc369b115 Fix cell output append edits showing up in reverse #119832
2f077172cb0 Add `php.validate.executablePath` to restrictedConfigurations
dfd1b65fce9 debug config manager: dynamic providers fix
894f50d5443 debug: make sure to not show dialog when launch config content is being created
b1ca80cf60a re #121140.
2d12c84be75 fix#121723.
1f75a0331bf Make narrow tabs show status color icon
aebef8cf5b7 Fix statusbar items with wrong width in new cell
7c17ed4680f Fix#121927 Remove new inner span in statusbar items, also switch to just codicon syntax
ab9a916272c some 💄 and a tricky todo
426f1b7d80c Fix layer issue
b6ff982121d Merge branch 'main' into sandy081/custommHover
9f43daf9028 use DAP 1.47.0
df42794a6c8 node-debug@1.44.27
5460fcfc4ea Support relaunch hover action
2130042ca4c disable github extension in virtual workspace as it depends on git
e1bfeec6b1a Show relaunch needed details in hover
f38f90dfe16 Improve package.json file check Fixes#120279
f68a7e77788 add NotebookDocument to executeHandler
690c76c1051 Fix statuses getting stuck, integrate decoration title
5fc245f2d74 refs #120675
a217409e38f include silent for notifications:actionExecuted
f6c4607367b Incorporate task upgrade feedback
68bed019705 adopt virtual workspaces - not supported
d4033de1f1d update distro
ed16789225e localise workspace trust strings for exts
97344537a59 Use affinity over priority
1305c61d823 Merge remote-tracking branch 'origin/main' into alex/change-default-enable-builtin-extensions
a385ea15bdd todos about affinity vs priority
5390ec0e7c3 remove isPreferred as instance property, replace selector with only viewType, allow controller to set a notebook priority instead
5c39e705cc7 Add tooltips to terminal statuses
b14455b318e Provide label formatter for terminal URIs
daab26c2e71 Merge pull request #121853 from microsoft/capabilities
70c5e1e00c5 fix compilation
07505af8c9e update distro
793cdaea1f7 Removed unused code
7ac3721a4d0 Hook visual bell up to enableBell setting
e90519d1cce Rever awaiting for ext host on open
1eb45d72c8a Delay terminal bell shortly after creation
3ebd601face Change default for enable builtin extensions
0cca69109c4 Ensure primary status event fires when status is removed
436725c584e Use Application scope for `keyboard.dispatch`
c95c0cbae49 Add tab view empty context menu
6779f853214 add comment
371b3de4367 Fix right click pasting in tab view
03a3abf6daa Use constant for dblclick
b64f1aa2358 Support double click to create new term
522062daf57 Expand terminal tabs to whole width
9fb92f0f705 mark property readonly
dab0e063bcd mark supportedLanguages as optional, some todos
166efae3664 Fix `--noImplicitOverride` problems (#120675)
6a781878370 Remove deprecated sync methods from configuration resolver Part of #108804
87eac45476d Support defaultProfile in selection default profile command
253fee71631 assert that executing a cell send selection event, https://github.com/microsoft/vscode/issues/121904
90c5c7a0d2f Merge branch 'main' into capabilities
56acb0b1d25 Throttle calls to spawn/kill under conpty
bceab04077b debug issues should get auto assigned to me
12741ed7d88 add notebook instance to interrupt handler, https://github.com/microsoft/vscode/issues/121912
b96d65b9be4 Finish adoption of IShellEnvironmentService in terminal
5c904937545 Fix case issue on Windows with variable resolving Fixes#121847
2a6703463d9 Update distro
5a78d3377f3 Merge pull request #121918 from microsoft/tyriar/120328
7bd176faa1b Adopt bash terminal icon
4ae4ca97598 Move dropdown with primary to base
1df9d8902c1 send controller selection event when selection knowledge is restored from memento, https://github.com/microsoft/vscode/issues/121904
e86fdc6728e Merge pull request #121732 from microsoft/tyriar/121657
22d2f01347b Fix compile
fd709cc79fa Reduce calls to getShellEnvironment
eaf3a5dcda4 Move off deprecated resolve function
ae50493e894 Only dispose on middle click
29ade591f55 Remove old prompt from tasks service Part of #119463
dc589f540ab Merge remote-tracking branch 'origin/main' into tyriar/121657
00e8e6459d2 fix UntrustedWorkspaces type
5d8f09d2708 adopt to new capabilities api proposal
f5b31e9a331 use UriComponents for extensionTestsPath. For #121734
af76d0cf137 export IDevelopmentOptions
79033ef7a19 Adds code lens on vfs files
46a25f25e87 update distro
8ce16487193 Merge pull request #121734 from microsoft/aeschli/testsInWebEH
71b23eb39d8 Merge branch 'main' into aeschli/testsInWebEH
b3151c10ce7 fix compile error, fyi @rebornix
a18d061b009 Merge branch 'main' into notebook/dev
2e0214b3645 rename ExecutionHandler to ExecuteHandler
7ce1499d954 More removed unused
60af02d7582 fix#121807.
27675a99be1 Remove unused services
49924bbab74 Remove notification ref #119463
4a8e9493472 consolidate tabActions code
f547ada6eeb Allow text search providers to give messages (#121528)
159d5d2799b move separator inside
a536ece09f7 add hide tabs panel to context menu
807ae1e167d fix#121744
79a5cd28cae re #121252. Add actions to toggle cell position.
c638290c09a add setting for specifying cell toolbar position per view type. fix#121252.
6c48db1730a testing: fix test failures
883424c4e37 testing: betterify view
57d4e39aebc Fix issue with tabbing out of outputs with iframe webviews enabled #119727
7c83a16e724 Fix tabbing into statusbar, #119727
a689b7ec842 Remove underline from h1s in notebooks
15110d66f0d Bump fallback version for webview contents
7e8193bee0d adjust hover position for panel
d2b7b09d716 show panel hover on top
fbfe0154989 remove NotebookTextModel._mapping.
9e29a9caf53 align left and right positions
61364b04926 introduce hover position and align hover and pointer
306f32b7ce5 re #121869.
dd2aefcd7cc fix#121818 and make terminalService manager/updater of available profiles (#121837)
264ccd16d4f Merge branch 'notebook/dev' into main
2a718949839 update distro
0867628480e Merge pull request #121836 from microsoft/tyriar/plus_style
2ae89029880 Update Codicons: update "copy"
951612b9339 Remove deps from dropdown with primary
6344624354d Await extension registration fixes#116259
cc66860c669 Add styles to dropdown.css
39c0b817706 Update Codicons - Add "wand" - Add "debug-line-by-line"
a509be4c994 Update Codicons: Add "filter-filled" cdceb9f5fc
dc0b17b5bfd typo
eaec4b3f2cd workbench embedder API: developmentOptions
731402dce22 async override -> override async
190e902afe6 Move editor associations to override service
685147c008f show hover pointer
9d0add77827 Update Codicons - Add "swap" - Add "copy" - Add "person-add"
2e5ca55a78b Update Codicons: add `terminal-bash` 678b2158fe
74cba9e0038 Move IEditorOverrideService to common
d86ba38b9eb Clean up cell margins
10afe5984ae Fix dragging cells near the execute button Fix#119535
07ebcc8d0ac remove virtual workspaces until onboarded
f9fc28d47db update ext manifest schema validation and built-in exts
0d29a8722c1 Revert "Move editorOverrideService to common"
6009275300c Don't lose cell toolbar when expanding the dropdown
c3265df7cc1 Show cell toolbar when hovering it, when it's invisible Fix#117618
84809f41cd7 Move editorOverrideService to common
4eee5c6ee5d testing: fix test wrapper not including ranges and not dealing with sync discovered root
3c4b64079d3 Logging categoryDescriptor.id instead of [object Object] (#121850)
301d4e9a50f fix broken test
aec0921e5c2 first pass to update workspace trust to capabilities
43d2efaab63 describe the context key for workspace trust
a9f70f7919e finalize basic workspace trust api
d97790d1624 Fixes#596c518bd9af
fa96e5566b0 Fix setting sync button in Getting Started.
aa6e570a848 Fix typo
0aad5f2390a fix#121841
3fe2d3b5433 [remote] Allow to open remote files through vscode://vscode-remote/. Fixes#108257
ce63fe5e18d correct name of initial dropdown
4af696b7892 Improve new terminal dropdown style
dbac9179a0b Merge pull request #121831 from microsoft/tyriar/121827
7623d09e3ae Remove tasks v1 Part of #118201
4a5c0bd88ae Don't expose change icon instance in command palette
27d236fec1c Inline menu entries
128c666879b Don't override keybinding for split
827d9284bfe Fix change icon/rename ctx menu
84e63b1d13f Create new command IDs for kill/split instance
f9737367372 Revert "fix #109765."
fd88b56ab91 improve messages, web: showSaveDialog
f80d55121f5 web: pickFileToSave
091b1f5a6ef web: showOpenDialog
9784c7a0efa fix compile errors
e2c97039958 prefix api object with api-prefix, like apiCell
e468d47ed84 some more API todos
415a43f04dc Remove has text log
37789e46950 Remove logs
28fbb99921c Merge pull request #121774 from microsoft/tyriar/121483
13302253b56 editors - respect override option in openEditors
034157dea81 gh auth: back to prod auth
e6a70813331 Action feedback
5b7a28c43fb text file tracker - open editors without going through override
a165ee92c50 Remove old new terminal panel action when showTabs is false
1efbb32036a editor service - cleanup isOpened()
14720cbc524 Remove configure term, replace with change icon+rename
74fc96f8491 rename IMainNotebookController to INotebookContentProvider
61baba1f583 remove some more kernel leftovers from notebook service
010267d7376 Handle cwd inside _convertProfileToShellLaunchConfig
16921f35e34 notebook editor status must listen to kernel instance updates
e09f0ecfcfc editors - require typeId for some methods that are otherwise unspecific
e3df15418ef relax NotebookCellOutputItem and NotebookCellOutput, e.g. don't enforce the member to be readonly
c1549ef877e sktech NotebookEdit ideas
7194c24dad9 use serializer in NB integration test
9af75c08c5b remove ability to alter notebook output via WorkspaceEdit or NotebookEditorEdit
4f9ac638ffc extension contributed kernels fall back to all languages when supportedLanguages isn't set, https://github.com/microsoft/vscode/issues/121329
832a699c00c move keybinding label computation to activity action item
89684626f23 editor service - 💄 API
e350c258dbe fix build
d60dbbf646a gh auth: fetch json
186897d756e distro
0c723c1bf37 tweak kernel sorting
9e8377d8cd3 TestWorkspaceTrustRequestService
3668a573adf gh auth: fix staging server selection
479a2247416 disable compare action when no active file, no need for notification
853f9171901 notification updates: #119463
141ecfb7981 mac specific actions should not respect web
820e70a460a gh auth: don't reach out to product.json
3236b8dd707 Revert "Enable the notebook renderer on web"
9bacf617b24 Use clearer variable names
5c3383251a8 unique working copy type id, stricter view types
625dcc34122 add enum-set for alternative commands and check the command type is a symbol navigation command
07013ef4a33 update ref viewlet
fc191749834 Move quick pick into editor override service (#121666)
7095f4706c0 unit tests (electron) - avoid sending circular structures over
2e79d9e362b Merge branch 'main' into notebook/dev
23a2409675b Update debug-auto-attach ext icon (refs #81760)
a72b1574b33 Double click on the middle part of a collapsed cell should expand it Fix#119777
65d1d29f7b4 Remove unused statusbar styles
e815d287851 fix#121655
27cf6a38076 Implement workspace trust for php-language-features
643756788f7 Allow running builtin php validation with a relative path configured to the php binary. This was previously allowed, but the fix to use 'which' was too strict
609e717d750 Merge pull request #121704 from microsoft/merogge/menus
21ae0ca0d45 fix#121736
91ee63fd0a0 Fix missing run buttons Update kernel context when editor model changes
64282aa6b7a Use new cell statusbar for execution items. Support color and icon info on cell statusbar items.
bc8c79c8f2c Fix missing run buttons Update kernel context when editor model changes
e23c988571b remove custom metadata internally
1315dbe4951 remove breakpointMargin internally.
b7d27a057d1 remove cellEditable internally.
7947c4d3f88 tweak split view width work
158ba0de72d fix typings.
1eb2a93ef39 fix#121631
e986377a625 move NotebookRange.
17fa3235965 more jsdoc
1d951484ed4 testing: bump distro and make document polyfill work again
8711b2dc92d remove deprecated transientMetadata.
2da00961559 remove deprecated custom metadata.
c67ac5d0830 Remove path from github-authentication
1d54cdf54a1 Avoid extra call to reveal if the editor is already active
9b8d52ded35 Fix calls to reveal for webviews that are inside of diff editors
24c6f586ddc Add requireTrust to comments.openPanel setting
7c486f3a693 Merge pull request #121758 from benmccann/patch-1
7d9dcaca452 Enable the notebook renderer on web
7d45a4503a2 Allow ThemeIcons to be used as decorations
3b20d95b3ad Consider updateOpen as signalling that project loading as completed
0642a7c299d Update debug server ready ext icon
851613fe478 fix unit test
ce91f3a00ff fix unit test
61f646674b0 Merge branch 'notebook/dev' into main
7b23ff442e1 more staging detection (#121769)
ad3e7ea1c06 gh auth: look at staging query param (#121768)
efe612365f1 feat: add support for additional surrounding pairs for markdown (#119982) (#121698)
ac48f78dd64 Add icons for built-in extensions (fixes#81760)
c32f4d0afd1 Make collapse/expanse cell actions apply to all selected cells
1764fc81a8c Add requiredForConfigurations for TS
ae24966cce1 Localize workspaceTrust
b9c647ab3f8 get rid of instantiation service
3737f9eacff fix#119866.
a818bda1aaf fix#121288.
3b3ec496f60 Adopt terminal ubuntu profile icon
3a862c2f7dc update wording
704f85a9db3 split, configure, kill for the focused instance
0772410c7d5 initialize installed extensions before starting extension host
3099237dbaa Max item width, style fixes for status bar items
cc850ade50c Cell statusbar test
b286729f356 Test cleanup
637403c1d57 Fix issue number in comment
4418386c13a Remove 'requireTrust' from search.exclude. Searching without excludes in an untrusted workspace would not be useful
1e6315f7059 Update Codicons: Add `terminal-ubuntu` (refs #121737) 98b2fc8136
1c726074ec0 add jsdoc for NotebookSerializer
66c8a845474 Revert agent pool name
b62af979828 Update build agent pool
6473cab2d34 add some api todos
94589129a2f Add experimentation service to github auth extension
008c20865ec Intermediate content for Getting Started (#120602)
eb45f2bd17e Override original agent again (#117054)
e324e19e96e add a comment
390d4388c6c only fetch the profiles on window reload or if config has changed
666a6e8896a pass cwd to convertToShellLaunchConfig
d3245fbf024 remove unused, make convertProfileToShellLaunchConfig public, rename MenuId
9809e3f12ff WIP style updates
bdf2ef774e0 #118731
faec962a3e9 more removal of unused interfaces
01b1689c1e9 fix comparison bug when updating kernel bindings
d9e4b98387c simplify notebook kernel service
f7b69ef7045 Add keybindings for navigating terminal groups
61017718099 #118731
82357d5d4c0 #119110
0922dbb475a Move vscode-windows-ca-certs dependency (#120546)
e838389be00 Update distro
03a096326f1 Fix binary mouse events on remote
5fa2193ba78 add extensionTestsPath to IWorkbenchConstructionOptions
454b741257f restore integration test
45e013b704f Merge remote-tracking branch 'origin/main' into merogge/menus
e791f6b410b Merge remote-tracking branch 'origin/main' into tyriar/121657
2447e78e687 Implement sash reset in terminal tabs
b2b45e1005f execute by cell-handle, kernel manager has only execute/cancel cells, also "fix" isNotebookCellData fyi @rebornix
74bbba9aa66 Fix compile
e9b2d57825b Middle click on terminal tab to kill terminal
6170715c03f Fix fallback profile using --login on macOS
d4a6400596f Merge branch 'main' into aeschli/testsInWebEH
064ead50123 notifications - properly hash resource
0b46219a2d6 move "execution" of markdown cells closer to command
514d136bd02 adopt typeId for simple notebook working copies
79d748989e0 some jsdoc for NotebookController
438cdf9232d remove unused NotebookCommunication interface
47b406c8227 Merge pull request #120359 from solomatov/optimized-memento
be6a9027041 notifications - introduce ID property to help detect duplicates better
3abadabac87 Merge branch 'main' into notebook/dev
b06388f501e Merge branch 'joh/clean-kernel' into notebook/dev
fe7951dd7ab remove kernel provider from core, adopt kernel service, merge kernel2 and kernel interface, extract context keys from kernel manager, make context key manager only for execution/cancellation
40c99293c86 Try another fix for tooltip on safari Part of #111756Fixes#121684
3a7cf0c9dc0 debug: update wording for safari dialog
1a74d20b2a4 file service - add test for `getProvider`
10b35b6aa2c #118077 remove hover background
a5b19b6f641 add supportsVirtualWorkspace to schema
b4816cfd1f4 fix tests
e74712bda17 fixes#118731
319d1511382 #118077 move custom hovers behind experiment flag
fa602ecdc37 extension tests - stop automated opening of devtools when running out of sources
1f9e039a11e 💄
ab27efcc9f9 use new types for browser fs
a09354329b8 exclude htmlfsp from monaco
eaabe284856 Revert "Revert "use dom api to resolve file schema on web""
193d5d2c5e6 revert unneeded change
e2d0668ffad get rid of tabsWidget buttons
bd0d9341399 improve styling
6491f003c7d stylize
53ca9ec8afa refine conditional
0db78a7d563 only re-render dropdown
29a726f400e add comma
c0d4b45306e Merge branch 'main' into merogge/menus
fa9e3a81c17 resolve disposable error
6de1a8b7b8d get rid of register
1292b973d09 Revert "use dom api to resolve file schema on web"
a4b13e3fcf7 Bump distro
909f03eb3e2 Adding a few more override specifiers
65273f89bc1 fix output max height update for diff editor.
8fa6582b834 fix diff editor output width/margin.
e5c466f587b markdown-language-features: Fix Windows Preview Link Uri (#120090)
25b47bb9571 Use ctrl for add to selection on non-mac platforms
e62f21f40cc Remove extra await
f47e207f915 style buttons
1dde9302af4 get profiles to appear
f26ca76fb62 fix#121623.
297ac839dca replaceNotebookCells with range.
87c10dba596 Protect against exception when initializing terminal tree
e382db30892 Improve terminal tab setting descriptions
ef0942ba058 Don't throw exceptions to the extension when an outputId has been removed Be sure to emit events from applyEdits even when an error occurs Fix#121687
427ab0079f4 clean up
891683014c8 Allow svgs inside iframes inside webviews
1845ee08b84 Allow specific command uri in extension editor
180f95fa222 Merge branch 'notebook/dev' into main
ea5434ca544 node-debug@1.44.26
41d0782edec resize when tab location changes
d6ddd5866c0 use dom api to resolve file schema on web
f6b293d318f IFileService.getProvider
288368cdc05 add @types/wicg-file-system-access
8215a110a94 fix: build
6df31c584a1 trust: make workspace trusted during unit tests
b0eff48b18c testing: adopt workspace trust for testing
94894dfe7f3 Close#121395
caaa44b7aa7 Update aria label to include codicon names and wrap in spaces (#121496)
8f8407812bb add CombinedButtonActionViewItem
9dff5e0e014 debug: workaround to open new debugee window in Safari
3a3864174e2 trust: onboard debug land to workspace trust
f937a28dd0b Move scheduler initialization to the ctor
7635c6504d0 resolve -> reject
6330a7a728e Addressed code review feedback
b4b2d40adf9 Addressed code review feedback
03666a06804 Cleanup redundant code
c25aa77e336 Fixing linter
59ce58884eb Fix linter error
a502d34d923 More effecient handling of changes
d415fc0d0e3 adopt notebookSelector in status bar API.
9e323dacff3 fixes#121621
68362616637 Adds workspace trust setting
86157f0d557 api resolves immediately trust state in non-modal
f9db59cc755 update jsdocs.
dec167076bf Remove code related to dangling files
d7f19966a49 Fix#121289
3b8bfe8cee6 setup menus
1cafce9f5be DAP: new option suspendDebuggee on disconnect request
cdb8d62f088 Ben/workingcopy typeid (#121646)
4dde01fe34f backups - some more 💄
500b051842e Fix#121506 @joaomoreno - Seems typo
11c3ba58af9 remove NotebookKernelProvider API and its implementation
05fa4efaec7 show disabled reason for extension disabled in virtualws
8f67a43aa28 web api - remove types that are not exposed in any API
5efce0f7e03 fix tests
5dbb0cc89aa working copy backup - more tests
7e22b12c4d7 fix build
2ea7d9c65f9 Merge branch 'joao/fix-120696' into main
3606317e4bf add test for whenTextEditorClosed
b89cb3dccd2 Format code
92b4126f276 Move workspace trust code into ExtensionManifestPropertiesService
401554bc451 change property to supportVirtualWorkspace
bfe28fa0962 implement workspace requirements for extensions
47231d090d3 adopt trust in github
f9fec24b452 make INotebookKernel2 extends INotebookKernel
b0ac820e347 working copy - do not allow VSBuffer for backups
1268f86ac7d add common.platformDetail in telemetry (#121264)
a8f860beecc remove window.sessionId
12aeeabdb5e more working copy backup cleanup
9da5986f515 Set default tab location to right
030e33ca8eb working copy backup cleanup
ef569a6e08c enable noImplicitOverride in our codebase
693c0e3e1da text files - add a getDecodedStream method
14981ce89d2 tests - enable colors for windows (CI supports it and the new Windows terminal too)
6b9bd78998a add NotebookController#detail
058552963b7 Merge branch 'main' into ben/workingcopy-typeid
cc778d679fb Merge pull request #121396 from limitedmage/suggestrace
0595da6b543 Merge pull request #121511 from gjsjohnmurray/fix-121509
b0d5ab6aabd 💄
8aff878db25 Fix typo in map.ts (#121279)
2288da484db Bump ssri from 6.0.1 to 6.0.2 (#121576)
200d4c77619 tests in web extension host
73c85159e72 change extension kind controller to a service
367c11f77b7 File gets garbled characters when restored from backup (fix#121347)
e5d6ff4c06e jschardet 2.2.1 -> 2.3.0 (#121575)
e877b8062de backup - change to a buffer format (away from text snapshots)
2b44820d337 windows - fix tests
8e43ae3087e Workspace trust - merge storage and management services (#121540)
085df87b3bf working copy - extract a workingCopy.ts file
e1727abb411 backups - rename to be working copy related
99075a46ec3 Merge branch 'connor4312/test-api-refactor-application' into main
6360146a419 backups - introduce backup identifiers and adopt
92b5ca6d968 testing: fix error for synchronnously discovered tests
5624d860cc5 Further tweaks to grid styling
db221b816d5 Revert "add description to statusList"
34bdd983e21 Update renderings of getting started items based on overrides
d7f55753675 skip failing test
45e308fb286 add description to statusList
fa0cd78f7d6 Dont clip steps unless needed
bb3ea733def testing: rework running side to new apis
5b5320b7d5a Remove onDidAddTask - categories now immutable
522b60a1979 Fix bug where tasks could not be opened
e5295350a09 Close#119964
0767f255d2d comment out tooltip causing build issues
c0e29b7d2dd show separator in filtered quick pick (#121075)
a9109869988 fix#121509 documentation error for two API command results
1845b9d2a52 Merge branch 'notebook/dev' into main
85ca912f72c extract NotebookDocumentContentOptions viewOptions.
c657cdbef30 avoid stripping custom data.
bbcb45cdcdd use label instead of a custo name in terminalDecorationsProvider
95cc902f2e1 try to fix the build
a37a8c517a3 Revert "Revert "Don't block svg loading inside of iframe based webviews""
f8bc55fd267 Remove unused
8706813cdf3 Set max tab view size of 500
23ac9b5184f Fix showTabs NPE
a3ac715bfb5 Set correct layout when turning showTabs on
29b621b47e8 Fix exception when loading with showTabs = false
1f544741220 Hide dropdown when tabs are showing
557ac0b24bf debugAdapterManager: update wording
186bced5aa1 Remove Task prefix from tabs only
2102600c561 Reduce min tab size
d2961b4c081 Remove extrenuous injection
8217e20a706 Make resizing smooth
03aad7bb2db Prevent wide tabs from being centered
8f70a2d6ac1 use language name for labels
8fec10e2516 Focus newly created group ref #121395
4dbad29ad41 Change configure terminal to pencil
8eb52dce857 Fix warning status showing up when env var widget is on
8a67dade9ea Make status decoration padding consistent
b97977ff55a Fix exception
a3d61cb0251 Add change icon/configure terminal action
0b9c11a49cf more binary editor cleanup
0e2d23ec434 Remove * as platform from terminal
b46bca09d52 binary editor - remove file size check (fix#121301)
19b577164e8 Update distro
8d234a4dc9d Merge pull request #121176 from microsoft/tyriar/shell_resolve_refactor
9d72785a2a6 Merge branch 'main' into tyriar/shell_resolve_refactor
067f60cc403 Merge pull request #121330 from microsoft/merogge/terminal-status
8bcc74944c2 require trust for cfg vals
27539a2ef78 tweak conditional
59963d0328f Make error message clearer (#121339)
f206da596e0 modify conditional
7c7c83e5644 Update replacing editors in editorOverride service
5138a81c177 🧹
3fb483e7fff chore: bump electron@12.0.4
880363524f6 Fix#120202
972978848e3 Merge remote-tracking branch 'origin/main' into tyriar/shell_resolve_refactor
93cf9f231e2 Clean up
6b7a55444a4 update configuration scope for tel,exp cfg
3595082e7d9 Address comments
5971cb68edb Fix race condition in suggestWidget
2c631534503 Revert "Don't allow multiple tasks runs to start at once"
b4dd497b275 add scheme Co-authored-by: Daniel Imms <daimms@microsoft.com>
30ae7bde852 Respect resolver's trust options
78872ce6113 Smooth the flow of installing new debuggers
d66d3929174 only register workspace trust request handler when trust is enabled
e4428f18335 revert change to a line
3e8b31b3947 Bump distro
7c7c0b7ee62 remove unneeded css
bbc5a53ac5b Try out another possible fix for safari tooltip Part of #111756
fe6850d4e73 Change default port setting value instead of setting Fixes#117189
5523c825ad2 Disable pre-resolving icon in remote windows
5029f1b18b4 Update distro
328937e7b64 Use OperatingSystem over Platform in terminal
f48845c4451 untitledHint: respect editor font
4430569ad07 debug session: pass configuration as args for restart
f4b60835ea7 Fix tests
c7d26be9a5c Disable terminal workspace settings until workspace trust is on
e077071ade6 Update distro
a79c0b09492 Update distro
5d72ea7c196 Add more top/bottom spacing to features boxes
f31f60b7aeb Pass remote authority to context methods
93dbc7ac44c remove NotebookControllerOptions and simplify createNotebookController-signature
aa6ae6b4193 Pass remote authority into resolver
5619daacc25 Merge remote-tracking branch 'origin/main' into tyriar/shell_resolve_refactor
27add7e2ac3 Merge branch 'lszomoru/workspace-trust-loose-file'
9e77384443c Resolve default profile in remote slc
3bddb9636c3 Fix compilation
a76a1efe043 Merge remote-tracking branch 'origin/main' into tyriar/shell_resolve_refactor
e49f95b5315 More removing workspace shell permissions
61556099dd6 Remove todos
96065290c8c Update distro
3ae9ec00516 Adopt requireTrust in terminal
3c0e4897460 Don't allow multiple tasks runs to start at once Fixes#118238
95932045c7d check that notebook controller are unique per id
949639b9424 use default some delay
17cec8c0089 Fix ~ with fill path pasting in simple file picker Fixes#121280
1f941f612fe Fix#121456
aeb9b2051c2 Remove only
0358f147137 Fix unit tests
ba5e81ab093 Fix import
31016ade1e9 Merge remote-tracking branch 'origin/main' into tyriar/shell_resolve_refactor
bdd072e51ba Add trust prompt
217359a80d2 some jsdoc and relaxed NotebookRange
ce791d27dc9 Fix#121362
564bcfe4cd9 render tree on trust / trust settings change
ba531de1988 fix ExtensionRecommendationsService test
bb43ee61909 Fix#121297
98f69856ea6 extract types for execute/interrupt handler, interrupt in not per document but per controller
9699bd793ce Smoke test fix
1f385f70e6e reduce usage of extensionDevelopmentLocationURI
c074bf897c0 make preload a creation argument, no editor needed when calling asWebviewUri
5ef190e98a4 Fix port log line and add regex check
fd7cedae033 💄
7668affd16b Merge branch 'main' into lszomoru/workspace-trust-loose-file
8877d8ca941 hook up execution task cancellation from controllers
cfdce942776 #116731
644e1d0bc42 💄 in notebook service, also make sure to clean-up editor contributions when disabling/enabling extensions
42e271dd2e7 do not show dialog if workspace trust is not enabled @lszomoru FYI
ddbc8ae408c fix remote integration tests - do not show trust dialog when change is coming from cache @lszomoru fyi
a387125e199 Merge branch 'main' into lszomoru/workspace-trust-loose-file
3ac5ff11b6a Merge branch 'main' into notebook/dev
3c31f0903e4 move workspace trust service out of config service
b7ba430dcee Begin to allow extensions to contribute start items
55b2ab7fa4b re #121329. NotebookCellExecutionSummary readonly properties.
4db99a10b86 transientDocumentMetadata
8629b48030e rename transientMetadata to transientCellMetadata.
881a304efe9 Add some NotebookCellStatusBarItemProvider jsdoc
a7c67442b97 Clean up cell statusbar keybinding tip placeholder
7193b08f344 Remove old cell language picker item CSS
402c9bee093 always show intro modal
e7004428b7e update todos.
7cccfd1d43a Merge remote-tracking branch 'origin/main' into notebook/dev
d85b11a2ac4 use terminal service's instance status changed instead of instance.statusList.changed
d0a23bb0667 revert some changes
dedc2d1150c Add other platform settings
8859256f866 Merge remote-tracking branch 'origin/main' into tyriar/shell_resolve_refactor
03333c995e7 Resolve icon in terminal asap
da16f9bef17 Move cell language picker to statusbar API
d87ab38a497 only show widget for manual relaunch
bd493ff734d Reduces validation timeout
ba4954af208 Ensures that the validation message shows up
0f890eeb173 Calls focus method
155df27d8dc 💄
9f027210ce3 Update distro
a1a9adb9176 Merge remote-tracking branch 'origin/main' into tyriar/shell_resolve_refactor
a6b849a8f9c Use icon of default profile
28b2a0f19fe Fix#121193
8894f893da6 Add platform override to default system shell
05bd596a618 Move new service to sandbox
6e84c224f44 allow for markdown dialogs and custom icons
77f067f0652 Merge remote-tracking branch 'origin/main' into tyriar/shell_resolve_refactor
d531f3b0547 Merge branch 'notebook/dev' into main
3d434efcc01 Progress on single file scenarios
b7d0ff397d3 always fire ptyReconnect after relaunch
de1c13e539c mostly working
662ea12128d NotebookCellRange is now NotebookRange.
df1214ddee9 Rename and move combined service
ebb0a7165bc update integration test.
25ea3341e0b Guess synthetic profile icon
dbbf3325212 Simplify service context by moving into browser
40ed9160e1c Implement browser profile resolver
2459b4fab9d 💄
4edba25ca9c Central service for notebooks and custom editors (#120426)
d9a371b9fd4 update comments.
ae5aeabcd7d flatten custom* metadata.
271189bbabe isReadOnly contributed by the file service.
a3b1c9550dd remove cellEditable.
060d4175057 remove editable and breakpointMargin.
bcecbeb2ad9 change to async
cba995310b3 Merge branch 'main' into lszomoru/workspace-trust-loose-file
dd4350388f2 adopt to workspace trust storage service - create the service during initialization @lszomoru FYI
0688b5a7bd5 Revert "custom dialog for introducing workspace trust (#121326)"
35dcde89ee3 Revert "adopt custom and shield icon for trusted workspaces"
43295fde7a6 Remove statusMessage from constructor
fb4b3e82ed8 Adopt shell env service in TerminalProcessManager
00ae987ad04 Remove getDefaultShellAndArgs
c780db5fe26 Use new service to resolve local process paths
348a8fa1fe7 Partially implement resolve shell launch config
2436eeee72d adopt custom and shield icon for trusted workspaces
6590d3e0f78 custom dialog for introducing workspace trust (#121326)
3bb83e95562 Skip failing tests temporarily
8cf96ed6454 pass icon directly
bbf148b0c60 merge renderer IPC into notebook controller, remove global renderer IPC
337e14744c0 implement decorationsProvider
296c417c07f Add workspace trust property to auth extensions
3f4e9a0ebdf node-debug@1.44.25
150af9a47a7 Use workspace trust signal when adding a folder to a workspace (#121197)
de246aa544e Turn on showTabs by default in Insiders
a49404e6443 Resolve todos in profile resolver
68d9e023384 add support for isPreferred for notebook controllers
b2103c79e45 add preloads to notebook controller, fyi @connor4312 NotebookKernel will go out soon
16663d23bc1 Register the new service
e5ab815d0c3 Fix collapse all tree view focus Fixes#120990
151c7d5dff0 Recognise commonly sourced files as shellscript (#121373)
9a0441e9cb8 Inject last active workspace
c079d216f0e actually remove fileName from the notebook document implementation, https://github.com/microsoft/vscode/issues/121329
45097cfcc9e remove NotebookDocument.fileName, https://github.com/microsoft/vscode/issues/121329
b6cee1ca22f add cancellation to NotebookSerializer, https://github.com/microsoft/vscode/issues/121329
afa4a2df2c3 rename to serializeNotebook and deserializeNotebook, https://github.com/microsoft/vscode/issues/121329
0287003973e workspace is virtual if all folders are virtual
b27d796dfc1 Inject context, convert functions to async
255f82dbece editors - move some code out of common/editor.ts
495ad394f46 Fix layering issues
8681ecba619 editors - move some code over to browser/editor.ts
fdca487fd41 Implement resolving default/synthetic profile
679c373828e editors - remove whenClosed from editor service and make a standalone helper specific for text files
12c93777db4 Merge branch 'main' into lszomoru/workspace-trust-loose-file
d13686a8607 Extract isWorkspaceTrustEnabled into a function (#121385)
9f4eceb52cb Merge remote-tracking branch 'origin/main' into tyriar/shell_resolve_refactor
91f8c81acbc Reveal active terminal on change
e24c03de151 Center +v when collapsed
520462074de working copies - first cut typeId support
6f9917d81fb no more need to dispose ExtHostCell
f8cf56ae9e7 Merge pull request #121272 from akosyakov/akosyakov/remote-race-between-terminal-121270
f1d0c30f1e0 pass cells and controller to execute handler
0aabafd35f9 NotebookControllerOptions instead of NotebookKernelOptions
f5bfd64982b Merge branch 'main' into notebook/dev
57b8d811da1 print cycle of dependencies when instantiation service alerts for loop, fyi @lszomoru
220560dd404 Switched to using Restored instead of Eventually for the extension enablement soft notification
c91c21bab07 Tweak dialog based on feedback
a4d95b35c4e Merge branch 'main' into lszomoru/workspace-trust-loose-file
f9ca74adc43 Merge branch 'main' into notebook/dev
e51173f3b6f startup code 💄
92d5997b1df "Help us improve.." notification is displaying language IDs (fix#121216)
25785b97e53 Adopt `requireTrust` for my configs
e870a6d7004 Update js/ts grammar
a5d656cd3f7 Configure workspace trust for simple browser and image preview
293061802c2 Add workspace trust for markdown extension
be2026c324c Only try to scroll to element when the target path exactly matches the base path of the current page
2ea7c77bf88 Remove statusMessage metadata
edbdd6fe092 Fix test, fix cell data startTime and duration visibility
0a6309be1ee Support markdown styling in task descriptions. (#121338)
2881355f372 Use es2020 as the default target for js/ts implicit projects
3e5c20b7626 Change execution duration to startTime/endTime
fe7f4c0241e Do not run code actions on auto save
bec017d389c testing: rework discovery side of testing to new apis
063bc4b7b11 Support seeding selected search text from embedded editors Fix#121060
1329659d841 Remove "please" from messages Fix#121312
7f2bcc15304 Fixes#119032 - changes to support settings UI
88361f24e07 DAP: add a missing comment
f065ba8d8a4 DAP: pass launch config to restart request
81fb5b7accf Merge pull request #121328 from microsoft/sandy081/settingsEditor/trust
263b76c8f00 add colors to css
e660d60f84c Merge branch 'main' into merogge/terminal-status
2ed7f15346f adjust opacity
bce7ea241ec incorporate UX feedback
7a72e4e95be fix styling in wt badge
36fcc538bda Merge branch 'notebook/dev' into main
6d468a59f69 Fixes#121325 - fixes notification deduplication
a9c869d4208 add statusIcons to terminalTabsWidget labels
dfc8f1fd037 Move back to min-width for hover hr
9a2b9a79f4a Add a very basic hover for the terminal tabs
22dd9030841 terminal: fix swapped cols/rows
d27fa1df47e #118077 introduce delay option
c4f59fa1e01 only show workspace scoped configurations
54beeaada6c Remove TerminalTabs from tabs, polish selection/focus
b7157be21e6 Fix compile
3e40e14bc41 Cell statusbar API (#121215)
93754ff5f0f Fix terminal tab actions to work on the hovered instance
ab15aa4d393 fix build error
a32d03dad99 modal false by default
040cfa078b1 Add override in notebook code
5b4ee563a1d Add override modifiers in a few more places
6299e56d22f debug: start debugging requires trust
f590a4901c0 add statusIcons to terminalTabsWidget labels
4e6b46a15f3 Implement notebook selection status bar item Fix#121194
279bdca34a2 Set title when reused terminal slc has name
6d81daa07c0 fix#121140.
3636a058e58 Fix launching profile from PATH var
08f9bbc2394 typo
fa56f6ea3db Add telemetry for import statement completions (#121243)
b42484b6871 add status icons and listeners
9c0300872ed simpler storing of ExtHostNotebookEditor
9afc7348000 no nested DOM.schedule.
361ba1a8231 update scrolling.
d3394d21773 set maxheight and overflow hidden for output container.
02f0f4a0c8e make createNotebookRendererCommunication independent of controller, make it renderer first
304200343eb Comment out unused prop
071b4b3b872 Add override to tasks and tunnels Part of #120675
1351e8c6e40 Add padding to terminal plus button
5c74225ab18 Workspace trust transition improvements (#121173)
4cf3e89b67f Fix tab widget layout height
af1b5066622 Merge pull request #121291 from microsoft/sandy081/activitybar/hover
388d40ffc3a Disable escape sequence logging by default
94f637a4965 Add new terminal with profile button
ec579a2c217 Mark server ready extension trusted
6c2ccf8be54 Implement custom hover for activity bar and panel
b2d002de4bb Fix centering, use action bar for +
fd640b0b32a Fix tunnel privacy context
20784c13a10 fixes#120981
85bf18a6d8d Correctly align plus button on load
ab0809ce864 Clean up terminal tabs widget ctor
0ea92219740 Improve plus icon position, style
c9b2c542316 rename NotebookKernel2 to NotebookController
d6ae97cf976 add Kernel2#createNotebookRendererCommunication
cb8b3ce97b6 polish remote menu separators
5371ac58c40 Include virtual workspace check for task type enablment
38066c2802c node-debug@1.44.24
7dd3678adf7 Change action order in tunnel view order in tunnel view
f15bbef705d Do some magic to pick best label action for ports Part of microsoft/vscode-remote-release#4826
94d369e27d1 backups - explicitly wait for editor group to signal restored when deciding to drop backups or not on shutdown
d9008be9ab5 Empty workspace is untrusted
5b66335738f perf - change lifecycle phase restored to work differently
4453232aee6 fix #121270: race between terminal create and initial resize
3d276ed5cc7 vscode API - env. Fixes#121261
907ab317dee fixes#120637
3ba684ae3aa Fix styling issue in the workspace trust editor
e7934ec243a Moved telemetry into a contribution
1317cdbc5dc remote: unnecessary separator
f157a3d2019 Merge branch 'main' into notebook/dev
02f2f886985 fixes#121248
f9490e715c4 fixes#121162
bb19564a844 fixes#121156
c2c5b7eaeb9 fixes#121117
7968e137fe3 fixes#120840
4ea838bcce9 perf - fix issues with how layout restore is handled
08226f4678c editors - whenCreated => whenReady
a09d6403113 github auth: improve test env detection
b5dfdbe00f1 editors - some 💄 renames for editor group model
b7b1315457f prefix terminal CSS rules (#121258)
730d57ed65e fix#120485 hide `Open Timeline` from Explorer context menu when there are no timeline providers
c8d5c905bfd Fixes git rename on windows
a11959e28cc Fix tests
66d0f975442 replace vars to fix build in terminalActions
44b3df962fb more todos
485d6c36463 Fix double localization
509c20c9b13 some API todos.
f59a77842e6 Use markdown for link contributions. Ref #120050
7a2f9014556 Only await for worker ready when setting content
1d22f863622 Don't wait until getting content to register service worker
a9216fb38c0 Remove __leftMargin__
c188a51edef Use clientHeight instead of computing the size ourselves
4ffd6a8d742 Merge pull request #120878 from microsoft/merogge/tabs-button
066dae222ff Merge remote-tracking branch 'origin/main' into merogge/tabs-button
72b09f10193 Compensate for out of sync clocks in cell timer Fix#117460
084668c6270 remove workspace trust grant/deny actions from gear
e143ce4a8c1 remove confusing elements from workspace trust editor
776ab3d6e5e Only enable pointer events for the folding indicator itself
5276ebf9509 Make sure we focus the markdown cell on contextmenu
3bf5b37fcfc Don't trigger notebook.find when focus is in another editor Partial fix for #121242
7f805ea0d93 Simplify redundant context keys
9cd8ff410e5 🧹
294e3eb7ef7 make private readonly in constructor
388a0c80dfd change type of icon to string | undefined
6e5a0a58032 Update src/vs/workbench/contrib/terminal/browser/media/terminal.css
3357bf274be fix hideText
d13a914bd6f Merge branch 'notebook/dev' into main
4dfa06cd356 snap right or left based on midpt
c5fab4faa37 Boolean Trust State (#121141)
75f2ce9735c Adopt workspaceTrust
40a6563f9b0 Remove git-ui extension
51451d8355f get rid of unused menu
a0099970e94 align button
71230441fa4 get button to stay on the page
090554355df notebook: cache preferred mimetypes for renderers
abf4835fd28 use tab instead of terminals
ab650745458 add instance connectors
a3444b12123 Theming for keybinding label (#120727)
9d1bfa6a6aa update distro
1d5f53777cd finalize #77423 (#121213)
23e346ab55a Add allowCommands option (#121211)
c826e9aabd2 Explicit remote CLI commands (#121212)
b3ff207039a get text to show or hide appropriately
ceda963326c Change proxy scope based on `useHostProxy` flag (#121207)
2e165500a6d Use CSS variables (#121208)
71043537525 php: use which (#121210)
f0a344a76e2 npm: use which (#121209)
bacfb76d909 localize action names
cb6a3cc3775 add rename Co-Authored-By: Daniel Imms <daimms@microsoft.com>
80dba2b8782 set min width Co-Authored-By: Daniel Imms <daimms@microsoft.com>
75bce498f9e fix css
ed139c10361 hide label text when min view Co-Authored-By: Daniel Imms <daimms@microsoft.com>
e0a85f94c59 Move windows mitigation comment into terminal process
fa852ac3f16 Remove redundant call
36c68a5d6dd Speculative fix for unresponsive pty host
83f13c70ff5 Merge pull request #121181 from microsoft/tyriar/reconnect_fix
f2b1e94fe78 api todos update
7c946e118a6 add onDidChangeNotebookAssociation-API and wire everything up using the glue adapter
dd14addcbd1 adopt to trusted configurations
fc15ccef8d5 Fix terminal reconnect, remove writeSync completely
ade32e71e59 add ability to bind a notebook to a kernel, add events and forward to ext-host
14b07fe6e75 Disable flushing of output
3986914a040 cleaner setup
ed545b8a43a add missing block
10bf5cfd61a align kernel and kernel2 a little more
6725bd39334 [json] fix for workspaceTrust
ed7d5c0d0e7 move all views under removed view container into default view container
fcd005ce8c3 fix compile errors, evolve internal API about kernel selection
8e8621c137b [css/json/html] add workspaceTrust property
b90e3e7786a Fix spacing issue in feature list
25366914862 rollback distro temporarily
89032503e31 wip
8c18565aae5 bump distro
1aa4efcd7ae 💄
e66dbdeb459 default supported languages is plaintext
bb55852fc2b relax NotebookDocumentContentOptions
2c123cc1a8d always show notebook status bar entry
394a2e4779f update distro
49796d31cb3 virtualWorkspace context key to detect virtual workspaces. Fixes#121165
38f2172759e editors - do not expose raw group from editor group view
5e33a56d232 editors - cleanup editor restore logic
0788b3fd68c Merge branch 'main' into notebook/dev
800ac2f7fac add doc
0c555419feb Extension workspace trust request using product/settings files (#121021)
601dec633b0 Reduce callers of createEditorInput when not needed (#121098) (#121099)
48387dfc3d6 Fix loading of webview resources that depend on query params
eac3821fbf9 Hook up basic context menu for markdown cells
50c310b6d7a fix#120955.
f69d2cc6dd4 fix#121032
ee0a183de19 fix#121115
60a7c6a9253 notebooks: add initial kernel/renderer constraints
f0cb4fe60ce Don't check cancel token after it has ended its lifetime Fix#120939
f7e5a67039b NotebookDocumentShowOptions#selections.
119581fc2ad Use more standard name for shared extension tsconfig
98bbcddec35 Enable noImplicitOverride for extensions
d5f4e119e05 Use `Array.from`'s map directly instead of a second call to `map`
32a7858a637 Remove override
9a00c870b9b remove NotebookEditor#selection.
aa1c694664c Add override
ead5639bbe1 Pick up new TS nightly for building VS Code
ab4c0f1e2e4 Remove duplicated code
2637da856a0 Use URL instead of regexp for getting webview id
069f8f39591 Load webview scripts async
62c62103fcd Use javascript modules for webview host script
b4d42b14241 Use ?. for accessing webview
1bf5e8f15c2 Remove `getInnerWebview`
48e7505c677 reformat
8f7df5e9c92 Merge branch 'notebook/dev' into main
1132a8a7d34 only show rows on hover
7dd9fe7e963 only show actions on terminal isntances
e963ace70ff Bump vscode-ripgrep
964ad75846c fix build
52c11b376ae Merge branch 'sandy081/settings/trusted'
27f3fc1f157 Merge branch 'connor4312/test-output' into main
1f3acad6320 testing: polish up test output terminal handling
9de25518855 add actions to items
a546db679a2 re #119599. Avoid flickering when outputs are cleared.
21806b884b9 debug: display error response from invalid exception filter conditions
e8325e7f073 review feedback
e5bef439287 Merge pull request #121027 from jeanp413/fix-121026
8e183f0d2ed terminal: standardize on customPtyImplementation
2962e6ade1f update untitledHint, remove button
f1ca325298b always allow split cells in cell toolbar.
2864eba6b06 get rid of twisties
5c99b8c11e3 Merge pull request #120925 from microsoft/joh/kernel-push
31da9f54b86 some jsdoc
88006b84373 add (bring back) NotebookKernel#createNotebookCellExecutionTask
f88027607dd fix#120906 panel issues
7f728230675 DAP: setExceptionBreakpoint optionally returns breakpoint array; related to #117789
51ff6b5e4e2 untitled hint: do not render keybinding
08a9de6e3e0 add rename to context menu
d38cfa11d8d Merge branch 'notebook/dev' into joh/kernel-push
82a5fe0aeef test 2
d837f9a26c1 Merge pull request #120503 from conwnet/main
8e41cc0471b test commit signing
79e47e06717 try to make monaco ESM happy
95fe64c807b api todos, remove unused type
4358b0c9f53 change to warning
765ce34320b vscode.openFolder: forceLocalWindow
5e49fc945f4 fix web dev builtin extensions
b7d7aaca741 add NotebookTextModel#reset which allows to re-init a notebook, use when reverting notebook editor models, https://github.com/microsoft/vscode/issues/120771
b36bcfe1b4f vscode.openFolder: allow to open a local window
318fe9ff80a improve TestResolver command names
219270a10c7 adopt to workspace trust
4c1946a2ecf #120675 adopt override
905a9016720 editors - supportsSplitEditor => canSplit
4ea02ea5e27 split workbench-web from dev
973f5d00b43 code-web: /builtin
53ec27a6c64 editor input getTypeId() => typeId
29aedf93830 move defining configurations requiring trust to workspace trust property
52ee0bd562b some more "no implicit override" work
8988e849bad Merge pull request #120891 from timmaffett/main
25d61e6f137 editor serializers - only allow 1 factory per type id
1b26a6d3224 Merge pull request #120938 from bourdakos1/update-seti-icons
b0b9ac30870 editors - 💄 a few assumptions around editor resources
1994b301513 Color Theme: add button.border. Fixes#120868
e6e2249f09e Expose stop/start methods and have start wait for all pending delta extensions to finish
fb5ea7962a1 fix yarn lock
66c78c9031d Merge pull request #120841 from CanadaHonk/patch-3
d2b6aa211d4 Problems in no-implici-override-watch
1bc121e0b80 Add all valid hosts to simple browser (#121080)
e70d5b0aee3 task for no-implict-override-watch
08037076738 fix#120911
b2a29c09430 Slim down the rendering of the remote command palette. Fixesmicrosoft/vscode-remote-release#4831
d6d57945d81 autodetect settings: add reference to preferred colors
932742fb26a Resolve unix shell env when default shell is PowerShell (#120769)
af0d76ffa98 Merge branch 'notebook/dev' into joh/kernel-push
4b719f95d8b add to suggest list
2dc222a3ae3 add code actions for untrusted settings
2278ddfa233 - update schema in non trusted workspace - decorate settings requiring trust
99524b3229a Fixes#121026
0dce221fa2e fix when there are no untrusted workspace settings
2e204caf72d fix compilation issues
48bdbd87453 Merge branch 'main' into sandy081/settings/trusted
d6cf66331cd update trust label
2331507e97a - show settings requiring trusted targets as readonly with action to manage trust - command to filter settings require trusted workspace - Show the number of settings requiring trusted workspace in workspace trust editor
01466cf692c Remove IWorkspaceTrustRequestModel
c41460cba5b Split WorkspaceTrustService (#120974)
3b4a74297c9 Getting Started: Allow click to toggle completion Closes#120996
148029c5357 Make find expand widget button themeable Fix#120899
0b305965c90 Close#119964
5d85fe4fa0b #119964
8047d350150 Clean up details view for small windows.
6b666279b8e wip
4c78efda3db add snap when in no-man's land
41861dc05b2 switch tabs when instance is clicked on in tabs widget
a5af80b4bc9 Getting started details page scrolling
6e978a960c4 Fix centering
8a8e2336697 move + button to the top
2134666ed13 fixup scrolling of categories page
a7e080af027 Revert "Don't block svg loading inside of iframe based webviews"
f95b7e935f0 Revert "chore: bump electron@12.0.2"
c5dd09e2f57 Update to use new webview url for permissions check
a7a14ff215d Don't block svg loading inside of iframe based webviews
d5ecfd54f1f Merge branch 'notebook/dev' into main
751d8deef06 load show more action only when necessary.
ee4bfad688b use custom icons on reconnect/reload 😄
6229e7a57f5 change to async
8df884882c9 #120860 Improve untrusted settings shape - define requireTrustedTarget on property - add tests
d993d5d5557 Adds proposed api checks and splits proposal
b8afc6415ba Simplify the trust editor (#120964)
4020b1a1e3a ci: disable exploration branch sync
532a0b3a99b Onboard search-result to workspace trust.
dfef0f6e43e Jackson/getting started grid (#120958)
c15d1c342c5 remove one command via consolidation
ded8b935cac fix typo
46feb94438d Bump windows-process-tree, fixes#120570
5c7879c29fc Merge branch 'main' into merogge/tabs-button
261862e2be8 make private readonly vars
6ba185b5952 removed font classes with hard-coded font stacks
c6d0c1139ef add check for show tabs and return min_width isntead of 0
6fe8914f37c remember split across sessions and set sane default
18c0f5ae8df add context menu groups
1820f177611 removed mention of user modifying CSS with extensions, added further explaination of the font support and font stacks to allow developer flexiblity in logging to the debug console.
1936c34a331 Fixed and extended Debug Console support for most ANSI SGR codes
58faca759ab custom editors - implement save retry properly
f7d9b934d34 Bump distro
2894338f388 Add all valid hosts to simple browser (#120929)
84043ab3b8f fixes#120934
243f4660ba1 Update seti icons
957d8d2e74a Ensure tab widget doesn't resize on workbench resize
1ed73408cd2 file working copy - prolong shutdown for pending saves
fd315204d7f 💄
d8e1c802f74 add some override https://github.com/microsoft/vscode/issues/120675
ec8c7257eda remove/disable selected and onDidChangeSelection from new kernel world
a1139fd83c9 💄
760ca343734 add some deprecation marks
5cadd1240b3 Merge remote-tracking branch 'origin/main' into merogge/tabs-button
ead08c9b518 update notebook editor status when kernel "instance" changes
50fe76ba290 Onboard task extension to workspace trust
b2b90e970c8 Improve type safety around terminalTabbedView
611bda0dbd4 Consolidate tab tree creation
acb172752a5 backups - move tracker and restorer out of contrib into service
2d2696a6d6d Adopt workspace trust in the tasks service
72b99e07bb5 backup restorer code 💄
f103814a2b2 Add Windows pwsh detected profile, remove cygwin source
43f58dbe1c6 Merge branch 'notebook/dev' into joh/kernel-push
e200749f888 remove NotebookEditor#onDidDispose
aa4285b8b5a remove hasExecutionOrder from notebook metadata
edd36fd64cc add and adopt implementsExecutionOrder
79a429d92d2 chore: bump electron@12.0.2
5bf85d71d89 perf - warm up canvas in idle callback (#120916)
c82eb7d4980 bring back accessibilityPageSize from deprecation, it is still needed due to upstream issues
b0733b55b98 layout code 💄
845efe5d8e3 debug: Variable do not override ExpressionContainer type
239bc433cb7 Debugger: Add option to allow disconnect and stop/terminate UI elements
fb5cc92c38b Update no commandline message in ports view
ac4f97790f6 fix quick input title
3af3fe66aaf Improve logging (#4813)
41985fd83b3 Update distro commit
53746f5cae7 fixes#120905
fb102278354 fixes#120871
9f9f73d704e perf - more fine grained window counters
4cacb3dce4c make executeHandler readonly
4c3becc0bbe Merge branch 'notebook/dev' into joh/kernel-push
9c40ada6157 Merge branch 'main' into notebook/dev
65a8d0905e3 update ref viewlet
f8c7dd64a4c tests - ensure preload promises are all resolved
ec972e8acc0 ts - fix some override errors (#120675)
479d3fcbed4 Remove log
13944bac07e Pick up new katex version
062e89fa198 Don't scroll to top when removing entries from recently opened (#120404)
08c3c088ba8 Polish getting started layout
d5e4bdc814b Remove unused import
3c89afbbc43 Pull in newer markdown-it katex version
9708fb15ff9 Fix markdown cells being re-rendered twice on edit
989c39e178f Remove commented code
ecb45f5207c Move shared webview focus implementation into base class
ed655c2d2ed Fix split json editor underline Fix#120876
4b5ef688725 Use cloneNode to inject default styles
02e5ed5280f Avoid calling `applyStyle` again if the style has not changed
6b5122bb067 Add typings
3fc15fb34aa Remove unused function
923fbc8c2a3 Cancel resource load when the webview is disposed of
d5b46d6e56c Use transfer for sending resource buffer from webview to service worker
fbf86d3709a on create, focus active instance
595c14a8d30 Inline `rewriteUri` into `loadLocalResource`
2d7ddf5a381 Remove extra indirection around `loadLocalResource`
8a918399897 Move webview resource loading from `platform` to `workbench`
de9887d9e0e Remove vscode-webview-resource path normalization logic
9c9e188aa0b Don't use 'self' for image editor csp
044a99585c3 Make sure we use the webviewResourceRoot on for computing cspSource
84391165c30 Pass in correct project root for notebook cells
f5ea03079ab turn off logging for notebook.
4d1131b7b32 revert a change
3622dafdc01 Adds new proposed api for scm input validation
4c02536030d get context menu to work
99868a33bf6 get profiles to appear in context menu, not working yet
a8563509738 april.
9bcf5a56253 try to modify tabsMenu actions
7c2007b9259 Merge branch 'main' into merogge/tabs-button
0203f8e25a6 add plus button and terminalTabsContext
852375649cd Remove extra whitespace
614dd5174f9 testing: fix explorer view
618705cc574 Merge branch 'notebook/dev' into main
93934cacd0f precalcuate cell editor height: guess if the editor will render scrollbar.
bc506127abf Temporarily restore vscode-webview-resource constant
1c27a285175 Fix rewriting old-school vscode-resource uris
7c26f27d906 #120860 Implement trusted workspace settings
f689971195a Mark Emmet trusted
bd815e462db Don't warmup markdown preview when input is collapsed
437f2383b92 Add icon to terminal tabs
618f06314e6 change terminal tab height for uniformity
2f26adffbe2 fixes#120786
8ec2bceec99 fix#120776 remove stray words from `contextualTitle` description. (#120777)
13f4f052582 Fix spacing
ae1452eea67 Add script to run build with noImplicitOverride
e29e1f908a4 Adding a few more overrides
86bf0279201 Add a few more overrides in codebase
5904b7b686e chore: info.plist => Info.plist
e1f0f8f5139 Add override keyword in codebase (#120755)
604b950f0da Reapply badclient commit
37025381399 fix#120824
e956e0a0eec 🐛 FIX: Typo (#120816)
464e51e24f0 Merge pull request #120054 from stoyannk/fix_extensions_profile
13452d7fd68 Fix JSON formatting in High Contrast Black default theme (3)
f4449876e4a file working copy - getAlternativeVersionId() => versionId
354c914f677 add NotebookKernelOptions so that createNotebookKernel is simpler
015d5565b71 remove createNotebookCellExecutionTask from NotebookKernel2 because exec-handler is called with executions
be198294e41 execute handler gets notebook cell execution directly
6062a5458a0 Merge pull request #120591 from microsoft/merogge/tabs2
7a1e1fd2af7 Fix ctx menu, clean up DI
a4fed64a16e fixes#120188
ffde5985b22 Update color for port wtih running process Part of microsoft/vscode-remote-release#4826
37a44ac7dbb Types, polish
29d772fc9e0 Merge remote-tracking branch 'origin/main' into merogge/tabs2
c14109e5ec5 perf - wait for dom ready when waiting for services
61dacc2f813 Add hover underline to port address Part of microsoft/vscode-remote-release#4826
e9b4e01a4b2 process explorer - fix window title
ffe10c858b7 Add ctrl+click message to address cell in ports view Part of microsoft/vscode-remote-release#4826
c111a4caf2b perf - delay notifications for extensions disabled to a later point
10c17f374e5 fix speling error
28c734595ac perf - add marks for crash reporter and window creation
965f86890dd Merge pull request #120815 from CanadaHonk/patch-2
936219d314f Fix JSON formatting in High Contrast Black default theme (2)
eadff843e8b Merge pull request #120761 from CanadaHonk/patch-1
969af665349 node-debug@1.44.23; fixes#120762
2214484ee44 startup perf - load NLS module conditionally; add perf mark for main IPC server
11d3a8027d9 debug: better launch schema updating
7c3f60f86e6 multiple action hover feedback fixes
5ffc27fb629 log error when vscode.workspace.applyEdit fails, https://github.com/microsoft/vscode/issues/120760#issuecomment-815602556
461f09ff789 add extension identifier to kernel 2
6abe3beb6a5 Merge branch 'notebook/dev' into joh/kernel-push
38fed243558 make auto-referencing of dirty notebook models simpler and lighter
9a8d55525d0 fix: skip sha comparison for info.plist
d10367cee83 Merge branch 'notebook/dev' into joh/kernel-push
a41711cab5a Windows: --user-data-dir argument no longer supports relative paths (fix#120269)
44207598e9d sandbox - properly await fs creation
75da2b7add1 sandbox - wire in paths from main side
de3aca7a531 Revert "Add badclient telemetry property"
1a141423308 remove empty line
71d57e05dcc copy directly from master
966eea39277 🧹
2a9e136e1b5 revert more changes to settings
77d5d2c7c2e revert some changes
494536b12e7 find widget
0b89eae87f7 add a bunch of stuff from terminalView
2c77e72f8b3 add or remove view depending on showTabs
e6c32c3d743 create issue to track indent guides todo
d228dbc70a3 use TerminalTab
e5ef9895b6e Add badclient telemetry property
513f2072960 Don't overwrite perf value
5207b984029 Update JS/TS grammars
74a43ce1498 Merge branch 'notebook/dev' into main
f593c515674 better perf marks.
3241e1ad249 Improve tabbed view size ranges
c492147a5b2 Simplify instance node
5b6f939eb2a Don't remove the textmodel when closing the notebook editor, and cleanup how the textmodel ref is created Fix#117936 more
5bcbaa2d825 Rerender tabs on title change event
3222bd6698d revert to node-debug@1.44.20
6846fee42fa Prevent disposable store exception
e6bf0c58615 feedback
d05ded6d3b6 Use service workers for loading webview resources on desktop (#120654)
b4fe86328a9 add some more checks
4f55d8181b5 Fix JSON formatting in High Contrast Black default theme
c19bae2dfc2 Pick up TS 4.2.4
fe106399c1a Make splitting respect supportMultipleDocument (#120263)
bb6757bfc6a Pick up electron 11.4.2 (#120670)
73ae56b82b0 Build with latest TS nightly (#120690)
ca0a583a1b4 🧹
b116dceb478 Merge branch 'main' into merogge/tabs2
8d235ef07ca Fix#120614
c2075cd2a98 revert some changes
aecaf0a6ac6 get widget to work
95c63b68e94 Support env in terminal profiles
c2269e6f64c get terminal container to show up
967a33b6e23 fix code cell output offset flickering caused by wrong font update.
28298795b13 debug: update debuggers, fix node not activating
5c12763dbe0 adopt toggled.title.
1db8a625c2c fix#120603.
74351e8f09e Remove processBinary from localTerminalService
970b14808c1 Update distro
b3ce5af360d Remove optional reduceGraceTime arg
17220763b62 fix title for toggle line numbers.
f8771f455c1 add Tabs Location
fe6e081a259 extensionEditor: focus only on enabled items
264ca56fe1f Rename initialText to message
72d772b1a15 make execution and interrupt callback instead of commands
16d8f35b261 Fix incorrect welcomView calculation for ports
07d0bba09d0 status bar: focus improvements
55b1c5bca85 sash working!
76a230d4b47 wire push-kernels into internal kernel provider API
08508fd2d51 call TerminalTabbedView.layout
17d52861097 styler - optional chaining ftw
aee12f9812c Add green to running process circle in ports view Part of microsoft/vscode-remote-release#4826
37abf64afd3 Add command line regex for port attributes provider Part of #115616
50d89df33cd css is awful
84f30546240 add local resource root and cancelCells so that Kernel2 is very similar to Kernel
4075475d310 accessibiiltyPageSize default down to 500
9221eb96970 don't forward changes for disposed kernels
a4270b8b6fd Merge branch 'notebook/dev' into joh/kernel-push
cf1634602a4 fix compile error due to missing mode service, fyi @roblourens
bb90ba3d5a5 sandbox - delete "Code Cache" folder on startup for now (workaround for #120655)
5dd5dd81004 extensions: more CSS fixes
f76b1ae3409 add test for extHostNotebookKernels
b1523b435b0 Update port attributes api to not use array Par of #115616
38e4243e2d7 add kernel push to proposed API
30dcb112b46 fixes#120698
d1505792171 fixes#120706
eec393e0d47 chore: use bundled node-gyp (#120683)
fefe5f324a6 extension view: CSS layout tweaks
b854effee99 Fix#120700
3cbbe4d2494 window - make sure all perf entries are there
5aef07536d9 window - more aligned window config handling
269025c30b0 hmm
0791b3d49c9 Merge branch 'notebook/dev' into joh/kernel-push
155f187b816 Merge branch 'main' into notebook/dev
219509dc2d7 fix yarn lock check
28a55539bb9 window - create a proper window config
04b6291eed8 build - push missing compile artifacts
c1db1db7b46 Set new language on TextModel, and listen to mode changes on existing cell text models #120284
6beb1b43af5 more splitView work
05b52df98a5 Update JS/TS grammar
28a246d9ec5 Don't call node-gyp anymore (#120673)
0e15648f9fc clean up a bit
3546e73c682 take 2, sash still disabled but otherwise working
d2f39824975 update markdown cell heights synchronously on init.
7ed402d3676 Remove nextTick usages
8117fec7dfb Fixes#120036 (#120275)
4cd60098755 Avoid measuring outputs unnecessarily Fix#120282
bbcaac9693c Fix output.selfClosingStyle, fixes#120417
b7989dddc59 Goto line number does not work when --remote and -g are used at the same time. Fixes#120487
3efdebb1e7f Merge branch 'notebook/dev' into main
331015eaf0c track notebook file open perf.
408d3561117 Fix#120657
d3d7966f8cf Merge pull request #120382 from LuisPeregrinaIBM2/main
0e34376ed38 Hook up actual icons
1b70c818a17 fix error, sign off for now
070e7087094 revert some changes
b8b23d85200 bump distro
4209e2cc125 Workspace trust not enabled in web
6b1d3bfb949 delete comment
2b6df1bba95 sandbox - disable vscode-file:// again (#120655)
ab4f455f850 more migration
56b96bc997b The Great Migration of code from terminalView to tabsView
ffb7adc71e0 Revert "fixes #120166"
551daf412ee Polish and fix#120245
d520e940afe Update Codicons: Fix typo for Debian
e7e15984bcb package.json completion: fetch on every key (always incomplete)
0e7d1610f3f Update Codicons: Add terminal icons 27e4b9b87e
383a22e924a try more stuff
76ec94285b9 a little closer
c7faaf0ea08 update wt static declarations (#120443)
3d6f3002545 fix#120641
c3f72be4959 add createNotebookCellExecutionTask to kernel object
baeae379657 correctly use outputs
c1236953128 fix syntax error
4790696ccca bring back task output
99d9bf26974 use this.
07dab53ae14 more yarn lock changes
dfafa70dce0 add debug to yarn lock task
639a32f9093 Make sure yarn.lock changes are allowed for committer PRs (#120642)
d52fbadeb20 more cleanup
be2e72af102 clean up
110be45dcc1 Move icon to side in term quick access
05de36649f2 Merge pull request #120317 from Jolg42/npm-ext-use-npm-only
ac35a5b937e better fix for #117095 and also fixes https://github.com/microsoft/vscode/issues/119086
0a9caa8efba Use tools icon for task terminals
2f62eb09067 ignore focus dependent test also on GHA, fixes https://github.com/microsoft/vscode/issues/120355
962933e8be8 fix actions margins across workbench
1603dc79ad2 Hook up bell status
33d5a743555 xterm@4.12.0-beta.20
8843da37a91 💄
40a16b61a16 Merge shellEnv into process.env (#120332)
b47fb7a2756 add kernel service and add extension host logic for it
92281913a1b shell env - change to ipc invoke/handle to speed up resolution
d491ec5c728 Merge pull request #120581 from gjsjohnmurray/fix-120578
6d9ca4a7a28 Merge pull request #120457 from lf-/config-error-reporting
ffd7a242f5b fixes#120166
f250472adc4 lifecycle - onShutdown => onDidShutdown
ee4b092ef2a Merge pull request #120362 from andrewbranch/ts-4.3-update
23d1a967cfd 💄
a1b33b14853 Fix#120340
6d097be455c fix test
d06df602de8 Add resolveWithEnvironment to config resovler Part of #120328
fef62f8d80d Fix#120486
b655f698806 update cssnano
4d5c6269454 fix logging zip path
65b8dfc686f #120545 remove <any> usages
6a1404a6f80 fixes#120518
fdbcc90b4f0 Fix removal of port label
52d2d096049 Trim port label Fixesmicrosoft/vscode-remote-release#4832
1e03dc25374 💄
4202acc9f76 node-debug@1.44.21
accd84def60 node-debug@1.44.20
5d94a7c9550 Refactor worksspace trust setting
ce275c6c0c7 remove obsolete todo-tag
58186680eb9 sandbox - enable vscode-file// protocol by default (#98682)
fca4457adaa Better action hover feedback (#120247)
def8fc7b0d5 integration tests - revert changes for commands test
fca1144d009 remove NotebookDocument#cells in favor of cellsAt, getCells, and cellCount
e848d708990 tests - increase leak warning threshold for #119968
e637ff1bf7f Update perl grammar Fixes https://github.com/microsoft/vscode/issues/120466
0215117ec6e Make easy adoptions of async configuation resolver service (#120326)
82c180bf346 tests - easy on the timeout
8de37914778 integration tests - use async test (#120225)
6f8b983dfdf fix tests
8684456b1e3 Merge pull request #119021 from qchateau/fix-format-modified
30f0d188c71 sandbox - prefer sandbox types over node.js types
6b67774b756 use NotebookEditorInput to work around https://github.com/microsoft/vscode/issues/120284
584d0acaf1e Fix#119369
ff0f7f3cf24 Make product configuration available to non node.js environments (fix#120243)
0c14397b64f Merge branch 'main' into notebook/dev
224127ce54e add splitTabsPane
dd37fc58cad fix#120513.
1722d6e243e Merge pull request #120590 from microsoft/tyriar/status
440a4415ade Merge branch 'main' into merogge/tabs2
6d55039842d prompt user for reload with wt tree changes
be56a9ec0c2 disable step* buttons rather than hiding them
329804e4cb3 Remove only
e757e4e25ad still not working
96e5868749c Move to quick pick for configuring welcome page item visibility
617b7c0067b take a break
04d8568000b cleanup unused var
b7b1e0cf8a6 Add unit tests
1e674d98414 Expose on did change primary status event
eaf1c8c6e9d Hook up disconnect and relaunch needed statuses
0f696464e69 get instances to focus on click
afebedaf0ee Show line number for current cell.
4377f6f19de Docs, remove old timeout
7d6c5a0174e Create status list
2633dd01e3b 💄
fb824ca76f1 fix using ref before initialization.
8d57595fe8c testing: store results in separate files to fix ui slowness with large results
0821b6fcbfd Prototype side by side commands for getting started (#120436)
37d72096b2a context key checks for cell line numbers.
92ff8a92093 rearrange code
30287791f85 Merge pull request #120562 from microsoft/tyriar/terminal_icon
04fb146b0a5 fix-120578 don't offer callstack step-in/over/out when not stopped
59c22b33530 more improvements
192e36293c4 Remove icon from title
a6754b2bce2 Merge remote-tracking branch 'origin/main' into tyriar/terminal_icon
9e86b50fe71 Remove todo
e4300049a4c Create terminals using only profile
a2056a83584 Remove unused "walkthroughs" section. Closes#119946
c097d4c618c move show line numbers into editor title
f2bdb4f37ab Remove task icon, maybe status is enough?
36cc8dd6611 Hardcode js-debug using id
606a68fa2a5 Fix typings in preferences
76736a879b3 add showTabs setting
782830d29e1 skip failing test, delete console.log, remove reduceGracetime call for local terminals
18548e7af05 fixes#120462
80f11080c1e fix get embedded css util (#120480)
218e702bbb4 children now work
6861fc9480c support action through keybindings.
e6678afeb76 toggle line numbers for notebook or active cell.
804c1fc594d notebook line numbers.
65be3acf599 cleanup access to process.env; fixes#108804
1c04d9f2df3 Update PHP grammar (#120339)
b3c6ef20394 Correct detected separator condition
060ac497525 Add contributed to create with profile
909f1ac17fa Support icons in terminal type contribution
abe140a32d2 Add a placeholder icon for tasks
83ef138eb37 Add source/profile icon schema
a5bcb9f3b59 Support icon in source
6359fa608b4 Add icon to create with profile
ac7338b4eab Add terminal icon to quick access
f8810116c6f Add terminal icon ext api
0e7fc5faf54 Add icon to launch config
76acf1ef644 working pretty well
027f6293107 add to terminal view
17ae3eea6a1 Update notebook.inactiveSelectedCellBorder for HC (refs #117705)
e8b3426f9b8 Fix#117705
3edb33fc0c3 push terminalTabsWidget
e7805ded7e0 Merge pull request #119468 from anthony-c-martin/update_vscode_icons
c86fff70459 Update distro
14470bff05d fix: only add readonly attribute to textarea dom when editor is readonly
874d19930e3 Calls new fork repo command in a codespace
3de15ba87ce Improve reporting of extension config schema validation errors
94c9ea46838 Merge pull request #120419 from microsoft/tyriar/profile_test
96eaf9dd9b8 update distro
60e19db154f rename channel action processBinary
c61393b0c17 void -> Promise<void>
731802f9452 Merge branch 'notebook/dev' into main
5364c0f9c92 update distro
e6cce4722c3 make reduceConnectionGraceTime and processBinary return promises
fc71fbf4905 render outputs for viewport.
83cf9f1503a wrarmup outputs.
c5974ffde6e 💄
bb4b451c17b Merge remote-tracking branch 'origin/main' into notebook/dev
b88f1ede0ec Emmet polish and updateExtensionsPath changes
7cd615ca4c3 Restructure outputs in notebooks to use relative offsets
638e801dae7 Remove extra not-null assertions
040454db280 update distro to include ptyService async method processBinary
7dc766dabc1 make processBinary async
215fe3d92be fall back to dom if webgl loses context (#120400)
15af2df708b tweak api based on conversations (#120397)
99ffa6db260 update distro
c247af6a237 remote processBinary
8fcdb2035ad Improve descriptions, fixes#117516, fixes#117518
d0061c5db63 Update distro
cd7499c1677 Ignore shutdown pty host messages when already shutdown
8be3c7391c8 Correct Windows PowerShell path
6b9e16f22f6 Remove only, describe
76f61e9183b Use profilesEqual helper
3f843c863a6 Test pwsh source fallbacks
6082284b318 Improve fs provider in windows tests
75b9018255b Validate /etc/shells and findExecutable in unix tests
8c315552d13 Merge mac/linux tests, clean up
c159ad6fb4e Add create with profile to term quick access
3ef964364cb Fix issue with getting extension trust requirement
55003580840 avoid flush cached focus mode.
4f46f64b437 Add slight right padding to markdown cells
b831938a47e Update distro
cd4ef67520e xterm@4.12.0-beta.15
b62d4a06bba Use a single resize observer instead of one per cell
f6b67b6cc32 Batch together a few more notebook change events
81f2d352a35 update distro again
50a900f51eb more 🧹
ce9c754d743 markdown editor model might be disposed.
4dc3a84c60e Flatted structure of preview nodes in markdown back layer webview
0a2a57cfc37 Clean up interface for dimension update apis
93b7b60aaf8 update distro
962e1afa634 🧹and store isBinary in writeBuffer
a99d2735ff8 notebookEditorWidget.layoutNotebook is still the better place.
68207be49ca compilation error
9b3eaf003c3 move layout cell into cell list.
b0a7f84a178 move layout cell into cell list.
ade3e6e6831 testing: some api polishing
2a3c39017a3 wsl -l -q, removes header and default mark
788d62f10f8 Merge branch 'notebook/dev' into main
e3d59bf3a55 fix#119661.
a3a61f467e1 Fix webview search, fixes#120158 (#120373)
ef1e9bfa2ca Merge remote-tracking branch 'origin/main' into notebook/dev
c8ccd07d0f7 Add initialText proposed API
062ed0700d2 bump distro
a816fcfb6b5 Hide outputs with visibility instead of display
470e37c3d85 Merge the two scroll events
0e5ecf116f0 Reduce the number of times we fire updateSelectedMarkdownPreviews
ee7c454339b Fix potentially null reference while updating scroll tops
fcc12d58d21 Batch dimension updates from backlayer webview when possible
5f445eae300 Avoid running content height update multiple times per frame
50b58c4868c Use for/of loop
003c7d95e4f Remove unused values from webview messaging
2557840bce4 Remove extra conditional
4bc5ab886f1 Use for/of loop
000e90ec385 Use single call to add/remove for classlist
c131f155684 Add guards to updateMarkdownScrollTop
b3df72fe764 Skip sending updateViewScrollTop if there is nothing to update
04492b42b04 Use for/of loop
4b20016f0df Use for of loop
79011a0fe1f Extract duplicated code
0691553200f pull reduce grace time into ptyService method (#120195)
3ab41807e91 fix compile error.
e2a0fe60b27 cut aligns with delete cells.
ae6d1a7328a fix#120187.
890372404a8 fix#120348.
1fd558ab2fa Fixes#117513 - deals with very old git
8426ff6475c Update language service call for 4.3 protocol
f3f8d3d870a Fix tests for #120356
083bf902040 JSX self-closing style should default to XHTML, fixes#120356
7a263003017 debug: update js-debug
4cd94d0299f `ILanguageSelection` should not be `IDisposable` (#119968)
abff1971b9f Update to vscode-proxy-agent 0.8.2 (#120354)
8e93733fb9a Revert to vscode-proxy-agent 0.8.1 (#120354)
c7be0b52229 Adopt `assert.deepStrictEqual` (#118667)
1ed36fae345 Fix#117881
a56afa9033c Emmet: Select next/previous item does not work with script tag. (#118842)
595a894b21b Add emmet self closing abbrev support (#120311)
3e22994cad3 Adopt latest loader (fixes#120150)
e664085b70e Use optional chaining in MainThreadTerminalService
11e96b2da8c Fixes#95843
49a164e8862 Workspace trust API polish
648ea3d1e03 Refactor requireWorkspaceTrust to requestWorkspaceTrust
be5170cc19a Fix#120343
5dc3db6ca24 Factor in workspace trust when installing/enabling an extension (#119069)
ee2fd0ea637 Set up scroll width even when width has to be detected by the list (#120281)
50ce1902037 Update PHP grammar
1e6d85953d9 Debounce port change events since they can be in batches Fixesmicrosoft/vscode-remote-release#4759
65a763bdf8b Remove long cpp colorizer test Fixes#120095
f427914f064 Add telemetry for task engine version Part of https://github.com/microsoft/vscode/issues/118201
fd14474d344 Add IShellEnvironmentService to configuration resolver Part of #108804
d05d8ca4c25 Adopt async configuration resolver in Tasks Part of #108804
13e5c93740d refactor npm extension to only use npm
0b8a7ca21a9 🆙 distro
1f30107d9e6 product - move the interfaces into base layer for reuse in sandbox
2dab9c80c1e bootstrap - some more cleanup around types
1db94dbb102 sandbox - add additional arguments also to test runner
0640cdeb8ba revert addition of events
4155993b36d add onProcessBinary to ptyService
c81420bb379 add onProcessbinary to ptyhostService
a06fd62f351 💄
78a974700f6 cellAt can actually return undefined.
c65082a28d5 avoid offsetHeight check on monaco-editor output/
7a98d1fd3d5 fix#119732
b41213c5735 Enable setTextDocumentLanguage (#119429)
0631bbc801b first resize of the builtin renderer can clear the minHeight.
90747e9da6c switch mimetype with minheight.
3fbe95a1cb5 bump distro
d5cf4ac0eb9 Fix terminal mouse reporting via binary events (#120145)
7b11e6519e0 debug: call to native console methods in web worker ext host development
5fa18996fc5 Revert "Fix #119369"
c4ceba7cb7b Add events for when the active webview changes
0e8edff8533 Avoid extra casts
fc691ebd333 💄
d9ab9acf160 Merge remote-tracking branch 'origin/main' into notebook/dev
85ad1676518 update coreActions getContextFromArgs.
c0299f4948e 💄
aefafa019df Merge remote-tracking branch 'origin/notebook/dev' into main
7c8891965b6 replace slice with getCells.
f16c14f484a getCells in range.
7617fa43ae1 adopt cellAt in tests.
cc094ec8972 cellAt.
6d0ffa2a345 Update distro commit to include REST Book enabled for insiders (#120265)
6d115ef2fdd Fixes#119738: In case of an extension being installed on both sides, prefer the side which has the extension under development
2754be9605a use viewModel.length.
f35264bfc61 fetch focus from view model other than list.
eb36432c6b4 use existing func for wid
8094bd9c60c auto show mgmt editor in unknown state
f1c4a8676e5 fix#119205.
cdab314713b check if type === createInstance
a49d15d70de Profiles via command pallette (#120141)
2a611bc6821 update trust parent language
1b934932765 Hides context key
ca980ecfac3 update notebook editor view column when moving editors, https://github.com/microsoft/vscode/issues/115704
407a0e37235 assert that we have static view columns
9e8699e844b change the label
f7753783ca1 Merge pull request #113155 from plainerman/fix-76879
388eaa34735 simplify auto update options to boolean + onlyEnabledExtensions introduce configure auto update action
e715199ccc7 extract createTestNotebookEditor to testing outside of with-util
36ef468d4dd Make async versions fo configuration resolver methods and deprecate the sync versions Part of #108804
1372233695c remove unused service
10a1caa55f8 Remove depreated assert.equals from configurationResolverService.test.ts Part of #118667
c1209ae4e01 extract separte interfaces from ExtHostNotebookShape but not change anything yet
48e11a0cab4 rename
fa48622fdf9 split mainThreadNotebook up into logical pieces
a851a2612f4 Add openwith entry for search editor. Fixes 119185 (#120198)
eece236bbd6 Fix#119369
5457db8aac5 Revert mkdirp resolution
96ae5e83d28 Add availableFilesSystems to Add Folder to Workspace Fixes#120232
5a673f33499 Revert node-pty update
4c76edff2b3 Revert "skip failing terminal tests."
141ac31cdcb sandbox - ensure to validate vscode-window-config ipc call
203f1cb56b1 add some logging to ipc object channels
1d883f8af1d fix issue with finding required node handles (#118091)
0f7d20c3b4e Revert "Add resolution for mkdirp"
7dab1460c16 Add resolution for mkdirp
e9047f01dcb Merge branch 'lszomoru/mkdirp'
dd360b25da3 add notebookEditorModelResolverService.isDirty and use that when forwarding events
65fbf884a8f 💄 bootstrap types
6b5f2532d9f cellCount and cellAt API proposal so that notebook aligns better with text document
5ec2f69fb30 sandbox config - add forceEnableDeveloperKeybindings
5b15a3c2636 Add resolution for mkdirp
8a4d271f43c 💄 bootstrap types
970f7998901 preload - apply zoom level after resolving config
5c795716107 Add next/prev conflicts (#97613)
96d0dc4154d Add next/prev conflicts (#97613)
bbdc0e4c79c add NotebookSelector which is like DocumentSelector
d0d89c94c38 IPC object URLs - make it generic and use ISandboxConfiguration in all windows for proper typing
335bc0196c3 Remove unused dependency
d35df4a3efe window - use IPC to transport window config and drop URL query param (#120096)
45f061b9c82 Swap cpx for cpx2
f04401cfa48 #118667 adopt to deep strict equal
367c5e2dd6b add some todo-tags
4fd610fc717 try bigger timeout awaiting events
38abcf09ad7 Merge branch 'main' into notebook/dev
325bea69a74 chore: add media and apple event entitlements
7a9151a29d9 do not block svg for webview resources (#120156)
c18893214c2 Fix#120215
2d5f0e49534 skip failing terminal tests.
00c1ca5afcb fix browser integration test timeout.
cd52cd7c8d0 Fix clicking on markdown cell to add/remove selection
9ab80019bf2 Use forked markdown-it-katex version
16cff9cff93 Finalize CodeActionTriggerKind
caa03cd52fc testing: remove total tests indicator
4bd5a83b86f testing: clean up 0% label running tests
d6448cfd3ad testing: fix test welcome being shown at inappropriate times
c79109bff16 testing: fix active style overriding checked in filter
8a7228ee7d9 search: use strict equals
665cc92c7e6 check if localPtyService is defined to avoid throwing in web playground (#120144)
63fbe4473f2 Remove vscode-webview-test from electron csp
f122b1096cf Don't use `dataTransfer` for cell drag and drop
d4412e708ae Render markdown preview cells inside a shadow dom (#120137)
268ac6e3df2 Bump documented min version for new postMessage behavior
795f44ea6a0 Build VS Code with latest TS nightly
7bbc15a60e0 Replace -1 constant in keycode with enum value (#120126)
c0ed513633d Add output.inlineBreak parameter, fixes#119088
1f5ff0f17a0 Bump dependencies, affects #119088
708b353f052 Remove notDeepEqual, part of #118667
6e07fb24ee8 Remove unnecessary condition, fixes#119120
588c2f6c783 skip showNotebookDocment.
9b091c7d228 💄 Emmet tests
9503e7dce7a 🆙 distro
78d3cc3feaa Remove use of assert.equal from the code (#118667)
1968bda7e67 platform#IProcessEnvironment is badly typed (fix#119046)
4ccad80121a fix#119322 (#120143)
d5a670eaeb0 Switch to deepStrictEqual part of #118667
33cc87e1c4e re #118108. separate selection and focus.
88c58b011c0 re #117623.
4bb08160c70 fix#117670.
48cc8a84fd3 fix powershell profile source (#120138)
0cea28a5ded Adopt ITerminalEnvironment in external terminal
d3da22dfc41 node-pty@0.11.0-beta4
dddbfa61652 Remove process.env from tasks Part of #108804
1f06361cd36 Debug view should show when a breakpoint is hit
770ba2b0c0c Debugger: Add option to allow disconnect and stop/terminate UI elements
1988caa6272 Merge pull request #119160 from alexmyczko/patch-1
1a4f9ebf8b9 Update distro
01e935eac97 xterm@4.12.0-beta.11
298b3bb7b99 show "no elements" for empty breadcrumb case, https://github.com/microsoft/vscode/issues/56327
e3853050254 Remove notEqual part of #118667
e30424ae617 Merge pull request #108397 from awilkins/feature/selection-paste-in-terminal
29d59497cd3 Update Github issue for workspace trust proposed api
149c304c8cf Merge branch 'main' into feature/selection-paste-in-terminal
142cbdbaad8 Increase timeout for browser integration tests
54bd78ffbec Revert "Increase timeout for browser integration tests"
849a2db25b5 Update markdown-it (#120161)
291cc7c9d55 Fix#120159
9dbdcc4a0cc Increase timeout for browser integration tests
7c498ec3a85 Update tests to use consistent version of mkdirp
26dba7aab5a better working copy uri for complex notebooks, https://github.com/microsoft/vscode/issues/117899
095d06955ca Fix table list height. Fixes#120062 (#120102)
1f43f5ffcff use INotebookEditorModelResolverService#onDidChangeDirty to drive notebook file tracker
29a1cfddcd2 make sure dirty state of notebooks from simple content provider is reflected in extension host, add integration test
5cf75096a60 💄
95420b39f28 Add cuda-cpp lang id, grammar and problem matchers (#119444)
3287cedd343 no more usage of assert.equal, https://github.com/microsoft/vscode/issues/118667
c3aa80c57b4 Merge branch 'main' into notebook/dev
2b04ebaa114 Remove unused static functions in grid (#120123)
eb7ccce154d update y18n
452b685b997 use assert.strictEqual
3499f63dc1c Exploration: Better transferring of TypedArrays used in Webview.postMessage (#115664)
242bea8c8f0 zoom - always set it early on (fix#108920)
de4b1cf9dca Add placeholder for empty markdown cells
eb17cca0d54 Don't call updateOutputRendering if dom not has not been set
f908389c0b1 fix#117670.
97044c900a2 Adopt workbench.hover.delay in the terminal (#120134)
768ea662541 Handle error in getting wsl distros (#120124)
9fd5f25ec58 rendererType -> gpuAcceleration
e09adb28ff4 add trusted parent button
2a1f20afc7c fix#115432.
0ff1928a3b9 Merge pull request #120002 from microsoft/tyriar/terminal_sandbox
cbed5812a3d testing: fix name of view container
469cd185a90 testing: add run/debug actions to context menu
9a27f0e2cc4 testing: s/re-run/rerun/
ca43526452b testing: be more consistent about focus actions, add context menu to reveal
3aff04dcae2 testing: improve test item labels
20fc2a175a4 debug: fix rare(?) cannot read property of null error when debugging
214acf0d65c fix: don't open peeks when tests are retired
a565ba12a38 testing: remove peek if showing for removed test
48e8463a897 testing: tear down app if renderer crashes
b6fc5df1d4b testing: toggle all visibility when reselecting the same test filter
412f45fa80a re #111663.
368f44e07bc Enable iframe based webviews on desktop for webviews that don't need search
c310e402216 Enable webview developer tools command for iframe based webviews
da681f2fef5 Merge pull request #120131 from microsoft/tyriar/gpuaccel
182d40c07c6 Fix test
6bf2a7eb960 Merge remote-tracking branch 'origin/main' into tyriar/terminal_sandbox
da94e122d1f Merge remote-tracking branch 'origin/main' into tyriar/gpuaccel
06ce7bd2977 Fix hygiene
06a451d8154 Merge branch 'notebook/dev' into main
34354cd5a5b Enable useMarkdownRenderer by default again and document this experimental setting
878c3fb7f45 Merge remote-tracking branch 'origin/main' into tyriar/terminal_sandbox
7d67641ef31 Merge remote-tracking branch 'origin/main' into tyriar/gpuaccel
dcb7f7c853a Skip environmentVariableCollection suite
30ccdf6b6cd feat: add typographer option for markdown preview (#119641)
f02e4853c37 Change rendererType to gpuAcceleration
bfe889d3b96 chore: bump electron@11.4.1
21fca08c978 Revisit webviewExternalEndpoint in environment (#118950) (#119780)
4dc2d399c75 Fix TS 4.3 compile errors
47256436d8c Remove explicit assignment
755424b11f8 Add type for constant
14373a5fc59 Merge remote-tracking branch 'origin/main' into notebook/dev
08e1302c980 Update telemtry extractor
cca122c4337 💄
54910b1970f cut cell without selection update selections correctly.
31fd94b6606 First round of getting rid of deprecated asserts (#120125)
5da392fdf03 allow authority in wt (#120059)
ca37086d9ae unify copy/paste cell from ui and kb.
29ca249959f [typescript-language-features] Support import statement completions for TypeScript 4.3 (#119009)
0854a0a6231 Add include for ms-auth extension (#119219)
12c4596ce31 Try fixing leak of backlayer webviews for notebook diffs (#119372)
a39120ddd11 Add support for JSDoc link tags (#119358)
1c3c96b4b9a fix(notebook): redo cell creation does not re-select the cell
a573d500d08 Merge pull request #120086 from arnobl/fix-notebook-redo-selection
a5f7945b3bf Update git test for integration tests, fixes#120116
2111c113802 remove (inline) INotebookEditorModel#isUntitled
d80301ca05e Update to vscode-proxy-agent 0.9.0
50d1ce4ad17 remove unused NotebookTextModelSnapshot
79e0e2737a1 remove default cell for empty, untitled notebooks
fe154b40607 Merge branch 'joh/nb/next' into notebook/dev
e2d3e9f9255 💄 throw if cancelled
030cb3c75cf Moves extension prop out of proposed
7164efa38e5 Open Editor refactors (#119274)
3e16e9151b9 update typescript-vscode-sh-plugin. For #120103
7c8da70fd02 Respect viewtype for reopen with in notebooks (#120101)
3e0f2f1c6ee allow wt description in widget (#119291)
848e3301a18 also 🆙 jschardet for web
34fa8941743 🆙 nsfw
9c2b0537785 🆙 sudo-prompt
f89406f2da7 🆙 native-is-elevated
13bbe762f5d Inline values provider isn't called with new view port when scrolling editor content
2bf76afac69 🆙 jschardet
17e7a257ffc Update grammars
c318085f383 Merge pull request #119817 from yannickowow/master
e09a24028ed Automatically show inline values if an inline values provider is registered
0d2b550ab1d Show current DataBreakpoint access type in "Breakpoints" view - Append debugViewlet.css for "access-type" element - extend IBaseBreakpointTemplateData when rendering
3a2a24e452c cli - set VSCODE_CLI earlier (#119660)
456651f2868 zen mode: do not keep pointer to editor. Just reset line number visibility for all visible editors
ddd480046df debug: update inline values when variable is set
ce184d9ec72 fixes#119825
d13f3b4a2ff remove NotebookContentProvider#resolveNotebook
e5b2742fff8 debt - provide common method to load renderer with config param
19f6f310360 💄 remove extra comment slashes
e96e70d59ef remove overflow action when there are no overflows
44f89fc13c3 editors - do not wait for editor to resolve to signal restored phase (fix#119059)
f554a745505 debug: always show top call stack column
01e844e75df Merge pull request #119992 from microsoft/tyriar/119046
df6d78a1695 debt - align editor model closer to file working copy
7031abadeaf debt - less explicit any
ec1def6ca81 fixes#120066
576ef958f1a don't save outputs anymore
7f36af1c924 debt - improve emmet integration tests
babbec1a0b1 file working copy - better cancellation support
82647af99ac debt - onDispose => onWillDispose
e8388ab7401 chore: allow vmodule switch for debugging
d2db91f2c68 Fix issue with bottom border for focus
8f7392d0788 Add confirmation for workspace trust state transition
7979a7b5166 Workspace trust - extension enablement (#120028)
5d2e7aceda5 Remove code that is not needed (#120005)
89571337d18 Fixes#115327 with HC images for GS setup/beginners.
21051a1d73a Recommend Quick Open when a workspace is open.
d99caf58bb9 Allow 100ms for terminal container to become available before spawn
2a60d7f8b00 Enable terminal event batching from ptyHost (#117268)
3b10a59cfc3 replace one additional displayDetectedWslProfiles
caa9478d80a allow terminal profiles w a source to have args (#119967)
f88275a0834 iPad OS ctrl + c in terminal (#119979)
f3d2dea9f5d displayDetectedWslProfiles -> useWslProfiles
307f57385b9 Workspace trust - multi-window improvements (#119483)
8bd15af0cba Reload window on workspace trust state transition
2aa503b9ece debug: double check that launch is defined
5e711f49fdb Remove quick launch terminology from code
dafbda4cd2b new file => new untitled file rather than explorer's new file ref #119882
7647d09883e debug: fix stop on entry not working after launch.json change
ceac3391bb6 Bump version to 1.56.0
e54d67868ca fix optional service typing
62e5b935091 Use ThrottledDelayer per review feedback.
183818196f2 ces: use ThrottledDelayer
8b642ee2953 Applied review feedback and tweaked heuristics
e847db90611 RunOneScheduler and code cleanup for CES
7f2dc82f044 Fix localization strings and typo
d662c36c8d6 More CES heuristics work
a49a633a042 Prompt within 1-8hrs heuristics
09ea4bcdbc3 CES experiment treatment
9c681aeb9be Draft for ces survey
74c15f1159b Ignore extension that is being installed
958e1f7cecb Update distro
ed74a5301c2 Adopt writeSync maxSubsequentCalls
05778206b4b xterm@4.12.0-beta.7
2a3acf9fd89 LocalizationService.update no longer needed. Fixes https://github.com/microsoft/vssaas-planning/issues/3290
4f6069c99a4 don't save outputs anymore
b19f50e0160 debt - improve emmet integration tests
7f9835ac433 file working copy - better cancellation support
5e3df4ce301 debt - onDispose => onWillDispose
03b35958bfd fix#119885.
f8436bd10ab 💄
7fbddb5522d fix(notebook): redo cell creation does not re-select the cell
dc9bdc2fc7b Fixed wrong variable name shadowing that caused Profiles for extensions not to appear.
c0fa3dfd3e2 chore: allow vmodule switch for debugging
720c1e74ec6 Change auto update extensions behavior in UI
f453ed8e382 Fix issue with bottom border for focus
c4eb9272319 Add confirmation for workspace trust state transition
908b5bfdf8b Show update all extensions only if auto updating is disabled
c2b5d3d4710 Workspace trust - extension enablement (#120028)
6aa528024bc Remove code that is not needed (#120005)
364923c06b6 Fixes#115327 with HC images for GS setup/beginners.
80a74dde2ef Recommend Quick Open when a workspace is open.
ff254794f5d re #119561.
1733f27dfb3 Move terminalRemote and parts of native contribution to sandbox
eb0f111c58d Remove unneeded impl from browser/terminalInstanceService
8ac3d73848e 💂 folding+cut
a802d1f9dff Allow 100ms for terminal container to become available before spawn
02d38098249 Allow undefined in terminal env map, unify interfaces
e7f329a8d8f re #119771.
a05c63db4fd Enable terminal event batching from ptyHost (#117268)
778d622ca16 replace one additional displayDetectedWslProfiles
76a7bfce680 tests for #119773.
db36fa61f1a extract copy/cut/paste actions.
31f8118486d allow terminal profiles w a source to have args (#119967)
cc077af2d6f iPad OS ctrl + c in terminal (#119979)
6bbfedaa7d7 displayDetectedWslProfiles -> useWslProfiles
b45ab9da567 Workspace trust - multi-window improvements (#119483)
3f511d294fb Reload window on workspace trust state transition
aad588a535f debug: double check that launch is defined
d684db7ba9a Merge pull request #119970 from microsoft/tyriar/quickLaunch
b32eca63091 add tests for undo/redo with invalid ranges.
16721ed9e02 out of boundary replace should not throw.
f39716e0151 undo/redo tests.
8804de8eb70 new file => new untitled file rather than explorer's new file ref #119882
91d308b13d0 debug: fix stop on entry not working after launch.json change
e0be2784123 Bump version to 1.56.0
d02a4aacbaf Remove quick launch terminology from code
5f30215a0f8 add `NotebookDocument#isClosed`
13c66745802 add `NotebookDocument#getCells(range?)`, https://github.com/microsoft/vscode/issues/119602
c0bb10ac324 always (re)load notebook editor model resolving notebook input
3a8a44f64bf implement saveAs and better resolving/loading, move some files around, split some files up
0d44c987c61 Change auto update key to allow not updating disabled extension
fecf3b3e3bd Update VSCode icons
3ef1a3394dd Check for extension updates on extension enabled
cb813a6ed18 Add change update disabled extensions behavior in extensions context menu
2fbe092c9c5 fix long description 50%
bfac4892e5f Fix#103631
f977d7f0663 format modified: format lines with whitespace changes
a0fecbd327f Merge remote-tracking branch 'upstream/main' into feature/selection-paste-in-terminal
f075b241438 Improve filtering of disabled extensions
c8ced34cdeb Add configuration key for updating disabled extensions
e7b681dc9ac fix: 76879
abc7ec3ad3b Merge branch 'feature/selection-paste-in-terminal' of github.com:awilkins/vscode into feature/selection-paste-in-terminal
ab34fa90e99 Merge branch 'master' into feature/selection-paste-in-terminal
426a04c8cc1 Merge branch 'master' into feature/selection-paste-in-terminal
db2809fe443 Merge branch 'master' into feature/selection-paste-in-terminal
ebf33532c61 Fixed a lint
39585898d12 Register command
441dfcd718b Fix a lint
65f3889331f Implement a selection paste action in terminal
REVERT: 3c4e3df9e89 Merge pull request #121167 from microsoft/alex/1-55-2-fix
REVERT: c01cbae1127 update distro
REVERT: 0320c595d05 Merge pull request #120967 from microsoft/roblou/bumpDistro
REVERT: 3f9cf547f7d Bump distro for release/1.55
REVERT: ead2c2ab0f5 Merge pull request #120858 from microsoft/alex/1-55-2
REVERT: bfb2654224e Pick up new distro version and bump version
REVERT: 08a217c4d27 Merge pull request #120733 from microsoft/joao/release/1.55/fix-build
REVERT: 6b89f1aaa2e Don't call node-gyp anymore (#120673)
REVERT: 6e3220a31a9 Merge shellEnv into process.env (#120332)
REVERT: 5dee7d559ff Update to vscode-proxy-agent 0.8.2 (#120354)
REVERT: 91fa7f030d2 Merge pull request #120519 from microsoft/misolori/icon-updates
REVERT: c5e030273bf Merge branch 'release/1.55' into misolori/icon-updates
REVERT: 8be12407ad0 bump version to 1.55.1 (#120379)
REVERT: d6e72b493ce debug: update js-debug (#120358)
REVERT: b7d152d5b2f Update distro
REVERT: c185983a683 Fix table list height. Fixes#120062 (#120102) (#120168)
REVERT: c71be15869a fix powershell profile source (#120138)
REVERT: 4c2a1fa6306 handle error when wsl is not installed (#120128)
REVERT: e3297826776 Merge pull request #120107 from microsoft/aeschli/120103
REVERT: c7f963cb27d Moves extension prop out of proposed
REVERT: 55f4c2ec1e2 update typescript-vscode-sh-plugin
REVERT: 26a60dbecac Merge pull request #120081 from microsoft/sandy081/fix119975
REVERT: 5753889f2d1 remove overflow action when there are no overflows
REVERT: be363080a36 fixes#120066 (#120080)
REVERT: 554774c21d6 Merge pull request #119983 from microsoft/lramos15/notebookViewType
REVERT: 428daa3650c Merge pull request #119990 from microsoft/tyriar/r155_wsl_compile
REVERT: 64876cb88e2 Fix test compilation
REVERT: 00296950306 [Getting Started] new file => new untitled file rather than explorer's new file (#119981)
REVERT: 2a8113f7231 Enable terminal event batching from ptyHost (#117268)
REVERT: aefdd723bd0 Merge pull request #119987 from microsoft/tyriar/r155_wsl_setting
REVERT: 98aeda8479a Remove RemoteHub from desktop stable (#119972)
REVERT: 981a2b53abc Merge pull request #119977 from microsoft/digitarald/fix-115327
REVERT: a3514cd1481 allow terminal profiles w a source to have args (#119967)
REVERT: 78636f2c133 Fixes#115327 with HC images for GS setup/beginners.
REVERT: b72964aaace iPad OS ctrl + c in terminal (#119979)
REVERT: a84f17acbbf displayDetectedWslProfiles -> useWslProfiles
REVERT: 1b0b1c67f35 Merge pull request #119973 from microsoft/digitarald-ces-distro-update
REVERT: c97d55a2131 debug: fix stop on entry not working after launch.json change (#119980)
REVERT: c7068ae9331 Respect viewtype for reopen with in notebooks
REVERT: 59b2869bdb1 Distro update
git-subtree-dir: lib/vscode
git-subtree-split: 631dbe250bcee37fcba8c4a6888284426943b48c
- Most people leave the logs out so add a section for them in the issue
template.
- Remove the VS Code logs because those get sent to stdout now and will
show up in our logs.
- Separate browser console and network.
Inside registerServiceWorker, we were originally using the nullash coalescing
operator to check if options.base was null or undefined. However, I realized
this check is not necessary.
If you look at getOptions' return value, we return an object with a key "base"
which is of type "string". We get that value by calling resolveBase which always
returns a string.
As a result, we didn't need to check if options.base was null or undefined
because it never can be.
- Moved everything I could into the class itself.
- Improve the logging situation a bit.
- Switch some trace logs to debug.
- Get debug port from message arguments.
- Move destroy logic into the class itself
- Improve logging a bit
- Remove the record option; we should always do this when using
permessage-deflate.
- Let debug port be null (it can be null in the message args).
- Add setSocket so we don't have to initiate a connection to set it.
- Move inflate bytes logic into the class itself.
This changes adds a new method called `.canTry` to the rate limiter to check if
there are tokens remaining in the bucket.
It also adds suggestions from @oxy to make sure the user can brute force past
the rate limiter.
Before, we weren't checking if a login was successful before counting it
against the rate limiter.
With this change, we only count unsuccessful logins against the rate limiter.
We did this because this was a bug but also because it caused problems with our
e2e tests hitting the rate limit.
- Instead of a single listener per terminal that handles all events VS
Code now has a single listener per event that handles that event for
all terminals.
- Refactor Terminal to extend TerminalProcess to avoid duplicating
methods. This required some modifications to TerminalProcess to access
the pid and title and to set the ID.
- Remove our async change to shutdown. This was necessary to avoid
disposing too early but shutdown already calls dispose so it turns out
we didn't need to call it ourselves.
- Rename methods to match the command strings.
- Fix getting system shell (uses process.env).
- Use a single bufferer. Since it already supports buffering for
multiple terminals there's no need to have one per terminal.
- Remove replay/reconnect logic. It's broken and unused so there doesn't
seem much point in trying to refactor it to fit the changes right now.
While terminals work now there are still a lot of todos.
ead2c2ab0f5 Merge pull request #120858 from microsoft/alex/1-55-2
bfb2654224e Pick up new distro version and bump version
08a217c4d27 Merge pull request #120733 from microsoft/joao/release/1.55/fix-build
6b89f1aaa2e Don't call node-gyp anymore (#120673)
6e3220a31a9 Merge shellEnv into process.env (#120332)
5dee7d559ff Update to vscode-proxy-agent 0.8.2 (#120354)
91fa7f030d2 Merge pull request #120519 from microsoft/misolori/icon-updates
c5e030273bf Merge branch 'release/1.55' into misolori/icon-updates
8be12407ad0 bump version to 1.55.1 (#120379)
d6e72b493ce debug: update js-debug (#120358)
b7d152d5b2f Update distro
c185983a683 Fix table list height. Fixes#120062 (#120102) (#120168)
c71be15869a fix powershell profile source (#120138)
4c2a1fa6306 handle error when wsl is not installed (#120128)
e3297826776 Merge pull request #120107 from microsoft/aeschli/120103
c7f963cb27d Moves extension prop out of proposed
55f4c2ec1e2 update typescript-vscode-sh-plugin
26a60dbecac Merge pull request #120081 from microsoft/sandy081/fix119975
5753889f2d1 remove overflow action when there are no overflows
be363080a36 fixes#120066 (#120080)
554774c21d6 Merge pull request #119983 from microsoft/lramos15/notebookViewType
428daa3650c Merge pull request #119990 from microsoft/tyriar/r155_wsl_compile
64876cb88e2 Fix test compilation
00296950306 [Getting Started] new file => new untitled file rather than explorer's new file (#119981)
2a8113f7231 Enable terminal event batching from ptyHost (#117268)
aefdd723bd0 Merge pull request #119987 from microsoft/tyriar/r155_wsl_setting
98aeda8479a Remove RemoteHub from desktop stable (#119972)
981a2b53abc Merge pull request #119977 from microsoft/digitarald/fix-115327
a3514cd1481 allow terminal profiles w a source to have args (#119967)
78636f2c133 Fixes#115327 with HC images for GS setup/beginners.
b72964aaace iPad OS ctrl + c in terminal (#119979)
a84f17acbbf displayDetectedWslProfiles -> useWslProfiles
1b0b1c67f35 Merge pull request #119973 from microsoft/digitarald-ces-distro-update
c97d55a2131 debug: fix stop on entry not working after launch.json change (#119980)
c7068ae9331 Respect viewtype for reopen with in notebooks
59b2869bdb1 Distro update
7208128b818 Merge pull request #119377 from microsoft/digitarald/ces
522cb113395 Ignore extension that is being installed
d06d2f1d624 Update distro
80c9c2bfdd8 Adopt writeSync maxSubsequentCalls
dd8ce595220 xterm@4.12.0-beta.7
1eb987f85f1 LocalizationService.update no longer needed. Fixes https://github.com/microsoft/vssaas-planning/issues/3290
70aab480c5a update labels for break commands
49ad7ad4f53 fix optional service typing
a0aea2c02ab Fix counting executing cells incorrectly Fix#119921
961935482ff Fix build
33c5dbf0407 Force internal execution metadata to be transient Fix#119853
0865813de51 showQuickLaunchWslProfiles -> displayDetectedWslProfiles
91b6bcd2cce Fix spelling error
5bf977258c5 Slide to first category for new users
72bb797593f Don't scroll to first category if already have Fix#119842Fix#119339
0a7dde45706 Update distro
9be5cb7f482 Fixes#118772: Remove a disconnected remote extension host from `extensionHostManagers`
c9829c32d11 Surface pwsh as a profile on mac/linux if it's installed
b59b0c5051e update distro
647f8724320 Roll back to `vscode-textmate@5.2.0`
a564f58b13f Fixes#119065: Also listen for EPIPE errors on the socket
99c8eb69942 Fixes regex - codespaces remotes are missing .git
ab39731a1e6 Avoid rolling back `vscode-textmate`
9b564ad40db update distro
85d03e9c382 Fixes#119915: Go back to `vscode-oniguruma@1.3.1`
f4f1bdb9265 update distro
e15a185f6ee Merge branch 'main' into notebook/dev
a6cef60b50f notebook toolbar init display be none. fix#119910.
654b5e80469 update to latest `vscode-oniguruma`
5a92084faeb Use ThrottledDelayer per review feedback.
357c13ac467 localize info message
5dcccb92e38 fix#119854
1ca4e703ba8 Optimizing newly add getting started images.
71d2102d7d0 fix#119803
c5d901812cd Merge pull request #119883 from microsoft/tyriar/webgl_fix
f7cc0f2c79d Adding light and hc getting started images. Closes#115325 and #115327
64256f22d66 Merge pull request #119895 from gregvanl/settingTypos
ad659fb25aa Allow null in profiles config
3e6f65a3acd Merge branch 'main' of https://github.com/microsoft/vscode into main
a30b6bfdc3b remove default value for overrideName
19bbe2edbee Remove extra space from error message
7ac7d4438a9 fix#119672
975115a2cb4 Setting descriptions typos and formatting
fe6b3e258b6 Re-enable measuring
c5a8eed0334 Accept array or single item for output items methods #119601
996391b87d3 Move proposed api piece into stable typings
6ebe2a14f37 fix#119852.
3d1d01690df Fix canvas -> dom fallback
da992a171e2 fix scroll cells from bottom view.
9ab0fb227ee use app scope
81a08478ef1 updated notebooks
ff869cd3581 Merge pull request #119878 from microsoft/isidorn/notificationVisible
1a184f9e9dc add visible flag to notification
b70c4fee0d8 Fix default webgl renderer
ad026f8130c ces: use ThrottledDelayer
755cbf5412a Merge branch 'main' into notebook/dev
08c4cd87e3c Reenable localization tests.
5064fae294b Fix#118134
e8111f76b5b Fix#119855
5b636c4a7b2 Revert "Fixes #111814 (#119475)"
6f726bcdf6a fix#118442
557c4b56995 update verification members
63f1721ed85 don't store output in GH issue notebooks
05ce54df77c testing: remove unused contributions
ce9298464e4 bring notebook actions back to editor title bar menu static.
ceff50539f0 re #119706.
ef80780f632 fix#118996.
383fb64cc58 remove displayOrder and fix#119830
81ba1dae860 Fix#117540
1a425eacb83 Accept single outputs or arrays in execution task output edit methods Fix#119601
75ed057885c fix#117937
1e6697ed77d fix#119561.
f0eacf87700 fix#119767.
1d3cbad0102 Wait for extension registration when resolving notebook viewType Fix#119686
ab317a2280e Hide select terminal profile in yarn web
a0e8b01ec49 testing: polish wording of testing.autoRun.mode
189fb15df90 Check PATH when validating non-absolute paths
5c6836eb44d Fix#119699
b63cfb3a8b6 skip test and remove unused code
8d6c2a23888 Make drop shadow much more subtle Closes#119633
23713de2bee don't emit events when splices are empty, fixes https://github.com/microsoft/vscode/issues/119608
5a241c767a9 fix https://github.com/microsoft/vscode/issues/119363
22212f5de84 use APIs over commands, fixes (?) https://github.com/microsoft/vscode/issues/119437
bd2402a6e8e Add double-click to collapse Fix#113248
c45540033a5 Aadd messge when getting started empty closes#119496
d115bb2a977 clean up statProvider, use existsFile, fix#119807
008e91bd7c9 contribute editor toolbar actions by checking active editor other than focus/blur. fix#119706
38160c823c8 Fixes codespaces fork on push
d765f3a43c7 testing: fix list view not working
0fb1882984e fix: items from results being added to collections and breaking decorations
ab94ad2b8f5 clean-up validateProfilePaths
46d5d38dd28 fix#119672
ebec68bc3d9 fix#119728.
2616ee94f38 fix#119775.
6384c7462f8 fix#119677
abaa23cdf39 fix#119774
09f43fd6aa4 testing: fix exclusion filter in view
e4bb4c1b77f testing: fix results disappearing or not showing for new files
cd31f2cdfac testing: fix test appearing on first line, remove location from TestItems
60849897630 fix#119773.
15ba6b4c957 Revert "extract _assertWebviewForMarkdownPreview"
2c232fed6af Update README.md
e3e7fb0b2ab Set explicit mode for markdown preview code
addf2d6d9e9 Fix spelling for gitignore
f8c1ffbb0cf Build simple-browser media during watch
68e582380d7 Maybe fix bug where sync task doesn't get checked
d087b5cf4f1 Add back old getting started flow as "walkthroughs"
e5afd670959 extract _assertWebviewForMarkdownPreview
d13e68e6cf5 avoid markdown preview removal when it is disabled.
8a960081e55 fix#119771.
f1334e055c8 Polish select default profile quick pick
563a617ca2a Applied review feedback and tweaked heuristics
8aac8643d77 Use 'terminal profile' instead of quick launch profile, change icon
64b4f5b934d use final DAP 1.46.0
f04acbd22a4 node-debug@1.44.19
0db170025e4 Fix terminal dropdown rebuilding itself
8ceb8b96153 Rename "expand cell content" to "input" Fix#119762
9e2e6cded21 Change cell pending indicator to clock codicon Fix#119739
ddb7709cbf3 Fix#119700fix#119731fix#119701 Co-authored-by: Daniel Imms <daimms@microsoft.com>
51c403193b6 do no change selections if the action is from toolbar.
7d19db7ad9b fix#119769.
f934e058c75 Fix profile permissions prompt on linux/mac
6dbb3800c5a Fix#116424
b8f5fd7f1b6 debug: update js-debug
c88146514ca debug: bump node-debug
8387a46298e snap-build-linux.yml: use "snap pack" to get LZO (#119478)
792c2318898 fixes#118660
eb135ec46e8 Fix#119626
e353502fb9d fixes#118045
f9d92f0fc6c Fix#119723
948839aa445 Fix#119660
6aa6260a843 fixes#118852
da1ed96b6a8 fix code-cli.bat
aeedd850ac4 fix#119073
2d9069014eb Add a placeholder for already forwarded root ports (#119792)
74cf3fb2021 Fixes#119529: Wait for eager extensions to activate before launching extension tests
5fbba30c046 Better Fix#119573
9a646e1967c fixes#119487
f91c464f1e1 Merge pull request #119784 from microsoft/tyriar/profile_schema
9f37f3f04ee Pull common unix/win parts into shared function
ac74acadddf Only set when win profile is non-null
f4fbc4abd78 Merge remote-tracking branch 'origin/main' into tyriar/profile_schema
a83eb44ecd5 fixes#119488
301e9ac1db8 fixes#119580
a34297a6085 fix#119384
47f0413ea29 window indicator: based on workspace config file location. For #119752
40d104ad84a Add schema to profiles settings
771b0192f43 window listeners handling
27fc3b41ed4 scm: add trace logs for #113803
08d5310eb18 update verifications notebook
8933c1564d0 Don't create a terminal on panel show without proc support
c55aff63798 API feedback (WorkspaceTrustRequest -> WorkspaceTrustRequestOptions) (#119658)
3eb6fec8cd6 Be more specific when listening for marker events
4ad88afc1f2 Fix#119573
42b8129c64e don't emit events when splices are empty, fixes https://github.com/microsoft/vscode/issues/119608
4dedb019f85 Clear data written flag on manual relaunch
1c3990938b8 Fix#119572
443b6f71bf8 fix https://github.com/microsoft/vscode/issues/119363
c6a8cb7f091 Fix#119698
8437d38d364 Fix#119753
a1ecc83a5d3 Merge branch 'main' into notebook/dev
a233c8683a2 workspaces history - proper check for untitled
7a1302a2b6c remote indicator - fix npe
90484dda2b2 shared process - also log if window visible
5245290dc56 file working copy - update test to account for events
2b66dfe0218 skip flaky tests.
d5abce78ab7 Remove unsued var
ff42bf46511 Disable markdown renders by default
279b4d92317 fix#119724.
514eefb789e Don't send execute request for markdown cells Fix#119734
91939fb9e7d handle invalid ignore options and avoid early dispose. fix#119638
548de3ac8ba fix#119708
85770c31911 hide all outputs (builtin and renderers) fix#119690.
a8b8e7bd483 Fixes#118979: Reduce find widget's z-index
11c0904a568 Don't enable the new markdown renderer if accessibility mode is enabled
376b25645be Only show selection if there multiple cells selected
31987b11c6f Merge pull request #117758 from conwnet/main
02b394a1a5c Add a special editor option to control the readonly textarea attribute
a9aebe3bce0 Merge remote-tracking branch 'origin/main' into pr/conwnet/117758
07eb4d9e076 Fix#114965
d7e1da38b17 Fix Linux referring to osx
8d3d8e0cd04 html: add vscode-languageserver-textdocument as dependency
bd18fe9bcec Fixes#119632: Handle `undefined` when validating a range
8c7a3d8f6ca html: fix compile errors
c099b873de7 update distro
0f65e64c2a3 Fixes#119636 - 🤦
76c5d1707cb RunOneScheduler and code cleanup for CES
b3058d60df4 update distro
7b7e3d9e1e5 Fixes#118041: Add workaround for `UTF16` `TextDecoder` eating up `0xFEFF` and `0xFFFE`
c7ad1b9020d Add sequences to type ahead comment
97b2514ca71 include source.id for progress notifications
6349f37d80f Merge pull request #119373 from wdesgardin/fix/replace-pattern-preserve-case
cca8a48b17a Restore notebook smoketests, Fix#113882
3225cf3037a update distro
3b44bb422d3 Only set detected profile if value is non-null
75f796dfb48 notificationTelemetry: id should always be a string
4eb625f0cf0 [html] update service
a53ce8af3b5 update remote indicator on workspace change
11e79c76d89 Merge pull request #119607 from NotWearingPants/patch-3
a780b76b9d5 Keep text from jumping when showing port input Fixesmicrosoft/vscode-remote-release#4729
61eb66d6c4b Fixed recent typo from afca445
64381abea97 unconfiguredPortsAttributes -> otherPortsAttributes Fixesmicrosoft/vscode-remote-release#4732
73b9e6679d5 Update README.md
a535549d893 update distro
f600cd9ef21 Fix compilation errors: update to latest `vscode-textmate`
684a4526059 Improve resolveTask documentation
ab12e39334e update distro
788c9dfdc48 update deps
afca44535df Add a trace statement to be able to track down which implementation handles a `MultiCommand`
9089e0cbd9f Update endgame notebooks
b28d8ca9fe0 use APIs over commands, fixes (?) https://github.com/microsoft/vscode/issues/119437
2bc5e538923 Merge branch 'main' into notebook/dev
ebe56205433 fix(search): preserve case when match start with lowercase char
a6f6b4aa8e3 Add feature flags to control availablity of getting started extension contributions
735e998fca0 update distro
10a74ff5c51 Open to getting started page on extension install
194c37b4cf2 Fix test for latestExecutionSummary init
9fa49ba9415 ignore optional dependencies when webpacking
7a8b665f25a Fix missing prop on cell data
808266d4dec Allow tests to be loaded asynchronously (#119537)
6e2cb85e207 debug: update js-debug
fdc4f23b108 Add double-click to collapse Fix#113248
35ae55affde diff editor output decorations fix.
aac461a3124 Improves behavior for #114945
851a849d2ce Don't validate non-absolute paths
2cde743fe21 Pass event modifier data when clicking on markdown cell
4cb75127664 add quick launch profiles for unix
9c00242866c updating telemetry module for built-in exts
3d987fdc5b3 fixes#117782
084fd5171a1 Terminal profile fixes (#119352)
7483058a0ab update distro
1f5dd686c8f Disable select for notebook preview cells in webviews
a685b5976ba Exclude DSR from type ahead
4b3ba3ea44c Removes proposed api check
44ffe526ffe auto layout for editors in output container, fix#119048.
d4a0fa9ca6d Build getting started service at startup in order to init event listeners
d657779c014 Improve getting started response to slow network conditions for content overrides
efb75d7262e Move override delay to conver all exp service usage
018eca5246f fix#118615 'scm/resourceXXX/context' extension point descriptions were muddled
0179466adac Move getting started service to workbench/contrib Closes#118603
e8290f52f4f run oss tool for 1.55
db670f1002c Use shellEnv (#108804)
64042213ed2 Bumps RemoteHub to 0.1.2
f201f7bc68a Fix notebook test
08cf8038dfd Merge pull request #95882 from jeanp413/fix-95671
4977db85c01 update tas-client-umd
7e719d3f046 Merge branch 'notebook/dev' into main
03e1ce6524d Fix getting started items appearing out of order
4a83a80aa7b update diff output height properly (using closure) on resize.
2949009de61 move more logic into abstractRenderer.
55e56ef9153 add options for controlling outputs/metadata in the diff editor.
0089ba3ae1d Bump vscode-emmet-helper, fixes#112675
c95389a7b2d Fix emmet completions in scss (#118666)
7b96cc4c8ba Implement Execution API (#116416)
4b0118871f0 Adds codespaces lookup via command for desktop
d46eca3d2dd Merge pull request #119385 from microsoft/merogge/fix
7176a40fc74 Add notebook.inactiveSelectedCellBorder (refs #114156)
64a8be3fa24 fix#117691
a2044cbd78d tweak
d909932d240 Fix#118104
33c11ec866f Bumps RemoteHub to 0.1.1
26cdfad1cd0 Fixes#118521
e79b88daadb handle view in terminalView
66961037cc3 Fixes#111814 (#119475)
57aada6cca9 Fix test
5efebbd4c4c Fixes#118270: Add new option to control deleting character pairs and delete by default only auto-inserted closing characters
91e41167e52 file working copy - clarify onDidChangeContent
8cfc30d5741 Fixes#118461: Don't show Open Workspace in the diff editor
c148f9a70bf Show error when port is already forwarded Fixes#117571
d239450d9b1 Ensure relaunched processes get shutdown
76b1ad1d1dc Improve profile order, remove profileName from config
6bac57decf7 file working copy - better document resolve() method
0ddc091edc6 some code 💄
a02448d6852 Ensure config service is optional in external terminal
917edde164f Fixes#117534: Allow to mark command args as optional
2cd8246a94b Fixes#118062
4c29fa41c6d Fixes#119416: Use control pictures for NULL and DEL when renderControlCharacters is on
cc8748a2397 notificationsTelemetry: change id to be string
bbe333f8782 Add tsec exemptions
42c9e63a7ed file working copy - resolve returns void
d9d0879741f file working copy - add save as support and a lot of tests
469e4f6e275 chore: bump distro
67eebf8ac58 avoid duplication.
0ab3c62ca2a fix action context detection.
5a0fe1f6a89 remove todo tag
d6a0bf700cd Merge branch 'main' into notebook/dev
5a66c91c029 Fixes#117935
a3415e669a8 Fixes#119383: Use `fetch` instead of `importScripts` to avoid deadlock in Safari
4a10c93b2d6 Remove unused argument
307ed64376a Adds RemoteHub as built-in
8290994dbbe Fix localization strings and typo
4995ce93673 More tweaks to geting started category
13ec92fe360 Update getting started category styling
e380c34cac7 Fix typos
a1c114aa9e6 replace more pathOrPaths with path
1aa0c31b55b pathOrPaths -> path
e7aedd975c8 Adjust notebook cell multi-select colors
4bcf96223a7 Fix some getting started crashes
0d83680d528 More CES heuristics work
d222e20941c Merge pull request #119328 from microsoft/tyriar/wsl_encoding
e92a80bb641 Merge remote-tracking branch 'origin/main' into tyriar/wsl_encoding
ee4b50aaa43 Allow creation of quick launch profiles via select default shell command
194f43025f6 Remove log
da7c7d1efea Merge branch 'main' into digitarald/ces
4b5354c5f98 alternative version for notebook document.
ff3c423cf3f alternative version for notebook document.
6480a6f20ea feat: add option to control scm font size (#115494)
d60cac30195 Fix a typo
f8acb0d6f63 Adding the 'delete branch...' function to the source control > branch section
6c0c77926ff Improve GitHub repository search
64ebc978e76 Revert "Use rmdirSync instead of rimraf"
0eff78fc42e Merge branch 'notebook/dev' into main
7f9ea9411c8 Reduce default tas override delay to 0
5c0c637a043 Make sure we ignore compiled media files
f5146529508 Automatically relaunch terminals when pty host is restarted
7727e93b22e Rename experiment override settings Log when experiments have been overridden for purposes of excluding data from scorecards
07879df53d9 update the layout since editor toolbar height changes
13ceef289f0 experiment service for nb toolbar position
1cd067471e8 Trims url to avoid issues
022d823577a Fixes#110904 - adjusts error regex
c2b6d30e9ef Fix input placeholders from 2275dba01afe2b8814d4ebdd67d1027fa51bdcb4
b1770e6ad8a Prompt within 1-8hrs heuristics
df3953996da notifications: send telemetry for silent notificatinos, smarter spot for hide event
f7f2f08eec5 Update distro
1b7470b25db Try to find ports with a root process (#119341)
421d67ec41a notifications: add source to notification:hide and also send events for silent notificatinos
2275dba01af Change files to include/exclude placeholder to tooltip
3d87801cb0c Merge pull request #119091 from microsoft/joh/nbSerialize
9734ab15dd6 💄
88e87f02bd6 file working copy - make resolve not return "this"
b74bae8ced6 refine NotebookCellData converter
d6c74de1f5c Merge branch 'main' into notebook/dev
61b73024053 Merge branch 'main' into joh/nbSerialize
3a6c54fb14e no more file watching in notebook diff editor, remove lastResolvedFileStat from notebook editor model
39ea9cac052 Make UI progress indicator clearly visible in the quickpick (#119293)
8cf7c12fd33 fixes#119331
d10866cca54 Fire onExit for feature terminals that lost pty host connection
7fa2b715ef0 Merge branch 'main' into joh/nbSerialize
b33801c2c66 file working copy - first cut tests
8736be196db Properly join string[] profile args
f68f1845d23 Move comment to the right place
2b2ff3e5e08 exec with the right encoding
ede3632a560 pimp up workbench-web.html
85cf30ab517 Properly decode wsl.exe -l output
163aeeedac7 Prevent seamless relaunch triggering multiple times
c64a8d59270 file working copy - use IDisposable not Disposable
bae75adfb41 no more double dispose needed in _onWillDisposeDocument
af10c8f65b5 Fixes#119051: Prefer fewer diff hunks
3271248da68 Merge branch 'main' into joh/nbSerialize
7902c6edcd1 remove NotebookService#destory
c8dc60adac6 Use widget.shadow for custom hover contrast
a07a508be8b Update distro
a02fabb6d64 file working copy - dispose model when working copy disposes
dfe12887da0 xterm@4.12.0-beta.3
06901e67a38 remove todo
3fd2415c9f7 Show args in profile selector
46d1ea3a2c8 fire event only when save succeeded
8410aa8f2e6 adopt name change
fee37f32af6 Merge branch 'main' into joh/nbSerialize
3f71de52eef Also exclude docker-desktop terminal profile
7d99c47b755 move notebook save event into notebook editor model service, remove resolve/save/backup from notebook service and let editor model use content provider directly
06e8814b29b Merge branch 'main' into fix-95671
5dad121bcb1 Merge pull request #119315 from gjsjohnmurray/fix-119261
a255250be89 Add a user setting for "workbench.hover.delay" Fixes#117894
156fed280ac fix#119261 filter also by description in Insert Snippet
1dbcde0f1fc Fixes#119065: Handle errors also using the socket.write() callback
958171a700d Fix port process finding starting even when using output
56b55c26070 #38607 Handle uninstalling extensions
a27b6f74497 implement load of the notebook model
f841a70b0c0 file working copy - rename `forceReadFromDisk` => `forceReadFromFile`
c8975ceaecd file working copy - remove getStat() that is only used in tests
8595f6f5d03 Update to align log level constants
23fa2860d3e add withNotebookDataProvider as strict variant of getXYZ, sends activation event, throws when no provider found
c17a5ca80f7 Merge pull request #100027 from matthew-haines/master
bed126ce9d7 #38607 Separete installing & installed state
6608083a3d4 💄 window error telemetry
ce3ebc9f5a6 add test
391b1a6b576 Add support for `"log": "<level>"` to the argv.json (fixes#118824)
d96f34c867b Fix#38607
e800c205df8 Merge branch 'main' into pr/matthew-haines/100027
b4fb4d8c2ff recognize .axaml as xml language Fixes#117298
abd1e0166e9 Merge pull request #119250 from noahbliss/patch-1
414a7eb7e06 Fixes#113614: Catch potential errors thrown when searching in the extension gallery
9710ecf1c66 Merge branch 'main' into notebook/dev
af8d8116eec Merge branch 'main' into joh/nbSerialize
9b5eceb1f66 💄
4f1cdb7aa0d flaky suite for #118969
d0f2d7eee63 build
e4b1e9ac57a Give room for border
0932039e138 Allow for exp modifications of getting started content
22c40603121 Extensions => Command Palette
5e0602716fe Small tweaks to styling.
fb8811e513b Add "copy cell down" to toolbar
7a9844238d8 terminal profile fixes (#119267)
c0885dd0c4d Add task to build extension media (#119294)
b0f4dba5d29 handle blur from other browser events.
3eae316f513 more padding for global toolbar.
99dd29307d1 no layout if not visible.
6d654b9bc9e polish css.
a99306b4871 Update padding for notebook toolbar & folding icon
fbcd54712ef fix duplicated actions on reload.
41ecc1eda5a cell output domNode npe.
c37f743a99e schedule task should check disposable again.
b814edf4735 keybindings for actions.
ece0761b33f swap notebook toolbar and editor toolbar.
1b52d828711 Revert "fix profile tests, path -> pathOrPaths, and exception"
a5219a9350c path -> pathOrPaths in terminalConfig
e9e112a6483 fix profile tests, path -> pathOrPaths, and exception
859edd7f4f0 Merge pull request #119292 from microsoft/misolori/get-started-polish
89135921788 Increase bottom padding for card
45ef6493842 Adds support for fork on push for Codespaces
f8b50611060 Polish getting started items
3b3b9be7062 Fixes#113811
746c323a55a Merge pull request #118830 from microsoft:aeschli/testsinwebworker
242ddc4bdf0 Merge pull request #118400 from thebinarysearchtree/main
c576cad0912 #38607 make renaming extension aware of other sources
89d8eed14f0 Allow extension authors to set the title of a QuickPick/InputBox in Options (#119144)
31a9b8f8158 Fixes#62307
14c4257e75d Fix background for markdown cells
651f0ee28a1 Simplify removal of (Default) from distro name
aef8a2af5c6 Improve encoding workaround for wsl.exe
9d2478b6259 Don't name quick launched terminals
a7bafc2a9a5 Add logging around port notification Part of #117790
342a55d10d7 worker eh: wrap console and send to renderer
7c4b2b09de1 add workbench-web
2ace42b0cc1 Don't attempt to create term in yarn web
9cd4712b352 file working copy - update todos
6bea69b5e2d Fix break
3a39aa41f5b Fix hiding tree hovers Fixes#118755
65fb4037a39 adopt latest working copy changes
59ee7787595 Merge branch 'main' into joh/nbSerialize
232266aaf22 first cut of IFileWorkingCopy adoption, misses saveAs and backsnapshot are improper...
2d7b64d423d add notification:hide event
9c204017ffc file working copy - remove _backupSnapshot
be93116b735 Replace "Favours" with "Favors"
9f773417714 Replace "Favours" with "Favors"
a23d2d40f31 Merge pull request #117994 from GitMensch/patch-1
4c9d23c8f57 file working copy 💄
adf6e065194 Fix ugly selection border on Add Port button Fixesmicrosoft/vscode-remote-release#4689
0b758c4e0d6 Unix profile selector (#119213)
abbd77d0188 Merge pull request #119075 from microsoft/isidorn/notificationsTelemetry
99d2cb82e59 pick up notification source ID properly
5804f7dd83a Merge branch 'main' into aeschli/testsinwebworker
8af8a869dc8 Merge branch 'main' into joh/nbSerialize
3da9f36645d Cancel packagejson search in npm after 1 second
c359effab04 Fix unconfiguredPortsAttributes in devcontainer.json
abb6ff6d93e file working copy - dispose working copy when model disposes
733f9323a46 Initial file working copies (#119233)
970d1916421 file working copy - self register to working copy service
1902dcddd8a file working copy - add onDispose
6d02fe2cb75 fix#118945 validationMessage on extension InputBox lacked Severity.Error
943ab428d72 file working copy - more cleanup and alignments
d2afd69d310 file working copy - some cleanup in working copy
111a6cec70f Don't include build files in repo
3e4c057624b Make sure we exclude ts files from published build
043a0ee0d94 Try cache busting on reload in simple browser
b9f33fc242d Rename CodeActionKind.Manual -> Invoke
52201359920 Scroll the notebook while dragging a markdown cell
e7f3b77a9c8 Remove typings for unused package
a7ae58f4dbb Use rmdirSync instead of rimraf
05e970086cd Add missing change session events to ms auth provider
b0bbf9c19ee improve pwsh logic
e01b60782ae Exclude compiled notebook files from hygine
42af2c38dd2 Merge pull request #117835 from yannickowow/master
7ccf0b03c60 debug: stepOver should be alt+F11 on windows browsers
8a095f4d233 Update test associated to DataBreakpoints
cf7e6f31f9c Support for DataBreakpointAccessType condition #117835
82cf09af92e file working copy - first cut manager
c332b6bea79 tweak grammar
31f3f2e6195 Add placeholder text to include/exclude boxes Fix#119107
547312993f8 provide extensions sync state version api in web - reset the resource sync state when the version changes
6f0d3d5c9f5 debug: do not de-dupe same named variables
fbc577e6f04 Double click to set port label Fixes#117573Fixesmicrosoft/vscode-remote-release#4624
5b21b951ecf Fix Add Port row click Fixesmicrosoft/vscode-remote-release#4687
fc1d49f95ed file working copy - make sure to bubble up errors
03e3fce973e file working copy - first cut extraction from text file model world
b335d9eaf10 Make "Set Port Label" an inline action only Part of microsoft/vscode-remote-release#4624
fdb91e27d3d Add new unconfiguredPortsAttributes to config edit
a268122729d Add more docs to PortAttributesProvider Part of #115616
1c6fcca5710 Fix#115039
c9fd3403447 fix https://github.com/microsoft/vscode/issues/119157
b12279b40c5 Get correct candidate for checking port attributes providers
fd57115d52c Allow for manually/programmatically checking/unchecking tasks
b353f063393 comment out failing notebook smoke tests, https://github.com/microsoft/vscode/issues/119164
06ee68d4bbf api notebook update
5bb215e893b Increase spacing between tasks
26a77fb7fb8 Clean up formatting
08877abd68a Relocate keybinding rendering closes#119113
970bcad11a4 Fix bug where expanded tasks did not adjust height on layout
1bcf2a3f1dd Tweak getting started to look more like welcome
9e470ce1efc chore: update distro
0585c2e05a6 Remove experiment (#110330)
ff1ce589e73 fix#119130
fc8d7681c4a Make sure katex styles are shipped under root of
581a659d427 Update markdown notebook scripts
806c22dcc91 Skip multiple tabs test for now
a7006f93215 Fix potential null access
f6f51117008 Update walkthrough contribution api to single object model Ref #119097
e8e6d64105b Terminal profiles (#118790)
e5fc49d8af8 Fix markdown editing code cells not having top margin
c09b3d2358f typescript: enable built-in 2020 semantic token support
1b695635457 Enable markdown renderer by default on desktop
83d80e8bcaf Don't try to relayout markdown cells if their height has not been set yet
772effc6e6c bind mimetype switcher later.
9063d4ac766 finalize InlineValuesProvider API; fixes#105690
9205c8bd920 Improve terminal key dispatch message
5615bb9eee4 Merge pull request #118725 from microsoft/joh/117273
a6b7fccdaab support appending per mimetype.
7af7449a295 add extension id to source of notification
a294694b583 Fix padding in webview based markdown cells
a7bbb5502dd notifications.test add tests for service add and remove events
99597e3974a delete cell handles multi select.
b3e7d37b8df clipboard actions handle selections around the target.
562962afc9e move copy,cut,paste into clipboard contrib.
30845ba2037 Include community in README.md (#119105)
19ac5d4a5c5 Merge pull request #119114 from microsoft/tyriar/118804
9ed0aa6c914 Fix type ahead issue in relaunched terminals
7243e13db16 Fix#118818
8303d03545a aria alert for cell index changes.
5f4e9a55f5a join with next cells through multi selections
4f488a7cf21 support both selections and ui actions.
4d3df5cd983 join cells with multi cells (single selection)
881e370539e add tests for joining single cell.
3f7651fed04 move join/split cells out of coreActions.
184560bb0ce tests for moving and duplicating cells.
4855eb46a0a make notebook unit test easier.
3ee43778c50 Merge pull request #119092 from microsoft/tyriar/118066
29abc8f3499 Merge pull request #119024 from microsoft/tyriar/116022
3e05837735a Merge pull request #119084 from microsoft/tyriar/118256_test
143f4e6fa2b Merge remote-tracking branch 'origin/main' into tyriar/118066
7a6944d2d0d Add unit tests for TerminalRecorder
5141aba1941 polish
7c0e20ca4c0 Allow terminal recorder to avoid initial resize event
b6921c2f2d6 api notebook snapshot
9a7366de9bd Prevent process ready log firing multiple times
32406c3f6ab Recalculate trust when workspace folders change
b1359b271c5 Fix focus + keybinding issue causing input box in Ports Fixes #microsoft/vscode-remote-release#4678
0cd2ba8bddb Merge remote-tracking branch 'origin/main' into tyriar/118066
df97bc32ada Tactical fix for watching problem matcher and closed documents Fixes#116760
508b6cc7864 💄
f56b5cf7cef react to feedback
b38200cf0a3 Ignore testWorkspace tasks.json
2d536914ea1 Await task config updates
f0ee79acfd1 Update src/vs/editor/standalone/browser/simpleServices.ts
846917d51fd Update src/vs/platform/notification/test/common/testNotificationService.ts
77e2397c121 Update src/vs/platform/notification/test/common/testNotificationService.ts
3765294bb11 Update src/vs/editor/standalone/browser/simpleServices.ts
5da95f0e11d Merge remote-tracking branch 'origin/main' into tyriar/116022
31283f32b2c keep notebook serializer locally
d1e5c8cddf4 Fix portsAttributes.unconfigured setting name And fix setting update not read Fixes#118991
e8f5186722f Improve task test layout
76cd8a00b37 Fixes#119011: Wait for the vscode API to become available before launching extension tests
1b9a61662a3 Regression test for #118256
b8476ece198 Fix task start firing with invalid process ID in dependsOn task
6fd693ec9e9 more deprecations
f2761b584a4 ignore file events while saving, more logging, https://github.com/microsoft/vscode/issues/118992
9426cea171e Ports: service -> application, defaults ->unconfigured
b33ce0ff5d9 Update types
2de06d768bf add INotebookSerializer interfaces and wire up IPC calls
3014c755cd7 Pick up fix for #117054
21d20148ee5 new debug setting for clearing a terminal before reusing; fixes#116699
70abcfc7689 add notification:actionExecuted telemetry event
66045febfe4 add notificationsTelemetry
45ea71d8c37 notificationsService: onDidAddNotification, onDidRemoveNotification
149a8b71c53 Workspace trust changes (#119017)
e787d6e3843 custom editors - make conflict resolution actions appear (#118949)
5060cbe7bc0 Merge pull request #119012 from Daniel-Knights/patch-1
537c648fb57 mark APIs as deprecated
b5eff84359d fix build
b89cf5c0aff Adds RemoteHub to api allow list
4222a0981e2 debt - use product quality instead of probing for name
a7f5a101589 debt - some more process and platform 💄
892a1083cb2 Fix border overlap in quick pick UI (#119039)
405d2cfbda4 Merge remote-tracking branch 'origin/main' into tyriar/116022
70a47bb275d Enable vscode.Pseudoterminals in web worker ext host
813bb397b01 update list item height on markdown cell ctor as we might already warm up the viewport.
fbf1e77578d adopt multi select in drag and drop. drag the focus or selection around the focus.
84f16040107 share drag impl for builtin and custom md renderer.
12adb0178f6 test view/model range convertion with hidden cells.
51a15dee0a2 update seti theme. fixes#118912
7f43e5c846c unHidePreview should also update dimensions
d949fd3bc09 Don't create markdown previews if cell is in edit mode
2f8d4892884 fix: typo
d7c0ea59d23 Rename setting gettingStarted.hiddenCategories => workbench.welcomePage.hiddenCategories Fixes#118990
8e2fc51526a Remove only
f390023d7e6 Remove unused
385cb56165e Fix#118953
5e09ecb9ab2 Fix#118958
83b6cdc6107 better aria label for the remote host status bar item
ad428ea8910 untitledHint: introduce default for workbench.editor.untitled.hint
98d129e8b9f firefox: do not use ctrl+shift+P for show all commands since it is taken, make sure F1 is rendered
3cca5540aa8 Do no install repo on Raspberry Pi OS (#118826)
c4fbdc32275 accessibility: 1000 page size as default
393adbd3971 fix#118970
61e44238a28 💄 process use
393cc7f4a22 debt - consolidate process usage
cf439681f6f multicursor aria polish
ae510aec2a7 no indent after 'source' tag: for #118902
fe1264b0f2f explorerModel: add toString to explorerItem for more precise error message
094274f0d1b Don't show select default shell when proc support not registered
d1bffb783a5 Merge remote-tracking branch 'origin/main' into tyriar/118066
a4adb60e883 Add "Copy As..." core submenu to editor context and Edit titlebar menu (#118212)
11b1f937eb1 Prioritize port label from setting Fixesmicrosoft/vscode-remote-release#4542
2ac67ce84c4 fixes#118951
7a55f6fed7a skip failing notebook test
3f81fd64303 🆙 distro
e8c71c048fa use %~1 in bat files
c7a86c07979 🆙 distro
68a252ea778 environment - depend on product service
eb90b1c59c6 sandbox - extract IPC based file service (client) and improve runtime behaviour
f241e2e26ac debt - inline deprecated amd.ts methods into tests
8f1b7a36def sandbox - allow to reuse environment service in sandbox
1441ba91f0e environment - consistently handle VSCODE_CWD in all our node.js processes
56ee90e32e3 path - never use fs.promises.realpath
3d626dd868e Use "%~1" instead of "%1" in bat argument parsing.
640fa1af29d debt - use product service in more places
0e05a1f21a1 fix integration test
819cb01e0e0 make notebook integration test more stable, fixes https://github.com/microsoft/vscode/issues/118889
84fe402d655 Improve getting started page - Allow clicking checks to dismiss items - Allow hiding categories
e05ab31f373 Clean up styling when contrast borders are defined
a90759b5395 fix build
3006ac8e940 try out multiline extension view
5ad7633c4e9 fix scrolling body for workspace trust editor
809e11134c1 fix css for extensions grid view and settings
1a5d7f4f8ed Merge pull request #118482 from microsoft/rebornix/nb-list-focus
b81cea2a350 Fix Emmet abbreviation for Handlebars style blocks (#118832)
257fbae3f34 Ensure editorContextKeyService on markdown cell gets disposed Related to #118782
e1f84e38ab2 Ensure markdown cell editor is disposed Fix#118782
216bff57715 Merge remote-tracking branch 'origin/main' into rebornix/nb-list-focus
eac163c0611 fix tests.
c1f954ce48b optimize scroll view from bottom.
5af4ccb87be copy cells with multi select.
ad7983834af extract clone cell.
34a537bb732 sort numbers.
162d08892db Clean up
569aedce014 Mostly working seamless relaunch
7806efac02a tests in webworker EH
ffdef6b9be7 Fixes#118759: Render a separate span for each inline decoration
458904ed7a3 move cells with multi select
e545c0750b8 copy paste with hidden cells.
17beaf29fd5 Fixes#118614: Clear any outstanding state / requests and fetch semantic tokens when the language mode changes
8ca6a56d467 Try restoring ports more often Part of microsoft/vscode-remote-release#4551
d7622d392b4 change back untitled hint default to be hidden
edf387a2e8f run filename through realpath because it seems nodejs isn't always doing that, https://github.com/microsoft/vscode/issues/118812
1c9e7eb296e 💄
5a8936ae639 Lift native text file service to electron-sandbox (#118815)
1bb87db91d3 debt - provide groups merging from service and add test
0b4915dcea2 Change portsAttributes others to be its own setting
61fe79db654 Remote indicator for folders and workspaces from contributed file systems. Fixes#118813
55bfe8c2167 Merge pull request #118766 from microsoft/aeschli/extensionDevelopmentKindSimple
5109a52b2a6 explorer: use findClosesRoot in select()
3aca77c0161 Merge pull request #118777 from jeanp413/fix-118557
3eae8534747 fix#117093 update Filter on Type indicator after 'list.toggleFilterOnType' command (#117099)
9d220a95c1c Fixes#110885: Have `--max-memory` also be applied to the extension host
bd74e2fb6a0 replace openOnFocus with selectionNavigation
5f451c6670d Merge branch 'main' into aeschli/extensionDevelopmentKindSimple
1f22e55badd sandbox - share most desktop.main code
d6d2910b96b sandbox - use actual workspace and config service
1dce5d35536 replaceCells as a single edit.
ebc6eade483 update prefix sum always when edits happen
fe9466a6e1d false negative hidden ranges test
4f5824ea28b enable async tests.
3dff030ea14 delete folded cell would not change other folding states.
5e2f573d1dd cut multi cells w/ folding.
06b54543d66 Comment out a few error logs for now
498449fa8c1 Remove content version logic from webview
02d3ca91dc7 Make sure we update cached version when cell changes
544b117130a createMarkdownPreview should only create previews, not also update them
1e92de9921e Log errors and remove unused method
574740fed37 NotebookEditorWidget should not have to know if a markdown preview already exists or not
b5e22e7ed43 Remove extra log
6ea4b1cdc1a Add version to MarkdownCellViewModel
97314005fca Revert move change and disable debug flag
aeb8f3811d6 Avoid re-rendering markdown cells if they have not changed
4b9d29ae6b4 more polish and re-use extension grid
d5f47dfb885 Notebook custom markdown renderer optimization (#118288)
3635f113876 💄
b4ebf03316c selection tests.
0dcf9300ddf Fixes#118557
e9b7b5d25b8 configure extension kind of extensions under development
63d6e0c008a adopt selectionNavigation.
46fd12b0a91 align selection and focus if they were both empty
d31566b57f4 Don't include css in main katex bundle
8627fd1f883 Merge pull request #118753 from microsoft/alex/extension-test-running
a97990c9713 sort indexes in cellIndexesToRanges
919292a6742 Merge remote-tracking branch 'origin/main' into rebornix/nb-list-focus
ae4ffb1b81e Handle extension test execution on the UI
52ab2fe123f add Education extension to category constants (#118589)
ac0008a25b8 Remove waiting for welcome page while we are experimenting with what the welcome page will be Fixes#118748
8f8321d638d Smooth relaunch poc
d574f8e9163 remove duplicate code
63460db67ea Fix#118741
d5e4525830e Add comments to add java workspace tags to GDPR inventory (#117740)
1ad8c467972 Merge pull request #118574 from microsoft/tyriar/100709
5afac656035 Prevent double attach to pty host listeners
ba8f0fff7ca Remove logs
b92b610e861 mark isEmpty as readonly
f2515c57a4d Fix repository link for vscode-references-view
bc405e936fd Try new CSS grammar Fixes#115480
244428dfa7a sash: workbench.sash.hoverDelay setting
10fc457d699 💄 sash
f8ce2745c05 add stdout and stderr mimetype, add renderer for stderr
97efcde244f Merge pull request #118664 from microsoft/aeschli/extensionKindController
3fb39ad72d6 fixes#118694
bd84f143797 Merge remote-tracking branch 'origin/main' into tyriar/100709
37a826fe75d Open Recent goes to wrong workspace from remote. Fixes#118683
6af126bb3ce Move to writeSync instead of writePromise
49cad9a1c0d Fixesmicrosoft/monaco-editor#2382
0740b4a3134 sandbox - move platform limits to common
fdd57917f30 don't mixin default metadata when "replacing" notebook metadata
9a982d0049f fix configuration caches - respect scopes
d7854c3914c Remove unused
8788d628814 First cut of moving to hybrid getting started/welcome editor
9b2ee7fb7d9 Reduce size of Katex bundle
da3cbe74dce Avoid extra postMessage call for iframe based webviews
8fefa6aff22 Speed up mac builds (#116984)
984479d1792 Fix not being able to run a cell when it is in the Success or Error state
07d02d3e2b1 use new icons
638926d5b5d CES experiment treatment
2d7fdd82ec8 update connection state before reconnections
f3f1c131385 Update Codicons: add trusted workspace icons 1f495f5857
b1b80801806 Avoid some calls to `.then` for iframe based webview post message
5b5dd906551 Fix manually providing PAT for GitHub auth, fixes#118675
11d5e82c80c Fix any key causing shift+tab focus change
c72d7612b41 Add an untitled document data property (#115790)
371562f630b move trust color tokens and update values
e679983a3fc remove border, use color icon, use link button
1f2313b4a2d Add back custom editor test workspace
0f6d7c41eb5 introduce customEndpointTelemetryService
268c0d04a66 fix#118578. offsetHeight to include padding and scrollbar.
d1db6f0efef notebooks: update output to match NodebookCellOutputItem api
7cae7b5cedf add ExtensionKindController
a2b5e58b091 remote authority - update comments
75da06499c2 #101995 extend tooltip of menu item that defines 'alt' command (#116211)
3ac310d1cf9 Remove icon from input row in ports view
3dc05e36e15 list: anchor trait
913a5949445 cleanup debugHelperService
f1f830aefa2 Fix User tasks only working once without folder Fixes#118370
27ce1eb630f list, table: selectionNavigation option
6be4a142367 fix https://github.com/microsoft/vscode/issues/118609
8fd24025701 :liptstick: deep freeze notebook events before emitting them
6c6db188b7a polish, avoid classname.split('')
f0c44394d11 Merge pull request #118433 from microsoft/aeschli/openWindowsWithAuthority
637b659e4ad refine NotebookCell API
afe0e2b9a77 Fix regex port attributes over applying
278a41c349b Show Open Preview in Ports view for public ports
a6d7d86e857 remove `viewType` from openNotebookDocument call
da562fa27c5 Add regular expressions and "others" to portsAttributes Fixesmicrosoft/vscode-remote-release#4623
b3e6307430d polish
1422de11110 sandbox - move performance.contrib to sandbox
abea343c10e fix https://github.com/microsoft/vscode/issues/118369
b0f0b6125dc implement review comments
23e0d141edf Update src/vs/platform/windows/electron-main/windows.ts
d383642ba20 Update src/vs/platform/windows/common/windows.ts
78224b9b9e9 refactor perf contribution so that they can be inside electron-sandbox, https://github.com/microsoft/vscode/issues/111211, fyi @bpasero
f83b2f46dee shell env: add more logging
1d6241a8a08 prefer ReadonlyArray<T> over readonly T[]
94303f8e574 build
256ce60286b Bump elliptic from 6.5.3 to 6.5.4 (#118478)
623075e0962 update distro
a713ca6204c Merge pull request #118596 from alienvspredator/main
420f8dde79f debt - more layering fixes
f0321e30875 debt - layering fixes
9d8042db309 more jsdoc around workspace concept
a19fac2442c better docs for #118566
96fabf5cf95 fix#118591.
6d079845776 fix(typescript-snippet): fixed "newpromise" snippet
1d686afe81c reduce grace time of remote terminals (#118571)
a9087e9d0a9 Try to avoid extra promise chaining for posting into a webview
cbacbe647c3 Fix markdown preview still being rendered while in edit mode
54f30ed19ce Lock to commit rather than tag for Azure login action
3244facbbbe wt editor stepping stone - make extensions list better - centered header style
d4ee684c8de testing: show progress in status bar, minor refactors and cleanup
80112e79ffb testing: show total number of tests to run
5b41604444b testing: add more logical default autorun behavior
7a9e144ee15 Fixes a listener leak with ILanguageSelection
57155e84203 Fixes#118195 - avoids update if already set
bcb8c8a4f4b Remove notebook document runnable metadata #106747
8454701b67c Update test for api
225a8c2b89d Infer cell "runnable" from notebook kernel state Fix#106747
7a19d09047d Begin eliminating cell runnable metadata
d1164661d29 Fix markdown edited cell height on reload
c77e5ccd947 Add back top margin for webview cells
d299be88ea6 Updates proposal for #116906
556e6d8310f Fixup search smoke tests
58bd8e075a3 Fix spelling in comment
ba54c76164b Use TS replacement span if returned
724bc08f906 Remove log
f2d687752c9 Create a new pty ready promise on relaunch
65e4309c0d9 Directly expose environmentVariableInfo
37c54c79e0d Fix compile
7f94f0d97c2 Move some ptyProcessReady usage inside proc manager
3cc479953ca fix#117718 fire onDidChangeResources event after unregistering group
a7c9230fb33 Update distro
d6f4353fae4 bump distro
9eceb504987 Move label about for #115244 after more tests are failing
f8a6f90dea7 Revert "chore: bump distro"
e5a10ca55d6 Skip search tests while diagnosing flakeyness
88655de6104 Adds logging
6922f6150d8 xterm@4.11.0 Diff: https://github.com/xtermjs/xterm.js/compare/a73fe62...4.11.0
79e2119c5e6 Revert "snap: set compression to lzo, #117852 (#118116)"
43ced8a10a3 chore: bump distro
0f042b2c856 fix https://github.com/microsoft/vscode/issues/118569
0e43220113c finalize telemetry enablement api refs #110267
95d3c1e63b7 finalize isNewAppInstall api refs #117058
e60b94d6e9c Merge branch 'main' into digitarald/ces
6438e0564af Add 'Marketplace' as option for file on and remove as top-level type, #118473
17c67963f32 api work snapshot
112bd090027 Queue file operations
4ee2ef41e5b update cache on reprocess
0f64ef1b655 remove NotebookDocument#contentOptions
f0cf34e073b debug: do not bind F10 to step over when on web
eaf4a6a91b7 Fix debug console URI being decoded (#118226)
417b7803a18 Update distro
2c11dafcc2f Merge pull request #118252 from microsoft/tyriar/116467_2
dc92ff53548 Set distro back to that in main
4bb960ade60 Merge remote-tracking branch 'origin/main' into tyriar/116467_2
b02e102f480 untitleHint: use expereiment service
90efd0a81aa Update README.md
449158a1aa7 Some Ports view cleanup
b8a320867e5 allow null for remoteAuthority in IBaseOpenWindowsOptions to force local window
637497076ac Update distro
1e7fbfa7674 Merge remote-tracking branch 'origin/main' into tyriar/116467_2
e7b0596d89a Revert "Comment out notebook compile error"
aaf6287eccc remove skipped test
e96f0ea3700 todo-tag
7bcec044268 Comment out notebook compile error
878526839a3 Update distro
364b9e98e83 Merge remote-tracking branch 'origin/main' into tyriar/116467_2
ab9e11f38e6 Remove resolved comments
e2ba7c6ae30 Breakpoint inline edit button should be a submenu
27efd88041d Remove preconnection terminal concept
4db71714ebd Properly dispose everything in tunnel view cells Part of #118544
9cc276648eb remove onDidChangeCellLanguage-event in favor of the existing document closed/opened event sequence
55af8021a12 Simplify RemotePty, revive shell config cwd
e373b9c59e2 Focus row when escaping input on Ports view Fixes#117771
3c96cb6254a Merge branch 'main' into aeschli/openWindowsWithAuthority
99e97da512b revert unnecessary change
d1dbb93317a Remove remote test failure comment
6d01ad952a9 Merge remote-tracking branch 'origin/main' into tyriar/116467_2
e15767f6dcd add comment for remoteAuthority
5ce792fcfad Add SECURITY.md
98a22a957a2 declare cancellation support for openNotebook and wire it up, exempt notebook content provider from provider naming rules
0e04c15de4f assert unsetting of active notebook needs null, https://github.com/microsoft/vscode/issues/118470
bcfcb539ab5 unit test for https://github.com/microsoft/vscode/issues/118470
8c436826ae5 Merge pull request #118471 from DonJayamanne/openNotebookBug
30d699fa104 on fire active notebook change event when something changed, https://github.com/microsoft/vscode/issues/118470
425316c3764 Add a compose language (#118042)
63be79e67de Merge pull request #117062 from NotWearingPants/bugfix/rtl-cursor
edfbf27e3af #118443 - change name
fa6d38a99b3 change nls ids
9d3a1d9f59c Fix#118443
6b76fcb671e Merge pull request #118468 from spetrescu/main
7d96db1e51b Make underlined link buttons blue to match the styling of similar buttons
27975dad4fb move to IProcessEnvService where appropriate in default shell logic (#118271)
ac229ced073 Revert "Reenable smoke test to see if still flakey" #115244
09c3c2d3be4 Remove broken part of test
11a84a6e8ac inset -> output.
b62e3c7d1db Update distro
5fdbc82111f Re-enable task and term test
9878ccfbd74 remove markdown preview only when it is hidden or deleted.
250c7baf7e8 Fix#117903
c870a55b708 Update terminalProcessManager.ts
8fe29a7c415 Uncomment in test
30f41631849 Skip the failing test for remote only
d89e8cd27ce recent entries with authority
c59c1101162 revealView should scroll a little to reveal items below viewport.
d4f8348c6ac Handle undefined extension publishers in issue reporter, fixes#118480
61301530c69 revealView should scroll a little to reveal items below viewport.
23ad719498b Log acceptTerminalOpened
bdbf5850127 Bump vscode-emmet-helper, fixes#118363
0e8fba32637 Add outline offset for view actions (fixes#117349)
9b1700a8291 example of notebook specific navigation commands.
2c1037d3521 Fixes#117600 (#118397)
b20839c1f3d Add 'Marketplace' issue type to issue reporter, closes#118473
a8739f9c3a5 Change messageDisposables to DisposableStore
2b9470cb4e1 Clean up SearchView link button code
31a7757fc7b Better "Open Settings" option in search view
18f16643ead Add button to reenable search excludes Fix#115352
244e9e6e793 set remoteAuthority in NativeHostService.openWindow if not yet defined
1761ecec3bd reduce selections.
b6b9aa15ef6 debug: allow passing partial config to start debugging command
221e20b3742 Re-enable, add some more test logs
7e6d4c5eb91 debug: fill in selected configuration by name if not provided
3f56118e7bb move cell up
a39e7343653 Oops
584999658ee Bug
820f0eeb270 Fix tooltip not showing for codelens extension
a0c8d41f9ed add notebook navigation commands
78cb4cfc32b improved comment for InlineValueContext.frameId
3df01b4ae74 Include ms in shutdown constant comments
45c032da7ab Skip the failing task test
1469a82540f fixes#118006
d8a7202293c Update distro
e22c2be14d1 snap: set compression to lzo, #117852 (#118116)
03c8548523f Merge remote-tracking branch 'origin/main' into tyriar/116467_2
9022c7fa945 Update distro
f2cfdcf19b8 Bump distro
4a82fbab162 Don't force create a terminal on no reconnect
06044789bfa API proposal for PortAttributesProvider (#118446)
3f778f6aebf Update distro
9c78fa40ca7 skip failing test (#118443)
20b19612917 Move proxy resolution to vscode-proxy-agent (#117054)
b41b95faee9 Pin windows-process-tree@0.2.4 to match main package.json
4d3b1580233 Disable terminal tests in remote again, fix settings for tasks
1cd624c12a3 Merge remote-tracking branch 'origin/main' into tyriar/116467_2
4abc244a97e Add windows-process-tree to remote deps
c2a92a1ba67 Merge pull request #118418 from microsoft/ben/sandbox
caed3ea183a Merge pull request #118269 from davidanthoff/julia-indentation-rules
007baec8d51 fixes#118214 (#118425)
c187999ee44 Merge pull request #118310 from smorimoto/ocaml
2a0f9aa8dc7 Reminder to compile between tests
69d36e8c982 Fix transformToSnakecase
305456c873f bump distro
f7274905565 editors - fix mergeAllGroups (#118268)
8c3a00f78cb allow debug textmate in sandbox (#118219)
f74d3b2fc75 fix tests
0c17e384499 sandbox - migrate backups from md5 to our hash algorithm
dbe9dd49675 sandbox - make signing and integrity available
3f46e7f7b59 add ui flag to mocha tests
74532eb261c Re-enable process unresponsive checking
5cc1775bbf0 Disable unresponsive create process
11897d00a7a Disable pty host listeners temporarily
074632a51f1 Try enable remote terminal integration tests
508fcfbb537 Add more OCaml related file extensions to the OCaml group
5d80c30e5b6 Reenable smoke test to see if still flakey Ref #115244
74014e7fc6d Fix#117251
fe79bb261fb Add defaultSnippets to getting started contribution point Closes#117476
2d5e9cae4e0 💄
d3086eaa8c5 expect commands to set selection and focus for us properly.
7707feab17b accept focus from the list view.
6e83ba82107 fix#118279
da79b9db816 Don't setup pty host listeners twice in remote
ea5f05a4358 Trying to clairify how webview options are used and passed around
e066c74761e Document new fixedChunkSizePolling ts watch mode
d7d42534260 Mark field as readonly
a01035c44f8 Pick up latest TS 4.3 for building VS Code
02a5d5925ba Disable relaunch in tests
755fae50ab5 Bail out of create process if it's been disposed
2d3f1a0b478 fix#117699
258ee03bfbe Update distro
3483e9541b2 update betweenCellToolbar actions per context change.
61ea6ad847a Remote shell type support
fc677cb3220 fix#118273.
c40b367840d Merge remote-tracking branch 'origin/main' into tyriar/116467_2
b15bbfa8516 More test logs
3e345101dfd update shellType when it changes for local windows terminals (#117998)
6b2daa9a897 Update distro
ff09362f443 Merge remote-tracking branch 'origin/main' into tyriar/116467_2
5d5fa588828 Support pty host management in remote
29b1fcffd1b fix#117684.
7af259ab841 Add logs to test
c24bfc336c2 💄& localization
daf840b9293 Revert "fix visually background flash of cells."
016b809eef0 kill terminal process on ipad (#118247)
c18378655bd Add Julia indentation rules
7f7e427d3ba fix visually background flash of cells.
f704f80f877 Pick up TS 4.2.3
22cb8ccdac3 Merge remote-tracking branch 'origin/main' into tyriar/116467_2
a7d9285b89f Update distro
2e68f2ae918 Better fix for #118235
00d3831d0c7 fix#118248.
59972ff745f fix build
5144d664926 dedup ansi color rendering.
bba6d12ccb2 💄
ff5da2ff172 DOM.show/hide.
d2e39d0ae09 use resize listener for all main frame outputs.
32f7c1d93a8 Don't assume uncompleted category exists Fixes#118235
ccb3601d552 Support term cli commands
c2e3a4cdc67 Update distro
af0ec1caa0b ctrl+c on ipad (#118243)
6799395da0c Revert "fix #114009" (#118242)
dfbc5374637 Increase local grace time to a minute
fe24a792b03 Support attach to session in local
f916e9f1aba fix#114009
df6b2691705 Support orphaned processes
48be13acf8e Check if VSCode runs serverless (#118233)
e518e533653 Share IOffProcessTerminalService
51e773e69f2 Merge branch 'main' into aeschli/openWindowsWithAuthority
0bcba0486bb Make setTerminalLayoutInfo interface consistent
7703dff5fc1 Clean up, bring local remote interfaces closer
92ad349125b fix typo in comment
aadc16a2371 Simplify channel comm
230e0fdc9aa clean up, some ground work to support viewColumn, $acceptEditorPropertiesChanged must update all state before sending events, remove active notion from notebook editor
9516844abfd use TS typle naming feature
68a6f1c30e4 look up editor by id, slimmer dtos
f7ff53d7b06 Remove `_wrapWebWorkerExtHostInIframe`
418b8248e43 Progress towards sharing local and remote term impl
25dc50c18ed Remove start-up timeouts
49b5e3ba0ae bump version
978d1399f54 Fix compilation error
fca9c7f78fb Fixesmicrosoft/monaco-editor#2375
5931e598b10 Fixesmicrosoft/monaco-editor#2344
205ec8c5f2d Fixesmicrosoft/monaco-editor#2358
b2a0913ad23 Fixesmicrosoft/monaco-editor#2168
9748b5f3c0b Fixesmicrosoft/monaco-editor#2359: Avoid syntax that confuses webpack less loader
5c4663baadf Fixesmicrosoft/monaco-editor#2355
60222b710d4 Align `MultiEditorAction` with `MultiCommand`
453e2793b2b Prefer using TS constant defining the context key
04770364fdc #118222 skip failed test
1260de1c101 sandbox - move workspace tags to sandbox
17212ee46f8 #118199
c024db9f419 NotebookEditorSelectionChangeEvent should contain selection ranges, not cells
2e84eb92077 explorer tests: use strict equal
1e28c1ec7ee debug tests: use strict equal
1a9df6127cc fix smoke tests
ef6d44f53aa debug console shouldn't collapse messages when they have different source locations
6e5e1e700b9 api todos
6117524374f make NotebookCellData and NotebookData classes, rename NotebookCellData#cellKind to NotebookCellData#kind
86df4442128 remove todos
3a21f7815c4 Merge pull request #118125 from microsoft/sandy081/keybindingsEditor/adoptTable
57aaafc72f3 Do not check for settings sync enablement while initializing in web
d4b5298cd62 -add bg color to even child - clean up
997c9f29307 add showNotebookDocument overload or uri
ae2f3e07e12 streams - add test for using error as data
be70750f862 comment 💄
b65719bfa27 streams - require explicit end() after error() and remove error support from end()
188e6aac851 stop the code bunny, reuse the createAndFillInContextMenuActions-util, fyi @sandy081 @rebornix
7386525c683 remove one more occurence of '1_run'
bc62648b05c Revert "Remove authentication provider package.json declaration"
fead22bae42 bump distro
eed8a79e81f Extract proxy agent support (#117054)
79096af4755 use CSS for odd styling
223f4f820f8 multi cursor: announce cursor changes
3b05017bb8e more 💄, more strict typings
1d8493b203e 💄 in mainThreadNotebooks, return types, more private, dispoable store, duplication removal, etc
81edf8b91ab Merge pull request #118071 from mtaran-google/main
85c1a17b60f Merge IEditor and INotebookEditor, move editor things into notebook editor service
fc785836967 fixes#118006
d84ddcbd529 Open window with authority
39c1d680867 #62531 clean up
2dfc39c6949 Remove arrays#mergeSort because by now browsers support the refined sort spec which mandates `sort` to be stable.
587274078c1 remove NotebookDocumentMetadata#displayOrder, https://github.com/microsoft/vscode/issues/117684
3e8b0eb2d4f remove displayOrder from NotebookDocumentMetadata API, https://github.com/microsoft/vscode/issues/117684
afae25919a8 Merge pull request #115351 from gjsjohnmurray/fix-62531
fa37b721d1e 💄
ddb17dc1282 💄
dbbf2b16882 shell env - introduce a service to resolve shell env as promise (#108804)
bd2b229870b debug: update js-debug
567b82a0f9c Reduce padding of new markdown cells in notebook
38ac13bc833 Slightly reposition the folding indicator for cells
99f2b830a1d Improve drag and drop indicators for custom markdown cells in notebooks
354a0a2620f Disallow dragging the outer markdown cell for rendered markdown cells
a34ed4b0d7b Make markdown cells span full width of editor
60d600b3661 Fix showing wrong name for files in search after rename Fix#117778
1c7ced625a3 Update dimensions of webview element when it is shown again
72995bcb80b Mark property as readonly array
28b7345808b Improve documentation for WebviewService
9fa1800b979 Make the webview icons manager disposable
5bff5459d13 Move webview icons from generic webview service to the webview workbench service
acdcb64a6c9 Throw error if a webview is double registered
487296741f5 Don't require lazy webview to be passed to WebviewInput
344f329dd42 Make reviveWebview take an options bag instead of parameters
79ff1ec91bd gate on feature flag
aca4cb12985 workspace trust telem
0f975049421 Fix output padding/margin for diff notebook editors
9f395ddb934 Update Codicons 7e0f377891
0eca51a2dad Mark selected markdown previews in notebooks (#117947)
191d3324132 Add offset to button focus (fixes#117909)
8a81f4149d3 add warning log if webgl cannot be loaded
6abc478020f Update src/vs/workbench/contrib/terminal/browser/terminalInstance.ts
8b1ddde4f5b move disposal to end so measureRenderTime gets called
920b8b31931 store suggestedRendererType to avoid retrying webgl if it's thrown an error unless the setting gets changed
e9a748131c1 use storageService
bab447271a3 measure render time if webgl throws and canvas set
b619d92639d use canvas if webgl throws
e7ce70318ff after webgl is disposed, don't retry to enable it unless the renderer type gets changed
ca83d009f37 Update src/vs/workbench/contrib/terminal/browser/terminalInstance.ts
d61adbfd923 part of #106202, make webgl renderer default, using dom if loading the add on throws
1e5e33cd023 testing: fix unit test err
d6b3bc68f1e testing: move types to classes instead of interfaces
35aed337263 testing: improve RequiredTestItem api
1370dacbe0f Rename localPtyService to ptyHostService
05ccfc4fcb7 Move localPtyService to node
db06103f1bd Enable search in open editors checkbox by default
597c5958527 fix overflow in command column
0150b020a10 Merge pull request #118121 from microsoft/tyriar/116467
2d4e671f730 update distro.
5b2865bc99b fix layout - do not consider header height
c6202bb3cc5 Adopt to use new table widget
dd3f3f9d7fe Update issue scraper to use standard bot PAT and run every month
8465489bbd4 Fix unit tests
8fd1b977166 Merge remote-tracking branch 'origin/main' into tyriar/116467
12ab47ff863 Fix compile
c9ae209c80e Use safe process env from electron-sandbox
97cb1ff41d2 Register ILocalTerminalService
468d73edeb0 Fix compile
306bebf0f15 Move responsiveness check to local terminal service
3a1f4c402b4 Move terminal instance service methods to local terminal service
df863f912b3 more context key doc
5ba5f986b92 remove notebook dependency from build edits
128e9b502d2 add frameId to InlineValueContext
cb7ad05cb7e Merge pull request #117766 from microsoft/tyriar/remove_flow_control
73fee061714 Update distro
9bf3a06e647 Merge pull request #118118 from microsoft/tyriar/117990
68a3a7bbf9b improve comment
0ef6619a3eb services - use refineServiceDecorator for environment (#117881)
1e0d5009b5d fix exception breakpoint padding
03681b39a50 Update distro
fa4c3c6cf1e Show ports badge on view, not view container Fixes#117904
a5c28d0ca06 Merge remote-tracking branch 'origin/main' into tyriar/remove_flow_control
ddd6fccfee0 services - use refineServiceDecorator for layout service (#117881)
ffa703d4805 Recover on pty host reconnect
c0f6549d1cb files - address #118060 on master
94dec183740 Fix simple file picker not opening entered value Fixes#116858
7586d1a0fc2 Fix extra http on some forwarded port addresses Fixesmicrosoft/vscode-remote-release#4595
fb46801cf2f lock file-changes-action
dd14e280254 Don't use an icon on the Port add row
c2a2cc2bc3b Allow quick input to show info severity (#118032)
179c89852f7 Change icon for npm scripts view Fixes#118019
3c238e71dbc Add "hasPackageJson" check back to npm view and let it find files in directories Fixes#117950
1d46693af84 fix IThemeService decoration ids. For #117881
31012ea2d4a add refineServiceDecorator, https://github.com/microsoft/vscode/issues/117881
978b0d6ead9 context key doc
16ea2f2894b remove "getter" wrapping for proposed API types (classed, enums). These checks needed to be disabled because of an TS issues
f79a0df4dbe api todos, remove long outdated proposal
01d775756c7 todo goes issue
b6141474a76 move undo/redo and clipboard support out of notebook service so that it slims down
c349764ab2e no graceful, throw errors when trying IO on notebooks that have no provider, move notebook model things together
069da883da5 Merge pull request #117834 from jeanp413/fix-panel-codicon-outline
8025d97ece8 mark `displayOrder` for removal, https://github.com/microsoft/vscode/issues/117684#issuecomment-790019754
73c01a5dd87 Merge pull request #117424 from atscott/dedupereferences
f43fcbe6a4e fix https://github.com/microsoft/vscode/issues/118103
62d6a24efb9 revive URI when receiving them, fixes https://github.com/microsoft/vscode/issues/118085
0657df6e82f fix some area labels in extensions and scm
534e2306379 Renaming a folder adds it to history (fix#118080)
2ba67b7b075 Allow ripgrep search provider to work for files backed by file scheme, but not file scheme themselves (vscode-userdata) (#118069)
5f17dc2a596 Ensure that PrefService calls openEditor with a proper options object and add tests Better fix for #117952
54758b7e16d Revert "Ensure that PrefService calls openEditor with a proper options object and add tests"
2ae55bc7164 Ensure that PrefService calls openEditor with a proper options object and add tests Better fix for #117952
16c94f18258 Remove incorrect command
a4b2541e379 Mark disposableStore property readonly
584d2338870 Use `_register` for disposable
538931e7906 Make sure context key listeners are disposed of
49d05f998f0 Add `CodeActionTriggerKind` api proposal
20f06e04445 Clarify docs on CodeAction return type
7e18b7006d0 Use generic type for CodeActionProvider
ba117e60c20 fix#118043
4bd99a42df0 Fix old markdown preview not being removed on drag
4371e72fb6a Fix potential null exception while dragging cells
abf99de040e 💄
aaf70523a8e Bump vscode-emmet-helper, fixes#118008
828f99eff55 Update diff editor with new webview options
e56182e67f2 Make the backlayer webview span the full width of the notebook editor (#117948)
bfa7822f703 Fix typo in IWorkbenchExtensioManagementService
e9533c22fee add basic workspace trust unit test
19b7444ccf0 fixup! fixmicrosoft/vscode#117095 de-duplicate location results
17f63a649ec testing: update to more proper provider api
2f7438f492f Fix spelling for type
5d5b9dd0a8b Don't label non-editable custom editors as readonly
5f24ec84ac7 Use correct new context name
6949fed6ed2 Update grammars and fix julia update script for Windows
0e94794c9d0 debt - remove unneccessary indirections from notebook service
09149ac0930 Avoid double dispose of pty host client
f80f0d7074e More forwarded ports trace logging
65c0eeb03d0 fixes#118006
a24cb4615a1 debug debt: remove unneneded check
341c130b0e9 call stack: get rid of actions, menus everywhere
fd948827992 Deprecate editor.accessibilityPageSize setting
79cf4e92ce1 Use Promise instead of event
14fd07d57a2 Workspace trust api feedback
65a9aa17768 Use "(Settings) " as a prefix for userdata paaths in web Closes#114979
c3d7bd2269d Reserve space for recent list to prevent shifting when it loads Fixes#117628
e21f3916af7 Focus first uncompleted category rather than whole document on start Closes#117540
09dae2618ae Disconnect in debug toolbar should dispatch to root session
8c13b011133 debug: simplify registration
b6f87905932 💄 comment
4def740615b wrap perf stuff in iife, https://github.com/microsoft/vscode/issues/116546
bc444ac3797 Fix#117869
bede292addb Error on `remoteAuthority` in Local Workspace File. Fixes#118023
6b3313141de make sure local dispoables are disposed and cleared, https://github.com/microsoft/vscode/issues/117675
d13b7ff3641 one class, one variable style, https://github.com/microsoft/vscode/issues/117675
2e9fde23fdd add todo-tag for InlineHint, https://github.com/microsoft/vscode/issues/105690
0a49559a443 Mitigates #118008, better fix TBD
a795f49b097 more enforcement of readonly nb doc.
62cfd68c779 absolutely no polish POC feature list
d82bb46c445 do not prompt for confirmation in editor
ed94b5d7562 allow text selection of description
6979a39169a move webview resolved state internal.
c113b806cca re-organize notebook editor widget methods.
1614e28a11c remove notebook editor widget methods not used.
c70fb23a27b 📓 move decorations out.
52bce12c25e testing: fix up wording in api
25b5db4d55c testing: make workspace test hierarchy required
94cda08af53 testing: make runTests required
9fbc8811428 testing: make hidden state more clear
2cc1a8061d1 Fix VSCode spacing
cf3faa40460 Don't relaunch extension owned terminals (#117987)
6c6caf678fe Don't force kill ptys on Windows on window exit
7b91cd85284 less exclamation
6643b5e520b de-dup: uri.
0eb8c53f90b de-dup, NotebookEditorWidget#willDispose, didScroll.
623741272a2 Add activeCustomEditorId context
08ceea18aa0 rpm-spec: fix the wrong claim about working on EL7
e3829dc2477 Add 'prune' option to fetch in git extension API (#117923)
975dfff6db6 Emmet: Change the type of emmet extensions path (#117946)
cc5db258239 testing: fix NaN if 0 tests ran
fe353a54240 testing: close error peek view when test run starts
7d1751444b2 testing: fix tree view overflowing container
b6251fc0baf testing: fix 'run in current file' running all tests
da98cc6e94d testing: fix run at cursor discovering indefinitely
7c1305782b1 testing: adopt new autorun icon
4a6488c6d03 Move kernel/execution code out of NotebookEditorWidget for testability
b629d888ca6 Bump Emmet yarn, fixes#117154, fixes#97632
5073e6f1fe5 fixes#117968
f97dd62ece6 Make sure we use the cannonical uri for file move target
1155803d134 Use case-insensitive check for file extensions
bb8b693479b Mark properties readonly
20ec5b80085 Reuse generic open with logic for custom editors
75b5207f850 Extract BaseToWebviewMessage interface
4e4c43f30fd Update distro
e994e5ab498 Persistent terminal id -> Persistent process id
647773d7e68 Rename terminal id to instance id
88d9e2b46b7 Refactor second task test
f8c41a80b0d Refactor first task test
c8fc575275d Ignore terminal events not related to task test
e62bf133c45 fixes#117575
15c02651811 use one element for focused/active item in actbar fixes#117584
cd9ce538ba5 Add shouldPersist terminal tests
c6d6bda7197 Merge pull request #117974 from ko1/patch-1
20096095f19 fix extension readme not rendering img width height (#117961)
2b50ba174f3 refs #117960
5d4377de987 March for API issues
72de8e9be86 add region markers to isTelemetryEnabled proposal, https://github.com/microsoft/vscode/issues/110267
ff225b9fcce add telemetry enablement api (#117944)
4de8cb29073 increase accessibility page size to 2000
9692037daa9 Update vscode.d.ts
9e4520310ed Fix remote terminal reconnect
85cbc2bc7ce cancel parameter hints when editor blurs, https://github.com/microsoft/vscode/issues/115265
44955421ae7 fix https://github.com/microsoft/vscode/issues/117431
7bc94131f17 change anyScore so it repeatedly run fuzzyScore on substrings of the pattern, https://github.com/microsoft/vscode/issues/116683
0018625d00e more details in explain dialog, https://github.com/microsoft/vscode/issues/116683
e2c5ff9db00 do not auto open pasted file
2022aede921 Return early on promise reject.
ed1118b27b1 Support empty messages during location import
58ab537f4fc Debt: descriptions/hide context keys (tree, ports, tasks)
66b7ffaabf9 simplify $tryShowNotebookDocument further
65e28321240 use label service to infer name of notebook input
83f40886812 notebook - simplify group/viewColumn handling when opening a notebook editor via API
df8763cfff7 api todos for notebook cell
be11cb2de00 disable failing test (#117446)
f70433a596a fixes#117910
73f9f126fb2 fix tests
932c7e247dc 🆙 distro
8c1bfcb569a services - distinguish environment services (#117881)
5510ee9c51d services - distinguish layout services (#117881)
6c13c8f4ed2 de-deup: getContextFromEditor.
9f7d229461a Extract decorateFileEditorLabel to a common function
d7f90c7dbcf re #114554.
d9d5e5d9c38 Merge branch 'main' into digitarald/ces
e3bc5abc511 Draft for ces survey
400737c5b89 Pass 'data' to completion details request (#117092)
5d6ea08985d fix#116751.
01025340392 Splits clone/docs welcome Allow GitHub Browser entry in the middle
015ca030c4b tests for selections for navigation and hidden ranges.
177e3474c5a consolidate index/handle update api.
1f08b8f9024 wrong use handle/selection
460ebdaaf5b Aggregates welcome view registration by view id
9d071596951 debug: bump js-debug-companion version
811dc8d45a0 Remove authentication provider package.json declaration
8e37e4722ec Fixes#74505 (#117807)
5aeafe2b209 Fix Emmet issue where incorrect abbreviation is displayed in an html document (#117759)
b3ade044793 fixes#117924
0c9476a0b6b testing: fix tree not updating if nodes are replaced with same id
f18a3400668 Use method instead of event
c30e2d46b2a Fix emmet update extensions path issue (#117797)
e4a69193d04 Merge pull request #117138 from shskwmt/fix/116822
a13f7ee916b actionBar: home and end should navigate to first and last item respectively
721514f2c1d Merge pull request #117832 from jeanp413/fix-117354
98883cf3b11 remove actionBar.reverse orientation
0bf5569f02c seti: use CONTRIBUTING
c3e2c76f762 add failing, skipped test for https://github.com/microsoft/vscode/issues/117899
edadf1c7194 Implement shouldPersist for all terminals processes
884ed1e3f33 Use initial instead of unset
b803df2435c Fix top shadow issue
3559e47c08d update gulp-tsb
bf894811515 Some Ports view clean up
73112daff11 Remove extra check that is not needed
e9166375289 tests - enable color output for integration tests
32b3afadcbe support to make N outline entries from 1 cell, https://github.com/microsoft/vscode/issues/115200
85588252af1 notebook - make outline entries use the heading text has preview text
b139c10f9a8 add tests for notebook outline
de020f04d13 debt - make withTestNotebook easier to use
a04913af757 Merge pull request #117716 from microsoft/tyriar/115396
d5eeb40b557 better focus for select boxes in action bars
a2bacaf9fc3 Reverting the top margin to avoid a regression
e4e9d1f43b2 Fix grammar
1c4daf4886c Merge pull request #117842 from TranquilMarmot/main
6a864f0b679 Add line height for title
ba83910eb76 Remove duplicate tooltip
8baa0ebc750 Fixes title casing
36b0a209a51 backups - consolidate web and desktop strategy for backups when auto save is on
b44cc868901 Revisit loose primary group check , use string instead of isPrimaryCheck
12675b4797e missing await
19aee3b6ddf untitled.hint let's go back to the button as the default
6dc076b5c4d debt - tackle an old todo
aacafc75b37 debt - use CompletionItem#textLabel in more places
f5153bbdacd use CompletionItem#textLabel
3c62a8f898b tabs - track last tab in row for wrapping
de50318b48f text files - open an editor that fails to auto save (#115840)
b497d17fec9 View: Maximize editor group" doesnt work with dragged file between editors (fix#117686)
3aff1320b81 my work for march
b99df4f2b6e don't pass model service to applyEdit but check model version for edit that come from extensions, fixes https://github.com/microsoft/vscode/issues/117683
8fd4a68845f Factor in workspace trust when switching versions (#117774)
f84aa806e45 🆙 distro
23dca79e8e9 🆙 nsfwatcher (#117871)
0a7ea106e6e Merge remote-tracking branch 'bpasero/ben/march-debt'
f3ec084d542 Update seti-ui icon theme
b061ac534cb Fix#117833
f3f4eebecbd Label custom editor as deleted if the backing file is deleted
64db4d5a1a5 Fixes#117354
d89e2e17a5d Allow single line comment after `{` for auto indent
5766526b0b3 Port the desktop iframe webivew focus improvements to the web
8572664c6c7 Enable semantic features (such as error reporting) in JS/TS notebook cells
a74ebb17cfe Add helper for tracking active js/ts editor
1f567e10f37 Fixing two more cases for promises in conditionals
3feb2ece1ed Pick up latest TS version for building VS Code
5c7c41fc3d2 Merge pull request #117723 from microsoft/rebornix/reduce-markdown-flickering
91d73da5e42 Only show `infer return type` refactoring when refactorings are requested
d596c568451 fix altClickMovesCursor setting description -> markdownDescription (#117793)
a4187782439 Merge remote-tracking branch 'origin/main' into tyriar/remove_flow_control
d0a46a03279 Merge pull request #117734 from jeanp413/fix-117682
ba9c72b1ff7 Merge pull request #117762 from microsoft/tyriar/remove_ext_host_proc
cadb56785ab Merge branch 'main' into tyriar/remove_ext_host_proc
e0b4ebc148d Merge remote-tracking branch 'origin/main' into tyriar/remove_flow_control
f4c1da9ca64 Update distro
ce4bbc7a19e bump version to 1.55
abdf5767046 ipc - allow to configure proxy
c41922bf427 chore - cleanup registerSingleton service usages
91a246998c2 Remove flow control setting
bd272ea6b74 chore - have a single display change listener
1f0f03e4a03 ipc - adopt utility methods (#114418)
df5d7c257df Remove exthost terminal processes
5f234672f57 fix: only use the readonly attribute on the IOS
509cd79dbd6 text file model - drop custom touch method and just go through normal save code
437904db063 file service - add a atomic read option
45f5c4d43f0 Fixes#117682
3d988a6800f Remove focus handling on the xterm element
9a9551b89fc pfs - copy should preserve dangling symbolic links
1e799f5a17e anything quick pick - only restore editor view state in certain cases
acea3970993 workspaces - use recursive mkdirSync
a469f5eafaa storage - rename storageservice2 => storageservice
2ab5a60c0b8 storage - drop old node based storage service
5fabc0d9dc1 smoke test - remove code only needed for stable january release
f5d9bdc8466 fixmicrosoft/vscode#117095 de-duplicate location results
4cda94b60c1 Remove escaping whitespace characters
495c0e996ad fix cursor position when at the start of RTL syntax tokens
234c7a45fee refactor change to fix fault and reduce diff
bf426c250ec structure FilterOptions.textFilter to hold negate flag
03ad36a18b6 Fix negation logic for filterResourceMarkers and filterRelatedInformation
878b0087e06 simplify negate logic in filterMarker
5a6c46fe60a fix#62531 support negation in text filter of Problems
490d7e38da9 Merge branch 'master' into fix-95671
057a47c1b62 Merge branch 'master' into fix-95671
8b73103dedf Merge branch 'master' of https://github.com/matthew-haines/vscode
ac89d9ef71f Fixed logic for setCollapseStateForRest and alt-click in editor
9e1b929816d Fixed logic for setCollapseStateForRest
330f6052ebb Added actions for folding/unfolding all regions except selected
8ef113d399c Added collapse surrounding regions with alt-click
3374969a2cb Fixes#95671
REVERT: fd6f3bce670 chore: bump electron@11.3.0 (#118680)
REVERT: 305bf142199 Remove icon from input row in ports view (#118649)
REVERT: b5af426d34c Properly dispose everything in tunnel view cells (#118546)
REVERT: f299ec03c2a Fix extra port icon (#118529)
REVERT: 62dbffbfe91 Merge pull request #118177 from microsoft/joh/bump-version
REVERT: 062c67a3210 Merge pull request #118491 from microsoft/env-var-recovery
REVERT: e11b6a730c9 Fix#117903 (#118492)
REVERT: e7936a3e885 prevent env var relaunch from extension owned terminals
REVERT: 3be37a725d6 Merge pull request #118438 from microsoft/tyriar/1_54_117990
REVERT: d461d2fd311 Merge pull request #118265 from microsoft/connor4312/candidate/js-debug-1.54.5
REVERT: 88b4d3f9a4e Merge pull request #118448 from microsoft/tyriar/1_54_118321
REVERT: c48a57b6988 Merge pull request #118437 from microsoft/tyriar/1_54_117956
REVERT: d68ab8fc717 Don't force create a terminal on no reconnect
REVERT: f9e6b352d1c Recover on pty host reconnect
REVERT: b31f6e1afea Don't force kill ptys on Windows on window exit
REVERT: bd655647d79 fixes#118214 (#118425)
REVERT: 3a6b7f7cbdc editors - fix mergeAllGroups (#118268) (#118406)
REVERT: 06c5e24837e FileSystemProvider extension: throwing a FileSystemError in readFile does not report to user (#118173)
REVERT: 61feeef2289 Renaming a folder adds it to history (fix#118080) (#118174)
REVERT: dd74fb1d885 debug: update js-debug
REVERT: 362f7e441ff Pick up TS 4.2.3 (#118261)
REVERT: 6b7199812b4 Don't assume uncompleted category exists (#118250)
REVERT: 21ea885f455 Merge pull request #118167 from microsoft/connor4312/candidate/js-debug-1.54.4
REVERT: de16aa4bae0 bump version to future 1.54.2
REVERT: 87ff6fb52f1 debug: update js-debug
REVERT: f30a9b73e8f bump version (#118144)
REVERT: a25525922cd update distro (#118129)
REVERT: 42e27fe5cdc Merge pull request #117982 from microsoft/roblou/settingsOpenEditor
REVERT: ac575425edc Ensure EditorOptions subclass is passed to openEditor Fix#117952
REVERT: 911868fa126 refs #117960 (#117976)
REVERT: 62c69b32bf7 Merge pull request #117972 from microsoft/tyriar/r_1_54_remote_reconnect
REVERT: 564f3917935 Fix remote terminal reconnect
REVERT: e7989863202 fixes#117924 (#117925)
REVERT: c4d7a739c9b Terminal cannot input (#117915)
REVERT: 5266d3cc7f3 Merge pull request #117898 from microsoft/tyriar/r1_54_remote_reconnect
REVERT: 6f0e457db3f Fix emmet update extensions path issue (#117797)
REVERT: 66c7b551727 Implement shouldPersist for all terminals processes
REVERT: ae03e39735b Only show `infer return type` refactoring when refactorings are requested (#117800)
git-subtree-dir: lib/vscode
git-subtree-split: ead2c2ab0f5c93b11e223fd8f4493939be2ee0de
Thanks for reporting a bug. Please see https://github.com/cdr/code-server/blob/main/docs/FAQ.md#how-do-i-debug-issues-with-code-server and include any logging information relevant to the issue.
Please search for existing issues before filing, as they may contain additional information about the problem and descriptions of workarounds. Provide as much information as you can, so that we can reproduce the issue. Otherwise, we may not be able to help diagnose the problem, and may close the issue as unreproducible or incomplete. For visual defects, please include screenshots to help us understand the issue.
-->
## OS/Web Information
- Web Browser:
- Local OS:
- Remote OS:
- Remote Architecture:
- `code-server --version`:
## Steps to Reproduce
1.
2.
3.
## Expected
<!-- What should happen? -->
## Actual
<!-- What actually happens? -->
## Screenshot
<!-- Ideally provide a screenshot, gif, video or screenrecording -->
## Notes
<!-- If you can reproduce the issue on vanilla VS Code,
please file the issue at the VS Code repository instead. -->
description:Please search to see if an issue already exists for the bug you encountered.
options:
- label:I have searched the existing issues
required:true
- type:textarea
attributes:
label:OS/Web Information
description:|
examples:
- **WebBrowser**:Chrome
- **LocalOS**:macOS
- **RemoteOS**:Ubuntu
- **RemoteArchitecture**:amd64
- **`code-server--version`**:4.0.1
Please do not just put "latest" for the version.
value:|
- Web Browser:
- Local OS:
- Remote OS:
- Remote Architecture:
- `code-server --version`:
validations:
required:true
- type:textarea
attributes:
label:Steps to Reproduce
description:|
Please describe exactly how to reproduce the bug. For example:
1. Open code-server in Firefox
2. Install extension `foo.bar` from the extensions sidebar
3. Run command `foo.bar.baz`
value:|
1.
2.
3.
validations:
required:true
- type:textarea
attributes:
label:Expected
description:What should happen?
validations:
required:true
- type:textarea
attributes:
label:Actual
description:What actually happens?
validations:
required:true
- type:textarea
id:logs
attributes:
label:Logs
description:Run code-server with the --verbose flag and then paste any relevant logs from the server, from the browser console and/or the browser network tab. For issues with installation, include installation logs (i.e. output of `npm install -g code-server`).
render:shell
- type:textarea
attributes:
label:Screenshot/Video
description:Please include a screenshot, gif or screen recording of your issue.
validations:
required:false
- type:dropdown
attributes:
label:Does this bug reproduce in native VS Code?
description:If the bug reproduces in native VS Code, submit the issue upstream instead (https://github.com/microsoft/vscode).
options:
- Yes,this is also broken in native VS Code
- No,this works as expected in native VS Code
- This cannot be tested in native VS Code
- I did not test native VS Code
validations:
required:true
- type:dropdown
attributes:
label:Does this bug reproduce in VS Code web?
description:If the bug reproduces in VS Code web, submit the issue upstream instead (https://github.com/microsoft/vscode). You can run VS Code web with `code serve-web` (this is not the same as vscode.dev).
options:
- Yes,this is also broken in VS Code web
- No,this works as expected in VS Code web
- This cannot be tested in VS Code web
- I did not test VS Code web
validations:
required:true
- type:dropdown
attributes:
label:Does this bug reproduce in GitHub Codespaces?
description:If the bug reproduces in GitHub Codespaces, submit the issue upstream instead (https://github.com/microsoft/vscode).
options:
- Yes,this is also broken in GitHub Codespaces
- No,this works as expected in GitHub Codespaces
- This cannot be tested in GitHub Codespaces
- I did not test GitHub Codespaces
validations:
required:true
- type:checkboxes
attributes:
label:Are you accessing code-server over a secure context?
description:code-server relies on service workers (which only work in secure contexts) for many features. Double-check that you are using a secure context like HTTPS or localhost.
options:
- label:I am using a secure context.
required:false
- type:textarea
attributes:
label:Notes
description:Please include any addition notes that will help us resolve this issue.
git commit -m "chore: updating version to ${{ env.VERSION }}"
git push -u origin $(git branch --show)
gh pr create --repo coder/code-server-aur --title "chore: bump version to ${{ env.VERSION }}" --body "PR opened by @$GITHUB_ACTOR" --assignee $GITHUB_ACTOR
docker:
runs-on:ubuntu-latest
steps:
- uses:actions/checkout@v1
- name:Run ./ci/steps/push-docker-manifest.sh
uses:./ci/images/debian10
with:
args:./ci/steps/push-docker-manifest.sh
env:
GITHUB_TOKEN:${{ secrets.GITHUB_TOKEN }}
DOCKER_USERNAME:${{ secrets.DOCKER_USERNAME }}
DOCKER_PASSWORD:${{ secrets.DOCKER_PASSWORD }}
- name:Checkout code-server
uses:actions/checkout@v6
homebrew:
# The newest version of code-server needs to be available on npm when this runs
# otherwise, it will 404 and won't open a PR to bump version on homebrew/homebrew-core
"description": "code-server provides a built-in proxy to help in developing web-based applications. This is the code for the domain-based proxy.\n\nAlso documented here: [https://github.com/cdr/code-server/blob/master/docs/FAQ.md#how-do-i-securely-access-web-services](https://github.com/cdr/code-server/blob/master/docs/FAQ.md#how-do-i-securely-access-web-services)"
"description": "code-server provides a built-in proxy to help in developing web-based applications. This is the code for the domain-based proxy.\n\nAlso documented here: [https://github.com/coder/code-server/blob/main/docs/FAQ.md#how-do-i-securely-access-web-services](https://github.com/coder/code-server/blob/main/docs/FAQ.md#how-do-i-securely-access-web-services)"
},
{
"file": "src/node/routes/pathProxy.ts",
"line": 19,
"description": "Here is the path-based version of the proxy.\n\nAlso documented here: [https://github.com/cdr/code-server/blob/master/docs/FAQ.md#how-do-i-securely-access-web-services](https://github.com/cdr/code-server/blob/master/docs/FAQ.md#how-do-i-securely-access-web-services)"
"description": "Here is the path-based version of the proxy.\n\nAlso documented here: [https://github.com/coder/code-server/blob/main/docs/FAQ.md#how-do-i-securely-access-web-services](https://github.com/coder/code-server/blob/main/docs/FAQ.md#how-do-i-securely-access-web-services)"
},
{
"file": "src/node/proxy.ts",
@ -95,7 +95,7 @@
{
"file": "src/node/routes/health.ts",
"line": 5,
"description": "A simple endpoint that lets you see if code-server is up.\n\nAlso documented here: [https://github.com/cdr/code-server/blob/master/docs/FAQ.md#healthz-endpoint](https://github.com/cdr/code-server/blob/master/docs/FAQ.md#healthz-endpoint)"
"description": "A simple endpoint that lets you see if code-server is up.\n\nAlso documented here: [https://github.com/coder/code-server/blob/main/docs/FAQ.md#healthz-endpoint](https://github.com/coder/code-server/blob/main/docs/FAQ.md#healthz-endpoint)"
},
{
"file": "src/node/routes/login.ts",
@ -145,7 +145,7 @@
{
"directory": "lib/vscode",
"line": 1,
"description": "code-server makes use of VS Code's frontend web/remote support. Most of the modifications implement the remote server since that portion of the code is closed source and not released with VS Code.\n\nWe also have a few bug fixes and have added some features (like client-side extensions). See [https://github.com/cdr/code-server/blob/master/docs/CONTRIBUTING.md#modifications-to-vs-code](https://github.com/cdr/code-server/blob/master/docs/CONTRIBUTING.md#modifications-to-vs-code) for a list.\n\nWe make an effort to keep the modifications as few as possible."
"description": "code-server makes use of VS Code's frontend web/remote support. Most of the modifications implement the remote server since that portion of the code is closed source and not released with VS Code.\n\nWe also have a few bug fixes and have added some features (like client-side extensions). See [https://github.com/coder/code-server/blob/main/docs/CONTRIBUTING.md#modifications-to-vs-code](https://github.com/coder/code-server/blob/main/docs/CONTRIBUTING.md#modifications-to-vs-code) for a list.\n\nWe make an effort to keep the modifications as few as possible."
"description": "## Commands\n\nTo start developing, make sure you have Node 12+ and the [required dependencies](https://github.com/Microsoft/vscode/wiki/How-to-Contribute#prerequisites) installed. Then, run the following commands:\n\n1. Install dependencies:\n>> yarn\n\n3. Start development mode (and watch for changes):\n>> yarn watch"
"description": "## Commands\n\nTo start developing, make sure you have Node 16+ and the [required dependencies](https://github.com/Microsoft/vscode/wiki/How-to-Contribute#prerequisites) installed. Then, run the following commands:\n\n1. Install dependencies:\n>> npm\n\n3. Start development mode (and watch for changes):\n>> npm run watch"
},
{
"file": "src/node/app.ts",
@ -20,7 +20,7 @@
{
"file": "src/node/app.ts",
"line": 62,
"description": "## That's it!\n\n\nThat's all there is to it! When this tour ends, your terminal session may stop, but just use `yarn watch` to start developing from here on out!\n\n\nIf you haven't already, be sure to check out these resources:\n- [Tour: Contributing](command:codetour.startTourByTitle?[\"Contributing\")\n- [Docs: FAQ.md](https://github.com/cdr/code-server/blob/master/docs/FAQ.md)\n- [Docs: CONTRIBUTING.md](https://github.com/cdr/code-server/blob/master/docs/CONTRIBUTING.md)\n- [Community: GitHub Discussions](https://github.com/cdr/code-server/discussions)\n- [Community: Slack](https://community.coder.com)"
"description": "## That's it!\n\n\nThat's all there is to it! When this tour ends, your terminal session may stop, but just use `npm run watch` to start developing from here on out!\n\n\nIf you haven't already, be sure to check out these resources:\n- [Tour: Contributing](command:codetour.startTourByTitle?[\"Contributing\"])\n- [Docs: FAQ.md](https://github.com/coder/code-server/blob/main/docs/FAQ.md)\n- [Docs: CONTRIBUTING.md](https://github.com/coder/code-server/blob/main/docs/CONTRIBUTING.md)\n- [Community: GitHub Discussions](https://github.com/coder/code-server/discussions)\n- [Community: Slack](https://community.coder.com)"
@ -10,67 +10,24 @@ Any file or directory in this subdirectory should be documented here.
- [./ci/lib.sh](./lib.sh)
- Contains code duplicated across these scripts.
## Publishing a release
1. Run `yarn release:prep` and type in the new version i.e. 3.8.1
2. GitHub actions will generate the `npm-package`, `release-packages` and `release-images` artifacts.
1. You do not have to wait for these.
3. Run `yarn release:github-draft` to create a GitHub draft release from the template with
the updated version.
1. Summarize the major changes in the release notes and link to the relevant issues.
2. Change the @ to target the version branch. Example: `v3.9.0 @ Target: v3.9.0`
4. Wait for the artifacts in step 2 to build.
5. Run `yarn release:github-assets` to download the `release-packages` artifact.
- It will upload them to the draft release.
6. Run some basic sanity tests on one of the released packages.
- Especially make sure the terminal works fine.
7. Make sure the github release tag is the commit with the artifacts. This is a bug in
`hub` where uploading assets in step 5 will break the tag.
8. Publish the release and merge the PR.
1. CI will automatically grab the artifacts and then:
1. Publish the NPM package from `npm-package`.
2. Publish the Docker Hub image from `release-images`.
9. Update the AUR package.
- Instructions on updating the AUR package are at [cdr/code-server-aur](https://github.com/cdr/code-server-aur).
10. Wait for the npm package to be published.
11. Update the [homebrew package](https://github.com/Homebrew/homebrew-core/blob/master/Formula/code-server.rb).
1. Install [homebrew](https://brew.sh/)
2. Run `brew bump-formula-pr --version=3.8.1 code-server` and update the version accordingly. This will bump the version and open a PR. Note: this will only work once the version is published on npm.
## Updating Code Coverage in README
Currently, we run a command to manually generate the code coverage shield. Follow these steps:
1. Run `yarn test:unit` and make sure all the tests are passing
2. Run `yarn badges`
3. Go into the README and change the color from `red` to `green` in this line:
NOTE: we have to manually change the color because the default is red if coverage is less than 80. See code [here](https://github.com/olavoparno/istanbul-badges-readme/blob/develop/src/editor.ts#L24-L33).
## dev
This directory contains scripts used for the development of code-server.
- [./ci/dev/image](./dev/image)
- See [./docs/CONTRIBUTING.md](../docs/CONTRIBUTING.md) for docs on the development container.
- [./ci/dev/fmt.sh](./dev/fmt.sh) (`yarn fmt`)
- [./ci/dev/fmt.sh](./dev/fmt.sh) (`npm run fmt`)
- Runs formatters.
- [./ci/dev/lint.sh](./dev/lint.sh) (`yarn lint`)
- [./ci/dev/lint.sh](./dev/lint.sh) (`npm run lint`)
echo >&2"We looked for a successful run triggered by a pull_request with for code-server version: $code_server_version and a branch named $version_branch"
echo >&2"URL used for curl call: $workflow_runs_url"
RUN --mount=from=packages,src=/tmp,dst=/tmp/packages rpm -i /tmp/packages/code-server*$(uname -m | sed 's/x86_64/amd64/g'| sed 's/aarch64/arm64/g').rpm
# Allow users to have scripts run on container startup to prepare workspace.
RUN --mount=from=packages,src=/tmp,dst=/tmp/packages rpm -i /tmp/packages/code-server*$(uname -m | sed 's/x86_64/amd64/g'| sed 's/aarch64/arm64/g').rpm
# Allow users to have scripts run on container startup to prepare workspace.
The prerequisites for contributing to code-server are almost the same as those
for [VS Code](https://github.com/Microsoft/vscode/wiki/How-to-Contribute#prerequisites).
Here is what is needed:
- Use Node.js version 12.x (or greater)
- Have [yarn](https://classic.yarnpkg.com/en/) installed (which is used to install JS packages and run development scripts)
- Have [nfpm](https://github.com/goreleaser/nfpm) (which is used to build `.deb` and `.rpm` packages and [jq](https://stedolan.github.io/jq/) (used to build code-server releases) installed
- `node` v22.x
- `git` v2.x or greater
- [`git-lfs`](https://git-lfs.github.com)
- [`npm`](https://www.npmjs.com/)
- Used to install JS packages and run scripts
- [`nfpm`](https://nfpm.goreleaser.com/)
- Used to build `.deb` and `.rpm` packages
- [`jq`](https://stedolan.github.io/jq/)
- Used to build code-server releases
- [`gnupg`](https://gnupg.org/index.html)
- All commits must be signed and verified; see GitHub's [Managing commit
# The standalone release is in ./release-standalone
# .deb, .rpm and the standalone archive are in ./release-packages
npm run release:standalone
npm run test:integration
npm run package
```
The `release.sh` script is equal to running:
> On Linux, the currently running distro will become the minimum supported
> version. In our GitHub Actions CI, we use CentOS 8 for maximum compatibility.
> If you need your builds to support older distros, run the build commands
> inside a Docker container with all the build requirements installed.
```shell
yarn
yarn build
yarn build:vscode
yarn release
```
#### Creating a Standalone Release
And `release-packages.sh` is equal to:
Part of the build process involves creating standalone releases. At the time of
writing, we do this for the following platforms/architectures:
```shell
yarn release:standalone
yarn test:standalone-release
yarn package
```
- Linux amd64 (.tar.gz, .deb, and .rpm)
- Linux arm64 (.tar.gz, .deb, and .rpm)
- Linux arm7l (.tar.gz)
- Linux armhf.deb
- Linux armhf.rpm
- macOS arm64.tar.gz
For a faster release build, you can run instead:
Currently, these are compiled in CI using the `npm run release:standalone`
command in the `release.yaml` workflow. We then upload them to the draft release
and distribute via GitHub Releases.
```shell
KEEP_MODULES=1 ./ci/steps/release.sh
node ./release
```
### Troubleshooting
#### I see "Forbidden access" when I load code-server in the browser
This means your patches didn't apply correctly. We have a patch to remove the
auth from vanilla Code because we use our own.
Try popping off the patches with `quilt pop -a` and reapplying with `quilt push
-a`.
#### "Can only have one anonymous define call per script"
Code might be trying to use a dev or prod HTML in the wrong context. You can try
re-running code-server and setting `VSCODE_DEV=1`.
### Help
If you get stuck or need help, you can always start a new GitHub Discussion
[here](https://github.com/coder/code-server/discussions). One of the maintainers
will respond and help you out.
## Test
There are four kinds of tests in code-server:
1. Unit tests
2. Script tests
3. Integration tests
4. End-to-end tests
### Unit tests
Our unit tests are written in TypeScript and run using
[Jest](https://jestjs.io/), the testing framework].
These live under [test/unit](../test/unit).
We use unit tests for functions and things that can be tested in isolation. The
file structure is modeled closely after `/src` so it's easy for people to know
where test files should live.
### Script tests
Our script tests are written in bash and run using [bats](https://github.com/bats-core/bats-core).
These tests live under `test/scripts`.
We use these to test anything related to our scripts (most of which live under
`ci`).
### Integration tests
These are a work in progress. We build code-server and run tests with `npm run
test:integration`, which ensures that code-server builds work on their
respective platforms.
Our integration tests look at components that rely on one another. For example,
testing the CLI requires us to build and package code-server.
### End-to-end tests
The end-to-end (e2e) tests are written in TypeScript and run using
[Playwright](https://playwright.dev/).
These live under [test/e2e](../test/e2e).
Before the e2e tests run, we run `globalSetup`, which eliminates the need to log
in before each test by preserving the authentication state.
Take a look at `codeServer.test.ts` to see how you would use it (see
`test.use`).
We also have a model where you can create helpers to use within tests. See
[models/CodeServer.ts](../test/e2e/models/CodeServer.ts) for an example.
## Structure
The `code-server` script serves an HTTP API for login and starting a remote VS Code process.
code-server essentially serves as an HTTP API for logging in and starting a
remote Code process.
The CLI code is in [src/node](../src/node) and the HTTP routes are implemented in
[src/node/routes](../src/node/routes).
The CLI code is in [src/node](../src/node) and the HTTP routes are implemented
in [src/node/routes](../src/node/routes).
Most of the meaty parts are in the VS Code portion of the codebase under [lib/vscode](../lib/vscode), which we described next.
Most of the meaty parts are in the Code portion of the codebase under
[lib/vscode](../lib/vscode), which we describe next.
### Modifications to VS Code
### Modifications to Code
In v1 of code-server, we had a patch of VS Code that split the codebase into a front-end
and a server. The front-end consisted of all UI code, while the server ran the extensions
and exposed an API to the front-end for file access and all UI needs.
Our modifications to Code can be found in the [patches](../patches) directory.
We pull in Code as a submodule pointing to an upstream release branch.
Over time, Microsoft added support to VS Code to run it on the web. They have made
the front-end open source, but not the server. As such, code-server v2 (and later) uses
the VS Code front-end and implements the server. We do this by using a git subtree to fork and modify VS Code. This code lives under [lib/vscode](../lib/vscode).
In v1 of code-server, we had Code as a submodule and used a single massive patch
that split the codebase into a front-end and a server. The front-end consisted
of the UI code, while the server ran the extensions and exposed an API to the
front-end for file access and all UI needs.
Some noteworthy changes in our version of VS Code:
Over time, Microsoft added support to Code to run it on the web. They had made
the front-end open source, but not the server. As such, code-server v2 (and
later) uses the Code front-end and implements the server. We did this by using a
Git subtree to fork and modify Code.
- Adding our build file, which includes our code and VS Code's web code
- Allowing multiple extension directories (both user and built-in)
- Modifying the loader, websocket, webview, service worker, and asset requests to
use the URL of the page as a base (and TLS, if necessary for the websocket)
- Sending client-side telemetry through the server
- Allowing modification of the display language
- Making it possible for us to load code on the client
- Making it possible to install extensions of any kind
- Fixing issue with getting disconnected when your machine sleeps or hibernates
- Adding connection type to web socket query parameters
Microsoft eventually made the server open source and we were able to reduce our
changes significantly. Some time later we moved back to a submodule and patches
(managed by `quilt` this time instead of the mega-patch).
As the web portion of VS Code matures, we'll be able to shrink and possibly
eliminate our modifications. In the meantime, upgrading the VS Code version requires
us to ensure that our changes are still applied and work as intended. In the future,
we'd like to run VS Code unit tests against our builds to ensure that features
work as expected.
As the web portion of Code continues to mature, we'll be able to shrink and
possibly eliminate our patches. In the meantime, upgrading the Code version
requires us to ensure that our changes are still applied correctly and work as
intended. In the future, we'd like to run Code unit tests against our builds to
ensure that features work as expected.
**Note**: We have [extension docs](../ci/README.md) on the CI and build system.
> We have [extension docs](../ci/README.md) on the CI and build system.
If the functionality you're working on does NOT depend on code from VS Code, please
If the functionality you're working on does NOT depend on code from Code, please
move it out and into code-server.
### Currently Known Issues
- Creating custom VS Code extensions and debugging them doesn't work
- Creating custom Code extensions and debugging them doesn't work
- Extension profiling and tips are currently disabled
Some files were not shown because too many files have changed in this diff
Show More
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
