coder/code-server
1
0
Fork 0
mirror of https://github.com/coder/code-server.git synced 2026-04-12 18:28:17 -05:00
Code Issues Packages Projects Releases 202 Wiki Activity

Add skip-auth-preflight flag to allow OPTIONS requests through proxy (#7284)

Browse Source
This commit is contained in:
helgehatt
2025-04-14 21:27:02 +02:00
committed by GitHub
parent 9045919d2b
commit bbf2e24648
6 changed files with 34 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
test/unit/node/cli.test.ts
View File

@@ -108,6 +108,8 @@ describe("parser", () => {
["--abs-proxy-base-path", "/codeserver/app1"],
"--skip-auth-preflight",
["--session-socket", "/tmp/override-code-server-ipc-socket"],
["--host", "0.0.0.0"],
@@ -146,6 +148,7 @@ describe("parser", () => {
"bind-addr": "192.169.0.1:8080",
"session-socket": "/tmp/override-code-server-ipc-socket",
"abs-proxy-base-path": "/codeserver/app1",
"skip-auth-preflight": true,
})
})

15
test/unit/node/proxy.test.ts
View File

@@ -268,6 +268,21 @@ describe("proxy", () => {
const text = await resp.text()
expect(text).toBe("app being served behind a prefixed path")
})
it("should not allow OPTIONS without authentication by default", async () => {
process.env.PASSWORD = "test"
codeServer = await integration.setup(["--auth=password"])
const resp = await codeServer.fetch(proxyPath, { method: "OPTIONS" })
expect(resp.status).toBe(401)
})
it("should allow OPTIONS with `skip-auth-preflight` flag", async () => {
process.env.PASSWORD = "test"
codeServer = await integration.setup(["--auth=password", "--skip-auth-preflight"])
e.post("/wsup", (req, res) => {})
const resp = await codeServer.fetch(proxyPath, { method: "OPTIONS" })
expect(resp.status).toBe(200)
})
})
// NOTE@jsjoeio