1 Commits

Author	SHA1	Message	Date
Jared Snider	28902acec8	Auth/Innovation/PM-4517 - Device Management - Add Last Activity Date (#7302) ... * PM-4517 - Add LastActivityDate to Device entity, interfaces, DTOs, and response models Adds the LastActivityDate nullable DateTime property to the Device entity, IDeviceRepository interface (BumpLastActivityDateByIdAsync and BumpLastActivityDateByIdentifierAsync), DeviceAuthDetails DTO, DeviceResponseModel, DeviceAuthRequestResponseModel, and the DevicesLastActivityDate feature flag key in Constants. * PM-4517 - Add BumpDeviceLastActivityDateCommand with distributed cache guard Adds IBumpDeviceLastActivityDateCommand and IDeviceLastActivityCacheService interfaces with their implementations. The cache service uses the persistent keyed IDistributedCache (Cosmos DB in cloud, SQL Server in self-hosted) with a 48h TTL to guard against redundant DB writes within the same calendar day. Moves device DI registration into a consolidated AddDeviceServices() extension. * PM-4517 - Add LastActivityDate SQL schema, stored procedures, and MSSQL migration Adds LastActivityDate DATETIME2 column to the Device table. Updates Device_Create and Device_Update stored procedures. Adds Device_BumpLastActivityDateById and Device_BumpLastActivityDateByIdentifier stored procedures with a CAST AS DATE guard as a fallback against redundant writes when the application-layer cache is unavailable. * PM-4517 - Implement LastActivityDate repository methods and EF migrations Implements BumpLastActivityDateByIdAsync and BumpLastActivityDateByIdentifierAsync in both Dapper (via stored procedures) and EF (via ExecuteUpdateAsync with a date-level guard). Adds EF migrations for Postgres, SQLite, and MySQL. * PM-4517 - Bump device LastActivityDate on login and refresh token Wires IBumpDeviceLastActivityDateCommand into BaseRequestValidator (login path, keyed on device.Id) and CustomTokenRequestValidator (refresh token path, keyed on device identifier from subject claims). Both call sites are feature-flagged behind DevicesLastActivityDate. * PM-4517 - Move AddDeviceServices() to AddBaseServices alongside IDeviceService Device services are not user features — co-locating them with IDeviceService in AddBaseServices is more cohesive than nesting them inside AddUserServices. * PM-4517 - Swallow transient LastActivityDate bump failures to prevent auth disruption * PM-4517 - Fix DeviceAuthDetails Dapper constructor parameter order to match LastActivityDate column position * PM-4517 - Add edge case tests for BumpDeviceLastActivityForRefreshAsync guard conditions * PM-4517 - Add tests for BumpLastActivityDate flag-disabled, null-device, and happy-path cases * PM-4517 - Add PM-34091 cleanup TODOs to all DevicesLastActivityDate feature flag sites * PM-4517 - Refine PM-34091 cleanup TODOs and add missing feature flag disabled test for refresh path * PM-4517 - Remove redundant LastActivityDate shadow property from DeviceAuthDetails * PM-4517 - Use CultureInfo.InvariantCulture in date string formatting for CA1305 * PM-4517 - Make _bumpDeviceLastActivityDateCommand protected in base to remove duplicate field in derived class * PM-4517 - Scope device last activity cache key by userId to prevent cross-user collisions The Device table's unique constraint is (UserId, Identifier), not Identifier alone, so two users can share the same device identifier (e.g. account switching in a browser). Scoping the cache key to device:last-activity:{userId}:{identifier} ensures that a cache hit for one user never suppresses a DB write for another. Also adds userId to BumpByIdAsync signature and reorders params to be consistent with BumpByIdentifierAsync(string identifier, Guid userId). * PM-4517 - Widen try-catch in TryBumpDeviceLastActivityForRefreshAsync and add happy-path test Renames BumpDeviceLastActivityForRefreshAsync to TryBumpDeviceLastActivityForRefreshAsync to signal the swallow-on-error intent. Moves the try-catch to wrap the entire method body, including GetSubjectId() which can throw InvalidOperationException, so no exception can escape and disrupt token refresh. Also moves the XML doc comment to RecordActivityForInstallation where it belongs, and adds a happy-path test verifying BumpByIdentifierAsync is called with the correct identifier and userId. * PM-4517 - Capture DateTime.UtcNow once in EF bump methods to ensure consistent timestamp Avoids a minor inconsistency where the WHERE filter and SET clause could evaluate DateTime.UtcNow at slightly different moments, aligning behavior with the SQL stored procedures which use a single @RevisionDate parameter. * PM-4517 - Preserve LastActivityDate on Device_Update when null to prevent regressions Device_Update previously overwrote LastActivityDate unconditionally, meaning any unrelated device update (push token rotation, trust changes, deactivation) could silently regress a recently-bumped value. COALESCE preserves the existing DB value when NULL is passed, while still allowing callers to set it in the same write by passing a non-NULL value. The EF ReplaceAsync override applies the same semantics via IsModified = false. Integration test added to cover the preserve-on-null behaviour across all DB providers. * PM-4517 - Add docs * PM-4517 - Adjust docs * PM-4517 - Add test coverage for BumpLastActivityDateByIdentifierAsync * PM-4517 - Per PR feedback, add docs on IDeviceLastActivityCacheService * PM-4517 - Per PR feedback, adjust IBumpDeviceLastActivityDateCommand.BumpById to be bump by device instead b/c it has all what we need. * PM-4517 - Per PR feedback, add tech debt ticket. * PM-4517 - Rename BumpByIdentifierAsync to BumpByIdentifierAndUserIdAsync across the board. * PM-4517 - Per PR feedback, adjust stored proc names to meet SQL style requirements * PM-4517 - Replace COALESCE with CASE in Device_Update to prevent stale non-null LastActivityDate overwrites * PM-4517 - Add EF repository feature parity for replace logic + test to ensure we don't run into this again. * PM-4517 - Fix DB migration order after main merge. * PM-4517 - Regenerate EF DB migrations * PM-4517 - actually regenerate EF DB migrations * PM-4517 - Add LastActivityDate to Device_ReadActiveWithPendingAuthRequestsByUserId and integration tests	2026-04-16 11:45:26 -04:00