Commit Graph

6 Commits

Author SHA1 Message Date
John Harrington
44b818acc6 [PM-3836] Tools - Make Controllers, Services and API Models nullable (#7212)
* enable nullable on AzureSendFileStorageService

* LocalSendStorageService nullable

* revert primary constructor and begin updating some models

* SendRequestModel > nullable

* SendAccessResponseModel SendFileDownloadDataResponseModel SendFileUploadDataResponseModel > nullable

* SendResponseModel SendFileModel SendTextModel > nullable

* ImportCiphersController > nullable
2026-04-02 10:15:18 -07:00
John Harrington
6fcf007672 [PM-33232] Update UX implemented in PM-33219 to resolve VULN-458 (#7204)
* expect AuthType in request and update tests

* handle older clients lacking AuthType in request gracefully

* update exception message to match behavior

* use presence of AuthType to branch to new logic, preserving old for null AuthType
2026-03-19 13:36:51 -07:00
John Harrington
8d9ace60e2 [PM-33219] Resolve silent auth removal on Sends (#7160)
* remove null assignment to auth props and update tests

* update PutRemoveAuth comment for clarity and assign null to empty email list allowing future client side changes to remove ALL emails

* update test to match email removal expectation

* implement expected behavior and update tests

---------

Co-authored-by: Alex Dragovich <46065570+itsadrago@users.noreply.github.com>
2026-03-06 10:35:53 -08:00
Graham Walker
818934487f PM-18939 refactoring send service to 'cqrs' (#5652)
* PM-18939 refactoring send service to 'cqrs'

* PM-18939 fixing import issue with sendValidationService

* PM-18939 fixing code based on PR comments

* PM-18339 reverting to previous code in test

* PM-18939 adding XMLdocs to services

* PM-18939 reverting send validation methods

* PM-18939 updating code to match main

* PM-18939 reverting validateUserCanSaveAsync to match main

* PM-18939 fill our param and return sections of XMLdocs

* PM-18939 updating XMLdocs based on PR comments

* Update src/Core/Tools/SendFeatures/Commands/Interfaces/IAnonymousSendCommand.cs

Co-authored-by:  Audrey  <ajensen@bitwarden.com>

* Update src/Core/Tools/SendFeatures/Commands/Interfaces/INonAnonymousSendCommand.cs

Co-authored-by:  Audrey  <ajensen@bitwarden.com>

* Update src/Core/Tools/SendFeatures/Commands/Interfaces/INonAnonymousSendCommand.cs

Co-authored-by:  Audrey  <ajensen@bitwarden.com>

* Update src/Core/Tools/SendFeatures/Services/Interfaces/ISendStorageService.cs

Co-authored-by:  Audrey  <ajensen@bitwarden.com>

* PM-18939 adding commits to change tuple to enum type

* PM-18939 resetting stream position to 0 when uploading file

* PM-18939 updating XMLdocs based on PR comments

* PM-18939 updating XMLdocs

* PM-18939 removing circular dependency

* PM-18939 fixing based on comments

* PM-18939 updating method name and documentation

---------

Co-authored-by:  Audrey  <ajensen@bitwarden.com>
2025-05-19 22:59:30 -05:00
aj-rosado
f275b2567d [PM-517] Added validation to maximum and minimum expiry date (#4199)
* Added validation to maximum and minimum expiry date

* Updated error text on SendRequestModel

* Add tests to ValidateEdit on SendRequestModel
2024-06-21 13:56:43 +01:00
Daniel James Smith
4e7b9d2edd [PM-328] Move files for team-tools (#2857)
* Extract Import-Api endpoints into separate controller

Moved ciphers/import and ciphers/import-organization into new ImportController
Paths have been kept intact for now (no changes on clients needed)
Moved request-models used for import into tools-subfolder

* Update CODEOWNERS for team-tools-dev

* Move HibpController (reports) to tools

* Moving files related to Send

* Moving files related to ReferenceEvent

* Removed unneeded newline
2023-04-18 14:05:17 +02:00