bitwarden/server
1
0
Fork 0
mirror of https://github.com/bitwarden/server.git synced 2025-12-10 15:55:10 -06:00
Code Issues Packages Projects Releases 211 Wiki Activity

Refactor HasPremiumAccessQuery to throw NotFoundException for null users

Browse Source
This commit is contained in:
Rui Tome 2025-12-08 10:54:46 +00:00
parent b8ff0ea2c0
commit 415a0b93c4
No known key found for this signature in database
GPG Key ID: 526239D96A8EC066
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/Core/Billing/Premium/Queries/HasPremiumAccessQuery.cs
View File

@ -1,4 +1,5 @@
using Bit.Core.Repositories; using Bit.Core.Exceptions;
using Bit.Core.Repositories;
namespace Bit.Core.Billing.Premium.Queries; namespace Bit.Core.Billing.Premium.Queries;
@ -18,7 +19,11 @@ public class HasPremiumAccessQuery : IHasPremiumAccessQuery
public async Task<bool> HasPremiumAccessAsync(Guid userId) public async Task<bool> HasPremiumAccessAsync(Guid userId)
{ {
var user = await _userRepository.GetCalculatedPremiumAsync(userId); var user = await _userRepository.GetCalculatedPremiumAsync(userId);
return user?.HasPremiumAccess ?? false; if (user == null)
{
throw new NotFoundException();
}
return user.HasPremiumAccess;
} }
public async Task<Dictionary<Guid, bool>> HasPremiumAccessAsync(IEnumerable<Guid> userIds) public async Task<Dictionary<Guid, bool>> HasPremiumAccessAsync(IEnumerable<Guid> userIds)
@ -32,7 +37,7 @@ public class HasPremiumAccessQuery : IHasPremiumAccessQuery
var user = await _userRepository.GetCalculatedPremiumAsync(userId); var user = await _userRepository.GetCalculatedPremiumAsync(userId);
if (user == null) if (user == null)
{ {
return false; throw new NotFoundException();
} }
// Has org premium if has premium access but not personal premium // Has org premium if has premium access but not personal premium