From dddcb8d7760687348474edf274f71b533df15848 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=81lison=20Fernandes?= Date: Tue, 29 Jul 2025 19:28:01 +0100 Subject: [PATCH] [PM-21331] Update build-any.yml to upload BWA dsyms to Crashlytics (#1817) --- .github/workflows/_build-any.yml | 4 ++-- Scripts-bwa/upload_dsym_to_crashlytics.sh | 10 ---------- Scripts/upload_dsym_to_crashlytics.sh | 10 ---------- project-bwa.yml | 6 ------ project-pm.yml | 13 ------------- 5 files changed, 2 insertions(+), 41 deletions(-) delete mode 100755 Scripts-bwa/upload_dsym_to_crashlytics.sh delete mode 100755 Scripts/upload_dsym_to_crashlytics.sh diff --git a/.github/workflows/_build-any.yml b/.github/workflows/_build-any.yml index 0c3e6a073..4b37c2946 100644 --- a/.github/workflows/_build-any.yml +++ b/.github/workflows/_build-any.yml @@ -263,11 +263,11 @@ jobs: --apiIssuer "${{ steps.get-kv-secrets.outputs.APP-STORE-CONNECT-TEAM-ISSUER }}" - name: Upload dSYM files to Crashlytics - if: ${{ env._BUILD_MODE == 'Device' && startsWith(env._BW_ENV, 'bwpm') }} + if: ${{ env._BUILD_MODE == 'Device' }} continue-on-error: true run: | find $_EXPORT_PATH/dSYMs -name "*.dSYM" \ - -exec "build/DerivedData/SourcePackages/checkouts/firebase-ios-sdk/Crashlytics/upload-symbols" \ + -exec "./build/DerivedData/SourcePackages/checkouts/firebase-ios-sdk/Crashlytics/upload-symbols" \ -gsp $_CRASHLYTICS_PATH \ -p ios -- {} + diff --git a/Scripts-bwa/upload_dsym_to_crashlytics.sh b/Scripts-bwa/upload_dsym_to_crashlytics.sh deleted file mode 100755 index a6f3d5201..000000000 --- a/Scripts-bwa/upload_dsym_to_crashlytics.sh +++ /dev/null @@ -1,10 +0,0 @@ -#!/bin/bash - -set -euo pipefail - -if [ "$CONFIGURATION" != "Debug" ]; then - find "${DWARF_DSYM_FOLDER_PATH}" -name "*.dSYM" \ - -exec "${BUILD_DIR%Build/*}/SourcePackages/checkouts/firebase-ios-sdk/Crashlytics/upload-symbols" \ - -gsp "${PROJECT_DIR}/Authenticator/Application/Support/GoogleService-Info.plist" \ - -p ios -- {} + -fi diff --git a/Scripts/upload_dsym_to_crashlytics.sh b/Scripts/upload_dsym_to_crashlytics.sh deleted file mode 100755 index 4d6b7a1bc..000000000 --- a/Scripts/upload_dsym_to_crashlytics.sh +++ /dev/null @@ -1,10 +0,0 @@ -#!/bin/bash - -set -euo pipefail - -if [ "$CONFIGURATION" != "Debug" ]; then - find "${DWARF_DSYM_FOLDER_PATH}" -name "*.dSYM" \ - -exec "${BUILD_DIR%Build/*}/SourcePackages/checkouts/firebase-ios-sdk/Crashlytics/upload-symbols" \ - -gsp "${PROJECT_DIR}/Bitwarden/Application/Support/GoogleService-Info.plist" \ - -p ios -- {} + -fi diff --git a/project-bwa.yml b/project-bwa.yml index 813a4fdd3..7ecf2c16e 100644 --- a/project-bwa.yml +++ b/project-bwa.yml @@ -138,12 +138,6 @@ targets: - path: Scripts-bwa/update_settings_version_number.sh name: "Settings.bundle: Update Version Number" basedOnDependencyAnalysis: false - - path: Scripts-bwa/upload_dsym_to_crashlytics.sh - name: "Upload dSYM files to Crashlytics" - basedOnDependencyAnalysis: false - inputFiles: - - ${DWARF_DSYM_FOLDER_PATH}/${DWARF_DSYM_FILE_NAME}/Contents/Resources/DWARF/${TARGET_NAME} - - ${BUILT_PRODUCTS_DIR}/${INFOPLIST_PATH} AuthenticatorTests: type: bundle.unit-test platform: iOS diff --git a/project-pm.yml b/project-pm.yml index ff008280a..aeef84ca4 100644 --- a/project-pm.yml +++ b/project-pm.yml @@ -203,12 +203,6 @@ targets: - path: Scripts/update_settings_version_number.sh name: "Settings.bundle: Update Version Number" basedOnDependencyAnalysis: false - - path: Scripts/upload_dsym_to_crashlytics.sh - name: "Upload dSYM files to Crashlytics" - basedOnDependencyAnalysis: false - inputFiles: - - ${DWARF_DSYM_FOLDER_PATH}/${DWARF_DSYM_FILE_NAME}/Contents/Resources/DWARF/${TARGET_NAME} - - ${BUILT_PRODUCTS_DIR}/${INFOPLIST_PATH} BitwardenTests: type: bundle.unit-test platform: iOS @@ -451,13 +445,6 @@ targets: - target: BitwardenWatchWidgetExtension - package: Firebase product: FirebaseCrashlytics - postBuildScripts: - - path: Scripts/upload_watch_dsym_to_crashlytics.sh - name: "Upload watch dSYM files to Crashlytics" - basedOnDependencyAnalysis: false - inputFiles: - - ${DWARF_DSYM_FOLDER_PATH}/${DWARF_DSYM_FILE_NAME}/Contents/Resources/DWARF/${TARGET_NAME} - - ${BUILT_PRODUCTS_DIR}/${INFOPLIST_PATH} BitwardenWatchWidgetExtension: type: app-extension