bitwarden/ios
1
0
Fork 0
mirror of https://github.com/bitwarden/ios.git synced 2025-12-11 04:34:55 -06:00
Code Issues Packages Projects Releases 32 Wiki Activity

[BITAU-190] Sync With Bitwarden App Should Go to App Store When Not Installed (#179)

Browse Source
This commit is contained in:
Brant DeBow 2024-11-07 10:58:38 -05:00 committed by GitHub
parent a84c21d564
commit 89d269da48
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 24 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
AuthenticatorShared/UI/Platform/Settings/Settings/SettingsProcessor.swift
View File

@ -7,7 +7,8 @@ import OSLog
final class SettingsProcessor: StateProcessor<SettingsState, SettingsAction, SettingsEffect> {
// MARK: Types
typealias Services = HasAppSettingsStore
typealias Services = HasApplication
& HasAppSettingsStore
& HasAuthenticatorItemRepository
& HasBiometricsRepository
& HasConfigService
@ -83,7 +84,11 @@ final class SettingsProcessor: StateProcessor<SettingsState, SettingsAction, Set
self.state.url = ExternalLinksConstants.privacyPolicy
})
case .syncWithBitwardenAppTapped:
state.url = ExternalLinksConstants.passwordManagerSettings
if services.application?.canOpenURL(ExternalLinksConstants.passwordManagerScheme) ?? false {
state.url = ExternalLinksConstants.passwordManagerSettings
} else {
state.url = ExternalLinksConstants.passwordManagerLink
}
case let .toastShown(newValue):
state.toast = newValue
case .tutorialTapped:

16
AuthenticatorShared/UI/Platform/Settings/Settings/SettingsProcessorTests.swift
View File

@ -5,6 +5,7 @@ import XCTest
class SettingsProcessorTests: AuthenticatorTestCase {
// MARK: Properties
var application: MockApplication!
var appSettingsStore: MockAppSettingsStore!
var authItemRepository: MockAuthenticatorItemRepository!
var configService: MockConfigService!
@ -16,6 +17,7 @@ class SettingsProcessorTests: AuthenticatorTestCase {
override func setUp() {
super.setUp()
application = MockApplication()
appSettingsStore = MockAppSettingsStore()
authItemRepository = MockAuthenticatorItemRepository()
configService = MockConfigService()
@ -23,6 +25,7 @@ class SettingsProcessorTests: AuthenticatorTestCase {
subject = SettingsProcessor(
coordinator: coordinator.asAnyCoordinator(),
services: ServiceContainer.withMocks(
application: application,
appSettingsStore: appSettingsStore,
authenticatorItemRepository: authItemRepository,
configService: configService
@ -34,6 +37,7 @@ class SettingsProcessorTests: AuthenticatorTestCase {
override func tearDown() {
super.tearDown()
application = nil
appSettingsStore = nil
authItemRepository = nil
configService = nil
@ -123,9 +127,19 @@ class SettingsProcessorTests: AuthenticatorTestCase {
/// Receiving `.syncWithBitwardenAppTapped` adds the Password Manager settings URL to the state to
/// navigate the user to the PM app's settings.
func test_receive_syncWithBitwardenAppTapped() {
func test_receive_syncWithBitwardenAppTapped_installed() {
application.canOpenUrlResponse = true
subject.receive(.syncWithBitwardenAppTapped)
XCTAssertEqual(subject.state.url, ExternalLinksConstants.passwordManagerSettings)
}
/// Receiving `.syncWithBitwardenAppTapped` adds the Password Manager settings App Store URL to
/// the state to navigate the user to the App Store when the PM app is not installed..
func test_receive_syncWithBitwardenAppTapped_notInstalled() {
application.canOpenUrlResponse = false
subject.receive(.syncWithBitwardenAppTapped)
XCTAssertEqual(subject.state.url, ExternalLinksConstants.passwordManagerLink)
}
}

3
AuthenticatorShared/UI/Platform/Settings/SettingsCoordinator.swift
View File

@ -11,7 +11,8 @@ final class SettingsCoordinator: Coordinator, HasStackNavigator {
typealias Module = FileSelectionModule
& TutorialModule
typealias Services = HasAppSettingsStore
typealias Services = HasApplication
& HasAppSettingsStore
& HasAuthenticatorItemRepository
& HasBiometricsRepository
& HasCameraService