bitwarden/ios
1
0
Fork 0
mirror of https://github.com/bitwarden/ios.git synced 2025-12-10 00:42:29 -06:00
Code Issues Packages Projects Releases 32 Wiki Activity

[PM-24348] Update type_name lint rule max length from 40 to 50 (#1826)

Browse Source
This commit is contained in:
Federico Maccaroni 2025-08-05 11:29:53 -03:00 committed by GitHub
parent 63291d4b3a
commit 40201dd9fc
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
14 changed files with 15 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
.swiftlint.yml
View File

@ -79,6 +79,9 @@ type_contents_order:
- other_method
- subscript
type_name:
max_length: 50
identifier_name:
excluded:
- id

2
BitwardenShared/Core/Auth/Extensions/MasterPasswordPolicyOptionsExtensionsTests.swift
View File

@ -4,7 +4,7 @@ import XCTest
@testable import BitwardenShared
class MasterPasswordPolicyOptionsExtensionsTests: BitwardenTestCase { // swiftlint:disable:this type_name
class MasterPasswordPolicyOptionsExtensionsTests: BitwardenTestCase {
// MARK: Tests
/// `isInEffect` returns `false` if none of the policy options apply.

2
BitwardenShared/Core/Auth/Models/Response/OrganizationAutoEnrollStatusResponseModel.swift
View File

@ -4,7 +4,7 @@ import Networking
/// The response returned from the API when requesting the auto-enroll status for an organization.
///
struct OrganizationAutoEnrollStatusResponseModel: JSONResponse, Equatable { // swiftlint:disable:this type_name
struct OrganizationAutoEnrollStatusResponseModel: JSONResponse, Equatable {
// MARK: Properties
/// The organization's ID.

2
BitwardenShared/Core/Auth/Services/API/OrganizationUser/Requests/OrganizationUserResetPasswordEnrollmentRequest.swift
View File

@ -4,7 +4,7 @@ import Networking
/// A networking request to enroll the user in password reset for an organization.
///
struct OrganizationUserResetPasswordEnrollmentRequest: Request { // swiftlint:disable:this type_name
struct OrganizationUserResetPasswordEnrollmentRequest: Request {
typealias Response = EmptyResponse
// MARK: Properties

2
BitwardenShared/Core/Autofill/Models/ASPasskeyCredentialRequestExtensionsTests.swift
View File

@ -5,7 +5,7 @@ import XCTest
@testable import BitwardenShared
class ASPasskeyCredentialRequestExtensionsTests: BitwardenTestCase { // swiftlint:disable:this type_name
class ASPasskeyCredentialRequestExtensionsTests: BitwardenTestCase {
// MARK: Tests
/// `excludedCredentialsList()` gets the excluded credential list using the

2
BitwardenShared/Core/Autofill/Models/Fido2CredentialAutofillViewExtensionsTests.swift
View File

@ -4,7 +4,7 @@ import XCTest
import BitwardenResources
@testable import BitwardenShared
class Fido2CredentialAutofillViewExtensionsTests: BitwardenTestCase { // swiftlint:disable:this type_name
class Fido2CredentialAutofillViewExtensionsTests: BitwardenTestCase {
// MARK: Tests
/// `toFido2CredentialIdentity()` returns the converted `ASPasskeyCredentialIdentity`.

3
BitwardenShared/Core/Autofill/Models/PublicKeyCredentialDescriptorExtensionsTests.swift
View File

@ -6,7 +6,6 @@ import XCTest
// MARK: - ASAuthorizationPublicKeyCredentialDescriptorExtensionTests
// swiftlint:disable:next type_name
class PublicKeyCredentialDescriptorExtensionsTests: BitwardenTestCase {
// MARK: Tests
@ -26,8 +25,6 @@ class PublicKeyCredentialDescriptorExtensionsTests: BitwardenTestCase {
/// A mock of `ASAuthorizationPublicKeyCredentialDescriptor`.
class MockASAuthorizationPublicKeyCredentialDescriptor: NSObject, ASAuthorizationPublicKeyCredentialDescriptor {
// swiftlint:disable:previous type_name
// MARK: Properties
static var supportsSecureCoding = false

2
BitwardenShared/Core/Autofill/Models/PublicKeyCredentialParametersExtensionsTests.swift
View File

@ -3,7 +3,7 @@ import XCTest
@testable import BitwardenShared
class PublicKeyCredentialParametersExtensionsTests: BitwardenTestCase { // swiftlint:disable:this type_name
class PublicKeyCredentialParametersExtensionsTests: BitwardenTestCase {
let publicKeyType = "public-key"
// MARK: Tests

6
BitwardenShared/Core/Vault/Extensions/BitwardenSdkVaultTests.swift
View File

@ -8,7 +8,7 @@ import XCTest
// MARK: - BitwardenSdk.CipherType
class BitwardenSdkVaultBitwardenCipherTypeTests: BitwardenTestCase { // swiftlint:disable:this type_name
class BitwardenSdkVaultBitwardenCipherTypeTests: BitwardenTestCase {
// MARK: Tests
/// `init(type:)` initializes the SDK cipher type based on the cipher type.
@ -44,7 +44,7 @@ class BitwardenSdkVaultCipherTests: BitwardenTestCase {
// MARK: - CipherDetailsResponseModel
class BitwardenSdkVaultCipherDetailsResponseModelTests: BitwardenTestCase { // swiftlint:disable:this type_name
class BitwardenSdkVaultCipherDetailsResponseModelTests: BitwardenTestCase {
// MARK: Tests
/// `init(cipher:)` Inits a cipher details response model from an SDK cipher without id throws.
@ -266,7 +266,7 @@ class CipherViewTests: BitwardenTestCase {
// MARK: - Collection
class BitwardenSdkVaultBitwardenCollectionTests: BitwardenTestCase { // swiftlint:disable:this type_name
class BitwardenSdkVaultBitwardenCollectionTests: BitwardenTestCase {
/// `init(collectionDetailsResponseModel:)` sets `manage` with the value in the model
/// if the server sent a value
func test_init_manageNotNull() {

2
BitwardenShared/Core/Vault/Helpers/VaultListPreparedDataBuilder.swift
View File

@ -13,8 +13,6 @@ protocol VaultListPreparedDataBuilderFactory { // sourcery: AutoMockable
/// The default implementation of `VaultListPreparedDataBuilderFactory`.
struct DefaultVaultListPreparedDataBuilderFactory: VaultListPreparedDataBuilderFactory {
// swiftlint:disable:previous type_name
/// The service used by the application to handle encryption and decryption tasks.
let clientService: ClientService
/// The service used by the application to report non-fatal errors.

2
BitwardenShared/Core/Vault/Services/Fido2CredentialStoreServiceTests.swift
View File

@ -333,7 +333,7 @@ class Fido2CredentialStoreServiceTests: BitwardenTestCase { // swiftlint:disable
}
}
class DebuggingFido2CredentialStoreServiceTests: BitwardenTestCase { // swiftlint:disable:this type_name
class DebuggingFido2CredentialStoreServiceTests: BitwardenTestCase {
// MARK: Properties
var fido2CredentialStore: MockFido2CredentialStore!

2
BitwardenShared/UI/Autofill/Utilities/Fido2UserVerificationMediatorTests.swift
View File

@ -421,7 +421,7 @@ class Fido2UserVerificationMediatorTests: BitwardenTestCase { // swiftlint:disab
}
}
class MockFido2UserVerificationMediatorDelegate: // swiftlint:disable:this type_name
class MockFido2UserVerificationMediatorDelegate:
MockUserVerificationHelperDelegate,
Fido2UserVerificationMediatorDelegate {
var onNeedsUserInteractionCalled = false

1
BitwardenShared/UI/Platform/Application/Utilities/PendingAppIntentActionMediatorTests.swift
View File

@ -153,7 +153,6 @@ class PendingAppIntentActionMediatorTests: BitwardenTestCase {
}
class MockPendingAppIntentActionMediatorDelegate: PendingAppIntentActionMediatorDelegate {
// swiftlint:disable:previous type_name
var onPendingAppIntentActionSuccessAction: PendingAppIntentAction?
var onPendingAppIntentActionSuccessData: Any?

2
BitwardenShared/UI/Vault/Vault/AutofillList/VaultAutofillListProcessor+AutofillModeAllTests.swift
View File

@ -9,7 +9,7 @@ import XCTest
@testable import BitwardenShared
@available(iOS 18.0, *)
class VaultAutofillListProcessorAutofillModeAllTests: BitwardenTestCase { // swiftlint:disable:this type_name line_length
class VaultAutofillListProcessorAutofillModeAllTests: BitwardenTestCase {
// MARK: Properties
var appExtensionDelegate: MockAutofillAppExtensionDelegate!