* Add IncreaseBulkReinviteLimitForCloud feature flag * Enhance PeopleTableDataSource with bulk operation limits and feature flag integration - Introduced a new feature flag to increase the bulk reinvite limit for cloud environments. - Added an observable to determine if the increased limit is enabled based on the feature flag and environment. - Updated the logic for enforcing checked user limits in bulk operations, allowing for a maximum of 4000 users when the feature flag is active. - Refactored the constructor to initialize the new observable and manage the maximum allowed checked count dynamically. * Add unit tests for PeopleTableDataSource to validate user limit enforcement and status counts * Refactor MembersComponent to integrate increased bulk limit feature - Added support for conditional user limit enforcement in bulk operations based on a feature flag. - Introduced new dependencies for ConfigService and EnvironmentService to manage configuration settings. - Updated methods to utilize the new getCheckedUsers function, which enforces limits when the feature is enabled. - Refactored data source initialization to accommodate the new logic for handling checked users. * Refactor enforceCheckedUserLimit method in PeopleTableDataSource to use filtered data for user limit enforcement and to keep checked the top rows. Removed unnecessary comments and improved readability. * Add bulk reinvite success messages to localization files This update introduces new localization keys for bulk reinvite success notifications, including a general success message and a limited success message that provides details on the number of users re-invited and those excluded due to limits. This enhances user feedback during bulk operations. * Enhance bulk reinvite functionality with toast notifications This update modifies the MembersComponent to display success messages via toast notifications when the feature flag for increased bulk limits is enabled. If the limit is exceeded, a detailed message is shown, otherwise a general success message is displayed. The legacy dialog is retained for cases when the feature flag is disabled, ensuring consistent user feedback during bulk reinvite operations. * Rename MaxBulkReinviteCount to CloudBulkReinviteLimit * Refactor user retrieval logic in MembersComponent to conditionally enforce bulk limits This update modifies the MembersComponent in both the admin console and provider management sections to replace the direct calls to getCheckedUsers() with a conditional check for increased bulk limit feature. If enabled, it enforces user limits; otherwise, it retrieves all checked users. The deprecated getCheckedUsers method has been removed to streamline the code. * Add constructor to MembersTableDataSource for improved dependency injection This update introduces a constructor to the MembersTableDataSource class in both the admin console and provider management sections, allowing for better dependency injection of ConfigService, EnvironmentService, and DestroyRef. This change enhances the overall structure and maintainability of the code. * Refactor PeopleTableDataSource and MembersComponent to implement new bulk limit logic This update modifies the PeopleTableDataSource to introduce a new property for managing increased bulk limits and refactors the MembersComponent to utilize this logic. The enforcement of user limits during bulk operations is now conditional based on the feature flag, allowing for a more flexible handling of user selections. Additionally, the method for limiting and unchecking excess users has been updated for clarity and efficiency. * Refactor PeopleTableDataSource tests to update limit enforcement logic This update modifies the test cases for the PeopleTableDataSource to reflect the new method for limiting and unchecking excess users. The method name has been changed from `enforceCheckedUserLimit` to `limitAndUncheckExcess`, and the tests have been adjusted accordingly to ensure they accurately validate the new functionality. Additionally, unnecessary tests have been removed to streamline the test suite. * Change CloudBulkReinviteLimit back to 4000 * Refactor MembersComponent to utilize new getCheckedUsersInVisibleOrder method This update modifies the MembersComponent to conditionally retrieve checked users based on the increased bulk limit feature. If enabled, it uses the new getCheckedUsersInVisibleOrder method to maintain visual consistency in the filtered/sorted table view. This change enhances the handling of user selections during bulk operations. * Refactor PeopleTableDataSource to use Signals for increased bulk limit feature and update related tests. Removed unused imports and dependencies on DestroyRef in MembersTableDataSource components. * Refactor MembersComponent to remove unused Signal for increased bulk limit and directly utilize dataSource method for feature flag checks. * Implement getCheckedUsersWithLimit method to streamline user retrieval based on feature flag; update MembersComponent to utilize this new method for bulk actions.
Bitwarden Client Applications
This repository houses all Bitwarden client applications except the mobile applications (iOS | android).
Please refer to the Clients section of the Contributing Documentation for build instructions, recommended tooling, code style tips, and lots of other great information to get you started.
Related projects:
- bitwarden/server: The core infrastructure backend (API, database, Docker, etc).
- bitwarden/ios: Bitwarden iOS Password Manager & Authenticator apps.
- bitwarden/android: Bitwarden Android Password Manager & Authenticator apps.
- bitwarden/directory-connector: A tool for syncing a directory (AD, LDAP, Azure, G Suite, Okta) to an organization.
We're Hiring!
Interested in contributing in a big way? Consider joining our team! We're hiring for many positions. Please take a look at our Careers page to see what opportunities are currently open as well as what it's like to work at Bitwarden.
Contribute
Code contributions are welcome! Please commit any pull requests against the main branch. Learn more about how to contribute by reading the Contributing Guidelines. Check out the Contributing Documentation for how to get started with your first contribution.
Security audits and feedback are welcome. Please open an issue or email us privately if the report is sensitive in nature. You can read our security policy in the SECURITY.md file.