2766 Commits

Author SHA1 Message Date
Shane Melton
a5f610ecf3
[PM-24689] Handle possible null active account (#16006)
(cherry picked from commit d825b5c6e539f8d41b32ab625af61eb003320864)
2025-08-13 11:59:59 -07:00
✨ Audrey ✨
6ab67e9a8f
[PM-23532] introduce send access guard (#15529)
* document expected auth flows
* implement send access trampoline
2025-08-08 14:28:03 -04:00
Stephon Brown
a75f9dc9f0
Billing/pm 22625/tax id should not be saved when hidden (#15905)
* fix: add logic for ngOnUpdate

* fix: use markAsTouched function

* tests: add component tests
2025-08-08 15:33:34 +00:00
bitwarden-charlie
7835d01456
chore/SRE-583 Deprecate usage of Auth-Email Header (#14418)
* chore/SRE-583 Deprecate usage of Auth-Email Header

* SRE-583 additional cleanup

* SRE-583 removed Utils

* SRE-583 formatting

---------

Co-authored-by: sneakernuts <671942+sneakernuts@users.noreply.github.com>
2025-08-08 08:26:03 -06:00
rr-bw
c5e5417abf
fix(device-management-sorting): [Auth/PM-24046] Device Management Sorting (#15889)
This PR makes it so the devices are always sorted in this order (by default):

1. Has Pending Auth Request (if any) comes first
2. Current Device comes second (or first if there are no pending auth requests)
3. First Login Date - the rest of the devices are sorted by first login date (newest to oldest)

This sort order is preserved even after a user approves/denies and auth request - that is, the approved/denied device will re-sort to its correct position according to it's first login date.

Feature Flag: `PM14938_BrowserExtensionLoginApproval`
2025-08-07 13:46:02 -07:00
Jason Ng
2ef8b1a6bf
[PM-18066] new item details view (#15311)
* update item details v2 in libs for new view design. targets web, browser, and desktop
2025-08-07 13:21:24 -04:00
Andreas Coroiu
c3f6892f9e
[PM-24451] firefox extension crash due to huge memory usage when unlocking vault (#15938)
* feat: only set badge state for the active tab

* fix: tests

* feat: avoid calculating states unecessarily

* Revert BrowserApi.removeListener change

* Add fatal log on observable failure

* Use fromChromeEvent

* Remove required-using tests

* Only disable some

* One of each

---------

Co-authored-by: Justin Baur <19896123+justindbaur@users.noreply.github.com>
2025-08-07 13:19:14 -04:00
rr-bw
46046ca1fa
fix(change-password-prompt) [Auth/PM-22356] Scope org invite email to submitted email (#15783)
Adds a check to make sure that the email on the Org Invite matches the email submitted in the form. If it matches, only then do we apply the org invite to get the MP policies. But if the emails do not match, it means the user attempting to login is no longer the user who originally clicked the emailed org invite link. Therefore, we clear the Org Invite + Deep Link and allow the user to login as normal.
2025-08-07 08:19:35 -07:00
Justin Baur
804ad79877
Fix extra signalr connection web (#15633)
* Revert "fix(SignalR): Revert "[PM-23062] Fix extra signalr connections""

This reverts commit 97ec9a633988cbed7790ced508368e37384f5ca9.

* Fix first login on web
2025-08-07 08:48:46 -04:00
Vicki League
8ae015f2d8
[CL-372] Add required type attr to buttons in stories (#15892) 2025-08-06 16:16:17 -04:00
Vicki League
6ec0a61b7e
[CL-682] Convert color password enum to const (#15908) 2025-08-06 14:35:37 -04:00
Brandon Treston
29e16fc5e0
[PM-22107] Update Remove Individual Vault policy dialog (#15323)
* WIP

* switch to signal

* fix ts strict errors

* clean up

* refactor policy list service

* implement vnext component

* refactor to include feature flag check in display()

* CR feedback

* refactor submit to cancel before request is built

* clean up

* Fix typo

---------

Co-authored-by: Thomas Rittson <31796059+eliykat@users.noreply.github.com>
2025-08-06 09:34:43 -04:00
Thomas Rittson
61cd0c4f51
[PM-23920] Admin Console - adopt strongly typed guids (#15814)
Update organization, collection and policy to use strongly typed IDs
2025-08-06 15:27:52 +10:00
Addison Beck
033642c0db
docs: document the basic-lib generator (#15891) 2025-08-05 12:21:16 -04:00
Daniel Riera
2549afc45d
PM-23890 Update overlays when a cipher is deleted (#15800)
* PM-23890 WIP

* add messaging service references

* Revert "PM-19574 Browser Autofill overlay displays outdated data (#15624)"

This reverts commit 9eceaa3d4c929e4dc40fb4bf3415580f655f4d6c.

* add test

* fix merge spacing

* Revert "Revert "PM-19574 Browser Autofill overlay displays outdated data (#15624)""

This reverts commit 0fc6ec4d0bb8af2901f47f51e6d894605beea107.
2025-08-05 12:17:38 -04:00
Bryan Cunningham
5f5f771adb
[CL-754] Fix shift when closing sidenav (#15849)
* update shield logo and container padding

* Fix horizontal icon shift

* use absolutel position to fix shield shifting

* add new shield and admin console logo

* add new logos

* add business unit portal logo

* delete redundant logos

* add missing fill color class
2025-08-05 11:06:23 -04:00
Vicki League
26c0176e2e
[CL-712] Update icon button, components using it, and affected virtual scroll heights (#15683) 2025-08-05 10:58:49 -04:00
Rui Tomé
40a1a0a2b7
[PM-22241] Add DefaultUserCollectionName support to bulk organization user confirmation (#15873)
* Add bulk user confirmation method to OrganizationUserService

* Update OrganizationUserBulkConfirmRequest to include optional defaultUserCollectionName property

* Implement conditional bulk user confirmation logic in BulkConfirmDialogComponent.

Its gated behind the feature flag for default user collection.

* Refactor OrganizationUserBulkConfirmRequest to use SdkEncString for defaultUserCollectionName

* Refactor BulkConfirmDialogComponent to use organization object instead of organizationId for improved clarity and type safety.

* Add unit tests for OrganizationUserService to validate user single/bulk confirmation logic

* Refactor OrganizationUserService to streamline encrypted collection name retrieval by introducing getEncryptedDefaultCollectionName$ method.

* Refactor unit tests for OrganizationUserService to reduce duplication by introducing a setupCommonMocks function for common mock configurations.

* refactor(organization-user.service): streamline retrieval of encrypted collection name in bulk confirmation process
2025-08-05 15:34:17 +01:00
Thomas Avery
2a3e1ae1f5
[PM-23619] Remove getPrivateKey from the key service and update consumers (#15784)
* remove getPrivateKey from keyService

* Update consumer code

* Increase unit test coverage
2025-08-05 09:25:50 -05:00
Nick Krantz
7145092889
[PM-24119] Manually open extension message (#15827)
* refactor manually open extension error message to a separate component

* allow icons and max width to be updated via setAnonLayoutWrapperData

* set error state when the extension fails to open

* bump timeout to 2000ms. I was seeing false error states when attempting to open the extension

* fix initialization of css variables
2025-08-05 08:42:05 -05:00
Andrei
80b74b3300
[PM-22472] break generated passphrase on separators (#15112) 2025-08-04 15:50:32 -04:00
rr-bw
25ada6f80f
refactor(login-approval-component) [Auth/PM-14940] Update LoginApprovalComponent (#15511)
- Renames the `LoginApprovalComponent` to `LoginApprovalDialogComponent`
- Renames the property `notificationId` to `authRequestId` for clarity
- Updates text content on the component
2025-08-04 09:20:12 -07:00
Patrick-Pimentel-Bitwarden
0bd48f6e58
fix(auth-request): [PM-24376] - Fixed bad logic for selecting which email to use to log in with. (#15875) 2025-08-04 11:44:56 -04:00
Bernd Schoolmann
25ae1f1aa7
Fix broken build (#15888) 2025-08-04 17:36:00 +02:00
Bernd Schoolmann
2e9a47721e
Remove legacy key support in vault code (#15348) 2025-08-04 08:15:26 -07:00
Bernd Schoolmann
6bd8638ad8
[PM-24126] Move pin service to km ownership (#15821)
* Move pin service to km ownership

* Run format

* Eslint

* Fix tsconfig

* Fix imports and test

* Clean up imports

* Remove unused dependency on PinService

* Fix comments

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2025-08-04 17:01:39 +02:00
Addison Beck
361f7e3447
refactor: introduce @bitwarden/state and other common libs (#15772)
* refactor: introduce @bitwarden/serialization

* refactor: introduce @bitwarden/guid

* refactor: introduce @bitwaren/client-type

* refactor: introduce @bitwarden/core-test-utils

* refactor: introduce @bitwarden/state and @bitwarden/state-test-utils

Creates initial project structure for centralized application state management. Part of modularization effort to extract state code from common.

* Added state provider documentation to README.

* Changed callouts to Github format.

* Fixed linting on file name.

* Forced git to accept rename

---------

Co-authored-by: Todd Martin <tmartin@bitwarden.com>
2025-08-04 11:01:28 -04:00
Vicki League
f7cc937581
[CL-753] Fix popover spacing in client code (#15839) 2025-08-04 10:19:07 -04:00
Maciej Zieniuk
8a22dca877
lock component unit test coverage (#15801) 2025-08-02 14:55:14 +02:00
renovate[bot]
2dd6164fce
[deps] Autofill: Update prettier to v3.6.2 (#15496)
* [deps] Autofill: Update prettier to v3.6.2

* fix: [PM-23425] Fix prettier issues related to dependency updte

Signed-off-by: Ben Brooks <bbrooks@bitwarden.com>

* [deps] Autofill: Update prettier to v3.6.2

---------

Signed-off-by: Ben Brooks <bbrooks@bitwarden.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Ben Brooks <bbrooks@bitwarden.com>
2025-08-01 14:02:54 -07:00
Bernd Schoolmann
0cc473fb0f
Remove legacy key support form platform code (#15351) 2025-08-01 13:06:22 -05:00
Dave Brothers
e47dc174a0
fix(login-component): [Auth/PM-19475] button icons are not marked as aria-hidden="true" (#15866) 2025-08-01 09:09:35 -04:00
Alex Morask
18bce185f0
Fix TaxService.previewTaxAmountForOrganizationTrial return type (#15848) 2025-07-31 08:19:20 -05:00
Justin Baur
4f9b2b618f
[PM-24280] Remove account service from state (#15828)
* Introduce ActiveUserAccessor

* Use ActiveUserAccessor over AccountService

* Updates tests and testing utils to support ActiveUserAccessor

* Update all injection points

* Fix types test

* Use ternary instead
2025-07-31 09:09:14 -04:00
Bernd Schoolmann
021d275c43
[PM-24079] Switch EncryptedString to SDK type (#15796)
* Update usages of sdk to type-safe SDK type

* Update sdk version

* Update to "toSdk"
2025-07-30 23:49:50 +02:00
Jordan Aasen
1c5095806f
[PM-24232] - [Defect][Web] Admin Console - SSH key and Folder should not show as options from New button (#15834)
* properly call input functions

* don't enable sshkey form

* fix logic for disabling cipher form

* prefer use of observable

* use destroyRef. change to enabled status only
2025-07-30 12:15:59 -07:00
Bernd Schoolmann
5dae5267d9
[PM-22623] Remove most TS encryption code, remove service workers (#15153)
* Add new encrypt service functions

* Undo changes

* Cleanup

* Fix build

* Fix comments

* Switch encrypt service to use SDK functions

* Move remaining functions to PureCrypto

* Tests

* Increase test coverage

* Enforce sdk.ready and drop unused codepaths

* Delete unused code

* Delete unused code

* Delete more code

* Add forgotten sdk init logic

* Fix build

* Fix cli

* Fix tests

* Fix build

* Fix browser build

* Remove compare and add more comments / warnings

* Run prettier

* Remove unused feature flags

* Add hazmat warning to aesDecrypt

* Fix build

* Fix comment

* Fix test
2025-07-30 15:50:00 +02:00
Bryan Cunningham
f6e8df18c0
[CL-587] disabled item styles (#15822)
* wip

* remove cursor not allowed

* add disabled button story

* add cursor not allowed
2025-07-29 16:12:01 -04:00
Vicki League
6a2d8ee294
[CL-768] Fix small a11y errors in storybook stories (#15826) 2025-07-29 14:29:37 -04:00
Bernd Schoolmann
a7d3c0f5c2
[PM-23809] Add simplified interface to MP service (#15631)
* Add new mp service api

* Fix tests

* Add test coverage

* Add newline

* Fix type

* Rename to "unwrapUserKeyFromMasterPasswordUnlockData"

* Fix build

* Fix build on cli

* Fix linting

* Re-sort spec

* Add tests

* Fix test and build issues

* Fix build

* Clean up

* Remove introduced function

* Clean up comments

* Fix abstract class types

* Fix comments

* Cleanup

* Cleanup

* Update libs/common/src/key-management/master-password/types/master-password.types.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update libs/common/src/key-management/master-password/services/master-password.service.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update libs/common/src/key-management/master-password/abstractions/master-password.service.abstraction.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update libs/common/src/key-management/master-password/types/master-password.types.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update libs/common/src/key-management/master-password/abstractions/master-password.service.abstraction.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Add comments

* Fix build

* Add arg null check

* Cleanup

* Fix build

* Fix build on browser

* Update libs/common/src/key-management/master-password/abstractions/master-password.service.abstraction.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update libs/common/src/key-management/master-password/abstractions/master-password.service.abstraction.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update libs/common/src/key-management/master-password/abstractions/master-password.service.abstraction.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Add tests for null params

* Cleanup and deprecate more functions

* Fix formatting

* Prettier

* Clean up

* Update libs/key-management/src/abstractions/key.service.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Make emailToSalt private and expose abstract saltForUser

* Add tests

* Add docs

* Update libs/common/src/key-management/master-password/abstractions/master-password.service.abstraction.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update libs/common/src/key-management/master-password/abstractions/master-password.service.abstraction.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

---------

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>
2025-07-29 18:53:17 +02:00
Oscar Hinton
e3d5385661
Migrate UIF to use takeuntilDestroyed (#15777) 2025-07-29 10:17:30 +02:00
adudek-bw
33ed9ac6ac
[PM-19976] Implement SDK generator engines (#15063)
* Hook up sdk engines to feature flag

---------

Co-authored-by:  Audrey  <ajensen@bitwarden.com>
2025-07-28 16:52:19 -04:00
Will Martin
f34260bc5e
[CL-800] delete a11y-grid, a11y-row, a11y-cell directives (#15709)
* delete a11y-grid,-row,-cell directives

* remove missed references

* remove missed references
2025-07-28 14:12:56 -04:00
Shane Melton
b48d7d4b97
[PM-23085] Use SDK to get rotated cipher data (#15670)
* [PM-23085] Add encryptWithKey method to CipherEncryptionService

* [PM-23085] Use new encryptWithKey() SDK method in getRotatedData() based on feature flag

* [PM-23085] Rename cipher encryption method to encryptCipherForRotation to better reflect intended use case

* [PM-23085] Update @bitwarden/sdk-internal package version

* [PM-23085] Fix failing test after method rename

* [PM-23085] Fix other failing test

* [PM-23085] Typo
2025-07-28 10:36:34 -07:00
Bernd Schoolmann
edeb0f4597
Remove decrypt with key from EncString, domain-base (#15702) 2025-07-28 18:18:36 +02:00
Alex Morask
f4254ba920
[PM-21821] Provider portal takeover states (#15725)
* Updates:

- Update simple dialog to disallow user to close the dialog on acceptance
- Split payment components to provide a "require" component that cannot be closed out of
- Add provider warning service to manage the various provider warnings

* Fix test

* Will's feedback and sync on payment method success
2025-07-28 09:26:19 -05:00
Thomas Avery
2db31d1228
[PM-22611] Require userid for masterKey methods on the key service (#15663)
* Require userId on targeted methods.

* update method consumers

* unit tests
2025-07-25 09:37:04 -05:00
Tom
b358d5663d
[PM-23822] [PM-23823] Organization integration and configuration api services (#15763)
* Adding the organization integration api service and test cases

* Adding configuration api files and test cases. Fixing the id guids and integration type and event type nullable

* Adding get endpoint methods to the integration and config service and test cases

* fixing type check issues

* lowercase directory name
2025-07-25 09:43:41 -04:00
Vicki League
37987f4f97
[CL-801] Move popover in kitchen sink story to avoid scrolling (#15767) 2025-07-25 08:34:39 -04:00
Bernd Schoolmann
594455af88
[PM-23099] Prevent private key regen / private key generation on v2 accounts (#15413)
* Prevent private key regen / private key generation on v2 accounts

* Fix tests

* Fix build

* Fix tests
2025-07-25 13:19:48 +02:00