bitwarden/android
1
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2025-12-10 09:56:45 -06:00
Code Issues Packages Projects Releases 169 Wiki Activity

Update BitwardenPasswordField semantics to support accessibility for visible passwords

Browse Source 
Improve accessibility support in `BitwardenPasswordField` by ensuring Talkback can read the password aloud when the user chooses to make it visible, while explicitly marking the content as sensitive data.

Behavioral changes:
*   When the "show password" toggle is active, Talkback will now read the actual password text instead of silence or obfuscated characters. This behavior occurs regardless of the system-wide "Speak Passwords" setting due to the custom visual transformation usage.
*   The field is semantically marked as containing sensitive data.

Specific changes:
*   Apply a `semantics` modifier to the internal `TextField` in `BitwardenPasswordField`.
*   Set `contentDescription` to the actual text value only when `showPassword` is true; otherwise, it defaults to an empty string.
*   Set the `isSensitiveData` semantic property to `true`.
This commit is contained in:
Patrick Honkonen 2025-12-03 14:13:37 -05:00
parent 26e7178300
commit ae5e4cace3
No known key found for this signature in database
GPG Key ID: 27C65CF8B03CC9FB
1 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
ui/src/main/kotlin/com/bitwarden/ui/platform/components/field/BitwardenPasswordField.kt
View File

@ -36,6 +36,9 @@ import androidx.compose.ui.platform.LocalFocusManager
import androidx.compose.ui.platform.LocalTextToolbar
import androidx.compose.ui.platform.TextToolbar
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.semantics.contentDescription
import androidx.compose.ui.semantics.isSensitiveData
import androidx.compose.ui.semantics.semantics
import androidx.compose.ui.text.input.ImeAction
import androidx.compose.ui.text.input.KeyboardType
import androidx.compose.ui.text.input.PasswordVisualTransformation
@ -228,6 +231,19 @@ fun BitwardenPasswordField(
)
},
modifier = Modifier
.semantics {
// Content description must be set to the field value in order for Talkback
// to speak the password aloud when it is visible because we apply a custom
// VisualTransformation to the text, which prevents Talkback from reading
// the value as it normally would.
// NOTE: This overrides the default behavior of Talkback's "Speak Passwords"
// setting. When visible, the password will always be spoken aloud
// regardless of the user's configuration.
contentDescription = textFieldValue.text
.takeUnless { !showPassword }
.orEmpty()
isSensitiveData = true
}
.nullableTestTag(tag = passwordFieldTestTag)
.fillMaxWidth()
.onFocusChanged { focusState -> focused = focusState.isFocused },