bitwarden/android
1
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2025-12-10 09:56:45 -06:00
Code Issues Packages Projects Releases 169 Wiki Activity

Add code formatting to file paths and code references

Browse Source 
This commit updates the `reviewing-changes/SKILL.md` document to improve readability. Code formatting (using backticks) has been applied to file paths, file extensions, and code-specific terms such as `StateFlow`, `@HiltViewModel`, and `biometricPrompt`.
This commit is contained in:
Patrick Honkonen 2025-10-23 18:16:58 -04:00
parent 9a0bd0b371
commit 60d00cf4ea
No known key found for this signature in database
GPG Key ID: 27C65CF8B03CC9FB
1 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
.claude/skills/reviewing-changes/SKILL.md
View File

@ -15,14 +15,14 @@ Start with high-level assessment of the change's purpose and approach. Read PR/c
### Step 2: Verify Compliance
Systematically check each area against Bitwarden standards documented in CLAUDE.md:
Systematically check each area against Bitwarden standards documented in `CLAUDE.md`:
1. **Architecture**: Follow patterns in docs/ARCHITECTURE.md
- MVVM + UDF (ViewModels with StateFlow, Compose UI)
- Hilt DI (interface injection, @HiltViewModel)
1. **Architecture**: Follow patterns in `docs/ARCHITECTURE.md`
- MVVM + UDF (ViewModels with `StateFlow`, Compose UI)
- Hilt DI (interface injection, `@HiltViewModel`)
- Repository pattern and proper data flow
2. **Style**: Adhere to docs/STYLE_AND_BEST_PRACTICES.md
2. **Style**: Adhere to `docs/STYLE_AND_BEST_PRACTICES.md`
- Naming conventions, code organization, formatting
- Kotlin idioms (immutability, null safety, coroutines)
@ -47,7 +47,7 @@ Systematically check each area against Bitwarden standards documented in CLAUDE.
### Step 3: Document Findings
Identify specific violations with file:line_number references. Be precise about locations.
Identify specific violations with `file:line_number` references. Be precise about locations.
### Step 4: Provide Recommendations
@ -77,13 +77,13 @@ Note well-implemented patterns (briefly, without elaboration). Keep positive fee
This PR adds biometric authentication to the login flow, implementing MVVM pattern with proper state management.
## Critical Issues
- app/login/LoginViewModel.kt:45 - Mutable state exposed; use StateFlow instead of MutableStateFlow
- data/auth/BiometricRepository.kt:120 - Missing null safety check on biometricPrompt result
- `app/login/LoginViewModel.kt:45` - Mutable state exposed; use `StateFlow` instead of `MutableStateFlow`
- `data/auth/BiometricRepository.kt:120` - Missing null safety check on `biometricPrompt` result
## Suggested Improvements
- Consider extracting biometric prompt logic to separate use case class
- Add integration tests for biometric failure scenarios
- app/login/LoginScreen.kt:89 - Consider using existing BitwardenButton component
- `app/login/LoginScreen.kt:89` - Consider using existing `BitwardenButton` component
## Good Practices
- Proper Hilt DI usage throughout
@ -91,8 +91,8 @@ This PR adds biometric authentication to the login flow, implementing MVVM patte
- Clear separation of concerns
## Action Items
1. Fix mutable state exposure in LoginViewModel
2. Add null safety check in BiometricRepository
1. Fix mutable state exposure in `LoginViewModel`
2. Add null safety check in `BiometricRepository`
3. Consider adding integration tests for error flows
```