bitwarden/android
1
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2025-12-10 09:56:45 -06:00
Code Issues Packages Projects Releases 169 Wiki Activity

Fix lint warnings and imports (#5623)

Browse Source
This commit is contained in:
David Perez 2025-07-30 15:32:18 -05:00 committed by GitHub
parent 01570c2555
commit 376a62edaf
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
20 changed files with 28 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/src/main/kotlin/com/x8bit/bitwarden/data/auth/util/PasswordlessRequestDataUtils.kt
View File

@ -2,9 +2,9 @@ package com.x8bit.bitwarden.data.auth.util
import android.content.Context
import android.content.Intent
import com.bitwarden.ui.platform.util.getSafeParcelableExtra
import com.x8bit.bitwarden.MainActivity
import com.x8bit.bitwarden.data.platform.manager.model.PasswordlessRequestData
import com.bitwarden.ui.platform.util.getSafeParcelableExtra
private const val NOTIFICATION_DATA: String = "notificationData"

2
app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/util/AutofillIntentUtils.kt
View File

@ -12,13 +12,13 @@ import android.service.autofill.Dataset
import android.view.autofill.AutofillManager
import androidx.core.os.bundleOf
import com.bitwarden.annotation.OmitFromCoverage
import com.bitwarden.ui.platform.util.getSafeParcelableExtra
import com.x8bit.bitwarden.AutofillTotpCopyActivity
import com.x8bit.bitwarden.MainActivity
import com.x8bit.bitwarden.data.autofill.model.AutofillAppInfo
import com.x8bit.bitwarden.data.autofill.model.AutofillSaveItem
import com.x8bit.bitwarden.data.autofill.model.AutofillSelectionData
import com.x8bit.bitwarden.data.autofill.model.AutofillTotpCopyData
import com.bitwarden.ui.platform.util.getSafeParcelableExtra
import kotlin.random.Random
private const val AUTOFILL_SAVE_ITEM_DATA_KEY = "autofill-save-item-data"

2
app/src/main/kotlin/com/x8bit/bitwarden/ui/credentials/manager/CredentialProviderCompletionManager.kt
View File

@ -1,8 +1,8 @@
package com.x8bit.bitwarden.ui.credentials.manager
import com.x8bit.bitwarden.ui.credentials.manager.model.AssertFido2CredentialResult
import com.x8bit.bitwarden.ui.credentials.manager.model.GetPasswordCredentialResult
import com.x8bit.bitwarden.ui.credentials.manager.model.GetCredentialsResult
import com.x8bit.bitwarden.ui.credentials.manager.model.GetPasswordCredentialResult
import com.x8bit.bitwarden.ui.credentials.manager.model.RegisterFido2CredentialResult
/**

2
app/src/main/kotlin/com/x8bit/bitwarden/ui/credentials/manager/CredentialProviderCompletionManagerImpl.kt
View File

@ -15,8 +15,8 @@ import androidx.credentials.exceptions.GetCredentialUnknownException
import androidx.credentials.provider.BeginGetCredentialResponse
import androidx.credentials.provider.PendingIntentHandler
import com.x8bit.bitwarden.ui.credentials.manager.model.AssertFido2CredentialResult
import com.x8bit.bitwarden.ui.credentials.manager.model.GetPasswordCredentialResult
import com.x8bit.bitwarden.ui.credentials.manager.model.GetCredentialsResult
import com.x8bit.bitwarden.ui.credentials.manager.model.GetPasswordCredentialResult
import com.x8bit.bitwarden.ui.credentials.manager.model.RegisterFido2CredentialResult
/**

2
app/src/main/kotlin/com/x8bit/bitwarden/ui/credentials/manager/CredentialProviderCompletionManagerUnsupportedApiImpl.kt
View File

@ -3,8 +3,8 @@ package com.x8bit.bitwarden.ui.credentials.manager
import androidx.credentials.CredentialProvider
import com.bitwarden.annotation.OmitFromCoverage
import com.x8bit.bitwarden.ui.credentials.manager.model.AssertFido2CredentialResult
import com.x8bit.bitwarden.ui.credentials.manager.model.GetPasswordCredentialResult
import com.x8bit.bitwarden.ui.credentials.manager.model.GetCredentialsResult
import com.x8bit.bitwarden.ui.credentials.manager.model.GetPasswordCredentialResult
import com.x8bit.bitwarden.ui.credentials.manager.model.RegisterFido2CredentialResult
/**

2
app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/SettingsViewModel.kt
View File

@ -232,7 +232,7 @@ sealed class SettingsAction {
*/
enum class Settings(
val text: Text,
@DrawableRes val vectorIconRes: Int,
@field:DrawableRes val vectorIconRes: Int,
val testTag: String,
) {
ACCOUNT_SECURITY(

4
app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/vaultunlockednavbar/VaultUnlockedNavBarViewModel.kt
View File

@ -190,8 +190,8 @@ class VaultUnlockedNavBarViewModel @Inject constructor(
* Models state for the [VaultUnlockedNavBarViewModel].
*/
data class VaultUnlockedNavBarState(
@StringRes val vaultNavBarLabelRes: Int,
@StringRes val vaultNavBarContentDescriptionRes: Int,
@field:StringRes val vaultNavBarLabelRes: Int,
@field:StringRes val vaultNavBarContentDescriptionRes: Int,
val notificationState: VaultUnlockedNavBarNotificationState,
)

10
app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/manager/nfc/NfcManagerImpl.kt
View File

@ -8,6 +8,7 @@ import android.content.IntentFilter
import android.nfc.NfcAdapter
import android.os.Build
import com.bitwarden.annotation.OmitFromCoverage
import com.bitwarden.core.util.isBuildVersionAtLeast
import com.x8bit.bitwarden.AuthCallbackActivity
import com.x8bit.bitwarden.data.autofill.util.toPendingIntentMutabilityFlag
import kotlin.random.Random
@ -26,9 +27,12 @@ class NfcManagerImpl(
override fun start() {
if (!supportsNfc) return
val options = ActivityOptions.makeBasic()
// When targeting API 35, we need to explicitly allow background activities to start on
// devices using API 34 and higher.
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.UPSIDE_DOWN_CAKE) {
if (isBuildVersionAtLeast(version = Build.VERSION_CODES.BAKLAVA)) {
options.setPendingIntentCreatorBackgroundActivityStartMode(
ActivityOptions.MODE_BACKGROUND_ACTIVITY_START_ALLOW_IF_VISIBLE,
)
} else if (isBuildVersionAtLeast(version = Build.VERSION_CODES.UPSIDE_DOWN_CAKE)) {
@Suppress("DEPRECATION")
options.setPendingIntentCreatorBackgroundActivityStartMode(
ActivityOptions.MODE_BACKGROUND_ACTIVITY_START_ALLOWED,
)

2
app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/SendViewModel.kt
View File

@ -522,7 +522,7 @@ data class SendState(
/**
* Indicates the type of send this, a text or file.
*/
enum class Type(@DrawableRes val iconRes: Int) {
enum class Type(@field:DrawableRes val iconRes: Int) {
FILE(iconRes = BitwardenDrawable.ic_file),
TEXT(iconRes = BitwardenDrawable.ic_file_text),
}

2
app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/model/SendStatusIcon.kt
View File

@ -10,7 +10,7 @@ import com.bitwarden.ui.util.asText
* Represents the types of icons to be displayed with the send.
*/
enum class SendStatusIcon(
@DrawableRes val iconRes: Int,
@field:DrawableRes val iconRes: Int,
val contentDescription: Text,
val testTag: String,
) {

2
app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/components/model/CreateVaultItemType.kt
View File

@ -7,7 +7,7 @@ import com.bitwarden.ui.platform.resource.BitwardenString
* Enumerated values to represent a create vault item option.
*/
enum class CreateVaultItemType(
@StringRes val selectionText: Int,
@field:StringRes val selectionText: Int,
) {
/**
* A login cipher.

2
app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/model/VaultTrailingIcon.kt
View File

@ -10,7 +10,7 @@ import com.bitwarden.ui.util.asText
* Represents the icons displayed after the cipher name.
*/
enum class VaultTrailingIcon(
@DrawableRes val iconRes: Int,
@field:DrawableRes val iconRes: Int,
val contentDescription: Text,
val testTag: String,
) {

2
authenticator/src/main/kotlin/com/bitwarden/authenticator/data/authenticator/datasource/disk/entity/AuthenticatorItemAlgorithm.kt
View File

@ -1,7 +1,5 @@
package com.bitwarden.authenticator.data.authenticator.datasource.disk.entity
import com.bitwarden.authenticator.data.authenticator.datasource.disk.entity.AuthenticatorItemAlgorithm.entries
/**
* Enum class representing SHA algorithms an authenticator item may be hashed with.
*/

2
authenticator/src/main/kotlin/com/bitwarden/authenticator/data/authenticator/datasource/disk/entity/AuthenticatorItemType.kt
View File

@ -1,7 +1,5 @@
package com.bitwarden.authenticator.data.authenticator.datasource.disk.entity
import com.bitwarden.authenticator.data.authenticator.datasource.disk.entity.AuthenticatorItemType.entries
/**
* Enum representing the supported "type" options for authenticator items.
*/

2
authenticator/src/main/kotlin/com/bitwarden/authenticator/data/authenticator/repository/AuthenticatorRepository.kt
View File

@ -10,9 +10,9 @@ import com.bitwarden.authenticator.data.authenticator.repository.model.SharedVer
import com.bitwarden.authenticator.data.authenticator.repository.model.TotpCodeResult
import com.bitwarden.authenticator.data.platform.manager.imports.model.ImportDataResult
import com.bitwarden.authenticator.data.platform.manager.imports.model.ImportFileFormat
import com.bitwarden.core.data.repository.model.DataState
import com.bitwarden.authenticator.ui.platform.feature.settings.export.model.ExportVaultFormat
import com.bitwarden.authenticator.ui.platform.manager.intent.IntentManager
import com.bitwarden.core.data.repository.model.DataState
import kotlinx.coroutines.flow.Flow
import kotlinx.coroutines.flow.StateFlow

2
authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/itemlisting/model/ItemListingExpandableFabAction.kt
View File

@ -1,9 +1,9 @@
package com.bitwarden.authenticator.ui.authenticator.feature.itemlisting.model
import androidx.compose.material3.ExtendedFloatingActionButton
import com.bitwarden.ui.util.Text
import com.bitwarden.authenticator.ui.platform.components.fab.ExpandableFabOption
import com.bitwarden.authenticator.ui.platform.components.model.IconResource
import com.bitwarden.ui.util.Text
/**
* Models [ExpandableFabOption]s that can be triggered by the [ExtendedFloatingActionButton].

2
authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/platform/components/dialog/BitwardenLoadingDialog.kt
View File

@ -19,9 +19,9 @@ import androidx.compose.ui.tooling.preview.Preview
import androidx.compose.ui.unit.dp
import androidx.compose.ui.window.Dialog
import androidx.compose.ui.window.DialogProperties
import com.bitwarden.authenticator.ui.platform.theme.AuthenticatorTheme
import com.bitwarden.ui.util.Text
import com.bitwarden.ui.util.asText
import com.bitwarden.authenticator.ui.platform.theme.AuthenticatorTheme
import kotlinx.parcelize.Parcelize
/**

2
ui/src/main/kotlin/com/bitwarden/ui/platform/components/content/model/ContentBlockData.kt
View File

@ -13,7 +13,7 @@ import com.bitwarden.ui.platform.components.content.BitwardenContentBlock
data class ContentBlockData(
val headerText: AnnotatedString,
val subtitleText: AnnotatedString? = null,
@DrawableRes val iconVectorResource: Int? = null,
@field:DrawableRes val iconVectorResource: Int? = null,
) {
/**
* Overloaded constructor for [ContentBlockData] that takes a [String] for the

4
ui/src/main/kotlin/com/bitwarden/ui/platform/components/icon/model/IconData.kt
View File

@ -28,7 +28,7 @@ sealed class IconData : Parcelable {
*/
@Parcelize
data class Local(
@DrawableRes val iconRes: Int,
@field:DrawableRes val iconRes: Int,
override val contentDescription: Text? = null,
override val testTag: String? = null,
) : IconData()
@ -42,7 +42,7 @@ sealed class IconData : Parcelable {
@Parcelize
data class Network(
val uri: String,
@DrawableRes val fallbackIconRes: Int,
@field:DrawableRes val fallbackIconRes: Int,
override val contentDescription: Text? = null,
override val testTag: String? = null,
) : IconData()

8
ui/src/main/kotlin/com/bitwarden/ui/util/Text.kt
View File

@ -38,7 +38,7 @@ interface Text : Parcelable {
* Implementation of [Text] backed by a string resource.
*/
@Parcelize
private data class ResText(@StringRes private val id: Int) : Text {
private data class ResText(@field:StringRes private val id: Int) : Text {
override fun invoke(res: Resources): CharSequence = res.getText(id)
}
@ -57,8 +57,7 @@ private data class TextConcatenation(private val args: List<Text>) : Text {
*/
@Parcelize
private data class ResArgsText(
@StringRes
private val id: Int,
@field:StringRes private val id: Int,
private val args: @RawValue List<Any>,
) : Text {
override fun invoke(res: Resources): String =
@ -73,8 +72,7 @@ private data class ResArgsText(
@Parcelize
@Suppress("UnusedPrivateClass")
private data class PluralsText(
@PluralsRes
private val id: Int,
@field:PluralsRes private val id: Int,
private val quantity: Int,
private val args: @RawValue List<Any>,
) : Text {