bitwarden/android
1
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2025-12-11 04:39:19 -06:00
Code Issues Packages Projects Releases 169 Wiki Activity

PM-20198: Update generator modal 'Save' button to 'Apply' (#5745)

Browse Source
This commit is contained in:
David Perez 2025-08-19 16:27:17 -05:00 committed by GitHub
parent 32e8fb7d8e
commit 277e4d8d6f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreen.kt
View File

@ -345,7 +345,7 @@ private fun ModalAppBar(
},
actions = {
BitwardenTextButton(
label = stringResource(id = BitwardenString.save),
label = stringResource(id = BitwardenString.apply),
onClick = onSaveClick,
modifier = Modifier.testTag("SaveButton"),
)

8
app/src/test/kotlin/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreenTest.kt
View File

@ -87,7 +87,7 @@ class GeneratorScreenTest : BitwardenComposeTest() {
.assertIsDisplayed()
composeTestRule
.onNodeWithText(text = "Save")
.onNodeWithText(text = "Apply")
.assertIsDisplayed()
}
@ -104,7 +104,7 @@ class GeneratorScreenTest : BitwardenComposeTest() {
.assertIsDisplayed()
composeTestRule
.onNodeWithText(text = "Save")
.onNodeWithText(text = "Apply")
.assertIsDisplayed()
}
@ -126,7 +126,7 @@ class GeneratorScreenTest : BitwardenComposeTest() {
}
@Test
fun `on save click should send SaveClick`() {
fun `on Apply click should send SaveClick`() {
updateState(
DEFAULT_STATE.copy(
generatorMode = GeneratorMode.Modal.Username(website = null),
@ -134,7 +134,7 @@ class GeneratorScreenTest : BitwardenComposeTest() {
)
composeTestRule
.onNodeWithText(text = "Save")
.onNodeWithText(text = "Apply")
.performClick()
verify {

1
ui/src/main/res/values/strings.xml
View File

@ -4,6 +4,7 @@
<string name="add_folder">Add folder</string>
<string name="add_item">Add Item</string>
<string name="an_error_has_occurred">An error has occurred</string>
<string name="apply">Apply</string>
<string name="back">Back</string>
<string name="bitwarden">Bitwarden</string>
<string name="cancel">Cancel</string>