From 4c0d5ea891ccc6481756930f4adaaf83be68f8de Mon Sep 17 00:00:00 2001 From: TheAssassin Date: Wed, 24 Oct 2018 12:46:24 +0200 Subject: [PATCH] Remove erroneous null termination The std::string is created using char pointer _and_ buffer size, so null termination wasn't necessary in there (might even be problematic with other tools which aren't strictly text based). CC #35. --- src/core/elf.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/core/elf.cpp b/src/core/elf.cpp index 882847d..058a6f0 100644 --- a/src/core/elf.cpp +++ b/src/core/elf.cpp @@ -163,7 +163,6 @@ namespace linuxdeploy { auto outBufSize = outBuf.size(); outBuf.reserve(outBufSize + size + 1); std::copy(buf.begin(), buf.begin() + size, std::back_inserter(outBuf)); - outBuf.push_back('\0'); } } while (lddProc.poll() < 0);