audacity/linuxdeploy
1
0
Fork 0
mirror of https://github.com/audacity/linuxdeploy.git synced 2025-12-11 05:46:48 -06:00
Code Issues Packages Projects Releases 1 Wiki Activity

Do not set rpath in statically linked or debug symbols ELF files

Browse Source
This commit is contained in:
TheAssassin 2021-05-29 01:25:21 +02:00
parent 3c6096433d
commit 1d534d2b32
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/core/appdir.cpp
View File

@ -215,10 +215,16 @@ namespace linuxdeploy {
const auto& filePath = currentEntry.first;
const auto& rpath = currentEntry.second;
elf_file::ElfFile elfFile(filePath);
// no need to set rpath in debug symbols files
// also, patchelf crashes on such symbols
if (isInDebugSymbolsLocation(filePath)) {
ldLog() << LD_WARNING << "Not setting rpath in debug symbols file:" << filePath << std::endl;
if (isInDebugSymbolsLocation(filePath) || elfFile.isDebugSymbolsFile()) {
ldLog() << LD_WARNING << "Not setting rpath in debug symbols file:" << filePath
<< std::endl;
} else if (!elfFile.isDynamicallyLinked()) {
ldLog() << LD_WARNING << "Not setting rpath in statically-linked file: " << filePath
<< std::endl;
} else {
ldLog() << "Setting rpath in ELF file" << filePath << "to" << rpath << std::endl;
if (!elf_file::ElfFile(filePath).setRPath(rpath)) {