audacity/audacity.github.io
1
0
Fork 0
mirror of https://github.com/audacity/audacity.github.io.git synced 2026-04-12 06:25:33 -05:00
Code Issues 9 Packages Projects Releases Wiki Activity

[PR #31] [MERGED] Implement post-download page #49

New Issue
Closed
opened 2025-09-09 19:41:52 -05:00 by Octech6711 · 0 comments
Octech6711 commented 2025-09-09 19:41:52 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/audacity/audacity.github.io/pull/31
Author: @DilsonsPickles
Created: 9/10/2024
Status: ✅ Merged
Merged: 9/12/2024
Merged by: @LWinterberg

Base: main ← Head: post-download

📝 Commits (8)

📊 Changes

11 files changed (+168 additions, -14 deletions)

View changed files

📝 src/components/button/DownloadButton.jsx (+5 -1)
📝 src/components/button/DownloadMuseHubButton.jsx (+6 -2)
➕ src/components/button/JoinAudioDotComButton.jsx (+28 -0)
➕ src/components/button/PlatformDownloadMuseHubButton.jsx (+32 -0)
➕ src/components/card/AudioDotComCard.jsx (+18 -0)
📝 src/components/card/DownloadCard.jsx (+6 -2)
📝 src/components/card/FeatureCard.jsx (+1 -2)
📝 src/layouts/DownloadPageLayout.astro (+6 -6)
➕ src/pages/post-download.astro (+49 -0)
📝 src/styles/icons.css (+16 -0)
📝 src/styles/input.css (+1 -1)

📄 Description

This pull request adds a timeout to the download button which, after 2 seconds, redirects the User to a post-download page. The post-download page contains a 'thank you' banner as well as promotional content for audio.com (including a 'Join now' CTA).

One thing worth considering is what happens if a User cancels their download as they will still be redirected. I am not yet sure how to solve this...

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/audacity/audacity.github.io/pull/31 **Author:** [@DilsonsPickles](https://github.com/DilsonsPickles) **Created:** 9/10/2024 **Status:** ✅ Merged **Merged:** 9/12/2024 **Merged by:** [@LWinterberg](https://github.com/LWinterberg) **Base:** `main` ← **Head:** `post-download` --- ### 📝 Commits (8) - [`ef253a5`](https://github.com/audacity/audacity.github.io/commit/ef253a595ff2f029787da1b9e7a3176d15626125) Init commit - [`9451f9c`](https://github.com/audacity/audacity.github.io/commit/9451f9c03a2b78eac58e9533c2b239fe5a02a5de) Increase 'Join now' button size - [`12106a4`](https://github.com/audacity/audacity.github.io/commit/12106a4cbc8b9036a17c1ecd9d40c6470f1d7ca7) Update card descriptive text - [`9d1e5c4`](https://github.com/audacity/audacity.github.io/commit/9d1e5c4f25cd52d76ea52d261033a294796da180) Rename MuseHub download button - [`af84ef1`](https://github.com/audacity/audacity.github.io/commit/af84ef1fd0826622fcae23d6fedf11b9675436da) Utilise component state - [`ff7fe44`](https://github.com/audacity/audacity.github.io/commit/ff7fe44f84202c4cbdf49c7a02612f020a1b136a) Improve function name - [`e6aeacc`](https://github.com/audacity/audacity.github.io/commit/e6aeacc6e98887ee9c90d8be4f41bd0ba64a78b3) Format button - [`eb408b6`](https://github.com/audacity/audacity.github.io/commit/eb408b69488da427f772ccb42e68ec870860db46) Update feature card copy ### 📊 Changes **11 files changed** (+168 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `src/components/button/DownloadButton.jsx` (+5 -1) 📝 `src/components/button/DownloadMuseHubButton.jsx` (+6 -2) ➕ `src/components/button/JoinAudioDotComButton.jsx` (+28 -0) ➕ `src/components/button/PlatformDownloadMuseHubButton.jsx` (+32 -0) ➕ `src/components/card/AudioDotComCard.jsx` (+18 -0) 📝 `src/components/card/DownloadCard.jsx` (+6 -2) 📝 `src/components/card/FeatureCard.jsx` (+1 -2) 📝 `src/layouts/DownloadPageLayout.astro` (+6 -6) ➕ `src/pages/post-download.astro` (+49 -0) 📝 `src/styles/icons.css` (+16 -0) 📝 `src/styles/input.css` (+1 -1) </details> ### 📄 Description This pull request adds a timeout to the download button which, after 2 seconds, redirects the User to a post-download page. The post-download page contains a 'thank you' banner as well as promotional content for audio.com (including a 'Join now' CTA). One thing worth considering is what happens if a User cancels their download as they will still be redirected. I am not yet sure how to solve this... --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Octech6711 added the pull-request label 2025-09-09 19:41:52 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Octech6711
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: audacity/audacity.github.io#49
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?