audacity/audacity.github.io
1
0
Fork 0
mirror of https://github.com/audacity/audacity.github.io.git synced 2026-04-12 06:25:33 -05:00
Code Issues 9 Packages Projects Releases Wiki Activity

[PR #38] [MERGED] Banner logic improvements #44

New Issue
Closed
opened 2025-09-09 19:41:51 -05:00 by Octech6711 · 0 comments
Octech6711 commented 2025-09-09 19:41:51 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/audacity/audacity.github.io/pull/38
Author: @DilsonsPickles
Created: 10/7/2024
Status: ✅ Merged
Merged: 10/11/2024
Merged by: @LWinterberg

Base: main ← Head: banner-logic-improvements

📝 Commits (4)

📊 Changes

6 files changed (+67 additions, -44 deletions)

View changed files

📝 package-lock.json (+7 -0)
📝 package.json (+1 -0)
📝 src/components/banner/PromoBanner.tsx (+39 -42)
➕ src/hooks/useDetectOS.ts (+17 -0)
📝 src/layouts/BaseLayout.astro (+3 -1)
📝 src/pages/index.astro (+0 -1)

📄 Description

Create hook function that uses useEffect to fetch browserOS. This creates a reusable function that we can use where needed without having to repeat the browserOS logic.

I've also tidied up the banner styling so that it renders a bit nicer on smaller screens.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/audacity/audacity.github.io/pull/38 **Author:** [@DilsonsPickles](https://github.com/DilsonsPickles) **Created:** 10/7/2024 **Status:** ✅ Merged **Merged:** 10/11/2024 **Merged by:** [@LWinterberg](https://github.com/LWinterberg) **Base:** `main` ← **Head:** `banner-logic-improvements` --- ### 📝 Commits (4) - [`ccae7a3`](https://github.com/audacity/audacity.github.io/commit/ccae7a33e0724fd1271ea1506f0844997b1f648b) Install @types/platform - [`76d0bb3`](https://github.com/audacity/audacity.github.io/commit/76d0bb353d6c15158b2e16cdce0e4553e700ed97) Create useDetectOS hook - [`7543cb3`](https://github.com/audacity/audacity.github.io/commit/7543cb3091fbd8afd1c34ec9ef22510351eb94be) Remove unused import - [`7e740d0`](https://github.com/audacity/audacity.github.io/commit/7e740d00f6d0c1084bc19af9f297f8657f185e02) Remove unused prop ### 📊 Changes **6 files changed** (+67 additions, -44 deletions) <details> <summary>View changed files</summary> 📝 `package-lock.json` (+7 -0) 📝 `package.json` (+1 -0) 📝 `src/components/banner/PromoBanner.tsx` (+39 -42) ➕ `src/hooks/useDetectOS.ts` (+17 -0) 📝 `src/layouts/BaseLayout.astro` (+3 -1) 📝 `src/pages/index.astro` (+0 -1) </details> ### 📄 Description Create hook function that uses useEffect to fetch browserOS. This creates a reusable function that we can use where needed without having to repeat the browserOS logic. I've also tidied up the banner styling so that it renders a bit nicer on smaller screens. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Octech6711 added the pull-request label 2025-09-09 19:41:51 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Octech6711
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: audacity/audacity.github.io#44
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?