[PR #10] [MERGED] Fix race condition #2185

New Issue

giteasync · 2025-09-10T23:56:28-05:00

giteasync commented

2025-09-10 23:56:28 -05:00

📋 Pull Request Information

Original PR: https://github.com/VSCodium/vscodium/pull/10
Author: @stripedpajamas
Created: 8/30/2018
Status: ✅ Merged
Merged: 8/31/2018
Merged by: @stripedpajamas

Base: master ← Head: master

📝 Commits (2)

6dfe579 Fix race condition
97b1ebe Add check for GITHUB_TOKEN env var

📊 Changes

3 files changed (+48 additions, -11 deletions)

View changed files

📝 .travis.yml (+0 -2)
📝 check_tags.sh (+47 -9)
📝 install_deps.sh (+1 -0)

📄 Description

Used to check if VSCodium had the latest MS tag, and if so, not build. If the tag wasn't there, build.

But since the builds are running in parallel on OSX and Linux, if one finished before the other, it was possible for the other one to not build and upload its assets.

This new approach hits the Github API to determine if the tag exists and if so, which assets have already been uploaded (rpm, deb for linux; zip for mac). If the build OS's asset isn't in the release, it will continue with the build+upload.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/VSCodium/vscodium/pull/10 **Author:** [@stripedpajamas](https://github.com/stripedpajamas) **Created:** 8/30/2018 **Status:** ✅ Merged **Merged:** 8/31/2018 **Merged by:** [@stripedpajamas](https://github.com/stripedpajamas) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`6dfe579`](https://github.com/VSCodium/vscodium/commit/6dfe579753c09ae5aa46dd343e690b6124bfdde5) Fix race condition - [`97b1ebe`](https://github.com/VSCodium/vscodium/commit/97b1ebe9a5a44588379259e0224082ad11374d63) Add check for GITHUB_TOKEN env var ### 📊 Changes **3 files changed** (+48 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `.travis.yml` (+0 -2) 📝 `check_tags.sh` (+47 -9) 📝 `install_deps.sh` (+1 -0) </details> ### 📄 Description Used to check if VSCodium had the latest MS tag, and if so, not build. If the tag wasn't there, build. But since the builds are running in parallel on OSX and Linux, if one finished before the other, it was possible for the other one to not build and upload its assets. This new approach hits the Github API to determine if the tag exists and if so, which assets have already been uploaded (rpm, deb for linux; zip for mac). If the build OS's asset isn't in the release, it will continue with the build+upload. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

giteasync added the

pull-request

label 2025-09-10 23:56:28 -05:00

giteasync closed this issue

2025-09-10 23:56:28 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: VSCodium/vscodium#2185