[PR #1965] [MERGED] build(riscv): Check electron version and bump to 29.4.0.riscv3 #1689

New Issue

giteasync · 2025-09-10T23:54:40-05:00

giteasync commented

2025-09-10 23:54:40 -05:00

📋 Pull Request Information

Original PR: https://github.com/VSCodium/vscodium/pull/1965
Author: @kxxt
Created: 7/20/2024
Status: ✅ Merged
Merged: 7/21/2024
Merged by: @daiyam

Base: master ← Head: riscv-1

📝 Commits (2)

c3a709e build(riscv): catch electron version mismatch
f7b63a9 build(riscv): bump electron to v29.4.0.riscv3

📊 Changes

1 file changed (+10 additions, -5 deletions)

View changed files

📝 package_linux_bin.sh (+10 -5)

📄 Description

Add a check that fails when the riscv electron version doesn't match .yarnrc.
- This ensures that we won't produce broken releases when they don't match and signal that the riscv electron version should be bumped.
Bump riscv electron to v29.4.0.riscv3 for https://github.com/riscv-forks/electron/issues/2

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/VSCodium/vscodium/pull/1965 **Author:** [@kxxt](https://github.com/kxxt) **Created:** 7/20/2024 **Status:** ✅ Merged **Merged:** 7/21/2024 **Merged by:** [@daiyam](https://github.com/daiyam) **Base:** `master` ← **Head:** `riscv-1` --- ### 📝 Commits (2) - [`c3a709e`](https://github.com/VSCodium/vscodium/commit/c3a709e0410db517c0906f80c5006fbcb7d777a5) build(riscv): catch electron version mismatch - [`f7b63a9`](https://github.com/VSCodium/vscodium/commit/f7b63a952a865d12bfc4131b5ceaa808e1c20863) build(riscv): bump electron to v29.4.0.riscv3 ### 📊 Changes **1 file changed** (+10 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `package_linux_bin.sh` (+10 -5) </details> ### 📄 Description - Add a check that fails when the riscv electron version doesn't match `.yarnrc`. - This ensures that we won't produce broken releases when they don't match and signal that the riscv electron version should be bumped. - Bump riscv electron to v29.4.0.riscv3 for https://github.com/riscv-forks/electron/issues/2 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

giteasync added the

pull-request

label 2025-09-10 23:54:40 -05:00

giteasync closed this issue

2025-09-10 23:54:40 -05:00

giteasync referenced this issue

2025-09-10 23:54:51 -05:00

[PR #1689] [MERGED] fix: use node-v18.17 to generate all artifacts #1741

Sign in to join this conversation.