Don't hard code the owner name and repo name in the Travis file #1502

Closed
opened 2025-09-10 23:53:34 -05:00 by giteasync · 0 comments
Owner

Originally created by @stripedpajamas on GitHub.

Currently we check the current releases by asking Github's API about VSCodium/vscodium's releases. This makes PRs more dangerous: a change to anything in the build matrix won't necessary be run through Travis because the binaries already exist.

Suggest using the $TRAVIS_REPO_SLUG env var which resolves to owner_name/repo_name in this API call. That way it will attempt all the builds during local development (provided a $GITHUB_TOKEN is defined).

Originally created by @stripedpajamas on GitHub. Currently we check the current releases by asking Github's API about VSCodium/vscodium's releases. This makes PRs more dangerous: a change to anything in the build matrix won't necessary be run through Travis because the binaries already exist. Suggest using the `$TRAVIS_REPO_SLUG` env var which resolves to `owner_name/repo_name` in [this API call](https://github.com/VSCodium/vscodium/blob/master/check_tags.sh#L3). That way it will attempt all the builds during local development (provided a `$GITHUB_TOKEN` is defined).
giteasync added the good first issue label 2025-09-10 23:53:34 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: VSCodium/vscodium#1502