mirror of
https://github.com/VSCodium/vscodium.git
synced 2026-04-09 20:50:20 -05:00
In file context menu change 'Open with VSCodium' to 'Open with Codium' #1277
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @lnlp on GitHub.
I use VSCodium on Windows.
In the file context menu it shows 'Open with VSCodium', where VSCode only shows 'Open with Code'.
It would be nice to see 'Open with Codium' for VSCodium instead.
That is consistent with VSCode behavior, is consistent with how the executables are named and is consistent with how VSCodium is started from a command line.
@stripedpajamas commented on GitHub:
#193 is not closed and will cover this change. PRs are welcome if anyone wants to just get the context menu change into the next release.
@lnlp commented on GitHub:
This issue is NOT covered by #193
#193 is about changing the product name from VSCodium to Codium.
This issue is about renaming the context menu entry 'Open with VSCodium' to 'Open with Codium'.
Issue has not been fixed. Please reopen.
Just proves that #369 has not (yet) been fixed.
@lnlp commented on GitHub:
Thanks for the link. I see that #193 is closed.
My suggestion has less impact, is consistent with VSCode and should be easy to implement.
@bulderi commented on GitHub:
See 193
@stripedpajamas commented on GitHub:
@lnlp #193 is about making VSCodium's naming conventions consistent with VSCode's naming conventions. This includes the context menu entry. You can see the same in the draft PR associated with #193. Specifically, the context menu entry sources its wording/name from the
product.jsonfile.As I said, if anyone wants only this change before we figure out how to align all our naming conventions with VSCode's, PRs are welcome. We don't need separate issues for each place in the application where our naming conventions differ from upstream's.
@lnlp commented on GitHub:
That is incorrect. #193 is not about making naming conventions consistent with VSCode. It is actually the opposite: remove "VS" from the VSCodium product name.
(I would appreciate the name change though.)
Inconsistency:
The inconsistency is that VSCode does not use the "VS" prefix in that menu but VSCodium does (and "Codium" just looks better).
There are two possible reasons for correcting the 'Open with' menu entry:
Reason 1. is VALID.
Reason 2. is currently invalid and it may never be. It will be valid only if the product name will be changed in future, which may never happen.
Fixing the menu entry inconsistency should not be made dependent on a possible future change of product name that may never happen. That is just incorrect. There currently already exists a valid reason to correct the menu entry and that is reason 1.
This issue should therefore be reopend (until it actually gets fixed).