[PR #34] [MERGED] Better lighthouse score #72

Closed
opened 2025-09-10 22:50:12 -05:00 by giteasync · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/VSCodium/vscodium.github.io/pull/34
Author: @GeopJr
Created: 1/15/2021
Status: Merged
Merged: 1/19/2021
Merged by: @stripedpajamas

Base: masterHead: lighthouse


📝 Commits (6)

📊 Changes

7 files changed (+30 additions, -110 deletions)

View changed files

📝 _includes/css/main.css (+18 -3)
📝 _posts/2000-01-01-intro.md (+1 -1)
📝 _posts/2000-01-04-why.md (+1 -1)
📝 _posts/2000-01-05-install.md (+7 -7)
📝 _posts/2000-01-06-moreinfo.md (+1 -1)
📝 index.html (+1 -2)
📝 site.js (+1 -95)

📄 Description

The site is pretty low on a11y and best practices.
This PR does the following:

  • Replaces jquery with css' smooth-scroll
  • Fixes color contrast between blockquotes and background
  • Adds (a nice looking) outline on anchor focus
  • Respects prefers-reduced-motion
  • Adds alt text to links and images
  • Removes useless anchors
  • Makes empty anchors unfocusable (and hides them on screen readers)
  • Removes excessive usage of here when used as alt text for anchors (https://webaccess.berkeley.edu/ask-pecan/click-here)
  • Makes (using vanilla js) code blocks focusable
  • Fixes mobile overflow-x caused by the download button

Closes: #31


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/VSCodium/vscodium.github.io/pull/34 **Author:** [@GeopJr](https://github.com/GeopJr) **Created:** 1/15/2021 **Status:** ✅ Merged **Merged:** 1/19/2021 **Merged by:** [@stripedpajamas](https://github.com/stripedpajamas) **Base:** `master` ← **Head:** `lighthouse` --- ### 📝 Commits (6) - [`803c4d5`](https://github.com/VSCodium/vscodium.github.io/commit/803c4d507f0744f78377a8ca07c939692d7bf93e) fix: ids should only be used once - [`86bf0d3`](https://github.com/VSCodium/vscodium.github.io/commit/86bf0d30d58663710eaff90c57d474bc7f1b184a) fix: a11y - [`ba22a62`](https://github.com/VSCodium/vscodium.github.io/commit/ba22a62763982fac5cd15ca7553a0fff7c5daff8) fix: best-practices - [`1d01ef4`](https://github.com/VSCodium/vscodium.github.io/commit/1d01ef410258135928807ec39b85dee96579754c) fix: some more a11y - [`36ee315`](https://github.com/VSCodium/vscodium.github.io/commit/36ee3156896afc311edfaf59353632d019b8a95d) fix: mobile overflow - [`04a5835`](https://github.com/VSCodium/vscodium.github.io/commit/04a583525b45392760adf46a3cf839aac926c5f5) fix: leftover ### 📊 Changes **7 files changed** (+30 additions, -110 deletions) <details> <summary>View changed files</summary> 📝 `_includes/css/main.css` (+18 -3) 📝 `_posts/2000-01-01-intro.md` (+1 -1) 📝 `_posts/2000-01-04-why.md` (+1 -1) 📝 `_posts/2000-01-05-install.md` (+7 -7) 📝 `_posts/2000-01-06-moreinfo.md` (+1 -1) 📝 `index.html` (+1 -2) 📝 `site.js` (+1 -95) </details> ### 📄 Description The site is pretty low on a11y and best practices. This PR does the following: - Replaces jquery with css' smooth-scroll - Fixes color contrast between blockquotes and background - Adds (a nice looking) outline on anchor focus - Respects prefers-reduced-motion - Adds alt text to links and images - Removes useless anchors - Makes empty anchors unfocusable (and hides them on screen readers) - Removes excessive usage of `here` when used as alt text for anchors (https://webaccess.berkeley.edu/ask-pecan/click-here) - Makes (using vanilla js) code blocks focusable - Fixes mobile overflow-x caused by the download button Closes: #31 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
giteasync added the pull-request label 2025-09-10 22:50:12 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: VSCodium/vscodium.github.io#72