mirror of
https://github.com/VSCodium/policy-watcher.git
synced 2025-12-10 03:53:55 -06:00
fix: Woverloaded-virtual and Wdelete-abstract-non-virtual-dtor warnings (#25)
This commit is contained in:
parent
b9c5bec7bd
commit
1a64245a1a
@ -13,6 +13,7 @@ using namespace Napi;
|
||||
class Policy
|
||||
{
|
||||
public:
|
||||
virtual ~Policy() {}
|
||||
virtual bool refresh() = 0;
|
||||
virtual Value getValue(Env env) const = 0;
|
||||
const std::string name;
|
||||
|
||||
@ -27,8 +27,6 @@ public:
|
||||
|
||||
void OnExecute(Napi::Env env);
|
||||
void Execute(const ExecutionProgress &progress);
|
||||
void OnOK();
|
||||
void OnError();
|
||||
void OnProgress(const Policy *const *policies, size_t count);
|
||||
void Dispose();
|
||||
|
||||
|
||||
@ -21,7 +21,5 @@ void PolicyWatcher::AddStringPolicy(const std::string name) {}
|
||||
void PolicyWatcher::AddNumberPolicy(const std::string name) {}
|
||||
void PolicyWatcher::OnExecute(Napi::Env env) {}
|
||||
void PolicyWatcher::Execute(const ExecutionProgress &progress) {}
|
||||
void PolicyWatcher::OnOK() {}
|
||||
void PolicyWatcher::OnError() {}
|
||||
void PolicyWatcher::OnProgress(const Policy *const *policies, size_t count) {}
|
||||
void PolicyWatcher::Dispose() {}
|
||||
|
||||
@ -21,7 +21,5 @@ void PolicyWatcher::AddStringPolicy(const std::string name) {}
|
||||
void PolicyWatcher::AddNumberPolicy(const std::string name) {}
|
||||
void PolicyWatcher::OnExecute(Napi::Env env) {}
|
||||
void PolicyWatcher::Execute(const ExecutionProgress &progress) {}
|
||||
void PolicyWatcher::OnOK() {}
|
||||
void PolicyWatcher::OnError() {}
|
||||
void PolicyWatcher::OnProgress(const Policy *const *policies, size_t count) {}
|
||||
void PolicyWatcher::Dispose() {}
|
||||
|
||||
@ -83,9 +83,6 @@ void PolicyWatcher::Execute(const ExecutionProgress &progress)
|
||||
}
|
||||
}
|
||||
|
||||
void PolicyWatcher::OnOK() {}
|
||||
void PolicyWatcher::OnError() {}
|
||||
|
||||
void PolicyWatcher::OnProgress(const Policy *const *policies, size_t count)
|
||||
{
|
||||
HandleScope scope(Env());
|
||||
|
||||
Loading…
x
Reference in New Issue
Block a user