TriliumNext/Trilium
1
0
Fork 0
mirror of https://github.com/TriliumNext/Trilium.git synced 2026-04-20 07:55:01 -05:00
Code Issues 1.1k Packages Projects Releases 10 Wiki Activity

[PR #4635] [MERGED] Fix showing unhoist confirm dialogue for bookmarked notes. #5351

New Issue
Closed
opened 2025-10-01 16:42:33 -05:00 by giteasync · 0 comments
giteasync commented 2025-10-01 16:42:33 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/TriliumNext/Trilium/pull/4635
Author: @WantToLearnJapanese
Created: 2/2/2024
Status: ✅ Merged
Merged: 2/15/2024
Merged by: @zadam

Base: master ← Head: WantToLearnJapanese-patch-unhoist-bookmark

📝 Commits (1)

  • a939599 Fix showing unhoist confirm dialogue for bookmarked notes.

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 src/public/app/services/hoisted_note.js (+2 -2)

📄 Description

Fix for following.

  • For bookmarked notes, the unhoist confirmation dialogue is not shown since it is under hidden/launchers.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/TriliumNext/Trilium/pull/4635 **Author:** [@WantToLearnJapanese](https://github.com/WantToLearnJapanese) **Created:** 2/2/2024 **Status:** ✅ Merged **Merged:** 2/15/2024 **Merged by:** [@zadam](https://github.com/zadam) **Base:** `master` ← **Head:** `WantToLearnJapanese-patch-unhoist-bookmark` --- ### 📝 Commits (1) - [`a939599`](https://github.com/TriliumNext/Trilium/commit/a939599223c7843a6b3e5316bb7c6914beacf48c) Fix showing unhoist confirm dialogue for bookmarked notes. ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/public/app/services/hoisted_note.js` (+2 -2) </details> ### 📄 Description Fix for following. * For bookmarked notes, the `unhoist` confirmation dialogue is not shown since it is under `hidden/launchers`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
giteasync added the pull-request label 2025-10-01 16:42:33 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BE
Difficulty: Easy
Difficulty: Hard
Difficulty: Hard
State: Blocked
State: Outdated
State: Triage
State: Triage
State: Under Debate
Type: Documentation
Type: Scripts & Themes
UI
UI
UI
awaiting feedback
ckeditor
container
dependencies
desktop-app
downstream
effort-high
effort-low
effort-medium
geo-map
llm
mermaid diagrams
mobile
ported-issues
pull-request
Mirrored from GitHub Pull Request
 question
refactor
regression
scripting
search
search
sync
upstream
web-clipper
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
giteasync
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: TriliumNext/Trilium#5351
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?